[kvm-devel] [PATCH 8/8] SVM: add support for Nested Paging

2008-01-25 Thread Joerg Roedel
This patch contains the SVM architecture dependent changes for KVM to enable support for the Nested Paging feature of AMD Barcelona and Phenom processors. Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> --- arch/x86/kvm/svm.c | 67 --- 1 files cha

[kvm-devel] [PATCH 8/8] SVM: add support for Nested Paging

2008-02-07 Thread Joerg Roedel
This patch contains the SVM architecture dependent changes for KVM to enable support for the Nested Paging feature of AMD Barcelona and Phenom processors. Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> --- arch/x86/kvm/svm.c | 72 --- 1 files cha

Re: [kvm-devel] [PATCH 8/8] SVM: add support for Nested Paging

2008-01-27 Thread Avi Kivity
Joerg Roedel wrote: > This patch contains the SVM architecture dependent changes for KVM to enable > support for the Nested Paging feature of AMD Barcelona and Phenom processors. > > +#ifdef CONFIG_X86_64 > +static bool npt_enabled = true; > +#else > static bool npt_enabled = false; > +#endif >

Re: [kvm-devel] [PATCH 8/8] SVM: add support for Nested Paging

2008-01-27 Thread Joerg Roedel
On Sun, Jan 27, 2008 at 10:52:30AM +0200, Avi Kivity wrote: > Joerg Roedel wrote: > > This patch contains the SVM architecture dependent changes for KVM to enable > > support for the Nested Paging feature of AMD Barcelona and Phenom > > processors. > > > > +#ifdef CONFIG_X86_64 > > +static bool

Re: [kvm-devel] [PATCH 8/8] SVM: add support for Nested Paging

2008-01-27 Thread Avi Kivity
Joerg Roedel wrote: > >> What happens to lazy fpu if we don't trap cr0 changes? >> >> Perhaps it's worth disabling lazy fpu with npt. >> > > It should be implicitly disabled with npt because accesses to cr3 are > not intercepted anymore. The svm_set_cr3 function is the only place > which disab

Re: [kvm-devel] [PATCH 8/8] SVM: add support for Nested Paging

2008-01-27 Thread Joerg Roedel
On Sun, Jan 27, 2008 at 11:51:06AM +0200, Avi Kivity wrote: > Joerg Roedel wrote: > > > >> What happens to lazy fpu if we don't trap cr0 changes? > >> > >> Perhaps it's worth disabling lazy fpu with npt. > >> > > > > It should be implicitly disabled with npt because accesses to cr3 are > > not

Re: [kvm-devel] [PATCH 8/8] SVM: add support for Nested Paging

2008-01-27 Thread Avi Kivity
Joerg Roedel wrote: >> On the other hand, we want to trap cr0 so the guest can't control the >> cache disable bits. Also cr4.pce and cr4.mce. >> > > Is it a problem when the guest disables caching? It disables it only in > its own context because it has its own copy of cr0. Some Intel proc