Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Add -Werror to libkvm compile

2008-03-26 Thread Avi Kivity
Jerone Young wrote: > Yeah. This could "potentially" cause hell for users (non developers) > down the road. I'm just going to keep this patch in my queue for myself, > so no one will complain about warnings from my patches anymore. > > I think having a --developer flag to configure could work, but

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Add -Werror to libkvm compile

2008-03-25 Thread Jerone Young
Yeah. This could "potentially" cause hell for users (non developers) down the road. I'm just going to keep this patch in my queue for myself, so no one will complain about warnings from my patches anymore. I think having a --developer flag to configure could work, but we would then need separate

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Add -Werror to libkvm compile

2008-03-25 Thread Avi Kivity
Jerone Young wrote: > It does work with gcc 4.2.3 . Though no idea if gcc-4.3 & 4.4 would > workout. Though they should. I'll need to to compile them and give them > a try. > While I'm a fan of -Werror, I have to agree with Anthony it can cause no end of pain to users if they have a slightly d

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Add -Werror to libkvm compile

2008-03-25 Thread Jerone Young
It does work with gcc 4.2.3 . Though no idea if gcc-4.3 & 4.4 would workout. Though they should. I'll need to to compile them and give them a try. On Mon, 2008-03-24 at 20:42 +0100, Segher Boessenkool wrote: > > This patch adds -Werror to CFLAGS for compilation of libkvm. This > > should stop com

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Add -Werror to libkvm compile

2008-03-24 Thread Segher Boessenkool
> This patch adds -Werror to CFLAGS for compilation of libkvm. This > should stop complaints about Warnings. Does libkvm build without warnings using GCC-4.3 (or even GCC-4.4) on all supported platforms? If not, please fix that first :-) Segher ---