Re: [PATCH 3/3] kvm: Fix obsolete comment about locking for kvm_io_bus_read/write

2013-05-02 Thread Gleb Natapov
On Thu, May 02, 2013 at 01:24:15AM +0200, Alexander Graf wrote: > > On 27.04.2013, at 02:53, Scott Wood wrote: > > > Nobody is actually calling these functions with slots_lock held. > > The srcu read lock, OTOH, is required. > > > > Signed-off-by: Scott Wood > > Marcelo, could you please ack?

RE: [PATCH 7/7 v3] KVM: PPC: Add userspace debug stub support

2013-05-02 Thread Bhushan Bharat-R65777
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Friday, April 26, 2013 4:46 PM > To: Bhushan Bharat-R65777 > Cc: kvm-ppc@vger.kernel.org; k...@vger.kernel.org; Wood Scott-B07421; Bhushan > Bharat-R65777 > Subject: Re: [PATCH 7/7 v3] KVM: PPC: Add userspace debug

Re: [PATCH 3/3] kvm: Fix obsolete comment about locking for kvm_io_bus_read/write

2013-05-02 Thread Alexander Graf
On 02.05.2013, at 09:18, Gleb Natapov wrote: > On Thu, May 02, 2013 at 01:24:15AM +0200, Alexander Graf wrote: >> >> On 27.04.2013, at 02:53, Scott Wood wrote: >> >>> Nobody is actually calling these functions with slots_lock held. >>> The srcu read lock, OTOH, is required. >>> >>> Signed-off-

Re: [PATCH 7/7 v3] KVM: PPC: Add userspace debug stub support

2013-05-02 Thread Alexander Graf
On 02.05.2013, at 11:46, Bhushan Bharat-R65777 wrote: > > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Friday, April 26, 2013 4:46 PM >> To: Bhushan Bharat-R65777 >> Cc: kvm-ppc@vger.kernel.org; k...@vger.kernel.org; Wood Scott-B07421; Bhushan >> Bharat-

Re: [PATCH] KVM: PPC: Book3S: Add API for in-kernel XICS emulation

2013-05-02 Thread Alexander Graf
On 27.04.2013, at 12:28, Paul Mackerras wrote: > This adds the API for userspace to instantiate an XICS device in a VM > and connect VCPUs to it. The API consists of a new device type for > the KVM_CREATE_DEVICE ioctl, a new capability KVM_CAP_IRQ_XICS, which > functions similarly to KVM_CAP_IRQ

Re: [PATCH -next] kvm/ppc/mpic: fix missing unlock in set_base_addr()

2013-05-02 Thread Alexander Graf
On 02.05.2013, at 07:17, Wei Yongjun wrote: > From: Wei Yongjun > > Add the missing unlock before return from function set_base_addr() > when disables the mapping. > > Introduced by commit 5df554ad5b7522ea62b0ff9d5be35183494efc21 > (kvm/ppc/mpic: in-kernel MPIC emulation) > > Signed-off-by: W

Re: [PATCH 1/3] kvm/ppc/booke: Hold srcu lock when calling gfn functions

2013-05-02 Thread Alexander Graf
On 02.05.2013, at 02:27, Scott Wood wrote: > On 05/01/2013 07:15:53 PM, Marcelo Tosatti wrote: >> On Fri, Apr 26, 2013 at 07:53:38PM -0500, Scott Wood wrote: >> > diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c >> > index 1020119..506c87d 100644 >> > --- a/arch/powerpc/kvm/booke.

Re: [PATCH 2/3] kvm/ppc: Hold srcu lock when calling kvm_io_bus_read/write

2013-05-02 Thread Alexander Graf
On 27.04.2013, at 02:53, Scott Wood wrote: > These functions do an srcu_dereference without acquiring the srcu lock > themselves. > > Signed-off-by: Scott Wood Thanks, applied to kvm-ppc-queue. Alex -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a messa

Re: [PATCH 3/3] kvm: Fix obsolete comment about locking for kvm_io_bus_read/write

2013-05-02 Thread Gleb Natapov
On Thu, May 02, 2013 at 12:53:44PM +0200, Alexander Graf wrote: > > On 02.05.2013, at 09:18, Gleb Natapov wrote: > > > On Thu, May 02, 2013 at 01:24:15AM +0200, Alexander Graf wrote: > >> > >> On 27.04.2013, at 02:53, Scott Wood wrote: > >> > >>> Nobody is actually calling these functions with

Re: [PATCH 1/2] kvm/ppc/mpic: fix mmio region lists when multiple guests used

2013-05-02 Thread Alexander Graf
On 01.05.2013, at 02:57, Scott Wood wrote: > Keeping a linked list of statically defined objects doesn't work > very well when we have multiple guests. :-P > > Switch to an array of constant objects. This fixes a hang when > multiple guests are used. > > Signed-off-by: Scott Wood Thanks, app

Re: [PATCH 3/3] kvm: Fix obsolete comment about locking for kvm_io_bus_read/write

2013-05-02 Thread Alexander Graf
On 02.05.2013, at 13:00, Gleb Natapov wrote: > On Thu, May 02, 2013 at 12:53:44PM +0200, Alexander Graf wrote: >> >> On 02.05.2013, at 09:18, Gleb Natapov wrote: >> >>> On Thu, May 02, 2013 at 01:24:15AM +0200, Alexander Graf wrote: On 27.04.2013, at 02:53, Scott Wood wrote: >>

[PULL 0/6] ppc patch queue 2013-05-02 for 3.10

2013-05-02 Thread Alexander Graf
Hi Marcelo / Gleb, This is my current patch queue for ppc. Please pull and apply to next, so it makes its way into 3.10. Sorry for the late request. There is still one RCU patch outstanding that needs a respin, so expect another request to come in later in the 3.10 cycle. Changes include: -

[PATCH 1/6] kvm/ppc/mpic: remove default routes from documentation

2013-05-02 Thread Alexander Graf
From: Scott Wood The default routes were removed from the code during patchset respinning, but were not removed from the documentation. Signed-off-by: Scott Wood Signed-off-by: Alexander Graf --- Documentation/virtual/kvm/devices/mpic.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/

[PATCH 3/6] kvm/ppc/mpic: remove users

2013-05-02 Thread Alexander Graf
From: Scott Wood This is an unused (no pun intended) leftover from when this code did reference counting. Signed-off-by: Scott Wood Signed-off-by: Alexander Graf --- arch/powerpc/kvm/mpic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c in

[PATCH 5/6] kvm/ppc/mpic: fix missing unlock in set_base_addr()

2013-05-02 Thread Alexander Graf
From: Wei Yongjun Add the missing unlock before return from function set_base_addr() when disables the mapping. Introduced by commit 5df554ad5b7522ea62b0ff9d5be35183494efc21 (kvm/ppc/mpic: in-kernel MPIC emulation) Signed-off-by: Wei Yongjun Signed-off-by: Alexander Graf --- arch/powerpc/kvm

[PATCH 4/6] kvm/ppc: Hold srcu lock when calling kvm_io_bus_read/write

2013-05-02 Thread Alexander Graf
From: Scott Wood These functions do an srcu_dereference without acquiring the srcu lock themselves. Signed-off-by: Scott Wood Signed-off-by: Alexander Graf --- arch/powerpc/kvm/powerpc.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/

[PATCH 6/6] KVM: PPC: Book3S: Add API for in-kernel XICS emulation

2013-05-02 Thread Alexander Graf
From: Paul Mackerras This adds the API for userspace to instantiate an XICS device in a VM and connect VCPUs to it. The API consists of a new device type for the KVM_CREATE_DEVICE ioctl, a new capability KVM_CAP_IRQ_XICS, which functions similarly to KVM_CAP_IRQ_MPIC, and the KVM_IRQ_LINE ioctl,

[PATCH 2/6] kvm/ppc/mpic: fix mmio region lists when multiple guests used

2013-05-02 Thread Alexander Graf
From: Scott Wood Keeping a linked list of statically defined objects doesn't work very well when we have multiple guests. :-P Switch to an array of constant objects. This fixes a hang when multiple guests are used. Signed-off-by: Scott Wood [agraf: remove struct list_head from mem_reg] Signed

RE: [PATCH 7/7 v3] KVM: PPC: Add userspace debug stub support

2013-05-02 Thread Bhushan Bharat-R65777
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Thursday, May 02, 2013 4:35 PM > To: Bhushan Bharat-R65777 > Cc: kvm-ppc@vger.kernel.org; k...@vger.kernel.org; Wood Scott-B07421 > Subject: Re: [PATCH 7/7 v3] KVM: PPC: Add userspace debug stub support > > > On

Re: [PATCH 7/7 v3] KVM: PPC: Add userspace debug stub support

2013-05-02 Thread Alexander Graf
On 02.05.2013, at 16:00, Bhushan Bharat-R65777 wrote: > > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Thursday, May 02, 2013 4:35 PM >> To: Bhushan Bharat-R65777 >> Cc: kvm-ppc@vger.kernel.org; k...@vger.kernel.org; Wood Scott-B07421 >> Subject: Re: [PA

Re: [PATCH 1/3] kvm/ppc/booke: Hold srcu lock when calling gfn functions

2013-05-02 Thread Marcelo Tosatti
On Wed, May 01, 2013 at 07:27:23PM -0500, Scott Wood wrote: > On 05/01/2013 07:15:53 PM, Marcelo Tosatti wrote: > >On Fri, Apr 26, 2013 at 07:53:38PM -0500, Scott Wood wrote: > >> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c > >> index 1020119..506c87d 100644 > >> --- a/arch/pow

Re: [PATCH 1/3] kvm/ppc/booke: Hold srcu lock when calling gfn functions

2013-05-02 Thread Scott Wood
On 05/02/2013 09:37:53 AM, Marcelo Tosatti wrote: On Wed, May 01, 2013 at 07:27:23PM -0500, Scott Wood wrote: > On 05/01/2013 07:15:53 PM, Marcelo Tosatti wrote: > >On Fri, Apr 26, 2013 at 07:53:38PM -0500, Scott Wood wrote: > >> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c >

Re: [PULL 0/6] ppc patch queue 2013-05-02 for 3.10

2013-05-02 Thread Marcelo Tosatti
On Thu, May 02, 2013 at 03:32:45PM +0200, Alexander Graf wrote: > Hi Marcelo / Gleb, > > This is my current patch queue for ppc. Please pull and apply to next, so it > makes its way into 3.10. Sorry for the late request. > > There is still one RCU patch outstanding that needs a respin, so expect