Re: [PULL 0/3] 4.0 patch queue 2015-03-25

2015-03-25 Thread Marcelo Tosatti
On Wed, Mar 25, 2015 at 10:58:54PM +0100, Alexander Graf wrote: Hi Paolo, This is my current patch queue for 4.0. Please pull. Alex The following changes since commit f710a12d73dfa1c3a5d2417f2482b970f03bb850: Merge tag 'kvm-arm-fixes-4.0-rc5' of

Re: [PATCH 1/3] kvm/ppc/booke: Hold srcu lock when calling gfn functions

2013-05-02 Thread Marcelo Tosatti
On Wed, May 01, 2013 at 07:27:23PM -0500, Scott Wood wrote: On 05/01/2013 07:15:53 PM, Marcelo Tosatti wrote: On Fri, Apr 26, 2013 at 07:53:38PM -0500, Scott Wood wrote: diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c index 1020119..506c87d 100644 --- a/arch/powerpc/kvm

Re: [PULL 0/6] ppc patch queue 2013-05-02 for 3.10

2013-05-02 Thread Marcelo Tosatti
On Thu, May 02, 2013 at 03:32:45PM +0200, Alexander Graf wrote: Hi Marcelo / Gleb, This is my current patch queue for ppc. Please pull and apply to next, so it makes its way into 3.10. Sorry for the late request. There is still one RCU patch outstanding that needs a respin, so expect

Re: [PATCH 16/17] KVM: PPC: MPIC: Add support for KVM_IRQ_LINE

2013-05-01 Thread Marcelo Tosatti
On Thu, Apr 25, 2013 at 11:13:40PM +0200, Alexander Graf wrote: On 25.04.2013, at 21:03, Scott Wood wrote: On 04/25/2013 09:49:23 AM, Alexander Graf wrote: On 25.04.2013, at 13:30, Alexander Graf wrote: On 19.04.2013, at 20:51, Scott Wood wrote: On 04/19/2013 09:06:27 AM,

Re: [PATCH 1/3] kvm/ppc/booke: Hold srcu lock when calling gfn functions

2013-05-01 Thread Marcelo Tosatti
On Fri, Apr 26, 2013 at 07:53:38PM -0500, Scott Wood wrote: KVM core expects arch code to acquire the srcu lock when calling gfn_to_memslot and similar functions. Signed-off-by: Scott Wood scottw...@freescale.com --- arch/powerpc/kvm/44x_tlb.c |5 + arch/powerpc/kvm/booke.c|

Re: [PULL 0/7] ppc patch queue 2013-03-22

2013-04-12 Thread Marcelo Tosatti
On Thu, Apr 11, 2013 at 03:50:13PM +0200, Alexander Graf wrote: On 11.04.2013, at 15:45, Marcelo Tosatti wrote: On Tue, Mar 26, 2013 at 12:59:04PM +1100, Paul Mackerras wrote: On Tue, Mar 26, 2013 at 03:33:12AM +0200, Gleb Natapov wrote: On Tue, Mar 26, 2013 at 12:35:09AM +0100

Re: [PULL 0/7] ppc patch queue 2013-03-22

2013-04-11 Thread Marcelo Tosatti
On Tue, Mar 26, 2013 at 12:59:04PM +1100, Paul Mackerras wrote: On Tue, Mar 26, 2013 at 03:33:12AM +0200, Gleb Natapov wrote: On Tue, Mar 26, 2013 at 12:35:09AM +0100, Alexander Graf wrote: I agree. So if it doesn't hurt to have the same commits in kvm/next and kvm/master, I'd be more

Re: [RFC PATCH 1/6] kvm: add device control API

2013-02-23 Thread Marcelo Tosatti
On Thu, Feb 21, 2013 at 08:00:25PM -0600, Scott Wood wrote: On 02/21/2013 05:03:32 PM, Marcelo Tosatti wrote: On Wed, Feb 20, 2013 at 07:28:52PM -0600, Scott Wood wrote: On 02/20/2013 06:14:37 PM, Marcelo Tosatti wrote: On Wed, Feb 20, 2013 at 05:53:20PM -0600, Scott Wood wrote

Re: [RFC PATCH 1/6] kvm: add device control API

2013-02-21 Thread Marcelo Tosatti
On Wed, Feb 20, 2013 at 07:28:52PM -0600, Scott Wood wrote: On 02/20/2013 06:14:37 PM, Marcelo Tosatti wrote: On Wed, Feb 20, 2013 at 05:53:20PM -0600, Scott Wood wrote: It is then not necessary to set device attributes on a live guest and deal with the complications associated

Re: [PATCH 3/9] KVM: PPC: Book3S: Add kernel emulation for the XICS interrupt controller

2013-02-20 Thread Marcelo Tosatti
On Wed, Feb 20, 2013 at 06:20:51PM -0600, Scott Wood wrote: On 02/20/2013 01:58:54 PM, Marcelo Tosatti wrote: This is probably a stupid question, but why the KVM_SET_IRQCHIP/KVM_SET_GSI_ROUTING interface is not appropriate for your purposes? x86 sets up a default GSI-IRQCHIP PIN mapping

Re: [RFC PATCH 1/6] kvm: add device control API

2013-02-20 Thread Marcelo Tosatti
On Wed, Feb 20, 2013 at 05:53:20PM -0600, Scott Wood wrote: Why exactly you need to set attributes Scott? That's best answered by looking at patch 6/6 and discussing the actual attributes that are defined so far. The need to set the base address of the registers is straightforward. When

Re: [PULL 00/14] ppc patch queue 2013-02-15

2013-02-18 Thread Marcelo Tosatti
Pulled, thanks. On Fri, Feb 15, 2013 at 01:16:16AM +0100, Alexander Graf wrote: Hi Marcelo / Gleb, This is my current patch queue for ppc. Please pull. Highlights of this queue drop are: - BookE: Fast mapping support for 4k backed memory - BookE: Handle alignment interrupts

Re: [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8

2013-01-21 Thread Marcelo Tosatti
On Fri, Jan 18, 2013 at 12:48:25AM +0100, Alexander Graf wrote: Hi Marcelo / Gleb, This is my current patch queue for ppc against 3.8. Please pull. It contains a bug fix for an issue that Ben Collins ran into, where a guest would just abort because it traps during an unknown instruction.

Re: [PULL 00/28] ppc patch queue 2012-12-06

2012-12-09 Thread Marcelo Tosatti
On Thu, Dec 06, 2012 at 01:40:49AM +0100, Alexander Graf wrote: Hi Marcelo / Gleb, This is my current patch queue for ppc. Please pull. Major changes this time around include: - Book3S PR: Multiple fixes for POWER7 hosts - Book3S HV: Prepare for full state exposure (live migration)

Re: [PULL 00/12] ppc patch queue 2012-10-30

2012-10-31 Thread Marcelo Tosatti
On Wed, Oct 31, 2012 at 12:26:04PM +0200, Avi Kivity wrote: On 10/31/2012 12:22 PM, Alexander Graf wrote: On 31.10.2012, at 02:32, Marcelo Tosatti mtosa...@redhat.com wrote: On Tue, Oct 30, 2012 at 11:02:13AM +0100, Alexander Graf wrote: Hi Avi / Marcelo, This is my current

Re: [PULL 00/12] ppc patch queue 2012-10-30

2012-10-31 Thread Marcelo Tosatti
On Wed, Oct 31, 2012 at 11:22:55AM +0100, Alexander Graf wrote: On 31.10.2012, at 02:32, Marcelo Tosatti mtosa...@redhat.com wrote: On Tue, Oct 30, 2012 at 11:02:13AM +0100, Alexander Graf wrote: Hi Avi / Marcelo, This is my current patch queue for ppc. Please pull. Headline

Re: [PATCH RFC 1/2] KVM: PPC: Move kvm-arch.slot_phys into memslot.arch

2012-08-27 Thread Marcelo Tosatti
On Sat, Aug 25, 2012 at 10:40:40PM +1000, Paul Mackerras wrote: Now that we have an architecture-specific field in the kvm_memory_slot structure, we can use it to store the array of page physical addresses that we need for Book3S HV KVM on PPC970 processors. This reduces the size of struct

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-24 Thread Marcelo Tosatti
On Fri, Aug 24, 2012 at 07:29:53PM +1000, Paul Mackerras wrote: On Thu, Aug 23, 2012 at 10:55:37AM -0300, Marcelo Tosatti wrote: There are a number of options to consider: 1) Merge the current patchset from Paul, which has two downsides: 1-1) It contains an unfixable race

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-13 Thread Marcelo Tosatti
On Mon, Aug 13, 2012 at 01:34:11PM -0300, Marcelo Tosatti wrote: On Sat, Aug 11, 2012 at 10:37:54AM +1000, Paul Mackerras wrote: On Fri, Aug 10, 2012 at 03:35:53PM -0300, Marcelo Tosatti wrote: There's no plan. I just wanted to confirm this before converting to per-memslot flush

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-10 Thread Marcelo Tosatti
On Fri, Aug 10, 2012 at 11:09:09AM +0900, Takuya Yoshikawa wrote: On Thu, 9 Aug 2012 22:25:32 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: I'll send a patch to flush per memslot in the next days, you can work out the PPC details in the meantime. Not anymore. Are you going

Re: [RFC PATCH 5/5] KVM: PPC: Take the SRCU lock around memslot use

2012-08-09 Thread Marcelo Tosatti
On Mon, Aug 06, 2012 at 08:08:16PM +1000, Paul Mackerras wrote: The generic KVM code uses SRCU (sleeping RCU) to protect accesses to the memslots data structures against updates due to userspace adding, modifying or removing memory slots. We need to do that too, both to avoid accessing stale

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-09 Thread Marcelo Tosatti
On Mon, Aug 06, 2012 at 08:06:03PM +1000, Paul Mackerras wrote: From 44067a8ee15021583636bea4cc1d47e5370b8397 Mon Sep 17 00:00:00 2001 From: Paul Mackerras pau...@samba.org Date: Mon, 30 Jul 2012 16:40:54 +1000 Subject: At present the HV style of KVM doesn't handle deletion or modification

Re: [PATCH 4/5] KVM: PPC: Book3S HV: Take the SRCU read lock before looking up memslots

2012-08-09 Thread Marcelo Tosatti
On Mon, Aug 06, 2012 at 08:06:55PM +1000, Paul Mackerras wrote: The generic KVM code uses SRCU (sleeping RCU) to protect accesses to the memslots data structures against updates due to userspace adding, modifying or removing memory slots. We need to do that too, both to avoid accessing stale

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-09 Thread Marcelo Tosatti
On Thu, Aug 09, 2012 at 10:25:32PM -0300, Marcelo Tosatti wrote: On Fri, Aug 10, 2012 at 10:34:39AM +1000, Paul Mackerras wrote: On Thu, Aug 09, 2012 at 03:16:12PM -0300, Marcelo Tosatti wrote: The !memslot-npages case is handled in __kvm_set_memory_region (please read that part

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-09 Thread Marcelo Tosatti
On Fri, Aug 10, 2012 at 10:34:39AM +1000, Paul Mackerras wrote: On Thu, Aug 09, 2012 at 03:16:12PM -0300, Marcelo Tosatti wrote: The !memslot-npages case is handled in __kvm_set_memory_region (please read that part, before kvm_arch_prepare_memory_region() call). kvm_arch_flush_shadow

Re: Reset problem vs. MMIO emulation, hypercalls, etc...

2012-08-03 Thread Marcelo Tosatti
On Fri, Aug 03, 2012 at 06:20:18AM +1000, Benjamin Herrenschmidt wrote: On Thu, 2012-08-02 at 15:35 +0300, Avi Kivity wrote: This is actually documented in api.txt, though not in relation to reset: NOTE: For KVM_EXIT_IO, KVM_EXIT_MMIO and KVM_EXIT_OSI, the corresponding operations

Re: Reset problem vs. MMIO emulation, hypercalls, etc...

2012-08-03 Thread Marcelo Tosatti
On Fri, Aug 03, 2012 at 02:41:13PM -0300, Marcelo Tosatti wrote: On Fri, Aug 03, 2012 at 06:20:18AM +1000, Benjamin Herrenschmidt wrote: On Thu, 2012-08-02 at 15:35 +0300, Avi Kivity wrote: This is actually documented in api.txt, though not in relation to reset: NOTE

Re: [PATCH 2/2 v5] KVM: PPC: booke: Add watchdog emulation

2012-07-25 Thread Marcelo Tosatti
On Fri, Jul 20, 2012 at 04:29:08PM -0500, Scott Wood wrote: On 07/20/2012 12:00 AM, Bharat Bhushan wrote: This patch adds the watchdog emulation in KVM. The watchdog emulation is enabled by KVM_ENABLE_CAP(KVM_CAP_PPC_WDT) ioctl. The kernel timer are used for watchdog emulation and emulates

Re: [PATCH 2/2 v5] KVM: PPC: booke: Add watchdog emulation

2012-07-25 Thread Marcelo Tosatti
On Wed, Jul 25, 2012 at 06:55:16PM -0500, Scott Wood wrote: On 07/25/2012 03:37 PM, Marcelo Tosatti wrote: On Fri, Jul 20, 2012 at 04:29:08PM -0500, Scott Wood wrote: On 07/20/2012 12:00 AM, Bharat Bhushan wrote: This patch adds the watchdog emulation in KVM. The watchdog emulation

Re: [PATCH 0/8] KVM: Optimize MMU notifier's THP page invalidation -v4

2012-07-18 Thread Marcelo Tosatti
On Mon, Jul 02, 2012 at 05:52:39PM +0900, Takuya Yoshikawa wrote: v3-v4: Resolved trace_kvm_age_page() issue -- patch 6,7 v2-v3: Fixed intersection calculations. -- patch 3, 8 Takuya Takuya Yoshikawa (8): KVM: MMU: Use __gfn_to_rmap() to clean up kvm_handle_hva() KVM: Introduce

Re: [PATCH 0/8] KVM: Optimize MMU notifier's THP page invalidation -v4

2012-07-05 Thread Marcelo Tosatti
On Mon, Jul 02, 2012 at 05:52:39PM +0900, Takuya Yoshikawa wrote: v3-v4: Resolved trace_kvm_age_page() issue -- patch 6,7 v2-v3: Fixed intersection calculations. -- patch 3, 8 Takuya Takuya Yoshikawa (8): KVM: MMU: Use __gfn_to_rmap() to clean up kvm_handle_hva() KVM: Introduce

Re: [PATCH v2] KVM: PPC: Rework wqp conditional code

2012-03-13 Thread Marcelo Tosatti
On Tue, Mar 13, 2012 at 10:35:01PM +0100, Alexander Graf wrote: On PowerPC, we sometimes use a waitqueue per core, not per thread, so we can't always use the vcpu internal waitqueue. This code has been generalized by Christoffer Dall recently, but unfortunately broke compilation for PowerPC.

Re: [PATCH v4] KVM: Factor out kvm_vcpu_kick to arch-generic code

2012-03-09 Thread Marcelo Tosatti
On Thu, Mar 08, 2012 at 04:44:24PM -0500, Christoffer Dall wrote: Any news on the status of this? On Thu, Feb 9, 2012 at 8:45 PM, Alexander Graf ag...@suse.de wrote: On 10.02.2012, at 02:40, Christoffer Dall wrote: The kvm_vcpu_kick function performs roughly the same funcitonality on

Re: [PATCH 19/38] KVM: PPC: e500mc: add load inst fixup

2012-03-08 Thread Marcelo Tosatti
On Wed, Feb 29, 2012 at 01:09:47AM +0100, Alexander Graf wrote: There's always a chance we're unable to read a guest instruction. The guest could have its TLB mapped execute-, but not readable, something odd happens and our TLB gets flushed. So it's a good idea to be prepared for that case and

Re: [PATCH v2] KVM: Factor out kvm_vcpu_kick to arch-generic code

2012-02-06 Thread Marcelo Tosatti
On Tue, Jan 24, 2012 at 11:27:39PM -0500, Christoffer Dall wrote: The kvm_vcpu_kick function performs roughly the same funcitonality on most all architectures, so we shouldn't have separate copies. PowerPC keeps a pointer to interchanging waitqueues on the vcpu_arch structure and to

Re: [PATCH v2] KVM: Factor out kvm_vcpu_kick to arch-generic code

2012-02-06 Thread Marcelo Tosatti
On Mon, Feb 06, 2012 at 09:06:04PM +0100, Jan Kiszka wrote: On 2012-02-06 19:25, Marcelo Tosatti wrote: diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index c38efd7..a1761ff 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2252,7 +2252,6 @@ void kvm_arch_vcpu_load

Re: [PATCH] KVM: Factor out kvm_vcpu_kick to arch-generic code

2012-01-23 Thread Marcelo Tosatti
On Thu, Jan 19, 2012 at 10:22:41PM -0500, Christoffer Dall wrote: The kvm_vcpu_kick function performs roughly the same funcitonality on most all architectures, so we shouldn't have separate copies. PowerPC keeps a pointer to interchanging waitqueues on the vcpu_arch structure and to

Re: [PATCH 0/4] KVM: Decouple rmap_pde from lpage_info write_count

2012-01-23 Thread Marcelo Tosatti
On Mon, Jan 23, 2012 at 07:42:04PM +0900, Takuya Yoshikawa wrote: The last one is an RFC patch: I think it is better to refactor the rmap things, if needed, before other architectures than x86 starts large pages support. Takuya Looks good to me. -- To unsubscribe from this list:

Re: [PULL 00/52] ppc patch queue 2012-01-13

2012-01-16 Thread Marcelo Tosatti
On Fri, Jan 13, 2012 at 03:31:03PM +0100, Alexander Graf wrote: Hi Avi, This is my current patch queue for ppc. Please pull. Alex The following changes since commit 188fc33198ddb1469562d40de33bcc29e7e2ed5f: Christian Borntraeger (1): kvm-s390: provide access guest registers

Re: [RFC PATCH 11/11] KVM: PPC: Eliminate global spinlock in kvmppc_h_enter

2011-11-23 Thread Marcelo Tosatti
On Thu, Nov 17, 2011 at 10:55:49AM +1100, Paul Mackerras wrote: From dfd5bcfac841f8a36593edf60d9fb15e0d633287 Mon Sep 17 00:00:00 2001 From: Paul Mackerras pau...@samba.org Date: Mon, 14 Nov 2011 13:30:38 +1100 Subject: Currently, kvmppc_h_enter takes a spinlock that is global to the

Re: [RFC PATCH 0/11] KVM: PPC: Update Book3S HV memory handling

2011-11-23 Thread Marcelo Tosatti
On Sat, Nov 19, 2011 at 08:54:24AM +1100, Paul Mackerras wrote: On Fri, Nov 18, 2011 at 02:57:11PM +0100, Alexander Graf wrote: This touches areas that I'm sure non-PPC people would want to see as well. Could you please CC kvm@vger too next time? Avi, Marcelo, mind to review some of

Re: [PATCH 09/14] KVM: PPC: Add generic single register ioctls

2011-11-10 Thread Marcelo Tosatti
On Thu, Nov 10, 2011 at 05:49:42PM +0100, Alexander Graf wrote: Documentation/virtual/kvm/api.txt | 47 ++ arch/powerpc/kvm/powerpc.c| 51 + include/linux/kvm.h | 32 +++

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-09-21 Thread Marcelo Tosatti
On Wed, Sep 21, 2011 at 07:11:08AM -0700, Dave Hansen wrote: On Tue, 2011-09-20 at 16:55 -0300, Marcelo Tosatti wrote: and the wall clock stays behind my host wall clock by the amount of time it took to resume. This is expected, similar to savevm/loadvm. That seems like pretty

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-09-09 Thread Marcelo Tosatti
On Thu, Sep 01, 2011 at 02:27:49PM -0600, emun...@mgebm.net wrote: On Thu, 01 Sep 2011 14:24:12 -0500, Anthony Liguori wrote: On 08/30/2011 07:26 AM, Marcelo Tosatti wrote: On Mon, Aug 29, 2011 at 05:27:11PM -0600, Eric B Munson wrote: Currently, when qemu stops a guest kernel that guest

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-08-30 Thread Marcelo Tosatti
On Tue, Aug 30, 2011 at 09:12:17AM -0500, Ryan Harper wrote: * Marcelo Tosatti mtosa...@redhat.com [2011-08-30 07:35]: On Mon, Aug 29, 2011 at 05:27:11PM -0600, Eric B Munson wrote: Currently, when qemu stops a guest kernel that guest will issue a soft lockup message when it resumes

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-08-30 Thread Marcelo Tosatti
On Tue, Aug 30, 2011 at 09:43:19AM -0500, Ryan Harper wrote: * Marcelo Tosatti mtosa...@redhat.com [2011-08-30 09:40]: On Tue, Aug 30, 2011 at 09:12:17AM -0500, Ryan Harper wrote: * Marcelo Tosatti mtosa...@redhat.com [2011-08-30 07:35]: On Mon, Aug 29, 2011 at 05:27:11PM -0600, Eric B

Re: [PULL 00/17] KVM PPC patch queue 2011-07-04

2011-07-07 Thread Marcelo Tosatti
On Mon, Jul 04, 2011 at 04:12:37PM +0200, Alexander Graf wrote: Hi Avi, Here is my current patch queue for KVM on PPC. It contains support for hardware accelerated KVM on 970 and POWER7 (no hardware) which is one of the most interesting features we had added for a while now. This new

Re: [PATCH] KVM: PPC: Fix SPRG get/set for Book3S and BookE

2011-01-06 Thread Marcelo Tosatti
On Wed, Dec 29, 2010 at 01:51:25PM -0600, Peter Tyser wrote: Previously SPRGs 4-7 were improperly read and written in kvm_arch_vcpu_ioctl_get_regs() and kvm_arch_vcpu_ioctl_set_regs(); Signed-off-by: Peter Tyser pty...@xes-inc.com --- I noticed this while grepping for somthing unrelated and

Re: [PATCH] powerpc: kvm: fix information leak to userland

2010-11-01 Thread Marcelo Tosatti
On Sat, Oct 30, 2010 at 01:04:24PM +0400, Vasiliy Kulikov wrote: Structure kvm_ppc_pvinfo is copied to userland with flags and pad fields unitialized. It leads to leaking of contents of kernel stack memory. Signed-off-by: Vasiliy Kulikov sego...@gmail.com --- I cannot compile this

Re: [PATCH] PPC: KVM: Book E doesn't have __end_interrupts.

2010-10-19 Thread Marcelo Tosatti
On Tue, Oct 19, 2010 at 12:57:29AM +0200, Alexander Graf wrote: On 19.10.2010, at 00:35, Scott Wood wrote: Fix an unresolved symbol with CONFIG_KVM_GUEST plus CONFIG_RELOCATABLE on Book E. Thanks, applied to the kvm-ppc-next tree. Avi, could you please pull my tree asap? That

Re: [PATCH 0/2] Faster MMU lookups for Book3s v3

2010-07-01 Thread Marcelo Tosatti
On Wed, Jun 30, 2010 at 03:18:44PM +0200, Alexander Graf wrote: Book3s suffered from my really bad shadow MMU implementation so far. So I finally got around to implement a combined hash and list mechanism that allows for much faster lookup of mapped pages. To show that it really is faster, I

Re: [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log()

2010-06-23 Thread Marcelo Tosatti
On Wed, Jun 23, 2010 at 12:00:47PM +0300, Avi Kivity wrote: On 06/23/2010 12:01 PM, Takuya Yoshikawa wrote: (2010/06/23 17:48), Avi Kivity wrote: diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c index 801d9f3..bea6f7c 100644 --- a/arch/powerpc/kvm/book3s.c +++

Re: [PATCH 0/4] KVM: kvm_vm_ioctl_get_dirty_log() fix and cleanup

2010-06-22 Thread Marcelo Tosatti
On Tue, Jun 22, 2010 at 06:03:58PM +0900, Takuya Yoshikawa wrote: This patch set is for making dirty logging development, and of course maintenance, easier. Please see individual patches for details. Takuya --- arch/ia64/kvm/kvm-ia64.c | 54

Re: [PATCH] KVM: PPC: elide struct thread_struct instances from stack

2010-06-02 Thread Marcelo Tosatti
On Mon, May 31, 2010 at 09:59:13PM +0200, Andreas Schwab wrote: Instead of instantiating a whole thread_struct on the stack use only the required parts of it. Signed-off-by: Andreas Schwab sch...@linux-m68k.org Tested-by: Alexander Graf ag...@suse.de --- arch/powerpc/include/asm/kvm_fpu.h

Re: Any comments? Re: [RFC][PATCH 0/12] KVM, x86, ppc, asm-generic: moving dirty bitmaps to user space

2010-06-01 Thread Marcelo Tosatti
On Mon, May 24, 2010 at 04:05:29PM +0900, Takuya Yoshikawa wrote: (2010/05/17 18:06), Takuya Yoshikawa wrote: User allocated bitmaps have the advantage of reducing pinned memory. However we have plenty more pinned memory allocated in memory slots, so by itself, user allocated bitmaps don't

Re: Any comments? Re: [RFC][PATCH 0/12] KVM, x86, ppc, asm-generic: moving dirty bitmaps to user space

2010-06-01 Thread Marcelo Tosatti
On Tue, Jun 01, 2010 at 09:05:38PM +0900, Takuya Yoshikawa wrote: (2010/06/01 19:55), Marcelo Tosatti wrote: Sorry but I have to say that mmu_lock spin_lock problem was completely out of my mind. Although I looked through the code, it seems not easy to move the set_bit_user to outside

Re: Keep index within boundaries in kvmppc_44x_emul_tlbwe()

2010-05-12 Thread Marcelo Tosatti
On Tue, May 11, 2010 at 01:10:49AM +0200, Alexander Graf wrote: On 11.05.2010, at 00:58, Hollis Blanchard wrote: On Sun, May 9, 2010 at 8:26 AM, Roel Kluin roel.kl...@gmail.com wrote: An index of KVM44x_GUEST_TLB_SIZE is already one too large. Signed-off-by: Roel Kluin

Re: [PATCH v2 0/3] kvmppc/e500: fix breaks

2010-01-23 Thread Marcelo Tosatti
On Fri, Jan 22, 2010 at 06:50:28PM +0800, Liu Yu wrote: These patches fix current e500 break. v2: patch 2: add comment about PIR patch 3: move tlbcfg code to init Applied all (and updated 3/3), thanks. -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a

Re: [PATCH] PPC: Enable lightweight exits again

2010-01-06 Thread Marcelo Tosatti
On Mon, Jan 04, 2010 at 10:19:25PM +0100, Alexander Graf wrote: The PowerPC C ABI defines that registers r14-r31 need to be preserved across function calls. Since our exit handler is written in C, we can make use of that and don't need to reload r14-r31 on every entry/exit cycle. This

Re: build error

2010-01-05 Thread Marcelo Tosatti
On Sun, Jan 03, 2010 at 03:09:52AM +0100, Alexander Graf wrote: Hi Marcelo, On 30.12.2009, at 16:40, Giuseppe Falsetti wrote: Hi, I get this error when compile the git tree virt/kvm/kvm.git next My machine is a Xserve G5 DUAL processor, Lenny with gcc-4.3.2 HOSTCC

Re: [PATCH] Only expose compat ioctl when CONFIG_COMPAT

2009-10-23 Thread Marcelo Tosatti
On Fri, Oct 23, 2009 at 11:41:54AM +0200, Alexander Graf wrote: Jan spotted that we shouldn't use a function only available when CONFIG_COMPAT in a struct that's available without the config option. So since my patch introduces that, let's just not export the compat ioctl function when

Re: [PATCH] Enable 32bit dirty log pointers on 64bit host

2009-10-22 Thread Marcelo Tosatti
On Wed, Oct 21, 2009 at 04:08:29PM +0200, Alexander Graf wrote: From: Arnd Bergmann a...@arndb.de With big endian userspace, we can't quite figure out if a pointer is 32 bit (shifted 32) or 64 bit when we read a 64 bit pointer. This is what happens with dirty logging. To get the pointer