RE: Software breakpoint in kvmppc guest debug

2010-11-22 Thread Yoder Stuart-B08248
> > > What about using the ehpriv instruction (defined in 2.06)? > > > We could define a unique "qemu software breakpoint", and the > > > hypervisor's ehpriv handler will be able to easily distinguish them. > > > > > > On e500v2, this would be an illegal instruction. > > > > > > We don't need to wo

Re: Software breakpoint in kvmppc guest debug

2010-11-10 Thread Jan Kiszka
xander Graf >>> Sent: Tuesday, November 09, 2010 12:50 PM >>> To: Wood Scott-B07421 >>> Cc: Hollis Blanchard; Liu Yu-B13201; kvm-ppc@vger.kernel.org; Jan >> Kiszka >>> Subject: Re: Software breakpoint in kvmppc guest debug >>> >>> &g

RE: Software breakpoint in kvmppc guest debug

2010-11-09 Thread Yoder Stuart-B08248
Graf > >> Sent: Tuesday, November 09, 2010 12:50 PM > >> To: Wood Scott-B07421 > >> Cc: Hollis Blanchard; Liu Yu-B13201; kvm-ppc@vger.kernel.org; Jan > > Kiszka > >> Subject: Re: Software breakpoint in kvmppc guest debug > >> > >> > &

Re: Software breakpoint in kvmppc guest debug

2010-11-09 Thread Alexander Graf
od Scott-B07421 >> Cc: Hollis Blanchard; Liu Yu-B13201; kvm-ppc@vger.kernel.org; Jan > Kiszka >> Subject: Re: Software breakpoint in kvmppc guest debug >> >> >> On 09.11.2010, at 19:43, Scott Wood wrote: >> >>> On Tue, 9 Nov 2010 19:26:25 +01

RE: Software breakpoint in kvmppc guest debug

2010-11-09 Thread Yoder Stuart-B08248
szka > Subject: Re: Software breakpoint in kvmppc guest debug > > > On 09.11.2010, at 19:43, Scott Wood wrote: > > > On Tue, 9 Nov 2010 19:26:25 +0100 > > Alexander Graf wrote: > > > >> > >> On 09.11.2010, at 19:17, Scott Wood wrote: >

Re: Software breakpoint in kvmppc guest debug

2010-11-09 Thread Alexander Graf
On 09.11.2010, at 19:43, Scott Wood wrote: > On Tue, 9 Nov 2010 19:26:25 +0100 > Alexander Graf wrote: > >> >> On 09.11.2010, at 19:17, Scott Wood wrote: >> >>> On Tue, 9 Nov 2010 18:14:31 +0100 >>> Alexander Graf wrote: >>> Now, if we can get away with not using an undefined instructi

Re: Software breakpoint in kvmppc guest debug

2010-11-09 Thread Scott Wood
On Tue, 9 Nov 2010 19:26:25 +0100 Alexander Graf wrote: > > On 09.11.2010, at 19:17, Scott Wood wrote: > > > On Tue, 9 Nov 2010 18:14:31 +0100 > > Alexander Graf wrote: > > > >> Now, if we can get away with not using an undefined instruction (be it sc > >> 64 or trap) I don't know. I'm not e

Re: Software breakpoint in kvmppc guest debug

2010-11-09 Thread Alexander Graf
On 09.11.2010, at 19:17, Scott Wood wrote: > On Tue, 9 Nov 2010 18:14:31 +0100 > Alexander Graf wrote: > >> Now, if we can get away with not using an undefined instruction (be it sc 64 >> or trap) I don't know. I'm not even sure we can get away with trap. >> Basically, WARN_ON should also tri

Re: Software breakpoint in kvmppc guest debug

2010-11-09 Thread Scott Wood
On Tue, 9 Nov 2010 17:50:12 +0100 Alexander Graf wrote: > > There are also some fun issues regarding MSR[DE] with E.HV -- > > there are two modes, either the guest can control it directly (and shut > > down KVM's debug events) or the guest does not have access to debug > > resources at all and gu

Re: Software breakpoint in kvmppc guest debug

2010-11-09 Thread Scott Wood
On Tue, 9 Nov 2010 18:14:31 +0100 Alexander Graf wrote: > Now, if we can get away with not using an undefined instruction (be it sc 64 > or trap) I don't know. I'm not even sure we can get away with trap. > Basically, WARN_ON should also trigger a trap, so you'd end up in gdb for > that when h

Re: Software breakpoint in kvmppc guest debug

2010-11-09 Thread Hollis Blanchard
On 11/09/2010 08:50 AM, Alexander Graf wrote: On 09.11.2010, at 17:36, Scott Wood wrote: > On Tue, 9 Nov 2010 13:14:47 +0100 > Alexander Graf wrote: >> On 09.11.2010, at 04:40, Liu Yu-B13201 wrote: >>> Software breakpoint is a instruction which should make guest exit. >>> We replace gues

Re: Software breakpoint in kvmppc guest debug

2010-11-09 Thread Alexander Graf
On 09.11.2010, at 18:00, Hollis Blanchard wrote: > On 11/09/2010 08:50 AM, Alexander Graf wrote: >> On 09.11.2010, at 17:36, Scott Wood wrote: >>> > On Tue, 9 Nov 2010 13:14:47 +0100 >>> > Alexander Graf wrote: >> On 09.11.2010, at 04:40, Liu Yu-B13201 wrote: > >>> Software breakpoi

Re: Software breakpoint in kvmppc guest debug

2010-11-09 Thread Alexander Graf
On 09.11.2010, at 17:36, Scott Wood wrote: > On Tue, 9 Nov 2010 13:14:47 +0100 > Alexander Graf wrote: > >> On 09.11.2010, at 04:40, Liu Yu-B13201 wrote: >> >>> Software breakpoint is a instruction which should make guest exit. >>> We replace guest code with software breakpoint instruction so

Re: Software breakpoint in kvmppc guest debug

2010-11-09 Thread Scott Wood
On Tue, 9 Nov 2010 13:14:47 +0100 Alexander Graf wrote: > On 09.11.2010, at 04:40, Liu Yu-B13201 wrote: > > > Software breakpoint is a instruction which should make guest exit. > > We replace guest code with software breakpoint instruction so that we can > > stop at anywhere we want. > > > > I

Re: Software breakpoint in kvmppc guest debug

2010-11-09 Thread Alexander Graf
Hi Yu, On 09.11.2010, at 04:40, Liu Yu-B13201 wrote: > > Hello all, > > Software breakpoint is a instruction which should make guest exit. > We replace guest code with software breakpoint instruction so that we can > stop at anywhere we want. > > In my previous guest debug patches for e500, I