Re: [PATCH 04/14] KVM: PPC: e500: MMU API

2011-11-10 Thread Avi Kivity
On 11/10/2011 04:20 PM, Alexander Graf wrote: >> looks like this is different in the 32x86 ABI. >> >> We can pad explicitly if you prefer. > The size is 16 on 32-bit ppc -- the alignment of __u64 forces this. It > > I would prefer if we keep this stable :). There's no good reason to > pad it - ppc

Re: [PATCH 04/14] KVM: PPC: e500: MMU API

2011-11-10 Thread Alexander Graf
On 11/01/2011 05:16 PM, Scott Wood wrote: On 11/01/2011 03:58 AM, Avi Kivity wrote: On 10/31/2011 10:12 PM, Scott Wood wrote: +4.59 KVM_DIRTY_TLB + +Capability: KVM_CAP_SW_TLB +Architectures: ppc +Type: vcpu ioctl +Parameters: struct kvm_dirty_tlb (in) +Returns: 0 on success, -1 on error + +str

Re: [PATCH 04/14] KVM: PPC: e500: MMU API

2011-11-02 Thread Avi Kivity
On 11/01/2011 06:16 PM, Scott Wood wrote: > > > > sizeof(struct kvm_tlb_dirty) == 12 for 32-bit userspace, but == 16 for > > 64-bit userspace and the kernel. ABI structures must have the same > > alignment and size for 32/64 bit userspace, or they need compat handling. > > The size is 16 on 32-b

Re: [PATCH 04/14] KVM: PPC: e500: MMU API

2011-11-01 Thread Scott Wood
On 11/01/2011 03:58 AM, Avi Kivity wrote: > On 10/31/2011 10:12 PM, Scott Wood wrote: +4.59 KVM_DIRTY_TLB + +Capability: KVM_CAP_SW_TLB +Architectures: ppc +Type: vcpu ioctl +Parameters: struct kvm_dirty_tlb (in) +Returns: 0 on success, -1 on error + +st

Re: [PATCH 04/14] KVM: PPC: e500: MMU API

2011-11-01 Thread Avi Kivity
On 11/01/2011 10:58 AM, Avi Kivity wrote: > > > We already have another mechanism for such shared memory, > > > mmap(vcpu_fd). x86 uses it for the coalesced mmio region as well as the > > > traditional kvm_run area. Please consider using it. > > > > What does it buy us, other than needing a separ

Re: [PATCH 04/14] KVM: PPC: e500: MMU API

2011-11-01 Thread Avi Kivity
On 10/31/2011 10:12 PM, Scott Wood wrote: > >> +4.59 KVM_DIRTY_TLB > >> + > >> +Capability: KVM_CAP_SW_TLB > >> +Architectures: ppc > >> +Type: vcpu ioctl > >> +Parameters: struct kvm_dirty_tlb (in) > >> +Returns: 0 on success, -1 on error > >> + > >> +struct kvm_dirty_tlb { > >> + __u64 bitmap; >

Re: [PATCH 04/14] KVM: PPC: e500: MMU API

2011-10-31 Thread Scott Wood
On 10/31/2011 08:24 AM, Avi Kivity wrote: > On 10/31/2011 09:53 AM, Alexander Graf wrote: >> From: Scott Wood >> >> This implements a shared-memory API for giving host userspace access to >> the guest's TLB. >> >> >> diff --git a/Documentation/virtual/kvm/api.txt >> b/Documentation/virtual/kvm/ap

Re: [PATCH 04/14] KVM: PPC: e500: MMU API

2011-10-31 Thread Avi Kivity
On 10/31/2011 09:53 AM, Alexander Graf wrote: > From: Scott Wood > > This implements a shared-memory API for giving host userspace access to > the guest's TLB. > > > diff --git a/Documentation/virtual/kvm/api.txt > b/Documentation/virtual/kvm/api.txt > index 7945b0b..ab1136f 100644 > --- a/Docume