Re: kvm book3s issues

2009-11-10 Thread Alexander Graf
On 10.11.2009, at 08:20, Benjamin Herrenschmidt wrote: Hi Alex ! After a bit of digging as to why the karmic installer dies, I found out that you don't set the right SRR1 bits when forwarding a program check exception to the guest. Cool, thanks for trying things out and debugging them!

Re: kvm book3s issues

2009-11-10 Thread Benjamin Herrenschmidt
On Tue, 2009-11-10 at 11:50 +0100, Alexander Graf wrote: if ((vcpu-arch.last_inst 0xff0007ff) != (INS_DCBZ 0xfff7)) { + vcpu-arch.msr |= (vcpu-arch.shadow_msr 0x1full); What bits are those? It might be

Re: kvm book3s issues

2009-11-10 Thread Alexander Graf
On 10.11.2009, at 22:16, Benjamin Herrenschmidt wrote: On Tue, 2009-11-10 at 11:50 +0100, Alexander Graf wrote: if ((vcpu-arch.last_inst 0xff0007ff) != (INS_DCBZ 0xfff7)) { + vcpu-arch.msr |=

Re: kvm book3s issues

2009-11-10 Thread Alexander Graf
On 11.11.2009, at 02:03, Benjamin Herrenschmidt wrote: + li r4,0 mfspr r5,SPRN_HID5 r5 = *HID5 So far so good... - rldimi r5,r5,6,56 Take r5, remove some bits, write into r5 Hrm... nope :-) rldimi will insert into the destination (r5) bits 56..57 the

Re: kvm book3s issues

2009-11-10 Thread Benjamin Herrenschmidt
On Wed, 2009-11-11 at 02:06 +0100, Alexander Graf wrote: On 11.11.2009, at 02:03, Benjamin Herrenschmidt wrote: +li r4,0 mfspr r5,SPRN_HID5 r5 = *HID5 So far so good... -rldimi r5,r5,6,56 Take r5, remove some bits, write into r5 Hrm... nope :-)

kvm book3s issues

2009-11-09 Thread Benjamin Herrenschmidt
Hi Alex ! After a bit of digging as to why the karmic installer dies, I found out that you don't set the right SRR1 bits when forwarding a program check exception to the guest. I also did a couple of minor fixups (though the s/mtmsr/mtmsrd may not be necessary, I think the clearing of HID5 is).