Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-19 Thread Jan Schreiber
Daniel Naber schrieb: > BTW, what do you think about using CamelCase for the entities, e.g. > "malenNomen" instead of "malennomen". I think this would improve > readability. I agree. Tbh, I never gave much thought to the entity names, because I didn't expect the file to become so large over time,

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-19 Thread Daniel Naber
On Samstag, 19. Mai 2012, Jan Schreiber wrote: > I got fairly close using > > It displays as expected in IE, but not in Firefox, and it doesn't pass > testrules.bat. I have reverted the change for now so the old workflow is in place again. BTW, what do you think about using CamelCase for t

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-19 Thread Jan Schreiber
I got fairly close using It displays as expected in IE, but not in Firefox, and it doesn't pass testrules.bat. Daniel Naber schrieb: > On Samstag, 19. Mai 2012, Jan Schreiber wrote: > >> Not a bug, but a (major) annoyance for me: When grammar.xml is displayed >> in a browser, the new externa

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-19 Thread Daniel Naber
On Samstag, 19. Mai 2012, Jan Schreiber wrote: > Not a bug, but a (major) annoyance for me: When grammar.xml is displayed > in a browser, the new external resources aren't embedded: > http://languagetool.svn.sourceforge.net/viewvc/languagetool/trunk/JLangu > ageTool/src/rules/de/grammar.xml ("Tipp

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-19 Thread Jan Schreiber
I just found this: http://www.xml.com/pub/a/2001/03/14/trxml10.html It looks as if it uses an XML-internal method. I'll try it and report back how it works. I wrote: > Not a bug, but a (major) annoyance for me: When grammar.xml is displayed > in a browser, the new external resources aren't embedd

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-19 Thread Jan Schreiber
Not a bug, but a (major) annoyance for me: When grammar.xml is displayed in a browser, the new external resources aren't embedded: http://languagetool.svn.sourceforge.net/viewvc/languagetool/trunk/JLanguageTool/src/rules/de/grammar.xml ("Tippfehler" is gone.) I often use the browser view to make s

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-18 Thread Daniel Naber
On Freitag, 18. Mai 2012, Jan Schreiber wrote: > Am I right that this method won't work out of the box, but requires > changes to the Java code? Yes. I have just committed this, moving only the typo rules to their own file as a test. Does everything work for you? Java code will not need to be t

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-18 Thread Jan Schreiber
Am I right that this method won't work out of the box, but requires changes to the Java code? I tried it but the external files failed to load. The only worry I have is that changes to the categories (like splitting a category etc.) will be more complicated. Daniel Naber wrote: > grammar.xml conta

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-17 Thread Jan Schreiber
If I understand this properly, it is exactly what I have been looking for. It would enable us to farm out those huge and cumbersome regExes to another file until we have a method in place that allows us to get along without them entirely. Daniel Naber schrieb: > Here's how the file could be split

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-17 Thread Daniel Naber
On Donnerstag, 17. Mai 2012, Jan Schreiber wrote: > The largest grammar files are something around 1.2 MB afaik, I guess > this is still in a range you can call normal today. I do all my work, programming and XML editing, with the same application (IDEA Intellij) and it doesn't work well with fi

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-16 Thread Jan Schreiber
Dominique, thanks for taking the trouble to test it, etc. >From my POV, the upshot of the discussion *so far* is that we should not split the grammar files, even though some of them are getting quite large. Correct me if I'm wrong. For me (on a six years old cheap computer), there is no problem to

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-16 Thread Jan Schreiber
Marcin: > Classifying some of the words semantically might be really useful for > some rules. Indeed, I could not agree more. The most difficult part would be coming up with the semantic categories in a way that is not completely ad hoc. Everyone who has ever used a public library is probably awa

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] trunk/JLanguageTool/src/rules/de/grammar. xml

2012-05-16 Thread Daniel Naber
On Montag, 14. Mai 2012, Ruud Baars wrote: > Don't bother converting the Dutch xml. > I have already manually done that. > > Have to find the time to download the snapshot and get it tested. Just send it when you're ready - I have applied the automatic conversion to Dutch for now so I can remov

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-16 Thread Marcin Miłkowski
W dniu 2012-05-16 20:10, Jan Schreiber pisze: > BTW, it should be possible to store at least those entities outside the > file itself, but I don't know how. --Jan Well, I had a look and it seems that you are using some of the entities to define fairly long regular expressions (disjunctions). Thi

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-16 Thread Dominique Pellé
Jan Schreiber > I know that ridiculously huge file is a bit of a problem Are they? grammar.xml files are not that big. A text editor opens the biggest grammar.xml in a blink on my 5 years old laptop. To make it easier to navigate when editing, I define folds in Vim with a modeline (see comment

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-16 Thread Jan Schreiber
Second thoughts: otoh, the earlier we do it, the less work will it be. I definitely agree that a file size of more than 1 MB is not very good. I wrote: > Daniel Naber wrote: >> But what about splitting up that file into its categories? We could have >> 5-10 smaller files rather than one large one

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-16 Thread Jan Schreiber
Daniel Naber wrote: > Feel free to do that, although some new spaces might be re-introduced as I > cannot set up my IDE for spaces/tabs on a per-project basis. Then let's forget that. If there is one thing on earth that I can't stand it's a mixture of spaces and tabs. It visually messes up indent

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-16 Thread Daniel Naber
On Mittwoch, 16. Mai 2012, Jan Schreiber wrote: > One tiny thing is still bugging me: Since the file is so long, the > change in indentation (four spaces rather than two) results in a > noticeable increase of the file size. We could avoid this by using tabs > instead of spaces for indentation, tha

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] ...

2012-05-16 Thread Jan Schreiber
Daniel Naber wrote: > I tried another conversion, please let me know if this is okay now. > > Regards > Daniel > Everything seems okay now, thanks. I made a few trivial cosmetic changes to the German grammar file though. One tiny thing is still bugging me: Since the file is so long, the chang

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] trunk/JLanguageTool/src/rules/de/grammar. xml

2012-05-15 Thread Daniel Naber
On Montag, 14. Mai 2012, Jan Schreiber wrote: > Daniel, the German grammar file is about one third larger now, probably > because in the course of the automatic replacement the entities defined > in the XML file itself (some of which are really huge, like "&sub...;") I tried another conversion, p

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] trunk/JLanguageTool/src/rules/de/grammar. xml

2012-05-14 Thread Ruud Baars
Don't bother converting the Dutch xml. I have already manually done that. Have to find the time to download the snapshot and get it tested. Ruud On 14-05-12 20:19, Daniel Naber wrote: > On Montag, 14. Mai 2012, Jan Schreiber wrote: > >> Daniel, the German grammar file is about one third larger n

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] trunk/JLanguageTool/src/rules/de/grammar. xml

2012-05-14 Thread Daniel Naber
On Montag, 14. Mai 2012, Jan Schreiber wrote: > Daniel, the German grammar file is about one third larger now, probably > because in the course of the automatic replacement the entities defined > in the XML file itself (some of which are really huge, like "&sub...;") > were replaced by their liter

Re: [Languagetool] [LanguageTool] SF.net SVN: languagetool:[6896] trunk/JLanguageTool/src/rules/de/grammar. xml

2012-05-14 Thread Jan Schreiber
Daniel, the German grammar file is about one third larger now, probably because in the course of the automatic replacement the entities defined in the XML file itself (some of which are really huge, like "&sub...;") were replaced by their literal counterparts. This is quite unwelcome because we def