Re: [LARTC] ESFQ not so fair?

2006-04-13 Thread Michał Margula
Corey Hickey napisał(a): Using jhash is a probably a good idea, the "improved" hash is broken and will cause reordering in some circumstances: return (h - q->dyn_min) * (q->hash_divisor - 1) / q->dyn_range; dyn_min, dyn_max and dyn_range, as their name suggests, are adjusted dynamically, so the

Re: [LARTC] ESFQ not so fair?

2006-04-12 Thread Corey Hickey
Patrick McHardy wrote: Andy Furniss wrote: Corey Hickey changed his esfq to use jhash for dst/src/fw - copy of his announce below. Andy. Corey Hickey wrote: So, I wrote an alternative hash function. It's quite simple, and as long as the range of input values is smaller than the hash table (de

Re: [LARTC] ESFQ not so fair?

2006-04-12 Thread Andy Furniss
Michał Margula wrote: Andy Furniss napisał(a): Corey Hickey changed his esfq to use jhash for dst/src/fw - copy of his announce below. Andy. Thanks, but I am already using his patch :-). It happens with that patch, I haven't tried original version at all. Ahh OK - looks like Patrick

Re: [LARTC] ESFQ not so fair?

2006-04-12 Thread Andy Furniss
Patrick McHardy wrote: Andy Furniss wrote: Corey Hickey changed his esfq to use jhash for dst/src/fw - copy of his announce below. Using jhash is a probably a good idea, the "improved" hash is broken and will cause reordering in some circumstances: return (h - q->dyn_min) * (q->hash_diviso

Re: [LARTC] ESFQ not so fair?

2006-04-12 Thread Patrick McHardy
Andy Furniss wrote: > Corey Hickey changed his esfq to use jhash for dst/src/fw - copy of his > announce below. > > Andy. > > Corey Hickey wrote: >> So, I wrote an alternative hash function. It's quite simple, and as long >> as the range of input values is smaller than the hash table (default > 1

Re: [LARTC] ESFQ not so fair?

2006-04-12 Thread Michał Margula
Andy Furniss napisał(a): Corey Hickey changed his esfq to use jhash for dst/src/fw - copy of his announce below. Andy. Thanks, but I am already using his patch :-). It happens with that patch, I haven't tried original version at all. -- Michał Margula, [EMAIL PROTECTED], http://alchemyx.

Re: [LARTC] ESFQ not so fair?

2006-04-12 Thread Andy Furniss
Michał Margula wrote: Hello! I am using since yesterday ESFQ instead of N HTB queues. It mostly works OK, but when somebody is using one single sesion (for example downloading file via FTP), it gets weird speed. For example it is 20 kilobytes pres second, then drops down to 9, then 20 aga

[LARTC] ESFQ not so fair?

2006-04-12 Thread Michał Margula
Hello! I am using since yesterday ESFQ instead of N HTB queues. It mostly works OK, but when somebody is using one single sesion (for example downloading file via FTP), it gets weird speed. For example it is 20 kilobytes pres second, then drops down to 9, then 20 again, and then slowly to 0