Ines Almeida has proposed merging
~ines-almeida/launchpad:fetch-service-call-remove-resources-endpoint into
launchpad:master.
Commit message:
Call fetch service endpoint to remove resources at the end of a successfull
build
Requested reviews:
Launchpad code reviewers (launchpad-reviewers
Ines Almeida has proposed merging
~ines-almeida/launchpad:fix-get-blob-from-store-git into launchpad:master.
Commit message:
Make store git hostnames configurable via feature flag
Setting valid hostnames won't require a deployment from Launchpad with this
change. Instead
ref_path, filename):
> return response.content
>
>
> -# XXX ines-almeida 2024-10-07: Needs refactoring to allow extending more
> easily
> -# especially since this list will for sure grow as we allow non-staging
> stores.
> -# Potentially look into
Ines Almeida has proposed merging
~ines-almeida/launchpad:db-add-fetch_service_policy into launchpad:db-devel.
Commit message:
db: add fetch_service_policy enum to Snaps, Rocks and Crafts tables
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Review: Approve
--
https://code.launchpad.net/~lgp171188/launchpad-mojo-specs/+git/private/+merge/474683
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing list: https://laun
The proposal to merge ~ines-almeida/launchpad:fix-get-blob-from-store-git into
launchpad:master has been updated.
Description changed to:
All tests from `TestGitRefGetBlob` (including the newly added ones) passed.
I also tested locally calling
https://git.staging.snapcraftcontent.com/ubuntu
Ines Almeida has proposed merging
~ines-almeida/launchpad:fix-get-blob-from-store-git into launchpad:master.
Commit message:
Allow snapcraft store git remote URLs
Currently we restrict which repositories we can fetch files from - this enables
the *craft stores with turnip backend as a
Review: Approve
LGTM
--
https://code.launchpad.net/~lgp171188/meta-lp-deps/add-postgres-14/+merge/474465
Your team Launchpad code reviewers is subscribed to branch lp:meta-lp-deps.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to
Ines Almeida has proposed merging
~ines-almeida/launchpad:fix-supported-arches-error-message into
launchpad:master.
Commit message:
Print correct base name in error when arch not supported
Currently when using `build-base` instead of `base` as defined in
https://snapcraft.io/docs/release
Should there be some constraint that prevents there being a `git_repository`
AND a `git_repository_url`?
--
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/474453
Your team Launchpad code reviewers is requested to review the proposed merge of
~lgp171188/launchpad:add-git-re
There are some conflicts to handle and linting is failing (could be an
intermittent issue, if so just try rebuilding)
Diff comments:
> diff --git a/lib/lp/crafts/adapters/buildarch.py
> b/lib/lp/crafts/adapters/buildarch.py
> new file mode 100644
> index 000..62dbe91
> --- /dev/null
> +++ b
Left a few comments.
I think I miss some context on what a sourcecraft.yaml file should look like,
so you might want another look from Jürgen for approval
Diff comments:
> diff --git a/lib/lp/crafts/adapters/buildarch.py
> b/lib/lp/crafts/adapters/buildarch.py
> new file mode 100644
> index 00
LGTM, but need to fix the value in LaunchpadDatabaseRevision
Diff comments:
> diff --git a/database/schema/patch-2211-29-1.sql
> b/database/schema/patch-2211-29-1.sql
> new file mode 100644
> index 000..ee6421a
> --- /dev/null
> +++ b/database/schema/patch-2211-29-1.sql
> @@ -0,0 +1,10 @@
>
I just realized this was in launchpad-buildd repo and not launchpad, sorry!
Deleting both these comments :)
--
https://code.launchpad.net/~jugmac00/launchpad-buildd/+git/launchpad-buildd/+merge/474071
Your team Launchpad code reviewers is requested to review the proposed merge of
~jugmac00/launc
Is there a reason to change it here instead of the launchpad-manual?
Also, is there a reason to keep the /docs folder in this repository at all
given there is a launchpad-manual repo?
--
https://code.launchpad.net/~jugmac00/launchpad-buildd/+git/launchpad-buildd/+merge/474071
Your team Launchpad
Diff comments:
> diff --git a/SECURITY.md b/SECURITY.md
> new file mode 100644
> index 000..0fc7efd
> --- /dev/null
> +++ b/SECURITY.md
> @@ -0,0 +1,17 @@
> +# Launchpad Security Policy
> +
> +If you discover a security vulnerability, please follow the steps outlined
> below to report it:
Looking good, left a few comments to be addressed
Lint build failed, need to look into something needs fixing or just needs a
re-run.
For another MP:
For snaps we set a `SNAP_USE_FETCH_SERVICE_FEATURE_FLAG` feature flag. I don't
think we need to add one here specially since there are feature fl
Don't forget to allocate your patch in
https://code.launchpad.net/~launchpad/+git/dbpatches
See 'how to/make a database patch' documentation:
https://documentation.ubuntu.com/launchpad/en/latest/how-to/database-schema-changes-process/#making-a-database-patch
The patch itself looks good!
Diff c
I'm slightly confused with this MP - the commit mentions adding logic to delete
rock builds but then it seems to have a lot of other code - either due to
conflicts or a wrong prerequisite branch, I assume.
I looked into the last commit hat seems to add deletion of rocks, and it
generally made s
This MP has a few conflicts that need addressing.
I also feel like the main commit message is lacking some context of what this
MP adds, would be nice to add to it for posterity. I'd also perhaps phrase it
as "Add run logic to RockRecipeRequestBuildsJob" instead of "Implement
RockRecipeRequestB
Review: Approve
Thanks for the fix!
--
https://code.launchpad.net/~lgp171188/launchpad-mojo-specs/+git/private/+merge/472991
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing
Looking really good for a WIP, just a small comment :)
Diff comments:
> diff --git a/lpbuildd/target/build_livefs.py b/lpbuildd/target/build_livefs.py
> index d77e1cf..59e936b 100644
> --- a/lpbuildd/target/build_livefs.py
> +++ b/lpbuildd/target/build_livefs.py
> @@ -177,6 +206,10 @@ class Build
I think this is great work and seems like a huge beast to tackle.
I do feel like it misses an opportunity to refactor code to make it easier to
add new recipes in the future. As it is, adding more build types will just
require copying thousands of lines of code every time.
Perhaps more of a thou
Review: Approve
Looks good
Diff comments:
> diff --git a/vbuilder/bundle.yaml b/vbuilder/bundle.yaml
> index d24573a..fa70489 100644
> --- a/vbuilder/bundle.yaml
> +++ b/vbuilder/bundle.yaml
> @@ -137,8 +137,8 @@
> {%- set openstack_username = "vbuilder_staging" %}
> {%- set openstack_user
Review: Approve
Looks good, but aren't there are relations that need to be removed as well?
--
https://code.launchpad.net/~lgp171188/launchpad-mojo-specs/+git/private/+merge/472777
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
Review: Approve
--
https://code.launchpad.net/~lgp171188/launchpad-mojo-specs/+git/private/+merge/472773
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing list: https://laun
Review: Approve
--
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/+merge/472498
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing list: https://launchp
Review: Approve
--
https://code.launchpad.net/~lgp171188/launchpad-mojo-specs/+git/private/+merge/471842
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing list: https://laun
Review: Approve
LGTM
--
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/+merge/471803
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing list: https://lau
Review: Approve
LGTM, only a small comment to address
Diff comments:
> diff --git a/vbuilder/bundle.yaml b/vbuilder/bundle.yaml
> index 87c5d1a..a05c15e 100644
> --- a/vbuilder/bundle.yaml
> +++ b/vbuilder/bundle.yaml
> @@ -361,6 +361,25 @@ applications:
>use_swift: false
>visibi
Review: Approve
Thanks for linking that wiki page!
All good from my side then, but it seem like removing the g-s-s units is not
part of that documentation and I believe it should (maybe as a last step?). Can
you please add it?
--
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/priv
This looks good, but we probably also need to remove the g-s-s units as well.
I have never removed builders, so I'm not entirely sure what the process should
be. If we do the inverse process to adding builders
(https://wiki.canonical.com/Launchpad/PolicyandProcess/AddNewArchRegionBuilder)
we mi
Review: Approve
--
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/+merge/470877
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing list: https://launchp
Review: Approve
--
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/+merge/470432
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing list: https://launchp
Ines Almeida has proposed merging
~ines-almeida/launchpad:bam-description-not-none into launchpad:master.
Commit message:
Allow binary package release wheel without description
The previous version of the `pkginfo` library we used would set the description
field to an empty string if none
Can you please clarify it in the commit message/comment in code?
--
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/+merge/470432
Your team Launchpad code reviewers is requested to review the proposed merge of
~pelpsi/launchpad-mojo-specs/+git/private:arm-builders-lxd-channel
I might not have the right context, but can you clarify the reason for pinning
a `candidate` channel here? I notice we do it for riscv builders for example,
but it would be nice to understand why in the commit message and perhaps as a
commend in the code.
I'd also consider perhaps adding a `if
Ines Almeida has proposed merging
~ines-almeida/launchpad-mojo-specs/+git/private:vbuilder-add-amd64-gpu-bos03-builders-prod
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
Commit message:
vbuilder: add 1 new amd64-gpu builder in bos03 in production
Requested reviews:
Launchpad
Ines Almeida has proposed merging
~ines-almeida/launchpad-mojo-specs/+git/private:vbuilder-add-notes-on-image-modifiers
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
Commit message:
vbuilder: add note about when to add `modifiers_XXX` variable
We only require this value for
pdating the docs as we go
--
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/470279
Your team Launchpad code reviewers is subscribed to branch
~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
___
Mailing li
Ines Almeida has proposed merging
~ines-almeida/launchpad-mojo-specs/+git/private:vbuilder-add-amd64-gpu-bos03-builders-prod
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
Commit message:
builder: update config to build bos03 amd64-gpu images in production
Requested reviews
The proposal to merge
~ines-almeida/launchpad:fetch-service-redact-certificate-in-logs into
launchpad:master has been updated.
Description changed to:
Tests from CIBuilds that tested the redacted secrets still ran successfully.
No other build type has `secrets` in their args except for snap
Ines Almeida has proposed merging
~ines-almeida/launchpad:fetch-service-redact-certificate-in-logs into
launchpad:master.
Commit message:
Redact `fetch_service_mitm_certificate` in build logs
When running a fetch service build, we send the certficate from buildd-manager
to buildd, and log
leted.")
> +if failed_target_instances:
> +print("Rebuilding images failed in the following instances:")
> +for instance in failed_target_instances:
> +print(f" - {instance}")
>
> if __name__ == "__main__":
>
Fixed the mypy issues and updated the logic to use the `use_fetch_service` flag
directly from the builder proxy info. I still need to re-work a test, but this
is now ready for review.
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/465152
Your team Launchpad code
Ines Almeida has proposed merging ~ines-almeida/launchpad-buildd:release-237
into launchpad-buildd:master.
Commit message:
Release version 237
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad-buildd
This has not been cleaned up (and mypy issues not fixed). Opening it up for an
early review.
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/465152
Your team Launchpad code reviewers is requested to review the proposed merge of
~ines-almeida/launchpad:fetch-service
Ines Almeida has proposed merging
~ines-almeida/launchpad:fetch-service-update-end-session into launchpad:master.
Commit message:
Update how to keep track of session_id within a builder session
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
The proposal to merge
~ines-almeida/launchpad-buildd:fetch-service-add-proxy-info-endpoint into
launchpad-buildd:master has been updated.
Commit message changed to:
Add `proxy_info` endpoint that returns details for the proxy setup
For more details, see:
https://code.launchpad.net/~ines
Ines Almeida has proposed merging
~ines-almeida/launchpad-buildd:fetch-service-add-proxy-info-endpoint into
launchpad-buildd:master.
Commit message:
WIP
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~ines-almeida
running in
buildd, and I checked the build logs to find that this expected arg wasn't
there. Adding it fixed the initial issue.
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/465003
Your team Launchpad code reviewers is requested to review the proposed merge of
Ines Almeida has proposed merging
~ines-almeida/launchpad:fetch-service-add-missing-fetch-service-args into
launchpad:master.
Commit message:
Add missing `use_fetch_service` arg when starting a build
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see
The proposal to merge
~ines-almeida/launchpad-mojo-specs/+git/private:vbuilder-rebuild-images-manifest-update
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder has been updated.
Description changed to:
For context, this is a script that runs as part of the deployment of
launchpad
The proposal to merge
~ines-almeida/launchpad-mojo-specs/+git/private:vbuilder-rebuild-images-manifest-update
into launchpad-mojo-specs:master has been updated.
Status: Work in progress => Superseded
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+
Ines Almeida has proposed merging
~ines-almeida/launchpad-mojo-specs/+git/private:vbuilder-rebuild-images-manifest-update
into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
Commit message:
Update `rebuild-images` script to be more resilient when images are missing
The script now
Ines Almeida has proposed merging
~ines-almeida/launchpad:fetch-service-update-build-metadata-url into
launchpad:master.
Commit message:
Add DB load bulk load for `build_metadata_url` attributes when getting multiple
builds
This reduces the number of DB queries made in the case for where
Review: Approve
Looks good!
Can you update the commit message to start with the model in question?
I.e.
```
lp-fetch-service: Deploy fetch-service charm from Charmhub
```
Diff comments:
> diff --git a/lp-fetch-service/bundle.yaml b/lp-fetch-service/bundle.yaml
> index 8bd8dd3..67472ee 100644
>
The proposal to merge
~ines-almeida/launchpad:fetch-service-update-build-metadata-url into
launchpad:master has been updated.
Commit message changed to:
Update `build_metadat_url` logic and tests and queries associated with it
This includes:
- Update the query used to get the metadata file
Ines Almeida has proposed merging
~ines-almeida/launchpad:fetch-service-update-build-metadata-url into
launchpad:master.
Commit message:
Update `build_metadat_url` logic and tests and queries associated with it
This includes:
- Update the query used to get the metadata file to be lighter
ot;""See `ISpecificBuildFarmJobSource`."""
> if len(build_farm_jobs) == 0:
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/464751
Your team Launchpad code reviewers is requested to review the proposed merge of
~ines-almeida/launchpad:fet
Changing this MP to Rejected in favor of this one:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/464697
--
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/464639
Your team Launchpad code reviewers is requested to review the proposed merge of
The proposal to merge ~jugmac00/launchpad:expose-build-metadata-via-api into
launchpad:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/464639
--
Your team Launchpad code reviewers is reques
Ines Almeida has proposed merging
~ines-almeida/launchpad:fetch-service-expose-build-metadata-url-api into
launchpad:master with
~ines-almeida/launchpad:fetch-service-buildd-manager-end-session as a
prerequisite.
Commit message:
Expose the URL to download the metadata file of the fetch
Diff comments:
> diff --git a/lib/lp/snappy/interfaces/snapbuild.py
> b/lib/lp/snappy/interfaces/snapbuild.py
> index 52019bf..fea9d5f 100644
> --- a/lib/lp/snappy/interfaces/snapbuild.py
> +++ b/lib/lp/snappy/interfaces/snapbuild.py
> @@ -370,6 +371,14 @@ class ISnapBuildView(IPackageBuildVie
The proposal to merge
~ines-almeida/launchpad:fetch-service-buildd-manager-refactor into
launchpad:master has been updated.
Commit message changed to:
Refactor buildd-manager: remove unneeded variables, rename and add comments
- Removed the `/session` from the base URL for the fetch service
Ines Almeida has proposed merging
~ines-almeida/launchpad:fetch-service-buildd-manager-refactor into
launchpad:master.
Commit message:
Refactor buildd-manager: remove unneeded variables, rename and add comments
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more
I know this isn't tested, but just a initial review!
Diff comments:
> diff --git a/lib/lp/snappy/interfaces/snapbuild.py
> b/lib/lp/snappy/interfaces/snapbuild.py
> index 52019bf..46bd205 100644
> --- a/lib/lp/snappy/interfaces/snapbuild.py
> +++ b/lib/lp/snappy/interfaces/snapbuild.py
> @@ -370
command,
but we can certainly see if we can with a few adjustments.
My plan is to get it working as is, test it, and then think about cleaning up
and optimizing.
> +arguments = [
> +(b"content", amp.Unicode()),
> + (b"path_to_write", amp.Unicode()),
>
Ines Almeida has proposed merging
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master.
Commit message:
Update fetch service revoke token authentication
We now use the proxy token as authentication to the fetch service control API
to revoke
n the multiple tests that contain `extraBuildArgs`
and all the tests within `lp.snappy.tests.test_snapbuildbehaviour`.
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/464303
Your team Launchpad code reviewers is requested to review the proposed merge of
~ines-al
Ines Almeida has proposed merging
~ines-almeida/launchpad:fetch-service-buildd-manager-refactor into
launchpad:master.
Commit message:
Refactor buildd-manager builder proxy logic
This separates the logic for making calls to the builder proxy and the fetch
service out of the
The code itself should be tested from the existing unit tests, since the
functionality was maintained. But I still need to have a look at adding new
tests for the new classes.
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/464303
Your team Launchpad code reviewers
quire authentication.
> +
> +TODO this might change depending on conversations about fetch service
IDEs should highlight the `TODO` comments as much as the `XXX` ones since it's
a generally used format as well (https://peps.python.org/pep-0350/) -
This MP has been updated after some conversations. The topic of how to
authenticate the call to revoke the token is still on not decided on, so that
part might change.
--
https://code.launchpad.net/~ines-almeida/launchpad-buildd/+git/launchpad-buildd/+merge/462875
Your team Launchpad code
The proposal to merge
~ines-almeida/launchpad-buildd:close-session-for-fetch-service into
launchpad-buildd:master has been updated.
Status: Work in progress => Rejected
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad-buildd/+git/launchpad-buildd/+merge/463
The proposal to merge
~ines-almeida/launchpad:fetch-service-add-get-data-endpoint into
launchpad:master has been updated.
Status: Work in progress => Rejected
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/463145
--
Your team Launchpad c
Ines Almeida has proposed merging
~ines-almeida/launchpad:change-appserver-log-rotate into launchpad:master.
Commit message:
charm: update appserver logrotate from daily to hourly
Currently log files for this service can get quite heavy (in the realm of 10
Gb) which makes it impossible to
The proposal to merge
~ines-almeida/launchpad-mojo-specs/+git/private:fetch-service-fix-typo into
~launchpad/launchpad-mojo-specs/+git/private:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+
Ines Almeida has proposed merging
~ines-almeida/launchpad-mojo-specs/+git/private:fetch-service-fix-typo into
~launchpad/launchpad-mojo-specs/+git/private:master.
Commit message:
lp-fetch-service: fix small typo in mojo spec
Requested reviews:
Launchpad code reviewers (launchpad-reviewers
The proposal to merge
~ines-almeida/launchpad:fetch-service-add-get-data-endpoint into
launchpad:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/463145
--
Your team Launch
The proposal to merge
~ines-almeida/launchpad-buildd:close-session-for-fetch-service into
launchpad-buildd:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad-buildd/+git/launchpad-buildd/+merge/463
Review: Approve
--
https://code.launchpad.net/~ruinedyourlife/lp-archive/+git/lp-archive/+merge/463798
Your team Launchpad code reviewers is requested to review the proposed merge of
~ruinedyourlife/lp-archive:feat-landing-page into lp-archive:main.
___
You have been requested to review the proposed merge of
~pelpsi/launchpad:snap-component-integration into launchpad:master.
For more details, see:
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/461063
--
Your team Launchpad code reviewers is requested to review the propose
Ines Almeida has proposed merging
~ines-almeida/launchpad-buildd:close-session-for-fetch-service into
launchpad-buildd:master with
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service as a
prerequisite.
Commit message:
End proxy session and gather data when using the fetch
I would still like to spend some more time going over where is the best place
to call the method to save the fetch service data, but I think this is in a
good enough state for a review.
--
https://code.launchpad.net/~ines-almeida/launchpad-buildd/+git/launchpad-buildd/+merge/463119
Your team
Ines Almeida has proposed merging
~ines-almeida/launchpad:fetch-service-add-get-data-endpoint into
launchpad:master.
Commit message:
Send end_session_endpoint to build manager when using fetch service
The fetch service will require 2 endpoints: one for revoking the token (as the
old
LGTM! Just a very small suggestion.
I was wondering if there are any tests to update or add, but maybe not since
this new model attribute isn't really used yet - we'll do it when adding
APIs/UI.
Note that this cannot be merged until the DB change is deployed to production.
I'm happy to approve
The proposal to merge
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master has been updated.
Description changed to:
This handles calling the revocation endpoint against the fetch service, but not
yet closing the session (that will be handled in
The proposal to merge
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master has been updated.
Description changed to:
This handles calling the revocation endpoint against the fetch service, but not
yet closing the session (that will be handled in
The proposal to merge
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master has been updated.
Description changed to:
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad-buildd/+git/launchpad-buildd/+merge/462875
--
Your
The proposal to merge
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master has been updated.
Commit message changed to:
Enable revoking a token for the fetch service
Handle calling the revocation_endpoint sent by Launchpad, both in the cases
Ines Almeida has proposed merging
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master.
Commit message:
WIP: Update end-of-session code for snaps that use the fetch service
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For
the
data (to be opened)
--
https://code.launchpad.net/~ines-almeida/launchpad-buildd/+git/launchpad-buildd/+merge/462875
Your team Launchpad code reviewers is requested to review the proposed merge of
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad
The proposal to merge
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad-buildd/+git/launchpad-buildd/+me
In a meeting, decided that we will most likely need to have 2 endpoints for
ending the session:
- One for revoking the token
- Another one to close the session
This MP is blocked until we settle that out.
--
https://code.launchpad.net/~ines-almeida/launchpad-buildd/+git/launchpad-buildd
Ines Almeida has proposed merging
~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service into
launchpad-buildd:master.
Commit message:
WIP: Update end-of-session code for snaps that use the fetch service
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For
Ines Almeida has proposed merging ~ines-almeida/launchpad:bump-launchpad-layers
into launchpad:master.
Commit message:
charms: bump launchpad-layers to 910dfb76754add5ed032a243c6081ee6a6b11256
The new source-commit updates the base configuration values for git related
domains so that the git
Ines Almeida has proposed merging
~ines-almeida/launchpad:update-ftpmaster-generate-content-cron-start into
launchpad:master.
Commit message:
charm: update ftpmaster-publisher genrate-content cron script to run earlier
This is relevant because currently this job runs during most Launchpad
Ines Almeida has proposed merging
~ines-almeida/launchpad-layers:update-git-domain-config into
launchpad-layers:main.
Commit message:
launchpad-base: update git domain configuration values to use default value if
not set
`domain_git` is generally used to determine if an environment has
Ines Almeida has proposed merging
~ines-almeida/launchpad:fetch-service-option-refactor into launchpad:master.
Commit message:
Refactor snap.use_fetch_service tests and feature flag description
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
1 - 100 of 355 matches
Mail list logo
