[LEDE-DEV] [PATCH] fstools: Fix some errors detected by cppcheck

2017-12-11 Thread Rosen Penev
Mainly plugging memory leaks. Size reduction as well. The calloc change accounts for 272 bytes on this machine for some reason... Signed-off-by: Rosen Penev v2: Add calloc fail check + turn some functions to void where it saves size. Total savings = 184 bytes after everything. --- block.c

Re: [LEDE-DEV] [PATCH] fstools: Fix some errors detected by cppcheck

2017-12-11 Thread Jonas Gorski
On 11 December 2017 at 10:04, Rosen Penev wrote: > Mainly plugging memory leaks. Size reduction as well. The calloc change > accounts for 272 bytes on this machine for some reason... Please state the exact errors found by cppcheck so we don't have to guess what it found. Regards Jonas ___

[LEDE-DEV] Uniform cryptography library

2017-12-11 Thread Matthias-Christian Ott
Packages use several cryptography libraries because different packages require different libraries. hostapd uses OpenSSL, dnsmasq Nettle and ustream-ssl can use multiple libraries for example. In itself this is also not a major problem. We could unify all packages to use a single cryptography libr

[LEDE-DEV] Stateless /etc/passwd, /etc/group, ...

2017-12-11 Thread Matthias-Christian Ott
Recently I did a sysupgrade on an older OpenWRT system and upgraded it to LEDE. I had the problem that there was no dnsmasq user because /etc/passwd is in /lib/upgrade/keep.d/base-files-essential and sysupgrade does not merge them. I thought a bit about how to improve this. There is a NSS module c

Re: [LEDE-DEV] Uniform cryptography library

2017-12-11 Thread Michael Richardson
Matthias-Christian Ott wrote: > We could unify all packages to use a single cryptography library, for > example LibreSSL or mbed TLS. We could save some space, effort for For some narrow things they are slightly interchangeable, but for many things you want one of these to avoid the bloa

Re: [LEDE-DEV] [PATCH] brcm47xx: proper region code in image name

2017-12-11 Thread txt.file
Didn't you want to use 'us' as image identifier? In your patch it is still north america just shortened to 2 letters. kind regards txt.file Moritz Warning: > Replace 'north-america' by 'us' and remove 'other-regions' in image files for > Netgear WGR614 v10. > > Signed-off-by: Moritz Warning >

Re: [LEDE-DEV] [PATCH] brcm47xx: proper region code in image name

2017-12-11 Thread Mathias Kresin
11.12.2017 20:37, txt.file: Didn't you want to use 'us' as image identifier? In your patch it is still north america just shortened to 2 letters. kind regards txt.file Please don't top-post. The way it was done is correct. North america != us. I fixed the commit message before I merged the p

Re: [LEDE-DEV] [PATCH] fstools: Fix some errors detected by cppcheck

2017-12-11 Thread Arjen de Korte
Citeren Jonas Gorski : On 11 December 2017 at 10:04, Rosen Penev wrote: Mainly plugging memory leaks. Size reduction as well. The calloc change accounts for 272 bytes on this machine for some reason... Please state the exact errors found by cppcheck so we don't have to guess what it found.

Re: [LEDE-DEV] Uniform cryptography library

2017-12-11 Thread Moritz Warning
On 12/11/2017 07:10 PM, Matthias-Christian Ott wrote: [..] > Do you think it would be worth the effort to unify the cryptography > libraries in LEDE? This sounds like a huge task. Maybe you can extend a program so it supports a different crypto library that is also used in the LEDE/OpenWRT ecosys