Re: [LEDE-DEV] [openwrt/openwrt] ar71xx: Ubiquiti Airmax M: add relocate-kernel to invalidate cache

2018-04-26 Thread Matthias Schiffer
2d2aaa7c >> >> commit eed9d40133fe6468cc253d0345c7d7332d2aaa7c >> Author: Matthias Schiffer >> AuthorDate: Thu Apr 26 20:04:48 2018 +0200 >> >> ar71xx: Ubiquiti Airmax M: add relocate-kernel to invalidate cache >> >> Some Ubiquiti U-boot versions, in particular the "

Re: [LEDE-DEV] [PATCH] ath10k-ct: make it depend on PCI support again

2018-04-16 Thread Matthias Schiffer
On 04/16/2018 12:54 AM, Hauke Mehrtens wrote: > The missing dependency causes build problems on systems without PCI > support. > The ath10k_pci kernel module depends on PCI support so this dependency > should be added. ath10k now also supported the ahb interface on the > IPQ4019 SoC, but this SoC a

Re: [LEDE-DEV] [PATCH v3 1/7] Update to latest ath10k-ct driver, enable AHB.

2018-04-13 Thread Matthias Schiffer
On 04/14/2018 12:05 AM, Ben Greear wrote: > On 04/13/2018 02:59 PM, Matthias Schiffer wrote: >> On 03/21/2018 06:28 PM, gree...@candelatech.com wrote: >>> From: Ben Greear >>> >>> The driver updates include: >>> >>> ath10k driver backport

Re: [LEDE-DEV] [PATCH v3 1/7] Update to latest ath10k-ct driver, enable AHB.

2018-04-13 Thread Matthias Schiffer
On 03/21/2018 06:28 PM, gree...@candelatech.com wrote: > From: Ben Greear > > The driver updates include: > > ath10k driver backport to fix WPA 'pn' related security bugs > (4.13 based driver only currently), > a fix for off-channel TX for CT wave-1 firmware, a likely > fix for napi related cras

Re: [LEDE-DEV] [PATCH 3/3] intel-microcode: create early load microcode image

2018-04-11 Thread Matthias Schiffer
On 04/03/2018 03:13 PM, Tomasz Maciej Nowak wrote: > Create initrd image with packed microcode. This'll allow to load it at > early boot stage. Unfortunately the package can't install files directly > to /boot directory, therefore additional installation hooks are placed > for standalone package an

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade depends on sha256sum now

2018-03-11 Thread Matthias Schiffer
On 03/11/2018 02:33 PM, Bjørn Mork wrote: > commit 6ed389da85a9 ("base-files: sysupgrade: do not rely on opkg > to list changed conffile") adds a call to sha256sum. Make sure it > exists. > > Signed-off-by: Bjørn Mork > --- We generally do no add dependencies for busybox applets that are enable

Re: [LEDE-DEV] 18.03/4 -> GCC 5 or 7

2018-03-09 Thread Matthias Schiffer
On 03/09/2018 01:56 PM, Matthias Schiffer wrote: > On 03/07/2018 06:49 PM, Lucian Cristian wrote: >> testing r6395-6c194078db on a ramips Ralink RT5350 with 4.14 and GCC 7.3 >> gives this error in luci >> >> daemon.err uhttpd[873]: /usr/bin/lua: /usr/lib/lua/luci/debug.

Re: [LEDE-DEV] 18.03/4 -> GCC 5 or 7

2018-03-09 Thread Matthias Schiffer
On 03/07/2018 06:49 PM, Lucian Cristian wrote: > testing r6395-6c194078db on a ramips Ralink RT5350 with 4.14 and GCC 7.3 > gives this error in luci > > daemon.err uhttpd[873]: /usr/bin/lua: /usr/lib/lua/luci/debug.lua:6: > attempt to call a number value > daemon.err uhttpd[873]: stack traceback:

Re: [LEDE-DEV] [PATCH 1/4] Update to latest ath10k-ct driver, enable AHB.

2018-01-19 Thread Matthias Schiffer
On 01/19/2018 09:12 PM, gree...@candelatech.com wrote: > From: Ben Greear > > The driver updates include: > > ath10k driver backport to fix WPA 'pn' related security bugs > (4.13 based driver only currently), > a fix for off-channel TX for CT wave-1 firmware, a likely > fix for napi related cras

Re: [LEDE-DEV] Trunk "make menuconfig" exit warnings

2018-01-18 Thread Matthias Schiffer
On 01/18/2018 10:34 AM, Mauro Mozzarelli wrote: > Since about the last 10 days, when I do a make menuconfig, on exit save I > do get the following warnings that I had not seen before (it is a long list > and I include only some excerpts). I also pulled a fresh trunk in case I > missed something in

[LEDE-DEV] [PATCH] ar71xx: disable devicetree support

2018-01-10 Thread Matthias Schiffer
While we'd like to convert ar71xx to DT-based configuration eventually, we aren't quite there yet, and shipping half-baked DT support that is not used at all wastes precious space. Saves ~120KB before LZMA, ~33KB after LZMA. Run-tested on TP-Link CPE510 and TL-WR841 v7. Signed-off-by

Re: [LEDE-DEV] [PATCH 00/15] Metadata generator refactoring, cleanup and PROVIDES improvements

2018-01-08 Thread Matthias Schiffer
On 01/08/2018 03:52 PM, Matthias Schiffer wrote: > When attempting to fix FS#837, I decided to treat our metadata generator to > a greater refactoring, which resulted in this patchset. FS#837 is fixed in > patch 13. > > I also removed two seemingly obsolete features, "pre

[LEDE-DEV] [PATCH 04/15] metadata: move 'builddepends' from binary to source packages

2018-01-08 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer --- scripts/feeds | 20 +++- scripts/metadata.pm | 6 +++--- scripts/package-metadata.pl | 16 +++- 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/scripts/feeds b/scripts/feeds index 42f7b3b116

[LEDE-DEV] [PATCH 13/15] metadata: always resolve dependencies through provides list

2018-01-08 Thread Matthias Schiffer
Instead of adding virtual packages to the normal package list, keep a separate list for provides, make each package provide itself, and resolve all dependencies through this list. This allows to use PROVIDES to replace existing packages. Fixes FS#837. Signed-off-by: Matthias Schiffer

[LEDE-DEV] [PATCH 09/15] build: remove package preconfig feature

2018-01-08 Thread Matthias Schiffer
This feature has been unused for years, and its scope is too limited to be actually useful. Signed-off-by: Matthias Schiffer --- include/package-dumpinfo.mk | 16 +--- package/Makefile| 3 --- scripts/metadata.pm | 20 +--- scripts/package

[LEDE-DEV] [PATCH 14/15] build: remove obsolete "package feature" feature

2018-01-08 Thread Matthias Schiffer
Package "features" seem to be unused for some time. In any case, custom Config.in snippets and package PROVIDES are a much more flexible way to express similar options. Signed-off-by: Matthias Schiffer --- include/package-dumpinfo.mk | 25 - scripts/m

[LEDE-DEV] [PATCH 11/15] metadata: handle target build depends together with host build depends

2018-01-08 Thread Matthias Schiffer
to binary packages afterwards. This does lead to PKG_BUILD_DEPENDS entries referring to binary package names not working anymore, which requires some fixes in the package repositories. Signed-off-by: Matthias Schiffer --- scripts/package-metadata.pl | 60

[LEDE-DEV] [PATCH 12/15] metadata: simplify generation of build depends from runtime depends

2018-01-08 Thread Matthias Schiffer
packages. Signed-off-by: Matthias Schiffer --- scripts/package-metadata.pl | 112 1 file changed, 41 insertions(+), 71 deletions(-) diff --git a/scripts/package-metadata.pl b/scripts/package-metadata.pl index e492cc8a09..980ad24dc0 100755 --- a/scripts

[LEDE-DEV] [PATCH 10/15] treewide: fix build depends to refer to source package names

2018-01-08 Thread Matthias Schiffer
Build depends must refer to source packages rather than binary package names. Signed-off-by: Matthias Schiffer --- include/autotools.mk | 4 ++-- include/nls.mk | 2 +- package/network/config/ltq-adsl-app/Makefile | 2 +- package/network

[LEDE-DEV] [PATCH 02/15] metadata: make srcpackage extensible

2018-01-08 Thread Matthias Schiffer
Turn the srcpackage values into hashes to allow storing more information than just binary package names. Signed-off-by: Matthias Schiffer --- scripts/feeds | 2 +- scripts/metadata.pm | 6 -- scripts/package-metadata.pl | 2 +- 3 files changed, 6 insertions(+), 4

[LEDE-DEV] [PATCH 00/15] Metadata generator refactoring, cleanup and PROVIDES improvements

2018-01-08 Thread Matthias Schiffer
ors)? As hinted in patch 15, I have further refactoring in mind, but let's try to get this set reviewed and committed first... Regards, Matthias [1] https://github.com/openwrt/packages/pull/5370 [2] https://github.com/openwrt-routing/packages/pull/345 Matthias Schiffer (15): metadat

[LEDE-DEV] [PATCH 15/15] include/package-dumpinfo.mk: don't duplicate source package information for every binary package

2018-01-08 Thread Matthias Schiffer
Eventually the BUILDONLY package flag could be replaced by simply creating a package Makefile without any BuildPackage calls. This will fail for now, as BuildPackage also causes the Makefile's compile target etc. to do something useful at all. Signed-off-by: Matthias Schiffer --- in

[LEDE-DEV] [PATCH 01/15] metadata: remove 'base-files' special case

2018-01-08 Thread Matthias Schiffer
Nothing explicitly depends on base-files, and even if it would, it would not cause any problems. Remove the unused special case. Signed-off-by: Matthias Schiffer --- scripts/package-metadata.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/package-metadata.pl b

[LEDE-DEV] [PATCH 05/15] metadata: interate over source packages when generating Makefile

2018-01-08 Thread Matthias Schiffer
lexicographically first). Signed-off-by: Matthias Schiffer --- scripts/metadata.pm | 1 + scripts/package-metadata.pl | 61 ++--- 2 files changed, 36 insertions(+), 26 deletions(-) diff --git a/scripts/metadata.pm b/scripts/metadata.pm index c150b547f1

[LEDE-DEV] [PATCH 06/15] metadata: change pkg->{src} field to hold a reference

2018-01-08 Thread Matthias Schiffer
We often want to access fields of a source packages through pkg->{src}. Allow accessing them directly instead of resolving the source hash through srcpackages. Signed-off-by: Matthias Schiffer --- scripts/feeds | 4 ++-- scripts/metadata.pm |

[LEDE-DEV] [PATCH 03/15] metadata: move 'buildtypes' from binary to source packages

2018-01-08 Thread Matthias Schiffer
Build types are a property of source rather than binary packages. This is a preparation for followup cleanup. Signed-off-by: Matthias Schiffer --- scripts/metadata.pm | 4 ++-- scripts/package-metadata.pl | 13 +++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git

[LEDE-DEV] [PATCH 07/15] metadata: replace %subdir hash with a path field in source packages

2018-01-08 Thread Matthias Schiffer
Every single reference to subdir was concatenated with the source package name, so it makes sense to store the concatenated value instead. Signed-off-by: Matthias Schiffer --- scripts/metadata.pm | 12 +++- scripts/package-metadata.pl | 25 - 2 files

[LEDE-DEV] [PATCH 08/15] metadata: remove redundant fields from package hash

2018-01-08 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer --- scripts/metadata.pm | 3 --- scripts/package-metadata.pl | 8 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/scripts/metadata.pm b/scripts/metadata.pm index e636a45a33..50f91407d6 100644 --- a/scripts/metadata.pm +++ b/scripts

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Matthias Schiffer
On 12/12/2017 11:01 PM, Jonas Gorski wrote: > On 12 December 2017 at 21:03, Jo-Philipp Wich wrote: >> Hi Piotr, >> >> my rough idea was to somehow tie the manifest generation to the "define >> Device/*" macros present in the image building code because there you >> have all required information in

Re: [LEDE-DEV] odhcpd vs odhcpd-ipv6only

2017-12-12 Thread Matthias Schiffer
Unless you have the option odhcpd_is_main in /etc/config/dhcp, odhcpd has never been used for IPv4, but only for DHCPv6; IPv4 DHCP is handled by dnsmasq by default. The switch to odhcpd-ipv6only simply removes some unused clutter from our default package set. Regards, Matthias On 12/12/2017 11:1

Re: [LEDE-DEV] [PATCH] base-files: add comment to uci-defaults.sh script

2017-12-12 Thread Matthias Schiffer
On 12/12/2017 11:24 AM, John Crispin wrote: > > > board_config_flush() { > + # when calling json_dump with a redirect, the shell will truncate the > target > + # file and not update it until a close/flush is called. this results in > a short > + # window where the file is 0 bytes.

[LEDE-DEV] [PATCH 2/3] busybox: streamline Makefile

2017-12-10 Thread Matthias Schiffer
Use default Build/Install steps where possible. No binary change in default configuration, so PKG_RELEASE is not incremented. Signed-off-by: Matthias Schiffer --- package/utils/busybox/Makefile | 67 +++--- 1 file changed, 17 insertions(+), 50 deletions

[LEDE-DEV] [PATCH 3/3] busybox: add missing TARGET_CPPFLAGS and TARGET_LDFLAGS

2017-12-10 Thread Matthias Schiffer
these flags increases the size of the stripped busybox binary by about 6KB (~4KB with fortify headers, ~2KB with "-znow -zrelro") with the default hardening options PKG_FORTIFY_SOURCE_1 and PKG_RELRO_FULL. Signed-off-by: Matthias Schiffer --- package/utils/busybox/Makefile | 5 +++

[LEDE-DEV] [PATCH 1/3] include/package.mk: remove old configured stamps before attempting configuration

2017-12-10 Thread Matthias Schiffer
rules can be dropped. Signed-off-by: Matthias Schiffer --- include/package.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/package.mk b/include/package.mk index 5dc4aec70d..c0dbf12787 100644 --- a/include/package.mk +++ b/include/package.mk @@ -165,11 +165,11

[LEDE-DEV] [PATCH 0/3] busybox Makefile improvements (fix hardening)

2017-12-10 Thread Matthias Schiffer
ng is applied as intended, and as it is done for the other packages. Do we have any numbers how much hardening usually increases binary sizes? Regrads, Matthias Matthias Schiffer (3): include/package.mk: remove old configured stamps before attempting configuration busybox: streamline Mak

Re: [LEDE-DEV] Latest trunk pull fails to compile?

2017-12-08 Thread Matthias Schiffer
Your build is based on an old .config that enables "odhcpd" (as it was the default in the past). The latest master includes a package "odhcpd-ipv6only", which is the default since c7b052db739e50f8a40f95ac17a21363b1593e33. Our Kconfig-based .config management can't properly deal with conficting pac

Re: [LEDE-DEV] [PATCH] base-files: config_generate: keep ipv6 interface in sync

2017-12-06 Thread Matthias Schiffer
On 12/06/2017 12:40 AM, Roman Yeryomin wrote: > On 2017-12-05 21:52, Hans Dedecker wrote: >> On Tue, Dec 5, 2017 at 5:22 PM, Roman Yeryomin wrote: >>> It's better not to configure ifname separately since they >>> are tied together. >>> >>> Signed-off-by: Roman Yeryomin >>> --- >>>  package/base-f

Re: [LEDE-DEV] [PATCH 1/5] build: append metadata for supported images.gz

2017-11-28 Thread Matthias Schiffer
On 11/28/2017 10:51 PM, Christian Lamparter wrote: > Targets that either directly or indirectly set > CONFIG_TARGET_IMAGES_GZIP currently have no way > to append the metadata at the end of new image > creation process. And this is going to be > necessary in order to convert the targets to use > the

Re: [LEDE-DEV] [PATCH] base-files: do not backup unchanged files

2017-11-24 Thread Matthias Schiffer
On 11/24/2017 08:11 AM, Luiz Angelo Daros de Luca wrote: >>> After applied, the list of files in backup in a fresh installation change >>> from: >>> to: >>> >>> root at LEDE:~# sysupgrade  -l >>> /etc/config/dhcp >>> /etc/config/firewall >>> /etc/config/network >>> /etc/config/system >>> /etc/drop

Re: [LEDE-DEV] [PATCH] base-files: do not backup unchanged files

2017-11-17 Thread Matthias Schiffer
On 11/17/2017 10:14 AM, Jonas Gorski wrote: > On 17 November 2017 at 01:41, wrote: >> From: Luiz Angelo Daros de Luca >> >> Only backup /aaa/bbb/ccc if /rom/aaa/bbb/ccc does not exist >> or /aaa/bbb/ccc is different from /rom/aaa/bbb/ccc. >> >> Signed-off-by: Luiz Angelo Daros de Luca >> --- >>

Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-08 Thread Matthias Schiffer
On 11/08/2017 10:57 AM, Zefir Kurtisi wrote: > On 11/07/2017 09:24 PM, Rosen Penev wrote: >> Less verbose >> >> Signed-off-by: Rosen Penev >> --- >> interface.c | 22 -- >> 1 file changed, 8 insertions(+), 14 deletions(-) >> >> diff --git a/interface.c b/interface.c >> index 7

Re: [LEDE-DEV] LEDE version numbers?

2017-11-07 Thread Matthias Schiffer
On 11/07/2017 06:20 PM, Bjørn Mork wrote: > Matthias Schiffer writes: > >> Fixing our revision numbering to include the branch name to make this more >> or less unambiguous is the intent of the two patches I linked. The commit >> ID should still be included in this revis

Re: [LEDE-DEV] LEDE version numbers?

2017-11-07 Thread Matthias Schiffer
On 11/07/2017 03:25 PM, James Feeney wrote: > On 11/06/2017 11:44 PM, Matthias Schiffer wrote: >> r# is the number of commits since the "reboot" tag. If your local branch >> (e.g. "master") has a upstream branch (e.g. "origin/master"), it will use >

Re: [LEDE-DEV] [PATCH] hostapd: explicitly set beacon interval for wpa_supplicant

2017-11-07 Thread Matthias Schiffer
On 11/07/2017 01:19 PM, Sven Eckelmann wrote: > The beacon_int is currently set explicitly for hostapd and when LEDE uses > iw to join an IBSS/mesh. But it was not done when wpa_supplicant was used > to join an encrypted IBSS or mesh. > > This configuration is required when an AP interface is conf

Re: [LEDE-DEV] LEDE version numbers?

2017-11-06 Thread Matthias Schiffer
On 11/07/2017 07:23 AM, David Lang wrote: > 17.01 is pointer to a particular commit on the master branch > > I haven't looked at the specific method used for the r# generation, but I > think it's incremented daily r# is the number of commits since the "reboot" tag. If your local branch (e.g. "mas

Re: [LEDE-DEV] jshn.sh: json_load replaces "-" with "_"

2017-10-30 Thread Matthias Schiffer
On 10/30/2017 09:58 PM, Paul Spooren wrote: > On 10/30/17 3:28 AM, Matthias Schiffer wrote: >> On 10/29/2017 09:21 PM, Paul Spooren wrote: >>> Hi all, >>> >>> I'm currently trying to use jshn.sh but it changes the data and makes it >>> unu

Re: [LEDE-DEV] jshn.sh: json_load replaces "-" with "_"

2017-10-29 Thread Matthias Schiffer
On 10/29/2017 09:21 PM, Paul Spooren wrote: > Hi all, > > I'm currently trying to use jshn.sh but it changes the data and makes it > unusable. > > Below an example: > > root@LEDE:~# json_string="{ \"foo-bar\": 10 }" > root@LEDE:~# echo $json_string > { "foo-bar": 10 } > root@LEDE:~# json_init >

Re: [LEDE-DEV] [source] ar71xx: deactivate some boards with too small kernel partitions

2017-10-23 Thread Matthias Schiffer
-SNIP- > >>   * ubnt-uap-pro >>   * ubnt-unifi-outdoor-plus > > No idea about these two. > I have a UAP Outdoor+ here, I'll have a look at it soon-ish. Matthias signature.asc Description: OpenPGP digital signature ___ Lede-dev mailing lis

[LEDE-DEV] [PATCH uclient] uclient-http: fix Host: header for literal IPv6 addresses

2017-09-05 Thread Matthias Schiffer
n the host, as neither IPv4 addresses nor DNS names can contain colons. An alternative would be to add a flag to the uclient_url struct; but as this struct is exposed in public headers, such a change could be considered an ABI change, making a backport difficult. Signed-off-by: Matthias Schiffer -

Re: [LEDE-DEV] Bind not building

2017-08-07 Thread Matthias Schiffer
On 08/07/2017 06:14 PM, Philip Prindeville wrote: > I’m seeing the following when building bind: > > OpenWrt-libtool: link: x86_64-openwrt-linux-musl-gcc -Os -pipe > -fno-caller-saves -fno-plt -fhonour-copts -Wno-error=unused-but-set-variable > -Wno-error=unused-result > -iremap/home/philipp/be

Re: [LEDE-DEV] [PATCH v2] scripts: metadata: always resolve dependencies through provides list

2017-07-20 Thread Matthias Schiffer
On 07/08/2017 09:18 PM, Matthias Schiffer wrote: > Instead of adding virtual packages to the normal package list, keep a > separate list for provides, make each package provide itself, and resolve > all dependencies through this list. This allows to use PROVIDES to replace > exist

Re: [LEDE-DEV] [PATCH procd v3 1/2] init: Check chroot return value in sysupgrade_exec_upgraded()

2017-07-20 Thread Matthias Schiffer
d from > preinit") > Signed-off-by: Florian Fainelli > --- > sysupgrade.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) Reviewed-by: Matthias Schiffer You should be able to push this yourself, otherwise I can do it later today (I'll also add another com

Re: [LEDE-DEV] [PATCH procd v2 1/2] init: Check chroot return value in sysupgrade_exec_upgraded()

2017-07-19 Thread Matthias Schiffer
On 07/18/2017 03:33 AM, Florian Fainelli wrote: > chroot() can fail and its return value should be checked against, in that case > do an exit() since this is a fatal condition that we cannot recover from. > > Fixes: 63789e51ed91 ("init: add support for sysupgrades triggered from > preinit") > Sig

Re: [LEDE-DEV] [PATCH procd 2/2] upgraded: Check chroot() return value

2017-07-16 Thread Matthias Schiffer
t; [-Werror=unused-result] chroot("."); > > Fixes: 056d8ddda8d5 ("upgraded: link dynamically, chroot during exec") > Signed-off-by: Florian Fainelli > --- LGTM. Reviewed-by: Matthias Schiffer > upgraded/upgraded.c | 5 - > 1 file changed, 4 insertions(+),

Re: [LEDE-DEV] [PATCH procd 1/2] init: Propagate sysupgrade_exec_upgraded() return value

2017-07-16 Thread Matthias Schiffer
On 07/15/2017 09:44 PM, Florian Fainelli wrote: > chroot() can fail and its return value should be checked against so propagate > sysupgrade_exec_upgraded() return value to its caller. > > Fixes: 63789e51ed91 ("init: add support for sysupgrades triggered from > preinit") > Signed-off-by: Florian

Re: [LEDE-DEV] procd: cherry-pick kernel watchdog start/stop to lede-17.01 branch

2017-07-12 Thread Matthias Schiffer
On 07/12/2017 08:02 PM, Philip Prindeville wrote: > >> On Jul 11, 2017, at 3:19 AM, Hans Dedecker wrote: >> >> Hi, >> >> I would like to cherry-pick the start/stop kernel watchdog support to >> the lede-17.01 procd branch : >> >> e5e99c4 watchdog: add support for starting/stopping kernel watchdog

Re: [LEDE-DEV] [PATCH 3/4] scripts/getver.sh: include branch name in revision string

2017-07-10 Thread Matthias Schiffer
On 07/10/2017 02:19 AM, Matthias Schiffer wrote: > To determine the originating branch of a commit, a file called "branch" > must be added to the root of the repository (similar to the existing > "version" file used to override the getver.sh logic). When no such f

[LEDE-DEV] [PATCH 2/4] scripts/getver.sh: drop try_hg

2017-07-09 Thread Matthias Schiffer
We don't use Mercurial, try_hg didn't understand GET_REV, and its output didn't have anything to do with the way LEDE counts revisions. Signed-off-by: Matthias Schiffer --- scripts/getver.sh | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/scripts/getv

[LEDE-DEV] [PATCH 4/4] scripts/getver.sh: only consider version override file when no argument is given

2017-07-09 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer --- scripts/getver.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/getver.sh b/scripts/getver.sh index f6d18bb3a3..30cf32ed14 100755 --- a/scripts/getver.sh +++ b/scripts/getver.sh @@ -10,7 +10,7 @@ get_branch() { } try_version

[LEDE-DEV] [PATCH 3/4] scripts/getver.sh: include branch name in revision string

2017-07-09 Thread Matthias Schiffer
umed. Signed-off-by: Matthias Schiffer --- scripts/getver.sh | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/getver.sh b/scripts/getver.sh index 215bb036a5..f6d18bb3a3 100755 --- a/scripts/getver.sh +++ b/scripts/getver.sh @@ -5,6 +5,10 @@ export LC_ALL=C GET_

[LEDE-DEV] [PATCH 1/4] scripts/getver.sh: fail when an invalid commit reference is given

2017-07-09 Thread Matthias Schiffer
Correctly return "unknown" instead of printing various error messages, followed by a "r0-..." revision. Signed-off-by: Matthias Schiffer --- scripts/getver.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/getver.sh b/scripts/getver.sh index 9175f411db..103

Re: [LEDE-DEV] [PATCH] firmware-utils: mktplinkfw: rework combined image option

2017-07-09 Thread Matthias Schiffer
On 07/10/2017 01:02 AM, Piotr Dymacz wrote: > We use combined option in "mktplinkfw" tool for generating initramfs > kernel images and header for kernel inside "safeloader" image type (in > fact, only for TL-WR1043ND v4 at this moment). > > There is also "mktplinkfw-kernel" tool, a stripped-down v

Re: [LEDE-DEV] [PATCH] uhttpd: fix PKG_BUILD_DEPENDS

2017-07-09 Thread Matthias Schiffer
On 06/22/2017 02:07 AM, Daniel Golle wrote: > uhttpd refered to ustream-ssl as PKG_BUILD_DEPENDS. While this > intuitively seems like the correct thing to do, it turns out not to > have the desired effect: PKG_BUILD_DEPENDS needs to list the resulting > package name (ie. one of libustream-*) and no

Re: [LEDE-DEV] [PATCH v2] scripts: metadata: always resolve dependencies through provides list

2017-07-08 Thread Matthias Schiffer
On 07/08/2017 09:18 PM, Matthias Schiffer wrote: > Instead of adding virtual packages to the normal package list, keep a > separate list for provides, make each package provide itself, and resolve > all dependencies through this list. This allows to use PROVIDES to replace > exist

[LEDE-DEV] [PATCH v2] scripts: metadata: always resolve dependencies through provides list

2017-07-08 Thread Matthias Schiffer
logic is that build dependencies are now always interpreted as source package names, instead of putting build and runtime dependencies into the same list. Fixes FS#837. Signed-off-by: Matthias Schiffer --- v2: Fixed an issue that caused syntax errors in .config-package.in for dependencies on on

[LEDE-DEV] [PATCH] scripts: metadata: always resolve dependencies through provides list

2017-07-07 Thread Matthias Schiffer
logic is that build dependencies are now always interpreted as source package names, instead of putting build and runtime dependencies into the same list. Fixes FS#837. Signed-off-by: Matthias Schiffer --- Some thorough review would be appreciated, I forgot almost all I once knew about Perl

Re: [LEDE-DEV] sysupgrade broken on brcm47xx

2017-07-02 Thread Matthias Schiffer
On 07/02/2017 04:05 PM, Hauke Mehrtens wrote: > Hi, > > I just tried to run sysupgrade on a WRT53GS (brcm47xx) device and it > failed. I am running LEDE r4504. > > Hauke Hmm, the "Could not get image magic" and "Image check failed." message are from mtd itself. What exactly does mtd check here?

Re: [LEDE-DEV] [PATCH] scripts: getver.sh: include branch name in a revision string

2017-06-22 Thread Matthias Schiffer
On 06/22/2017 10:50 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > The purpose of revision (r* number) is to provide a rough info about > build next to the (very) specific SHA-1. Unfortunately without a branch > name specified it's a bit misleading and what's more two commits may get > the sa

Re: [LEDE-DEV] [PATCH procd] upgraded: cmake: Find and include uloop.h

2017-05-31 Thread Matthias Schiffer
On 05/31/2017 11:02 PM, Florian Fainelli wrote: > Add a CMake FIND_PATH and INCLUDE_DIRECTORIES searching for > libubox/uloop.h. Some external toolchains which do not include standard > locations would fail to find the header otherwise. > > Signed-off-by: Florian Fainelli > --- > upgraded/CMakeL

Re: [LEDE-DEV] openwrt and lede - remerge proposal V3

2017-05-29 Thread Matthias Schiffer
On 05/29/2017 09:03 AM, John Crispin wrote: > (resend, this time as plain text) > > Hi, > > here is a V3 of the remerge proposal, I tried to fold all the comments > people made into it, if anything is missing let me know. Please remeber > that post remerge anything can be voted on, so cluttering

[LEDE-DEV] [PATCH v2 15/19] x86: sysupgrade: move partition table change check to platform_check_image

2017-05-13 Thread Matthias Schiffer
The staged sysupgrade will prevent us from using ask_bool in platform_do_upgrade; therefore, the check is moved to platform_check_image. Signed-off-by: Matthias Schiffer --- .../linux/x86/base-files/lib/upgrade/platform.sh | 29 +++--- 1 file changed, 25 insertions(+), 4

[LEDE-DEV] [PATCH v2 16/19] x86: sysupgrade: refactor platform_do_upgrade

2017-05-13 Thread Matthias Schiffer
By returning early when no upgrade device can be found and handling the SAVE_PARTITIONS=0 case differently, we can get rid of two levels of if. Signed-off-by: Matthias Schiffer --- .../linux/x86/base-files/lib/upgrade/platform.sh | 69 +++--- 1 file changed, 36 insertions

[LEDE-DEV] [PATCH v2 19/19] sunxi: sysupgrade: sync with x86

2017-05-13 Thread Matthias Schiffer
: sysupgrade: explicitly rescan disk after writing partition table Signed-off-by: Matthias Schiffer --- target/linux/sunxi/Makefile| 2 +- .../linux/sunxi/base-files/lib/upgrade/platform.sh | 120 - 2 files changed, 72 insertions(+), 50 deletions(-) diff --git

[LEDE-DEV] [PATCH v2 17/19] x86: sysupgrade: explicitly rescan disk after writing partition table

2017-05-13 Thread Matthias Schiffer
This should ensure that the kernel partition can be mounted in platform_copy_config when its size has changed. Signed-off-by: Matthias Schiffer --- target/linux/x86/base-files/lib/upgrade/platform.sh | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/linux/x86/base-files/lib

[LEDE-DEV] [PATCH v2 07/19] base-files: always use staged sysupgrade

2017-05-13 Thread Matthias Schiffer
allow unmounting the root filesystem. Signed-off-by: Matthias Schiffer --- package/base-files/files/lib/upgrade/common.sh | 123 +++-- package/base-files/files/lib/upgrade/nand.sh | 60 ++-- package/base-files/files/lib/upgrade/stage2| 50 ++ package

[LEDE-DEV] [PATCH v2 18/19] sunxi: sysupgrade: don't write partitions twice

2017-05-13 Thread Matthias Schiffer
1024KiB). In addition, conv=notrunc is replaced with conv=fsync. It seems this was an oversight, as notrunc doesn't make sense for block devices and all other dd commands use conv=fsync. Signed-off-by: Matthias Schiffer --- target/linux/sunxi/base-files/lib/upgrade/platform.sh | 2 +- 1

[LEDE-DEV] [PATCH v2 11/19] procd: init: add support for sysupgrades triggered from preinit

2017-05-13 Thread Matthias Schiffer
This will allow to add sysupgrade support via upgraded for failsafe mode. Signed-off-by: Matthias Schiffer Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the whole series. --- ...pport-for

[LEDE-DEV] [PATCH v2 12/19] base-files: sysupgrade cleanup

2017-05-13 Thread Matthias Schiffer
that function on some targets. Targets that do the latter should be fixed eventually to use platform_do_upgrade for that purpose. Signed-off-by: Matthias Schiffer --- package/base-files/files/lib/upgrade/common.sh | 100 --- package/base-files/files/lib/upgrade/stage2

[LEDE-DEV] [PATCH v2 10/19] procd: remove code that has become unnecessary after sysupgrade changes

2017-05-13 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the whole series. --- ...-that-has-become-unnecessary-after-sysupg.patch | 120 + 1 file

[LEDE-DEV] [PATCH v2 05/19] procd: upgraded: add support for passing a "command" argument to stage2

2017-05-13 Thread Matthias Schiffer
This allows us to make use of upgraded in "snapshot convert" as well. Signed-off-by: Matthias Schiffer Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the whole series. --- ...d-s

[LEDE-DEV] [PATCH v2 06/19] procd: remove procd-nand package

2017-05-13 Thread Matthias Schiffer
We always want to support staged upgrades now, so it's better to include upgraded into the main package. /lib/upgrade/nand.sh is moved to base-files. The procd-nand-firstboot package is removed for now, it may return later as a separate package. Signed-off-by: Matthias Schiffer --- pa

[LEDE-DEV] [PATCH v2 13/19] base-files: add support for staged sysupgrades from failsafe mode

2017-05-13 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer --- .../base-files/files/lib/preinit/40_run_failsafe_hook | 6 +- .../base-files/files/lib/preinit/99_10_failsafe_login | 11 +++ package/base-files/files/sbin/sysupgrade | 18 +- 3 files changed, 25 insertions(+), 10

[LEDE-DEV] [PATCH v2 09/19] fstools: snapshot: handle jffs2 conversion using upgraded

2017-05-13 Thread Matthias Schiffer
We can reuse the kill_remaining and run_ramfs facilities of the stage2 run by upgraded. Signed-off-by: Matthias Schiffer --- package/system/fstools/Makefile | 2 +- package/system/fstools/files/snapshot | 14 -- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a

[LEDE-DEV] [PATCH v2 08/19] fstools: clean up trailing whitespace in snapshot script

2017-05-13 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer --- package/system/fstools/files/snapshot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/system/fstools/files/snapshot b/package/system/fstools/files/snapshot index c1a5b733f3..baf24f1e3e 100644 --- a/package/system/fstools/files

[LEDE-DEV] [PATCH v2 14/19] ramips: sysupgrade: move nand_do_upgrade call to platform_do_upgrade

2017-05-13 Thread Matthias Schiffer
All targets with NAND support should gradually move their nand_do_upgrade calls from platform_pre_upgrade to platform_do_upgrade. Signed-off-by: Matthias Schiffer --- target/linux/ramips/base-files/lib/upgrade/platform.sh | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git

[LEDE-DEV] [PATCH v2 00/19] Universal staged sysupgrade and assorted fixes

2017-05-13 Thread Matthias Schiffer
far. Matthias Matthias Schiffer (19): procd: clean up trailing whitespace in nand.sh procd: prepare NAND sysupgrade for making upgraded dynamically linked procd: system: always support staged sysupgrade procd: upgraded: link dynamically, chroot during exec procd: upgraded: add support for pass

[LEDE-DEV] [PATCH v2 02/19] procd: prepare NAND sysupgrade for making upgraded dynamically linked

2017-05-13 Thread Matthias Schiffer
Use install_bin to copy upgraded with all dependencies. The old name /tmp/upgraded is temporarily retained as a symlink to avoid breaking things. Signed-off-by: Matthias Schiffer --- package/system/procd/files/nand.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a

[LEDE-DEV] [PATCH v2 04/19] procd: upgraded: link dynamically, chroot during exec

2017-05-13 Thread Matthias Schiffer
ation, and libraries need to be made available. Signed-off-by: Matthias Schiffer Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the whole series. --- ...raded-link-dynamically-chroot-during-exec.p

[LEDE-DEV] [PATCH v2 01/19] procd: clean up trailing whitespace in nand.sh

2017-05-13 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer --- package/system/procd/files/nand.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/system/procd/files/nand.sh b/package/system/procd/files/nand.sh index 01dba61644..b5f86e0301 100644 --- a/package/system/procd/files/nand.sh

[LEDE-DEV] [PATCH v2 03/19] procd: system: always support staged sysupgrade

2017-05-13 Thread Matthias Schiffer
method that will become unused with the staged sysupgrade is retained for now. Signed-off-by: Matthias Schiffer Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the whole series. --- ...1-system-alwa

Re: [LEDE-DEV] openwrt and lede - remerge proposal

2017-05-11 Thread Matthias Schiffer
[Some lists were dropped from this thread, adding again] > >>> According to the rules there shall be no personal mail accounts at all. >>> There should be plenty of time until the actual remerge to fade them out >>> and to set up forwarding elsewhere. >> >> I hope you agree that a merge means bo

Re: [LEDE-DEV] openwrt and lede - remerge proposal

2017-05-11 Thread Matthias Schiffer
On 05/11/2017 12:17 AM, Hauke Mehrtens wrote: > Thanks for moving this forward. > > On 05/08/2017 03:19 PM, John Crispin wrote: >> *) github > . >> >> - obsolete the lede github org after a grace period of 3-6 months > > As long as it does not cost us effort I would like to keep the lede > doma

Re: [LEDE-DEV] [RFC 01/13] procd: prepare NAND sysupgrade for making upgraded dynamically linked

2017-04-24 Thread Matthias Schiffer
On 04/24/2017 10:05 PM, Philip Prindeville wrote: > Inline… > >> On Apr 23, 2017, at 6:06 PM, Matthias Schiffer >> wrote: >> >> Use install_bin to copy upgraded with all dependencies. The old name >> /tmp/upgraded is temporarily retained as a symlink to av

Re: [LEDE-DEV] [RFC 13/13] x86: sysupgrade: explicitly rescan disk after writing partition table

2017-04-24 Thread Matthias Schiffer
On 04/24/2017 12:19 PM, Jo-Philipp Wich wrote: > Hi, > >> While we're at it, also remove the ask_bool that can't work anymore with >> staged sysupgrade. > > We should find an alternative solution though; like some new flag > "--proceed-even-if-partition-table-changed" to avoid accidentally > kill

[LEDE-DEV] [RFC 10/13] base-files: sysupgrade cleanup

2017-04-23 Thread Matthias Schiffer
that function on some targets. Targets that do the latter should be fixed eventually to use platform_do_upgrade for that purpose. Signed-off-by: Matthias Schiffer --- package/base-files/files/lib/upgrade/common.sh | 100 - package/base-files/files/lib/upgrade/stage2

[LEDE-DEV] [RFC 06/13] base-files: always use staged sysupgrade

2017-04-23 Thread Matthias Schiffer
allow unmounting the root filesystem. Signed-off-by: Matthias Schiffer --- package/base-files/files/lib/upgrade/common.sh | 123 +++-- package/base-files/files/lib/upgrade/nand.sh | 60 ++-- package/base-files/files/lib/upgrade/stage2| 50 ++ package

[LEDE-DEV] [RFC 09/13] procd: init: add support for sysupgrades triggered from preinit

2017-04-23 Thread Matthias Schiffer
This will allow to add sysupgrade support via upgraded for failsafe mode. Signed-off-by: Matthias Schiffer Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the whole series. --- ...pport-for

[LEDE-DEV] [RFC 05/13] procd: remove procd-nand package

2017-04-23 Thread Matthias Schiffer
We always want to support staged upgrades now, so it's better to include upgraded into the main package. /lib/upgrade/nand.sh is moved to base-files. The procd-nand-firstboot package is removed for now, it may return later as a separate package. Signed-off-by: Matthias Schiffer --- pa

[LEDE-DEV] [RFC 13/13] x86: sysupgrade: explicitly rescan disk after writing partition table

2017-04-23 Thread Matthias Schiffer
e ask_bool that can't work anymore with staged sysupgrade. Signed-off-by: Matthias Schiffer --- target/linux/x86/base-files/lib/upgrade/platform.sh | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/linux/x86/base-files/lib/upgrade/platform.sh b/target/linux/x86/ba

[LEDE-DEV] [RFC 08/13] procd: remove code that has become unnecessary after sysupgrade changes

2017-04-23 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the whole series. --- ...-that-has-become-unnecessary-after-sysupg.patch | 120 + 1 file

  1   2   >