On 12/19/2017 12:01 AM, Hauke Mehrtens wrote:
> On 12/18/2017 11:38 PM, Hauke Mehrtens wrote:
>> On 12/18/2017 03:07 PM, Kevin Darbyshire-Bryant wrote:
>>>
>>>
On 18 Dec 2017, at 10:12, Felix Fietkau wrote:
On 2017-12-18 11:07, Kevin Darbyshire-Bryant wrote:
> Hi Felix,
>
>>
On 12/18/2017 11:38 PM, Hauke Mehrtens wrote:
> On 12/18/2017 03:07 PM, Kevin Darbyshire-Bryant wrote:
>>
>>
>>> On 18 Dec 2017, at 10:12, Felix Fietkau wrote:
>>>
>>> On 2017-12-18 11:07, Kevin Darbyshire-Bryant wrote:
Hi Felix,
Thanks for explaining that. I suspect you’re right t
On 12/18/2017 03:07 PM, Kevin Darbyshire-Bryant wrote:
>
>
>> On 18 Dec 2017, at 10:12, Felix Fietkau wrote:
>>
>> On 2017-12-18 11:07, Kevin Darbyshire-Bryant wrote:
>>> Hi Felix,
>>>
>>> Thanks for explaining that. I suspect you’re right that there’s an
>>> underlying bug in gcc mips. So id
On 12/18/2017 10:34 AM, Syrone Wong wrote:
> I agree with Felix. I found libtommath issue in dropbear several
> months before. I can confirm the issue fixed by upgrading libtommath
> and libtomcrypt. The update is already done by upstream, but not
> released yet.
With this patch libtommath will be
> On 18 Dec 2017, at 10:12, Felix Fietkau wrote:
>
> On 2017-12-18 11:07, Kevin Darbyshire-Bryant wrote:
>> Hi Felix,
>>
>> Thanks for explaining that. I suspect you’re right that there’s an
>> underlying bug in gcc mips. So ideally we need some code that exposes the
>> bug when using -O2
On 2017-12-18 11:07, Kevin Darbyshire-Bryant wrote:
> Hi Felix,
>
> Thanks for explaining that. I suspect you’re right that there’s an
> underlying bug in gcc mips. So ideally we need some code that exposes the
> bug when using -O2 (or even just -funroll_loops) Looking at FS 814 there’s a
> h
> On 18 Dec 2017, at 08:40, Felix Fietkau wrote:
>
> On 2017-12-17 22:21, Hauke Mehrtens wrote:
>> This patch made GCC produce broken code, remove it.
>> In mp_cmp_d() function in th libtommath shipped with dropbear the
>> following code was compiled wrong:
>>
>> /* compare based on magnitude
I agree with Felix. I found libtommath issue in dropbear several
months before. I can confirm the issue fixed by upgrading libtommath
and libtomcrypt. The update is already done by upstream, but not
released yet.
You can try a CI-successfully-built commit from
https://github.com/mkj/dropbear and s
On 2017-12-17 22:21, Hauke Mehrtens wrote:
> This patch made GCC produce broken code, remove it.
> In mp_cmp_d() function in th libtommath shipped with dropbear the
> following code was compiled wrong:
>
> /* compare based on magnitude */
> if (a->used > 1) {
> return 1;
> }
>
> In the broken A
> On 17 Dec 2017, at 21:21, Hauke Mehrtens wrote:
>
> This patch made GCC produce broken code, remove it.
> In mp_cmp_d() function in th libtommath shipped with dropbear the
> following code was compiled wrong:
>
> /* compare based on magnitude */
> if (a->used > 1) {
> return 1;
> }
>
> In
On 12/17/2017 10:21 PM, Hauke Mehrtens wrote:
> This patch made GCC produce broken code, remove it.
> In mp_cmp_d() function in th libtommath shipped with dropbear the
> following code was compiled wrong:
>
> /* compare based on magnitude */
> if (a->used > 1) {
> return 1;
> }
>
> In the broke
This patch made GCC produce broken code, remove it.
In mp_cmp_d() function in th libtommath shipped with dropbear the
following code was compiled wrong:
/* compare based on magnitude */
if (a->used > 1) {
return 1;
}
In the broken ASM this part returned -1 like the previous return
statement did
12 matches
Mail list logo
