Re: [LEDE-DEV] [PATCH 2/2] x86: Add board configs for the PC Engines APU2

On Mon, 2017-02-13 at 12:50 +0100, Felix Fietkau wrote: > > Please leave out the /lib/.sh anti-pattern. Just use > /tmp/sysinfo/board_name directly or (even better) introduce a generic > function for getting the board name. Once I stop /etc/diag.sh from having hard-coded board name stuff, we go

Re: [LEDE-DEV] [PATCH 2/2] x86: Add board configs for the PC Engines APU2

On 2017-02-13 09:01, Chris Blake wrote: > This adds the default LED and network settings for the PC Engines APU2 > when running under the x86 target. > > Signed-off-by: Chris Blake > --- > target/linux/x86/base-files/etc/board.d/01_leds| 7 +++- >

Re: [LEDE-DEV] [PATCH 2/2] x86: Add board configs for the PC Engines APU2

On Mon, 2017-02-13 at 02:01 -0600, Chris Blake wrote: > > +get_status_led() { > +    case $(x86_board_name) in > +    pc-engines-apu2) > +    status_led="apu2:green:power" > +    ;; > +    esac > +} Ick. Why hard-code that and have board-specific stuff in more