Re: I am going to start using PR's

2020-08-22 Thread Thomas Passin
What's weird is that I don't see any comment or commit for the changes that I found. Not in my repo or Leo's. Anyway, I reverted the changes and added a better way to accomplish the same thing. I have put in a pull request for this version. On Saturday, August 22, 2020 at 2:14:34 PM UTC-4,

Re: I am going to start using PR's

2020-08-22 Thread Thomas Passin
It looks like the changes to vr3 came via a change in the devel branch, and those must have come from leo-editor's devel branch. So it probably wasn't someone changing my repo directly. Still, there should have been some discussion somewhere first. On Saturday, August 22, 2020 at 1:31:00 PM U

Re: I am going to start using PR's

2020-08-22 Thread Thomas Passin
As long as we're on the subject, someone made some changes to viewrendered3 *in my github repo* that I didn't know about. There is a syntax error in these changes, and I *think* something else got inadvertently changed, and I will have to fix that up, too. Now if they had put in a PR, it would

Re: I am going to start using PR's

2020-08-22 Thread Offray Vladimir Luna Cárdenas
On 22/08/20 10:37 a. m., Offray Vladimir Luna Cárdenas wrote: > Git/GitHub and kind of formatting processes to the image of the Linux > Kernel development Git/GitHub *is* kind of formatting processes to the image of the Linux Kernel development -- You received this message because you are sub

Re: I am going to start using PR's

2020-08-22 Thread Offray Vladimir Luna Cárdenas
Hi, I have seen healthy discussion of features and commits in the Fossil Forum[1], without PR mechanism. I have seen a lot of discussion about features here with the engineering  notebooks withtout PR. Again not a prerequisite. But whatever works best for the community should be adopted. [1] http

Re: I am going to start using PR's

2020-08-22 Thread Thomas Passin
I submitted a PR for one module in rst2pdf. We had about three months of discussions - and I discovered I had to make a change to my code update - before everyone was satisfied and the PR was approved. You can read through the thread and see how much went into it before the PR ended p being a

Re: I am going to start using PR's

2020-08-22 Thread Edward K. Ream
On Fri, Aug 21, 2020 at 9:36 PM Thomas Passin wrote: > I'm not crazy about bureaucracy, but I have noticed that the PR can lead > to a lot of good discussion, and what gets added in the end may not be > exactly what was in the PR at the start. > Imo, "bureaucracy" is a misleading word. True, PR

Re: I am going to start using PR's

2020-08-21 Thread Thomas Passin
I'm not crazy about bureaucracy, but I have noticed that the PR can lead to a lot of good discussion, and what gets added in the end may not be exactly what was in the PR at the start. On Friday, August 21, 2020 at 8:55:30 PM UTC-4, Offray Vladimir Luna Cárdenas wrote: > > Lunzer, > > I may sh

Re: I am going to start using PR's

2020-08-21 Thread Offray Vladimir Luna Cárdenas
Lunzer, I may share the Fossil comments, as I'm an avid user of it. Paraphrasing Conway's Law[1] culture and infrastructure reflect each other and I think that Git reflect the bureaucracy of Linux Kernel development with its fork and PR by default, while Fossil considers a small group of developer

Re: I am going to start using PR's

2020-08-21 Thread Edward K. Ream
On Fri, Aug 21, 2020 at 3:01 PM lun...@gmail.com wrote: > @offay, I've seen similar comments on the Fossil forums. > > I don't have faith in developers to write "good commit messages". > Imo, commit messages usually only need to be a readable tag. There are exceptions, but they are few. Let's t

Re: I am going to start using PR's

2020-08-21 Thread lun...@gmail.com
@offay, I've seen similar comments on the Fossil forums. I don't have faith in developers to write "good commit messages". You need only see this comic to understand my feelings: https://xkcd.com/1296/ . Developers (in general) are lazy, and this is not entirely caused by "laziness", but these

Re: I am going to start using PR's

2020-08-21 Thread Offray Vladimir Luna Cárdenas
On 17/08/20 11:28 a. m., Edward K. Ream wrote: > The days of cowboy commits are coming to an end. > > In future, I plan to create a PR for all my work. A PR is a good > record of what has been done, and it should help prevent unwanted > merge conflicts. > > I think separate PR's for all work make

Re: I am going to start using PR's

2020-08-18 Thread Edward K. Ream
On Tue, Aug 18, 2020 at 7:17 AM lun...@gmail.com wrote: > More than anything else, they force a stronger self documenting style of > coding. That said PR history is github proprietary (if of course you're > using github for your PRs). It may be prudent to occasionally back up your > data: https:/

Re: I am going to start using PR's

2020-08-18 Thread lun...@gmail.com
More than anything else, they force a stronger self documenting style of coding. That said PR history is github proprietary (if of course you're using github for your PRs). It may be prudent to occasionally back up your data: https://github.blog/2018-12-19-download-your-data/ . On Monday, Augus

Re: I am going to start using PR's

2020-08-17 Thread Thomas Passin
I'd go for that. PRs, I have noticed on other projects, can support a good discussion before the thing is finalized. On Monday, August 17, 2020 at 12:28:58 PM UTC-4, Edward K. Ream wrote: > > The days of cowboy commits are coming to an end. > > In future, I plan to create a PR for all my work. A

I am going to start using PR's

2020-08-17 Thread Edward K. Ream
The days of cowboy commits are coming to an end. In future, I plan to create a PR for all my work. A PR is a good record of what has been done, and it should help prevent unwanted merge conflicts. I think separate PR's for all work makes sense for all of Leo's devs. What do you think? Edward