Re: Some smallish cleanups: one level of indirection is enough!

2014-09-09 Thread Edward K. Ream
On Tue, Sep 9, 2014 at 2:46 AM, Ville M. Vainio wrote: > Great to see where this is going :). Should help make the code approachable > by other people as well. Thanks. Iirc, you complained about the extra redirections years ago, but git made these massive changes safe enough to contemplate. I c

Re: Some smallish cleanups: one level of indirection is enough!

2014-09-09 Thread Edward K. Ream
On Mon, Sep 8, 2014 at 7:11 PM, EmanueL Czirai wrote: > Cool. Starts up. > I see some Qt4 related errors which are maybe harmless? Thanks for this report. The errors you report are from plugins. For example: from PyQt4 import QtCore, QtGui The recommended way to get qt-related modules is

Re: Some smallish cleanups: one level of indirection is enough!

2014-09-09 Thread Ville M. Vainio
Great to see where this is going :). Should help make the code approachable by other people as well. As they say, great design is more about removing things than adding more things. On Mon, Sep 8, 2014 at 10:49 PM, Edward K. Ream wrote: > I've just pushed a cleanup of Leo's qt tree code in qt_t

Re: Some smallish cleanups: one level of indirection is enough!

2014-09-08 Thread EmanueL Czirai
Figured out how to run tests. This is while python-pyqt4 is not installed: Ran 864 tests in 101.304s FAILED (failures=11) I know this isn't really useful but there's too much output to even know what to paste:) On Tue, Sep 9, 2014 at 2:11 AM, EmanueL Czirai wrote: > Cool. Starts up. > I see

Re: Some smallish cleanups: one level of indirection is enough!

2014-09-08 Thread EmanueL Czirai
Cool. Starts up. I see some Qt4 related errors which are maybe harmless? but mentioning them just in case you'll want to address -- $ ./launchLeo.py ** isPython3: True Leo 4.11 final, build 20140908184639, Mon Sep 8 18:46:39 CDT 2014 Git re

Re: Some smallish cleanups: one level of indirection is enough!

2014-09-08 Thread Edward K. Ream
On Mon, Sep 8, 2014 at 6:17 PM, Edward K. Ream wrote: >> Otoh, I'm not sure whether anyone is using Qt5 for Leo, despite the >> support in leoQt.py. I'll see whether I can get Leo working with Qt5 >> on ubuntu and report back. > > Happily, I got the same traceback you did. The problem is a Qt4/

Re: Some smallish cleanups: one level of indirection is enough!

2014-09-08 Thread Edward K. Ream
On Mon, Sep 8, 2014 at 5:58 PM, Edward K. Ream wrote: > Otoh, I'm not sure whether anyone is using Qt5 for Leo, despite the > support in leoQt.py. I'll see whether I can get Leo working with Qt5 > on ubuntu and report back. Happily, I got the same traceback you did. The problem is a Qt4/5 gotc

Re: Some smallish cleanups: one level of indirection is enough!

2014-09-08 Thread Edward K. Ream
On Mon, Sep 8, 2014 at 5:19 PM, EmanueL Czirai wrote: > I've been able to run only Leo 4.11 final, but never the git version yet. That makes sense ;-) > I've qt5 installed > extra/pyqt5-common 5.3.1-1 [installed] > extra/python-pyqt5 5.3.1-1 [installed] > extra/qt5-base 5.3.1-1 (qt qt5) [instal

Re: Some smallish cleanups: one level of indirection is enough!

2014-09-08 Thread EmanueL Czirai
I'm on linux manjaro(based on archlinux) Linux manji 3.17.0-rc4-gd030671 #83 SMP Mon Sep 8 15:35:58 CEST 2014 x86_64 GNU/Linux I've been able to run only Leo 4.11 final, but never the git version yet. I've qt5 installed extra/pyqt5-common 5.3.1-1 [installed] extra/python-pyqt5 5.3.1-1 [installed]

Re: Some smallish cleanups: one level of indirection is enough!

2014-09-08 Thread Edward K. Ream
On Mon, Sep 8, 2014 at 4:44 PM, EmanueL Czirai wrote: > if isinstance(widget,QtGui.QTextEdit): > AttributeError: 'module' object has no attribute 'QTextEdit' What platform are you on. Do you have Qt installed? Have you been able to run Leo before today? Edward -- You received this messa

Re: Some smallish cleanups: one level of indirection is enough!

2014-09-08 Thread EmanueL Czirai
On Mon, Sep 8, 2014 at 9:49 PM, Edward K. Ream wrote: > I've just pushed a cleanup of Leo's qt tree code in qt_tree.py. The new > code eliminates the the BaseNativeTreeWidget class and moves all the > functional code from the BaseNativeTreeWidget class to the LeoQtTree class, > eliminating code

Some smallish cleanups: one level of indirection is enough!

2014-09-08 Thread Edward K. Ream
I've just pushed a cleanup of Leo's qt tree code in qt_tree.py. The new code eliminates the the BaseNativeTreeWidget class and moves all the functional code from the BaseNativeTreeWidget class to the LeoQtTree class, eliminating code that existed only to be over-ridden. Sheesh. LeoQtTree is