Re: Bootscripts rewrite - writing/logging messages

2011-09-08 Thread Bruce Dubbs
Bruce Dubbs wrote: DJ Lucas wrote: On 09/05/2011 07:48 PM, Bruce Dubbs wrote: DJ Lucas wrote: Get rid of boot_mesg all together. I'm working on this. Attached is a reworked version of init-functions. I've added a few functions and variables to it. This includes support for headless sy

Re: Bootscripts rewrite - redefining variables

2011-09-06 Thread Bryan Kadzban
(Splitting this off as well.) DJ Lucas wrote: > On 09/05/2011 07:48 PM, Bruce Dubbs wrote: >> DJ Lucas wrote: >>> There is no reason to redefine 35+ values every time a new script >>> is run. Once per runlevel change in rc is sufficient. One >>> conditional around the source line in each script, o

Re: Bootscripts rewrite - writing/logging messages

2011-09-06 Thread Bruce Dubbs
Jeremy Huntwork wrote: > On Sep 6, 2011, at 1:42 PM, Bruce Dubbs wrote: >> Comments? > > Test and use the LSB scripts. There's no reason to duplicate all this > effort in the current scripts. I did. I just pointed out that echo in a script is not logged. The logging in general can be improved.

Re: Bootscripts rewrite - writing/logging messages

2011-09-06 Thread Jeremy Huntwork
On Sep 6, 2011, at 1:42 PM, Bruce Dubbs wrote: > Comments? Test and use the LSB scripts. There's no reason to duplicate all this effort in the current scripts. JH -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above informa

Re: Bootscripts rewrite - writing/logging messages

2011-09-06 Thread Bruce Dubbs
DJ Lucas wrote: > On 09/05/2011 07:48 PM, Bruce Dubbs wrote: >> DJ Lucas wrote: >>> Get rid of boot_mesg all together. This was left over from a mixed >>> results attempt at international messages and long display output >>> (and line wrapping). As James mentioned the other day, it has long >>> si

Re: Bootscripts rewrite

2011-09-05 Thread DJ Lucas
On 09/05/2011 07:48 PM, Bruce Dubbs wrote: > DJ Lucas wrote: > > LSB defined functions belong in /lib/lsb/init_functions so that > compliant >> bootscripts work as expected. Do not include the LSB definitions directly in >> the distro's functions file. Either source them in the distribution's >> f

Re: Bootscripts rewrite

2011-09-05 Thread Bruce Dubbs
DJ Lucas wrote: > Okay, so here is a more thorough review as promised (about 20 times before). > Again, this is based mostly on my own observations formed over the past few > years. As we all know, ego can be a bitch, ;-) and I do feel that my own > work was disregarded in many ways, so I'd like to

Bootscripts rewrite

2011-09-05 Thread DJ Lucas
Okay, so here is a more thorough review as promised (about 20 times before). Again, this is based mostly on my own observations formed over the past few years. As we all know, ego can be a bitch, ;-) and I do feel that my own work was disregarded in many ways, so I'd like to see input from everyone