On Wed, Sep 07, 2011 at 09:43:03PM +0200, Laurent Aimar wrote:
---
libavcodec/wavpack.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c
index 62f6880..0a70c4c 100644
--- a/libavcodec/wavpack.c
+++
On Wed, Sep 07, 2011 at 10:17:39PM +0200, Laurent Aimar wrote:
---
libavcodec/wavpack.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c
index 8e81d2d..f43819c 100644
--- a/libavcodec/wavpack.c
+++
On Wed, Sep 07, 2011 at 11:12:32PM +0200, Laurent Aimar wrote:
---
libavcodec/wavpack.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c
index f43819c..f6d30b0 100644
--- a/libavcodec/wavpack.c
+++ b/libavcodec/wavpack.c
On Wed, Sep 07, 2011 at 10:08:37PM +0200, Laurent Aimar wrote:
See patch.
Last two chunks (zeroing samples_left when end of data is reported) is fine,
first chunks are a bit suspicious since they hit corner cases. For example,
what happens if block ends with a run of zeroes? Probably some
On 9/7/11 7:34 PM, Anton Khirnov wrote:
Convoluted? -helptopic looks pretty straightforward to me
That part is fine is just show_help() being called that way that isn't
straightforward.
lu
___
libav-devel mailing list
libav-devel@libav.org
On 9/8/11 4:58 AM, Justin Ruggles wrote:
Ok.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
On Thu, Sep 08, 2011 at 09:09:14AM +0200, Kostya Shishkov wrote:
On Wed, Sep 07, 2011 at 09:43:03PM +0200, Laurent Aimar wrote:
---
libavcodec/wavpack.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c
index
On Thu, Sep 08, 2011 at 09:23:56AM +0200, Kostya Shishkov wrote:
On Wed, Sep 07, 2011 at 10:08:37PM +0200, Laurent Aimar wrote:
See patch.
Last two chunks (zeroing samples_left when end of data is reported) is fine,
first chunks are a bit suspicious since they hit corner cases. For example,
On Thu, Sep 08, 2011 at 09:57:04AM +0200, Laurent Aimar wrote:
On Thu, Sep 08, 2011 at 09:09:14AM +0200, Kostya Shishkov wrote:
On Wed, Sep 07, 2011 at 09:43:03PM +0200, Laurent Aimar wrote:
---
libavcodec/wavpack.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
On Thu, Sep 08, 2011 at 10:01:54AM +0200, Laurent Aimar wrote:
On Thu, Sep 08, 2011 at 09:23:56AM +0200, Kostya Shishkov wrote:
On Wed, Sep 07, 2011 at 10:08:37PM +0200, Laurent Aimar wrote:
See patch.
Last two chunks (zeroing samples_left when end of data is reported) is fine,
first
On Thu, 8 Sep 2011, Kostya Shishkov wrote:
On Thu, Sep 08, 2011 at 10:01:54AM +0200, Laurent Aimar wrote:
On Thu, Sep 08, 2011 at 09:23:56AM +0200, Kostya Shishkov wrote:
On Wed, Sep 07, 2011 at 10:08:37PM +0200, Laurent Aimar wrote:
See patch.
Last two chunks (zeroing samples_left when
On Thu, Sep 08, 2011 at 12:07:46PM +0300, Martin Storsjö wrote:
[...]
Pushed this one and the other two that you ok'd so far - only one
left pending ok?
Yes, seems so (with the number of decorrelation terms)
___
libav-devel mailing list
From: Aviad Rozenhek avia...@gmail.com
---
libavformat/mpegts.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index 9636274..6ac7cd3 100644
--- a/libavformat/mpegts.c
+++ b/libavformat/mpegts.c
@@ -1413,10 +1413,10 @@
From: Aviad Rozenhek avia...@gmail.com
---
libavformat/mpegts.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index fa5bd4c..9636274 100644
--- a/libavformat/mpegts.c
+++ b/libavformat/mpegts.c
@@ -1411,12 +1411,14 @@
From: Aviad Rozenhek avia...@gmail.com
---
libavformat/mpegts.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index 6ac7cd3..dac5903 100644
--- a/libavformat/mpegts.c
+++ b/libavformat/mpegts.c
@@ -1293,7 +1293,7 @@ static
On 9/8/11 11:58 AM, avia...@gmail.com wrote:
From: Aviad Rozenhekavia...@gmail.com
looks ok, I'd rework a little more the commit message.
basically on seek it resets all the pids not just those that contain
pes, isn'it
lu
___
libav-devel mailing
On 9/8/11 4:58 AM, Justin Ruggles wrote:
From: Michael Niedermayermichae...@gmx.at
What is the performance gain in hand unrolling this loop?
lu
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
On Thu, Sep 08, 2011 at 12:58:26PM +0300, avia...@gmail.com wrote:
--- a/libavformat/mpegts.c
+++ b/libavformat/mpegts.c
@@ -1413,10 +1413,10 @@ static int handle_packets(MpegTSContext *ts, int
nb_packets)
for (i = 0; i NB_PID_MAX; i++) {
if (ts-pids[i]) {
On 9/8/11 11:58 AM, avia...@gmail.com wrote:
From: Aviad Rozenhekavia...@gmail.com
---
libavformat/mpegts.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index 6ac7cd3..dac5903 100644
--- a/libavformat/mpegts.c
+++
On Thu, Sep 08, 2011 at 03:19:49PM +0300, aviad rozenhek wrote:
On Thu, Sep 8, 2011 at 14:49, Diego Biurrun di...@biurrun.de wrote:
On Thu, Sep 08, 2011 at 12:58:26PM +0300, avia...@gmail.com wrote:
--- a/libavformat/mpegts.c
+++ b/libavformat/mpegts.c
@@ -1413,10 +1413,10 @@
---
libavformat/avlanguage.c |3 ++-
libavformat/mxf.c|2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavformat/avlanguage.c b/libavformat/avlanguage.c
index 787382e..e606ef2 100644
--- a/libavformat/avlanguage.c
+++ b/libavformat/avlanguage.c
@@ -20,6
---
libavutil/fifo.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/libavutil/fifo.c b/libavutil/fifo.c
index 5774d33..75a0439 100644
--- a/libavutil/fifo.c
+++ b/libavutil/fifo.c
@@ -145,8 +145,7 @@ int main(void)
/* peek at FIFO */
n =
On Thu, Sep 08, 2011 at 02:29:01PM +0200, Diego Biurrun wrote:
---
libavformat/avlanguage.c |3 ++-
libavformat/mxf.c|2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavformat/avlanguage.c b/libavformat/avlanguage.c
index 787382e..e606ef2 100644
---
On date Thursday 2011-09-08 14:31:41 +0200, Diego Biurrun encoded:
---
libavutil/fifo.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/libavutil/fifo.c b/libavutil/fifo.c
index 5774d33..75a0439 100644
--- a/libavutil/fifo.c
+++ b/libavutil/fifo.c
@@ -145,8
On Thu, Sep 8, 2011 at 14:43, Luca Barbato lu_z...@gentoo.org wrote:
On 9/8/11 11:58 AM, avia...@gmail.com wrote:
From: Aviad Rozenhekavia...@gmail.com
looks ok, I'd rework a little more the commit message.
basically on seek it resets all the pids not just those that contain pes,
isn'it
---
libavformat/mpegts.c | 12 +++-
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index fa5bd4c..6ac7cd3 100644
--- a/libavformat/mpegts.c
+++ b/libavformat/mpegts.c
@@ -1411,12 +1411,14 @@ static int
On Thu, Sep 08, 2011 at 02:55:15PM +0200, Stefano Sabatini wrote:
On date Thursday 2011-09-08 14:31:41 +0200, Diego Biurrun encoded:
---
libavutil/fifo.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/libavutil/fifo.c b/libavutil/fifo.c
index
From: Reimar Döffinger reimar.doeffin...@gmx.de
Unfortunately the output buffer size check assumes that the
input buffer is never over-consumed, thus this actually
also allowed to write outside the output buffer if lucky.
Based on:
git.videolan.org/ffmpeg.git
commit
On 9/8/11 4:58 AM, Justin Ruggles wrote:
From: Peter Rosspr...@xvid.org
Signed-off-by: Michael Niedermayermichae...@gmx.at
---
libavcodec/adpcm.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c
index 10bda64..c81d1d2 100644
---
On 09/08/2011 07:46 AM, Luca Barbato wrote:
On 9/8/11 4:58 AM, Justin Ruggles wrote:
From: Michael Niedermayermichae...@gmx.at
What is the performance gain in hand unrolling this loop?
On Athlon64 it goes from 60 cycles to 54 cycles.
-Justin
___
Justin Ruggles justin.rugg...@gmail.com writes:
On 09/08/2011 07:46 AM, Luca Barbato wrote:
On 9/8/11 4:58 AM, Justin Ruggles wrote:
From: Michael Niedermayermichae...@gmx.at
What is the performance gain in hand unrolling this loop?
On Athlon64 it goes from 60 cycles to 54 cycles.
Which
I'm surprised nobody has bitten yet..
On Fri, Aug 26, 2011 at 08:33:02PM +0200, Reinhard Tartler wrote:
On Fri, Aug 26, 2011 at 19:01:51 (CEST), Kostya wrote:
On Fri, Aug 26, 2011 at 06:43:03PM +0200, Anton Khirnov wrote:
And on a totally unrelated note, let's mark libpostproc for
On 09/08/2011 11:49 AM, Måns Rullgård wrote:
Justin Ruggles justin.rugg...@gmail.com writes:
On 09/08/2011 07:46 AM, Luca Barbato wrote:
On 9/8/11 4:58 AM, Justin Ruggles wrote:
From: Michael Niedermayermichae...@gmx.at
What is the performance gain in hand unrolling this loop?
On
On Wed, Sep 7, 2011 at 2:46 PM, Laurent Aimar fen...@elivagar.org wrote:
On Wed, Sep 07, 2011 at 02:43:48PM -0700, Alex Converse wrote:
libavcodec/wavpack.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c
index
On Tue, Sep 06, 2011 at 09:49:16AM -0700, Ronald S. Bultje wrote:
On Tue, Sep 6, 2011 at 2:51 AM, Diego Biurrun di...@biurrun.de wrote:
--- a/libavcodec/mpeg12.c
+++ b/libavcodec/mpeg12.c
@@ -49,28 +49,20 @@
-static inline int mpeg1_decode_block_intra(MpegEncContext *s,
-
---
As a positive side-effect, this eliminates 80+ character lines that
received complaints during the mpeg12.c reformatting patch review.
libavcodec/mpeg12.c | 1053 +--
1 files changed, 521 insertions(+), 532 deletions(-)
diff --git
On 9/8/11 2:52 PM, Luca Barbato wrote:
On 9/8/11 11:58 AM, avia...@gmail.com wrote:
From: Aviad Rozenhekavia...@gmail.com
---
libavformat/mpegts.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index 6ac7cd3..dac5903 100644
---
---
libavcodec/wavpack.c | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c
index 53aab6d..0604452 100644
--- a/libavcodec/wavpack.c
+++ b/libavcodec/wavpack.c
@@ -1120,6 +1120,10 @@ static int
On Thu, Sep 08, 2011 at 10:24:40AM +0200, Kostya Shishkov wrote:
On Thu, Sep 08, 2011 at 09:57:04AM +0200, Laurent Aimar wrote:
On Thu, Sep 08, 2011 at 09:09:14AM +0200, Kostya Shishkov wrote:
On Wed, Sep 07, 2011 at 09:43:03PM +0200, Laurent Aimar wrote:
---
libavcodec/wavpack.c |
On Thu, 8 Sep 2011, Alex Converse wrote:
On Thu, Sep 8, 2011 at 2:01 AM, Laurent Aimar g...@libav.org wrote:
Module: libav
Branch: master
Commit: 0aedab03405849962b469277afe047aa2c61a87f
Author: Laurent Aimar fen...@videolan.org
Committer: Martin Storsjö mar...@martin.st
Date: Wed Sep
On Thu, Sep 08, 2011 at 09:58:33PM +0200, Laurent Aimar wrote:
Hi,
On Thu, Sep 08, 2011 at 09:54:50PM +0200, Kostya Shishkov wrote:
It's initialised here and on error it would use random (last correct)
value
for it. Not that it really matters since decoding won't start anyway
On Thu, Sep 08, 2011 at 10:05:40PM +0200, Kostya Shishkov wrote:
On Thu, Sep 08, 2011 at 09:58:33PM +0200, Laurent Aimar wrote:
Hi,
On Thu, Sep 08, 2011 at 09:54:50PM +0200, Kostya Shishkov wrote:
It's initialised here and on error it would use random (last correct)
value
On Thu, Sep 08, 2011 at 10:11:17PM +0200, Laurent Aimar wrote:
On Thu, Sep 08, 2011 at 10:05:40PM +0200, Kostya Shishkov wrote:
On Thu, Sep 08, 2011 at 09:58:33PM +0200, Laurent Aimar wrote:
Hi,
On Thu, Sep 08, 2011 at 09:54:50PM +0200, Kostya Shishkov wrote:
It's initialised
Based on a patch from The Chromium Projects.
---
libavcodec/get_bits.h | 44 +---
1 files changed, 41 insertions(+), 3 deletions(-)
diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h
index d2ae345..d910686 100644
--- a/libavcodec/get_bits.h
+++
On Thu, Sep 8, 2011 at 3:18 PM, Alex Converse alex.conve...@gmail.com wrote:
Based on a patch from The Chromium Projects.
---
libavcodec/get_bits.h | 44 +---
1 files changed, 41 insertions(+), 3 deletions(-)
Here is the original:
---
libavformat/matroskadec.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
index 0379977..01c9a7b 100644
--- a/libavformat/matroskadec.c
+++ b/libavformat/matroskadec.c
@@ -1148,7 +1148,7 @@ static int
Hi,
After trying some fuzzing on libavcodec, it seems that a lot of decoders
does not check (or not enough) for buffer overread which can lead for some
to a segfault.
I attached a patch that make get_bits.h function checked for overread by
default but let safe decoders disabling the checks at
Hi,
On Thu, Sep 8, 2011 at 4:05 PM, Laurent Aimar fen...@elivagar.org wrote:
I attached a patch that make get_bits.h function checked for overread by
default but let safe decoders disabling the checks at compilation time by
defining UNCHECK_BITSTREAM_READER before including get_bits.h.
If
On Thu, Sep 08, 2011 at 04:12:53PM -0700, Ronald S. Bultje wrote:
+#ifndef UNCHECK_BITSTREAM_READER
+# warn Checked bistream reader unimplemented
+#endif
biTstream.
Locally fixed, thanks.
--
fenrir
___
libav-devel mailing list
Hi,
On Fri, Sep 09, 2011 at 01:57:38AM +0200, Michael Niedermayer wrote:
One decoder breaks with this patch: mpegaudio. It seems to do weird things
with two get bit context and switching them while decoding. I will try to
have a look at it (unless someone would volunteer to explain me what
On Thu, Sep 8, 2011 at 4:05 PM, Laurent Aimar fen...@elivagar.org wrote:
@@ -172,10 +184,18 @@ static inline int get_bits_count(const GetBitContext
*s){
static inline void skip_bits_long(GetBitContext *s, int n){
s-index += n;
+#ifndef UNCHECK_BITSTREAM_READER
+if (s-index
On Thu, Sep 8, 2011 at 4:05 PM, Laurent Aimar fen...@elivagar.org wrote:
Hi,
After trying some fuzzing on libavcodec, it seems that a lot of decoders
does not check (or not enough) for buffer overread which can lead for some
to a segfault.
I attached a patch that make get_bits.h function
Hi,
On Thu, Sep 8, 2011 at 6:06 PM, Alex Converse alex.conve...@gmail.com wrote:
This is a very expensive form of error resilience and there are a lot
of use cases where people just don't care. They will tolerate the SEGV
on the occasional bad file if it means they can decode a good with
53 matches
Mail list logo
