[libav-devel] [PATCH] xl: Fix Over Reads

2011-12-18 Thread Aneesh Dogra
--- libavcodec/xl.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/libavcodec/xl.c b/libavcodec/xl.c index 197b0c2..9a6ea19 100644 --- a/libavcodec/xl.c +++ b/libavcodec/xl.c @@ -68,6 +68,12 @@ static int decode_frame(AVCodecContext *avctx, V = a->pic.data[2];

Re: [libav-devel] [PATCH 1/2] Revert "h264: skip start code search if the size of the nal unit is known"

2011-12-18 Thread Ronald S. Bultje
Hi, On Sun, Dec 18, 2011 at 5:41 PM, Janne Grunau wrote: > On 2011-12-18 18:20:31 -0800, Ronald S. Bultje wrote: > > On Sun, Dec 18, 2011 at 6:03 PM, Janne Grunau >wrote: > > > > > This reverts commit 87eebb3454ff0cd6af6ebf9e1d31bdfd1c3b601b. > > > --- > > > libavcodec/h264.c| 11 ++--

Re: [libav-devel] [PATCH 1/2] Revert "h264: skip start code search if the size of the nal unit is known"

2011-12-18 Thread Janne Grunau
On 2011-12-18 18:20:31 -0800, Ronald S. Bultje wrote: > Hi, > > On Sun, Dec 18, 2011 at 6:03 PM, Janne Grunau wrote: > > > This reverts commit 87eebb3454ff0cd6af6ebf9e1d31bdfd1c3b601b. > > --- > > libavcodec/h264.c| 11 ++- > > libavcodec/h264.h|5 + > > libavco

Re: [libav-devel] [PATCH 2/2] H264: fix slice end error detection

2011-12-18 Thread Ronald S. Bultje
Hi, On Sun, Dec 18, 2011 at 6:03 PM, Janne Grunau wrote: > From: Michael Niedermayer > > Signed-off-by: Janne Grunau > --- > libavcodec/h264.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/h264.c b/libavcodec/h264.c > index 77acd71..6b95456 100644

Re: [libav-devel] [PATCH 1/2] Revert "h264: skip start code search if the size of the nal unit is known"

2011-12-18 Thread Ronald S. Bultje
Hi, On Sun, Dec 18, 2011 at 6:03 PM, Janne Grunau wrote: > This reverts commit 87eebb3454ff0cd6af6ebf9e1d31bdfd1c3b601b. > --- > libavcodec/h264.c| 11 ++- > libavcodec/h264.h|5 + > libavcodec/h264_parser.c |2 +- > 3 files changed, 4 insertions(+), 14 dele

[libav-devel] [PATCH 1/2] Revert "h264: skip start code search if the size of the nal unit is known"

2011-12-18 Thread Janne Grunau
This reverts commit 87eebb3454ff0cd6af6ebf9e1d31bdfd1c3b601b. --- libavcodec/h264.c| 11 ++- libavcodec/h264.h|5 + libavcodec/h264_parser.c |2 +- 3 files changed, 4 insertions(+), 14 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 5d4c

[libav-devel] [PATCH 2/2] H264: fix slice end error detection

2011-12-18 Thread Janne Grunau
From: Michael Niedermayer Signed-off-by: Janne Grunau --- libavcodec/h264.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 77acd71..6b95456 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@ -3662,7 +3662,9 @@ stati

Re: [libav-devel] [PATCH 2/2] x86: conditionally compile 10-bit H.264 QPEL optimizations

2011-12-18 Thread Diego Biurrun
On Mon, Dec 19, 2011 at 12:52:47AM +, Måns Rullgård wrote: > Diego Biurrun writes: > > > > --- a/configure > > +++ b/configure > > @@ -939,6 +939,7 @@ CONFIG_LIST=" > > h264dsp > > h264pred > > +h264qpel > > hardcoded_tables > > @@ -1301,7 +1302,7 @@ h263_encoder_select="aan

Re: [libav-devel] [GCI][PATCH] Code cosmetics & re-indention of qcelpdec.c

2011-12-18 Thread Diego Biurrun
On Mon, Dec 19, 2011 at 01:32:54AM +0200, Asen Lekov wrote: > Fixed! Queued with some additional fixes, will push tomorrow. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/2] x86: conditionally compile 10-bit H.264 QPEL optimizations

2011-12-18 Thread Ronald S. Bultje
Hi, 2011/12/18 Måns Rullgård > Diego Biurrun writes: > > > --- > > configure | 15 --- > > libavcodec/x86/Makefile |2 +- > > 2 files changed, 9 insertions(+), 8 deletions(-) > > > > diff --git a/configure b/configure > > index 22542af..1ba505c 100755 > > --- a/

Re: [libav-devel] [PATCH 2/2] x86: conditionally compile 10-bit H.264 QPEL optimizations

2011-12-18 Thread Måns Rullgård
Diego Biurrun writes: > --- > configure | 15 --- > libavcodec/x86/Makefile |2 +- > 2 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/configure b/configure > index 22542af..1ba505c 100755 > --- a/configure > +++ b/configure > @@ -939,6 +939,7 @@ C

Re: [libav-devel] [PATCH 1/2] x86: conditionally compile dnxhd encoder optimizations

2011-12-18 Thread Måns Rullgård
Diego Biurrun writes: > --- > libavcodec/x86/Makefile |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile > index 6759a22..aa97942 100644 > --- a/libavcodec/x86/Makefile > +++ b/libavcodec/x86/Makefile > @@ -31,6 +31,

[libav-devel] [PATCH 3/4] avcodec: Add avcodec_encode_audio2() as replacement for avcodec_encode_audio()

2011-12-18 Thread Justin Ruggles
This allows audio encoders to optionally take an AVFrame as input and write encoded output to an AVPacket. This also adds AVCodec.encode2() which will also be usable by video and subtitle encoders once support is implemented in the public functions. --- libavcodec/avcodec.h | 47 ++

[libav-devel] [PATCH 4/4] avcodec: bump minor version and add APIChanges for the new audio encoding API

2011-12-18 Thread Justin Ruggles
--- doc/APIchanges |8 libavcodec/version.h |2 +- 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 49c49d8..44699fc 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -13,6 +13,14 @@ libavutil: 2011-04-18 API changes

[libav-devel] [PATCH 2/4] avcodec: add a public function, avcodec_fill_audio_frame().

2011-12-18 Thread Justin Ruggles
This is a convenience function for the user to fill audio AVFrame information. --- libavcodec/avcodec.h | 20 +++ libavcodec/utils.c | 94 +- 2 files changed, 75 insertions(+), 39 deletions(-) diff --git a/libavcodec/avcodec.h b/libavc

[libav-devel] [PATCH 1/4] avcodec: Add CODEC_CAP_VARIABLE_FRAME_SIZE capability.

2011-12-18 Thread Justin Ruggles
This does not change any current behavior, but it does more clearly define it. --- libavcodec/avcodec.h | 16 +++- libavcodec/g722enc.c |1 + libavcodec/pcm.c |1 + 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h

[libav-devel] [PATCH 0/4] avcodec_encode_audio2

2011-12-18 Thread Justin Ruggles
Here is my first attempt at a new audio encoding API. I haven't included an implementation in any encoders yet, and the existing encoders have not all been thoroughly tested (although FATE does pass). I just want to get reactions and/or suggestions for moving forward. Thanks, Justin Justin Rugg

Re: [libav-devel] Patch error_resilience:cosmetics

2011-12-18 Thread Diego Biurrun
On Sat, Dec 17, 2011 at 10:12:00PM +0200, доналд овчаров wrote: > Fixed. Please stop top-posting and use a mailer that does not break threads. > --- a/libavcodec/error_resilience.c > +++ b/libavcodec/error_resilience.c > @@ -40,26 +40,36 @@ > > +static void decode_mb(MpegEncContext *s, int ref

[libav-devel] [PATCH 1/2] x86: conditionally compile dnxhd encoder optimizations

2011-12-18 Thread Diego Biurrun
--- libavcodec/x86/Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile index 6759a22..aa97942 100644 --- a/libavcodec/x86/Makefile +++ b/libavcodec/x86/Makefile @@ -31,6 +31,7 @@ YASM-OBJS-$(CONFIG_VC1_DECODER)

[libav-devel] [PATCH 2/2] x86: conditionally compile 10-bit H.264 QPEL optimizations

2011-12-18 Thread Diego Biurrun
--- configure | 15 --- libavcodec/x86/Makefile |2 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/configure b/configure index 22542af..1ba505c 100755 --- a/configure +++ b/configure @@ -939,6 +939,7 @@ CONFIG_LIST=" h264chroma h264dsp

Re: [libav-devel] [GCI][PATCH] Code cosmetics & re-indention of qcelpdec.c

2011-12-18 Thread Asen Lekov
Fixed! From a93302e4531b3cf9f2e2390715d0056b0ff2da7e Mon Sep 17 00:00:00 2001 From: Asen Lekov Date: Sun, 18 Dec 2011 01:12:47 +0200 Subject: [PATCH] Cosmetics & code re-indentation --- libavcodec/qcelpdec.c | 350 - 1 files changed, 173 insertion

Re: [libav-devel] [GCI][PATCH] Code cosmetics & re-indention of qcelpdec.c

2011-12-18 Thread Ronald S. Bultje
Hi, On Sat, Dec 17, 2011 at 4:01 PM, Asen Lekov wrote: > Fixed some re-indentation misstakes! > [..] > @@ -129,12 +129,12 @@ static int decode_lspf(QCELPContext *q, float *lspf) [..] > -for (i=0; i<10; i++) { > +for (i = 0; i < 10; i++) { > q->predictor_l

Re: [libav-devel] [PATCH 2/2] h264: correct start code prefix detection in ff_h264_decode_nal()

2011-12-18 Thread Janne Grunau
On 2011-12-18 14:50:08 -0800, Ronald S. Bultje wrote: > Hi, > > On Sun, Dec 18, 2011 at 1:56 PM, Janne Grunau wrote: > > > --- > > libavcodec/h264.c | 10 ++ > > 1 files changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/libavcodec/h264.c b/libavcodec/h264.c > > index 5d4ce9

Re: [libav-devel] [PATCH] cljr: Check if width or height are positive integers

2011-12-18 Thread Paul B Mahol
On 12/18/11, Janne Grunau wrote: > On 2011-12-16 04:50:21 +0530, Shitiz Garg wrote: >> width and height might get passed as 0 and would cause floating point >> exceptions in decode_frame. >> Fixes bugzilla #149 >> --- >> libavcodec/cljr.c |5 + >> 1 files changed, 5 insertions(+), 0 delet

Re: [libav-devel] [PATCH] cljr: Check if width or height are positive integers

2011-12-18 Thread Ronald S. Bultje
Hi, On Sun, Dec 18, 2011 at 1:56 PM, Janne Grunau wrote: > On 2011-12-18 14:52:13 -0800, Ronald S. Bultje wrote: > > On Sun, Dec 18, 2011 at 1:48 PM, Janne Grunau >wrote: > > > On 2011-12-16 04:50:21 +0530, Shitiz Garg wrote: > > > > width and height might get passed as 0 and would cause floatin

Re: [libav-devel] [PATCH] cljr: Check if width or height are positive integers

2011-12-18 Thread Janne Grunau
On 2011-12-18 14:52:13 -0800, Ronald S. Bultje wrote: > Hi, > > On Sun, Dec 18, 2011 at 1:48 PM, Janne Grunau wrote: > > > On 2011-12-16 04:50:21 +0530, Shitiz Garg wrote: > > > width and height might get passed as 0 and would cause floating point > > > exceptions in decode_frame. > > > Fixes bug

Re: [libav-devel] [PATCH] cljr: Check if width or height are positive integers

2011-12-18 Thread Ronald S. Bultje
Hi, On Sun, Dec 18, 2011 at 1:48 PM, Janne Grunau wrote: > On 2011-12-16 04:50:21 +0530, Shitiz Garg wrote: > > width and height might get passed as 0 and would cause floating point > > exceptions in decode_frame. > > Fixes bugzilla #149 > > --- > > libavcodec/cljr.c |5 + > > 1 files ch

Re: [libav-devel] [PATCH 2/2] h264: correct start code prefix detection in ff_h264_decode_nal()

2011-12-18 Thread Ronald S. Bultje
Hi, On Sun, Dec 18, 2011 at 1:56 PM, Janne Grunau wrote: > --- > libavcodec/h264.c | 10 ++ > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/h264.c b/libavcodec/h264.c > index 5d4ce90..0da8ae4 100644 > --- a/libavcodec/h264.c > +++ b/libavcodec/h264.c > @@

Re: [libav-devel] [PATCH 1/2] h264: skip start code search if the size of the nal unit is known

2011-12-18 Thread Ronald S. Bultje
Hi, On Sun, Dec 18, 2011 at 1:56 PM, Janne Grunau wrote: > Start code emulation prevention is only required in Annex B bytestream > packed NAL units. For other coding formats the size is already known. > Looking for a start code prefix can result in false positives like in > http://streams.videol

Re: [libav-devel] [PATCH] cljr: Check if width or height are positive integers

2011-12-18 Thread Janne Grunau
On 2011-12-16 04:50:21 +0530, Shitiz Garg wrote: > width and height might get passed as 0 and would cause floating point > exceptions in decode_frame. > Fixes bugzilla #149 > --- > libavcodec/cljr.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/libavcodec/cljr.

Re: [libav-devel] Patch error_resilience:cosmetics

2011-12-18 Thread Ronald S. Bultje
Hi, On Sat, Dec 17, 2011 at 12:52 PM, Luca Barbato wrote: > I'd say we could consider it a sheer improvement and commit it. > > The probably another pass to fix small issue might be needed but this > patch already is huge. > Let's give it a few rounds of review - we do that for all such patches

Re: [libav-devel] [PATCH] cljr: fix buf_size sanity check

2011-12-18 Thread Janne Grunau
On 2011-12-17 18:58:06 +, Paul B Mahol wrote: > --- > libavcodec/cljr.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/cljr.c b/libavcodec/cljr.c > index a5ee738..999c2d8 100644 > --- a/libavcodec/cljr.c > +++ b/libavcodec/cljr.c > @@ -57,7 +57,7 @@

Re: [libav-devel] [PATCH] 0001-cleaned-up-swscale_unscaled.c.patch

2011-12-18 Thread Ronald S. Bultje
Hi, On Sun, Dec 18, 2011 at 1:52 PM, Nathan Maxson wrote: > [..] > -#define BY ( (int)(0.114*219/255*(1< -#define BV (-(int)(0.081*224/255*(1< -#define BU ( (int)(0.500*224/255*(1< -#define GY ( (int)(0.587*219/255*(1< -#define GV (-(int)(0.419*224/255*(1< -#define GU (-(int)(0.331*224/255*(1< -

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Janne Grunau
On 2011-12-18 20:49:53 +, Mans Rullgard wrote: > This was intended as an optimisation for skipped blocks in MPEG2 > P-frames and never used elsewhere. Removing this "optimisation" > speeds up MPEG2 decoding by 1-2% (ARM Cortex-A9). > > Signed-off-by: Mans Rullgard > --- > avplay.c

[libav-devel] [PATCH 2/2] h264: correct start code prefix detection in ff_h264_decode_nal()

2011-12-18 Thread Janne Grunau
--- libavcodec/h264.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 5d4ce90..0da8ae4 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@ -173,11 +173,13 @@ const uint8_t *ff_h264_decode_nal(H264Context *h, const

[libav-devel] [PATCH 1/2] h264: skip start code search if the size of the nal unit is known

2011-12-18 Thread Janne Grunau
Start code emulation prevention is only required in Annex B bytestream packed NAL units. For other coding formats the size is already known. Looking for a start code prefix can result in false positives like in http://streams.videolan.org/streams/mp4/Mr_MrsSmith-h264_aac.mp4 which has a false posit

Re: [libav-devel] [PATCH] mtv: Make sure audio_subsegments is not 0

2011-12-18 Thread Justin Ruggles
On 12/15/2011 02:06 PM, Shitiz Garg wrote: > audio_subsegments would be 0 and cause floating point exceptions > Fixes bugzilla #144 > --- > libavformat/mtv.c |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/libavformat/mtv.c b/libavformat/mtv.c > index c3fb15c..

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Uoti Urpala
On Sun, 2011-12-18 at 19:22 +, Måns Rullgård wrote: > The next release will have the field marked deprecated, and the one > after that will remove it. That's how we roll. BTW doesn't the version check in the patch fail to match this? If you follow this policy, the next release will probably r

[libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Mans Rullgard
This was intended as an optimisation for skipped blocks in MPEG2 P-frames and never used elsewhere. Removing this "optimisation" speeds up MPEG2 decoding by 1-2% (ARM Cortex-A9). Signed-off-by: Mans Rullgard --- avplay.c |1 - doc/APIchanges |3 +++ libavcodec/avco

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Måns Rullgård
Anton Khirnov writes: >> if(buf->base[0]){ >> -pic->age= *picture_number - buf->last_pic_num; >> buf->last_pic_num= *picture_number; > > Unless I'm missing something, last_pic_num is now unused. You're not missing anything. Thanks for spotting this. -- Måns Rullgård m...

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Uoti Urpala
On Sun, 2011-12-18 at 19:42 +0100, Janne Grunau wrote: > On 2011-12-18 21:37:37 +0200, Uoti Urpala wrote: > > On Sun, 2011-12-18 at 19:22 +, Måns Rullgård wrote: > > > > > The next release will have the field marked deprecated, and the one > > > after that will remove it. That's how we roll.

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Anton Khirnov
On Sun, 18 Dec 2011 17:20:22 +, Mans Rullgard wrote: > This was intended as an optimisation for skipped blocks in MPEG2 > P-frames and never used elsewhere. Removing this "optimisation" > speeds up MPEG2 decoding by 1-2% (ARM Cortex-A9). > > Signed-off-by: Mans Rullgard > --- > avplay.c

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Anton Khirnov
On Sun, 18 Dec 2011 21:10:43 +0200, Uoti Urpala wrote: > On Sun, 2011-12-18 at 19:29 +0100, Anton Khirnov wrote: > > On Sun, 18 Dec 2011 19:53:00 +0200, Uoti Urpala > > wrote: > > > On Sun, 2011-12-18 at 17:20 +, Mans Rullgard wrote: > > > > -int age; > > > > +attribute_deprecated i

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Janne Grunau
On 2011-12-18 21:37:37 +0200, Uoti Urpala wrote: > On Sun, 2011-12-18 at 19:22 +, Måns Rullgård wrote: > > > The next release will have the field marked deprecated, and the one > > after that will remove it. That's how we roll. > > I have no objection to that. But it doesn't require you to s

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Uoti Urpala
On Sun, 2011-12-18 at 19:22 +, Måns Rullgård wrote: > Uoti Urpala writes: > > Unconditional attribute_deprecated can be used once it's appropriate > > to expect the users to actually remove use of the deprecated symbol > > when they see the warning. > > I fully expect any user tracking git to

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Luca Barbato
On 18/12/11 20:10, Uoti Urpala wrote: Adding an entry to APIchanges is a more appropriate way to communicate this (this was missing from Måns's patch). Unconditional attribute_deprecated can be used once it's appropriate to expect the users to actually remove use of the deprecated symbol when the

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Uoti Urpala
On Sun, 2011-12-18 at 19:05 +, Måns Rullgård wrote: > Uoti Urpala writes: > > > Yes. It should not produce a forced warning now. Having a separate > > method to request warnings for everything that is scheduled to be > > changed in the (possibly distant) future would be more appropriate. > >

[libav-devel] [PATCH] 4xm: Fixes Invalid Reads

2011-12-18 Thread Aneesh Dogra
Add checks for over reading in the Bytestream API. --- libavcodec/4xm.c| 20 ++-- libavcodec/bytestream.h | 34 +- 2 files changed, 39 insertions(+), 15 deletions(-) diff --git a/libavcodec/4xm.c b/libavcodec/4xm.c index 21bde52..c2ff45c

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Måns Rullgård
Uoti Urpala writes: > On Sun, 2011-12-18 at 19:29 +0100, Anton Khirnov wrote: >> On Sun, 18 Dec 2011 19:53:00 +0200, Uoti Urpala >> wrote: >> > On Sun, 2011-12-18 at 17:20 +, Mans Rullgard wrote: >> > > -int age; >> > > +attribute_deprecated int age; >> > >> > IMO setting attribute

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Uoti Urpala
On Sun, 2011-12-18 at 19:29 +0100, Anton Khirnov wrote: > On Sun, 18 Dec 2011 19:53:00 +0200, Uoti Urpala > wrote: > > On Sun, 2011-12-18 at 17:20 +, Mans Rullgard wrote: > > > -int age; > > > +attribute_deprecated int age; > > > > IMO setting attribute_deprecated immediately is a ba

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Måns Rullgård
Uoti Urpala writes: > Yes. It should not produce a forced warning now. Having a separate > method to request warnings for everything that is scheduled to be > changed in the (possibly distant) future would be more appropriate. That method already exists. Simply turn deprecation warnings on/off

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Uoti Urpala
On Sun, 2011-12-18 at 19:19 +0100, Luca Barbato wrote: > On 18/12/11 18:53, Uoti Urpala wrote: > > On Sun, 2011-12-18 at 17:20 +, Mans Rullgard wrote: > >> -int age; > >> +attribute_deprecated int age; > > > > IMO setting attribute_deprecated immediately is a bad idea. > > Why? For re

Re: [libav-devel] [PATCH] xl: Fix Over Reads

2011-12-18 Thread Mashiat Sarker Shakkhar
- Original Message - > From: Aneesh Dogra > To: libav-devel@libav.org > Cc: Aneesh Dogra > Sent: Sunday, December 18, 2011 7:54 AM > Subject: [libav-devel] [PATCH] xl: Fix Over Reads > > While reading a fuzzed bitsream , the decoder can read past the end of the > bitstream causing inval

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Anton Khirnov
On Sun, 18 Dec 2011 19:53:00 +0200, Uoti Urpala wrote: > On Sun, 2011-12-18 at 17:20 +, Mans Rullgard wrote: > > -int age; > > +attribute_deprecated int age; > > IMO setting attribute_deprecated immediately is a bad idea. Unless you > want your application to break when used with lib

Re: [libav-devel] [PATCH] 4xm: remove unneeded check for remaining unused data.

2011-12-18 Thread Måns Rullgård
Justin Ruggles writes: > This is unnecessary complication that only prints a message and does not > affect decoding. > --- > libavcodec/4xm.c |9 - > 1 files changed, 0 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/4xm.c b/libavcodec/4xm.c > index 21bde52..0ae10d5 100644

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Luca Barbato
On 18/12/11 18:53, Uoti Urpala wrote: On Sun, 2011-12-18 at 17:20 +, Mans Rullgard wrote: -int age; +attribute_deprecated int age; IMO setting attribute_deprecated immediately is a bad idea. Why? Unless you want your application to break when used with libavcodec compiled yeste

[libav-devel] [PATCH] 4xm: remove unneeded check for remaining unused data.

2011-12-18 Thread Justin Ruggles
This is unnecessary complication that only prints a message and does not affect decoding. --- libavcodec/4xm.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/libavcodec/4xm.c b/libavcodec/4xm.c index 21bde52..0ae10d5 100644 --- a/libavcodec/4xm.c +++ b/libavcodec/

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Uoti Urpala
On Sun, 2011-12-18 at 17:20 +, Mans Rullgard wrote: > -int age; > +attribute_deprecated int age; IMO setting attribute_deprecated immediately is a bad idea. Unless you want your application to break when used with libavcodec compiled yesterday you can't remove mentions of the field imm

Re: [libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Anton Khirnov
On Sun, 18 Dec 2011 17:20:22 +, Mans Rullgard wrote: > This was intended as an optimisation for skipped blocks in MPEG2 > P-frames and never used elsewhere. Removing this "optimisation" > speeds up MPEG2 decoding by 1-2% (ARM Cortex-A9). > Awesome patch. LGTM. -- Anton Khirnov _

[libav-devel] [PATCH] avcodec: deprecate AVFrame.age

2011-12-18 Thread Mans Rullgard
This was intended as an optimisation for skipped blocks in MPEG2 P-frames and never used elsewhere. Removing this "optimisation" speeds up MPEG2 decoding by 1-2% (ARM Cortex-A9). Signed-off-by: Mans Rullgard --- avplay.c |1 - libavcodec/avcodec.h |9 - libavcode

Re: [libav-devel] [PATCH] segment: introduce segmented chain muxer

2011-12-18 Thread Luca Barbato
On 18/12/11 16:10, Anton Khirnov wrote: +avio_close(oc->pb); +if (oc->oformat->priv_class) +av_opt_free(oc->priv_data); The indentation is off. The rest looks good. Fixing it and pushing then =) -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero _

Re: [libav-devel] [PATCH] segment: introduce segmented chain muxer

2011-12-18 Thread Anton Khirnov
On Tue, 13 Dec 2011 16:09:33 +0100, Luca Barbato wrote: > It behaves similarly to image2 muxer > --- > Changelog|1 + > doc/muxers.texi | 32 ++ > libavformat/Makefile |1 + > libavformat/allformats.c |1 + > libavformat/segment.c| 273 > +

Re: [libav-devel] [PATCH] fix tmv decoder pix_fmt

2011-12-18 Thread Ronald S. Bultje
Hi, On Sun, Dec 18, 2011 at 6:34 AM, Uoti Urpala wrote: > [..] Pushed, thanks. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] fix tmv decoder pix_fmt

2011-12-18 Thread Uoti Urpala
>From ab12550fb90253175a33770802885203fafd8435 Mon Sep 17 00:00:00 2001 From: Uoti Urpala Date: Sun, 18 Dec 2011 16:17:07 +0200 Subject: [PATCH] tmv decoder: set correct pix_fmt Previously the decoder only worked if the user had set avctx->pix_fmt manually. For some reason the libavformat tmv de