Re: [libav-devel] MXF changes from FFmpeg

2011-12-22 Thread Tomas Härdin
On Wed, 2011-12-21 at 17:56 +0100, Janne Grunau wrote: On 2011-12-21 15:47:24 +0100, Tomas Härdin wrote: On Wed, 2011-12-21 at 15:28 +0100, Luca Barbato wrote: On 21/12/11 14:58, Tomas Härdin wrote: I hope you made sure the code still work fine on 32-bit systems, especially when

Re: [libav-devel] [PATCH 01/19] mxfdec: Parse MXF partitions.

2011-12-22 Thread Tomas Härdin
On Wed, 2011-12-21 at 19:45 +0100, Janne Grunau wrote: From: Tomas Härdin tomas.har...@codemill.se --- libavformat/mxfdec.c | 108 +- 1 files changed, 107 insertions(+), 1 deletions(-) diff --git a/libavformat/mxfdec.c

[libav-devel] [PATCH 3/8] lavc: add width and height fields to AVFrame

2011-12-22 Thread Anton Khirnov
From: Stefano Sabatini stefano.sabatini-l...@poste.it width and height are per-frame properties, setting these values in AVFrame simplify the operation of extraction of that information, since avoids the need to check the codec/stream context. --- libavcodec/avcodec.h |7 +++

[libav-devel] [PATCH 1/8] lavfi: always build vsrc_buffer.

2011-12-22 Thread Anton Khirnov
It's a part of public API. --- configure|2 -- libavfilter/Makefile |2 +- 2 files changed, 1 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 1c7fb3b..8e2e08b 100755 --- a/configure +++ b/configure @@ -1525,14 +1525,12 @@ postproc_deps=gpl # programs

[libav-devel] [PATCH 5/8] lavfi: add avfilter_copy_frame_props()

2011-12-22 Thread Anton Khirnov
From: Stefano Sabatini stefano.sabatini-l...@poste.it avfilter_copy_frame_props() avoids code duplication and increases robustness. --- avplay.c |4 ++-- libavfilter/avfilter.c| 19 +++ libavfilter/avfilter.h|9 +

[libav-devel] [PATCH 7/8] avconv: implement get_buffer()/release_buffer().

2011-12-22 Thread Anton Khirnov
This will allow memcpy-free passing frames to lavfi. --- avconv.c | 137 ++ 1 files changed, 137 insertions(+), 0 deletions(-) diff --git a/avconv.c b/avconv.c index dfef98f..b47c91f 100644 --- a/avconv.c +++ b/avconv.c @@ -44,6 +44,7

[libav-devel] [PATCH 8/8] avconv: avoid memcpy in vsrc_buffer when possible.

2011-12-22 Thread Anton Khirnov
Decoding Sintel.2010.1080p.mkv with 4 threads on an i7 2600K goes from 260s to 244s. --- avconv.c | 55 --- 1 files changed, 40 insertions(+), 15 deletions(-) diff --git a/avconv.c b/avconv.c index b47c91f..c4cf32f 100644 --- a/avconv.c +++

[libav-devel] [PATCH 6/8] lavfi: add a new function av_buffersrc_buffer().

2011-12-22 Thread Anton Khirnov
It can be used to directly pass a AVFilterBufferRef to lavfi, avoiding a memcpy. --- libavfilter/Makefile |2 +- libavfilter/buffersrc.h | 38 ++ libavfilter/vsrc_buffer.c | 66 ++-- 3 files changed, 72 insertions(+),

Re: [libav-devel] [PATCH 1/8] lavfi: always build vsrc_buffer.

2011-12-22 Thread Janne Grunau
On 2011-12-22 11:01:11 +0100, Anton Khirnov wrote: It's a part of public API. --- configure|2 -- libavfilter/Makefile |2 +- 2 files changed, 1 insertions(+), 3 deletions(-) ok Janne ___ libav-devel mailing list

Re: [libav-devel] [PATCH 1/8] lavfi: always build vsrc_buffer.

2011-12-22 Thread Anton Khirnov
And before someone asks, this set is more of a RFC. I'll add all the bumps and APIchanges later. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] MXF changes from FFmpeg

2011-12-22 Thread Måns Rullgård
Tomas Härdin tomas.har...@codemill.se writes: On Wed, 2011-12-21 at 17:56 +0100, Janne Grunau wrote: On 2011-12-21 15:47:24 +0100, Tomas Härdin wrote: On Wed, 2011-12-21 at 15:28 +0100, Luca Barbato wrote: On 21/12/11 14:58, Tomas Härdin wrote: I hope you made sure the code still work

Re: [libav-devel] [PATCH 1/8] lavfi: always build vsrc_buffer.

2011-12-22 Thread Måns Rullgård
Anton Khirnov an...@khirnov.net writes: It's a part of public API. --- configure|2 -- libavfilter/Makefile |2 +- 2 files changed, 1 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 1c7fb3b..8e2e08b 100755 --- a/configure +++ b/configure @@

Re: [libav-devel] [PATCH 4/8] lavc: add format field to AVFrame

2011-12-22 Thread Måns Rullgård
Anton Khirnov an...@khirnov.net writes: From: Stefano Sabatini stefano.sabatini-l...@poste.it The format is a per-frame property, having it in AVFrame simplify the operation of extraction of that information, since avoids the need to access the codec/stream context. ---

Re: [libav-devel] [PATCH] ra144enc: zero the reflection coeffs if the filter is unstable

2011-12-22 Thread Benjamin Larsson
On 12/21/2011 10:19 PM, Justin Ruggles wrote: fixes use of uninitialized values if the filter is still unstable after using the previous frame lpc coefficients. OK ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] MXF changes from FFmpeg

2011-12-22 Thread Tomas Härdin
On Thu, 2011-12-22 at 11:52 +, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: On Wed, 2011-12-21 at 17:56 +0100, Janne Grunau wrote: On 2011-12-21 15:47:24 +0100, Tomas Härdin wrote: On Wed, 2011-12-21 at 15:28 +0100, Luca Barbato wrote: On 21/12/11 14:58,

Re: [libav-devel] [PATCH] add bytestream2_tell() and bytestream2_seek() functions

2011-12-22 Thread Justin Ruggles
On 12/22/2011 01:38 AM, Ronald S. Bultje wrote: Hi, On Wed, Dec 21, 2011 at 10:36 PM, Ronald S. Bultje rsbul...@gmail.com mailto:rsbul...@gmail.com wrote: On Wed, Dec 21, 2011 at 7:32 PM, Justin Ruggles justin.rugg...@gmail.com mailto:justin.rugg...@gmail.com wrote:

Re: [libav-devel] [PATCH 4/8] lavc: add format field to AVFrame

2011-12-22 Thread Justin Ruggles
On 12/22/2011 06:59 AM, Måns Rullgård wrote: Anton Khirnov an...@khirnov.net writes: From: Stefano Sabatini stefano.sabatini-l...@poste.it The format is a per-frame property, having it in AVFrame simplify the operation of extraction of that information, since avoids the need to access the

[libav-devel] [PATCH] lavfi: always build vsrc_buffer.

2011-12-22 Thread Anton Khirnov
It's a part of public API. --- configure|2 -- libavfilter/Makefile |2 +- libavfilter/allfilters.c |7 ++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 1c7fb3b..8e2e08b 100755 --- a/configure +++ b/configure @@

Re: [libav-devel] [PATCH] lavfi: always build vsrc_buffer.

2011-12-22 Thread Måns Rullgård
Anton Khirnov an...@khirnov.net writes: It's a part of public API. --- configure|2 -- libavfilter/Makefile |2 +- libavfilter/allfilters.c |7 ++- 3 files changed, 7 insertions(+), 4 deletions(-) This seems like it should work. -- Måns Rullgård

Re: [libav-devel] PATCH asv1:cosmetics

2011-12-22 Thread Chris Berov
On Wed, Dec 21, 2011 at 11:01 PM, Diego Biurrun di...@biurrun.de wrote: On Wed, Dec 21, 2011 at 10:12:42PM +0200, Chris Berov wrote: --- a/libavcodec/asv1.c +++ b/libavcodec/asv1.c @@ -139,212 +140,247 @@ static av_cold void init_vlcs(ASV1Context *a){ -static inline int

[libav-devel] [PATCH] 4xm: remove unused variables.

2011-12-22 Thread Anton Khirnov
--- libavcodec/4xm.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/libavcodec/4xm.c b/libavcodec/4xm.c index ba8bb4a..cffb315 100644 --- a/libavcodec/4xm.c +++ b/libavcodec/4xm.c @@ -650,8 +650,6 @@ static int decode_i_frame(FourXContext *f, const uint8_t *buf, int

Re: [libav-devel] PATCH asv1:cosmetics

2011-12-22 Thread Diego Biurrun
On Thu, Dec 22, 2011 at 04:47:06PM +0200, Chris Berov wrote: [...] Please snip your quotes, thank you. --- a/libavcodec/asv1.c +++ b/libavcodec/asv1.c @@ -139,212 +140,270 @@ static av_cold void init_vlcs(ASV1Context *a){ -static inline void asv2_put_level(PutBitContext *pb, int level){

Re: [libav-devel] [PATCH] 4xm: remove unused variables.

2011-12-22 Thread Diego Biurrun
On Thu, Dec 22, 2011 at 03:56:18PM +0100, Anton Khirnov wrote: --- libavcodec/4xm.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) OK Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] add bytestream2_tell() and bytestream2_seek() functions

2011-12-22 Thread Ronald S. Bultje
Hi, On Thu, Dec 22, 2011 at 5:09 AM, Justin Ruggles justin.rugg...@gmail.comwrote: On 12/22/2011 01:38 AM, Ronald S. Bultje wrote: Hi, On Wed, Dec 21, 2011 at 10:36 PM, Ronald S. Bultje rsbul...@gmail.com mailto:rsbul...@gmail.com wrote: On Wed, Dec 21, 2011 at 7:32 PM,

Re: [libav-devel] [PATCH] add bytestream2_tell() and bytestream2_seek() functions

2011-12-22 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Thu, Dec 22, 2011 at 5:09 AM, Justin Ruggles justin.rugg...@gmail.comwrote: On 12/22/2011 01:38 AM, Ronald S. Bultje wrote: Hi, On Wed, Dec 21, 2011 at 10:36 PM, Ronald S. Bultje rsbul...@gmail.com mailto:rsbul...@gmail.com wrote:

Re: [libav-devel] [PATCH 01/10] fate: split off demuxer FATE tests into their own file

2011-12-22 Thread Diego Biurrun
On Wed, Dec 14, 2011 at 11:51:57PM +0100, Diego Biurrun wrote: --- tests/Makefile |1 + tests/fate.mak | 26 -- tests/fate/demux.mak | 38 ++ 3 files changed, 39 insertions(+), 26 deletions(-) create mode

[libav-devel] [PATCH] Drop ALT_ prefix from BITSTREAM_READER_LE name.

2011-12-22 Thread Diego Biurrun
The prefix is a historic remnant that probably meant alternative. Now that the A32 bitstream reader has been dropped it makes no sense anymore. --- libavcodec/apedec.c |2 +- libavcodec/bink.c |2 +- libavcodec/binkaudio.c |2 +- libavcodec/eatgq.c |

Re: [libav-devel] [PATCH] Drop ALT_ prefix from BITSTREAM_READER_LE name.

2011-12-22 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: The prefix is a historic remnant that probably meant alternative. Now that the A32 bitstream reader has been dropped it makes no sense anymore. --- libavcodec/apedec.c |2 +- libavcodec/bink.c |2 +- libavcodec/binkaudio.c

Re: [libav-devel] [PATCH] lavfi: always build vsrc_buffer.

2011-12-22 Thread Måns Rullgård
Anton Khirnov an...@khirnov.net writes: +extern avfilter_vsrc_buffer; Sorry, that's missing a type name, should be AVFilter. -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] MXF changes from FFmpeg

2011-12-22 Thread Luca Barbato
On 22/12/11 13:45, Tomas Härdin wrote: It's also hard to define crazy when it comes to MXF. After all, we're talking about a format that allows indexing individual scanlines in raw footage.. So we should accept 64bit/sizeof(the thing) values on 64bit architectures? lu -- Luca Barbato

Re: [libav-devel] [PATCH 01/19] mxfdec: Parse MXF partitions.

2011-12-22 Thread Luca Barbato
On 22/12/11 10:44, Tomas Härdin wrote: On Wed, 2011-12-21 at 19:45 +0100, Janne Grunau wrote: From: Tomas Härdintomas.har...@codemill.se --- libavformat/mxfdec.c | 108 +- 1 files changed, 107 insertions(+), 1 deletions(-) diff --git

Re: [libav-devel] MXF changes from FFmpeg

2011-12-22 Thread Måns Rullgård
Luca Barbato lu_z...@gentoo.org writes: On 22/12/11 13:45, Tomas Härdin wrote: It's also hard to define crazy when it comes to MXF. After all, we're talking about a format that allows indexing individual scanlines in raw footage.. So we should accept 64bit/sizeof(the thing) values on 64bit

[libav-devel] [PATCH] allfilters: fix type of avfilter_vsrc_buffer.

2011-12-22 Thread Anton Khirnov
--- libavfilter/allfilters.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c index a6f1731..ba66941 100644 --- a/libavfilter/allfilters.c +++ b/libavfilter/allfilters.c @@ -91,7 +91,7 @@ void avfilter_register_all(void)

Re: [libav-devel] MXF changes from FFmpeg

2011-12-22 Thread Janne Grunau
On 2011-12-22 16:20:55 +, Måns Rullgård wrote: Luca Barbato lu_z...@gentoo.org writes: On 22/12/11 13:45, Tomas Härdin wrote: It's also hard to define crazy when it comes to MXF. After all, we're talking about a format that allows indexing individual scanlines in raw footage..

Re: [libav-devel] Code cleanup

2011-12-22 Thread Ronald S. Bultje
Hi, On Thu, Dec 22, 2011 at 8:04 AM, KJT TOD bioact...@abv.bg wrote: [.. until hpel_motion_lowres ..] Hi, @@ -1012,31 +1161,35 @@ int ff_find_unused_picture(MpegEncContext *s, int shared){ [..] -for(i=0; i64; i++){ -s-dct_offset[intra][i]= (s-avctx-noise_reduction *

Re: [libav-devel] Code cleanup

2011-12-22 Thread Ronald S. Bultje
Hi, On Thu, Dec 22, 2011 at 9:08 AM, Ronald S. Bultje rsbul...@gmail.com wrote: On Thu, Dec 22, 2011 at 8:04 AM, KJT TOD bioact...@abv.bg wrote: [.. until hpel_motion_lowres ..] and the rest... static inline int hpel_motion_lowres(MpegEncContext *s, [..] +if ((unsigned)src_x

Re: [libav-devel] Code cleanup

2011-12-22 Thread Felipe Contreras
On Thu, Dec 22, 2011 at 7:08 PM, Ronald S. Bultje rsbul...@gmail.com wrote: @@ -1086,75 +1248,93 @@ int MPV_frame_start(MpegEncContext *s, AVCodecContext *avctx) [..] -/*    av_log(s-avctx, AV_LOG_DEBUG, L%p N%p C%p L%p N%p C%p type:%d drop:%d\n, s-last_picture_ptr,

Re: [libav-devel] Code cleanup

2011-12-22 Thread Felipe Contreras
On Thu, Dec 22, 2011 at 7:51 PM, KJT TOD bioact...@abv.bg wrote: Now is fixed. :) Isn't there some kind of guideline to send patches inlined? -- Felipe Contreras ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] allfilters: fix type of avfilter_vsrc_buffer.

2011-12-22 Thread Måns Rullgård
Anton Khirnov an...@khirnov.net writes: --- libavfilter/allfilters.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c index a6f1731..ba66941 100644 --- a/libavfilter/allfilters.c +++ b/libavfilter/allfilters.c

Re: [libav-devel] Code cleanup

2011-12-22 Thread Måns Rullgård
Felipe Contreras felipe.contre...@gmail.com writes: On Thu, Dec 22, 2011 at 7:51 PM, KJT TOD bioact...@abv.bg wrote: Now is fixed. :) Isn't there some kind of guideline to send patches inlined? There is, but it is largely ignored. -- Måns Rullgård m...@mansr.com

[libav-devel] [PATCH] libaf: Add SMJPEG demuxer.

2011-12-22 Thread Paul B Mahol
Signed-off-by: Paul B Mahol one...@gmail.com --- Changelog|1 + doc/general.texi |1 + libavformat/Makefile |1 + libavformat/allformats.c |1 + libavformat/smjpeg.c | 183 ++ libavformat/version.h|

Re: [libav-devel] [PATCH] get_bits: remove A32 variant

2011-12-22 Thread Felipe Contreras
On Fri, Dec 16, 2011 at 10:22 PM, Mans Rullgard m...@mansr.com wrote: The A32 bitstream reader variant is only used on ARMv5 and for Prores due to the larger bit cache this decoder requires. In benchmarks on ARMv5 (Marvell Sheeva) with gcc 4.6, the only statistically significant difference

Re: [libav-devel] Code cleanup

2011-12-22 Thread Ronald S. Bultje
Hi, On Thu, Dec 22, 2011 at 9:59 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Thu, Dec 22, 2011 at 7:08 PM, Ronald S. Bultje rsbul...@gmail.com wrote: @@ -1086,75 +1248,93 @@ int MPV_frame_start(MpegEncContext *s, AVCodecContext *avctx) [..] -/*    av_log(s-avctx, AV_LOG_DEBUG,

Re: [libav-devel] Code cleanup

2011-12-22 Thread Diego Biurrun
On Thu, Dec 22, 2011 at 07:59:38PM +0200, Felipe Contreras wrote: On Thu, Dec 22, 2011 at 7:08 PM, Ronald S. Bultje rsbul...@gmail.com wrote: @@ -1086,75 +1248,93 @@ int MPV_frame_start(MpegEncContext *s, AVCodecContext *avctx) [..] -/*    av_log(s-avctx, AV_LOG_DEBUG, L%p N%p C%p L%p

Re: [libav-devel] [PATCH] libaf: Add SMJPEG demuxer.

2011-12-22 Thread Mike Melanson
+- SMJPEG demuxer Thank you. I've been meaning to do this for 8 years or so. The SMJPEG IMA ADPCM decoder isn't much use without it. :-) -- -Mike Melanson ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 7/8] avconv: implement get_buffer()/release_buffer().

2011-12-22 Thread Ronald S. Bultje
Hi, On Thu, Dec 22, 2011 at 2:01 AM, Anton Khirnov an...@khirnov.net wrote: [..] +    memset(buf-base[0], 128, ret);     /* XXX this shouldn't be needed, but +                                           some codecs rely on it now */ Which? We should fix it. This is slow and unnecessary and

Re: [libav-devel] [PATCH 3/8] lavc: add width and height fields to AVFrame

2011-12-22 Thread Ronald S. Bultje
Hi, On Thu, Dec 22, 2011 at 2:01 AM, Anton Khirnov an...@khirnov.net wrote: From: Stefano Sabatini stefano.sabatini-l...@poste.it width and height are per-frame properties, setting these values in AVFrame simplify the operation of extraction of that information, since avoids the need to

Re: [libav-devel] [PATCH 09/10] fate: whitespace cosmetics

2011-12-22 Thread Justin Ruggles
On 12/14/2011 05:52 PM, Diego Biurrun wrote: --- tests/fate.mak | 65 +--- 1 files changed, 43 insertions(+), 22 deletions(-) looks fine. -Justin ___ libav-devel mailing list

Re: [libav-devel] [PATCH 10/10] fate: Merge fate2.mak into fate.mak.

2011-12-22 Thread Justin Ruggles
On 12/14/2011 05:52 PM, Diego Biurrun wrote: --- tests/Makefile |1 - tests/fate.mak | 19 +++ tests/fate2.mak | 18 -- 3 files changed, 19 insertions(+), 19 deletions(-) delete mode 100644 tests/fate2.mak make sense. patch ok. -Justin

[libav-devel] [PATCH 1/3] build: fix standalone compilation of Core Audio Format demuxer

2011-12-22 Thread Diego Biurrun
The demuxer depends on the mov chan tag code, so link against it. --- libavformat/Makefile |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index c3a4c0d..d3a7619 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile @@

[libav-devel] [PATCH 2/3] build: fix standalone compilation of Microsoft XMV demuxer

2011-12-22 Thread Diego Biurrun
The demuxer depends on the RIFF codec tags code, so link against it. --- libavformat/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index d3a7619..d4054df 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile

[libav-devel] [PATCH 3/3] build: fix standalone compilation of OMA muxer

2011-12-22 Thread Diego Biurrun
The muxer depends on the id3v2 writing code, so link against it. --- libavformat/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index d4054df..36ef2a5 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile @@

Re: [libav-devel] [PATCH 02/10] fate: group all VP* codec FATE tests together in one file

2011-12-22 Thread Justin Ruggles
On 12/14/2011 05:51 PM, Diego Biurrun wrote: --- tests/Makefile |2 +- tests/fate.mak | 10 -- tests/fate/vp8.mak | 20 tests/fate/vpx.mak | 38 ++ tests/fate2.mak|3 --- 5 files changed, 39

Re: [libav-devel] [PATCH 08/10] fate: split off vqf/twinvq FATE tests into their own file

2011-12-22 Thread Justin Ruggles
On 12/14/2011 05:52 PM, Diego Biurrun wrote: --- tests/Makefile |1 + tests/fate.mak |2 -- tests/fate/vqf.mak |7 +++ tests/fate2.mak|5 - 4 files changed, 8 insertions(+), 7 deletions(-) create mode 100644 tests/fate/vqf.mak ok. -Jusitn

Re: [libav-devel] [PATCH 07/10] fate: split off mpc FATE tests into their own file

2011-12-22 Thread Justin Ruggles
On 12/14/2011 05:52 PM, Diego Biurrun wrote: --- tests/Makefile |1 + tests/fate.mak |4 tests/fate/mpc.mak | 11 +++ tests/fate2.mak|6 -- 4 files changed, 12 insertions(+), 10 deletions(-) create mode 100644 tests/fate/mpc.mak ok. -Justin

Re: [libav-devel] [PATCH 06/10] fate: split off libavcodec FATE tests into their own file

2011-12-22 Thread Justin Ruggles
On 12/14/2011 05:52 PM, Diego Biurrun wrote: --- tests/Makefile|1 + tests/fate/libavcodec.mak |3 +++ tests/fate2.mak |4 3 files changed, 4 insertions(+), 4 deletions(-) create mode 100644 tests/fate/libavcodec.mak I don't know what other tests

Re: [libav-devel] [PATCH 01/10] fate: split off demuxer FATE tests into their own file

2011-12-22 Thread Justin Ruggles
On 12/14/2011 05:51 PM, Diego Biurrun wrote: --- tests/Makefile |1 + tests/fate.mak | 26 -- tests/fate/demux.mak | 38 ++ 3 files changed, 39 insertions(+), 26 deletions(-) create mode 100644

[libav-devel] Implement automatic thread count for Linux, Mac OS X, *BSD and Windows

2011-12-22 Thread Janne Grunau
Hi, Implemented number CPUs detection for all mayor systems. Mac OS X and *BSD patch is untested, Windows patch only cross-compiled. Uses now sched_getaffinity on Linux. The number of logical CPUs + 1 is used as thread count. This is a compromise for machines with hyperthreading. At least for

[libav-devel] [PATCH 1/4] pthreads: reset active_thread_type when slice thread_init returrns early

2011-12-22 Thread Janne Grunau
--- libavcodec/pthread.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/libavcodec/pthread.c b/libavcodec/pthread.c index 7e03c64..ac15fef 100644 --- a/libavcodec/pthread.c +++ b/libavcodec/pthread.c @@ -237,8 +237,10 @@ static int thread_init(AVCodecContext *avctx)

[libav-devel] [PATCH 2/4] linux: use number of CPUs as automatic thread count

2011-12-22 Thread Janne Grunau
Use sched_getaffinity to determine the number of logical CPUs. Limits the number of threads to 16 since slice threading of H.264 seems to be buggy with more than 16 threads. --- configure|2 ++ libavcodec/pthread.c | 43 +++ 2 files

[libav-devel] [PATCH 4/4] bsd: use number of logical CPUs as automatic thread count

2011-12-22 Thread Janne Grunau
--- configure|2 ++ libavcodec/pthread.c | 10 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 64233cc..9b510de 100755 --- a/configure +++ b/configure @@ -1138,6 +1138,7 @@ HAVE_LIST= symver symver_asm_label

[libav-devel] [PATCH 3/4] windows: use number of CPUs as automatic thread count

2011-12-22 Thread Janne Grunau
--- configure|2 ++ libavcodec/pthread.c |6 ++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/configure b/configure index b5ee3b5..64233cc 100755 --- a/configure +++ b/configure @@ -1086,6 +1086,7 @@ HAVE_LIST= gethrtime GetProcessMemoryInfo

Re: [libav-devel] [PATCH 1/3] options: set minimum for threads to zero

2011-12-22 Thread Ronald S. Bultje
Hi, On Tue, Dec 20, 2011 at 5:02 PM, Janne Grunau janne-li...@jannau.net wrote: Negative number of threads does not make sense and 0 is used for automatic number of threads. ---  libavcodec/options.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) OK. Can we also somehow set a

Re: [libav-devel] [PATCH 2/4] linux: use number of CPUs as automatic thread count

2011-12-22 Thread Ronald S. Bultje
Hi, On Thu, Dec 22, 2011 at 12:22 PM, Janne Grunau janne-li...@jannau.net wrote: Use sched_getaffinity to determine the number of logical CPUs. Limits the number of threads to 16 since slice threading of H.264 seems to be buggy with more than 16 threads. ---  configure            |    2 ++  

Re: [libav-devel] [PATCH 3/4] windows: use number of CPUs as automatic thread count

2011-12-22 Thread Ronald S. Bultje
Hi, On Thu, Dec 22, 2011 at 12:22 PM, Janne Grunau janne-li...@jannau.net wrote: ---  configure            |    2 ++  libavcodec/pthread.c |    6 ++  2 files changed, 8 insertions(+), 0 deletions(-) OK. Ronald ___ libav-devel mailing list

Re: [libav-devel] [PATCH 4/4] bsd: use number of logical CPUs as automatic thread count

2011-12-22 Thread Ronald S. Bultje
Hi, On Thu, Dec 22, 2011 at 12:22 PM, Janne Grunau janne-li...@jannau.net wrote: ---  configure            |    2 ++  libavcodec/pthread.c |   10 ++  2 files changed, 12 insertions(+), 0 deletions(-) OK. Ronald ___ libav-devel mailing list

Re: [libav-devel] Code cleanup

2011-12-22 Thread Diego Biurrun
On Thu, Dec 22, 2011 at 07:51:48PM +0200, KJT TOD wrote: Now is fixed. :) From 42d1346b6e1c605243874437f7da0b255ef6cf08 Mon Sep 17 00:00:00 2001 From: unknown Konstantin@RED.(none) Date: Mon, 5 Dec 2011 18:40:28 +0200 Subject: [PATCH] Mpegvideo.c - 1000to2000line cleanup Please fix your

[libav-devel] [PATCH] build: fix standalone compilation of Core Audio Format demuxer

2011-12-22 Thread Diego Biurrun
The demuxer depends on the mov code, which in turn depends on the mov chan tag code, so link against it. --- libavformat/Makefile |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index c3a4c0d..d3a7619 100644 ---

[libav-devel] [PATCH] options: set minimum for threads to zero

2011-12-22 Thread Janne Grunau
2011-12-22 12:24:00 -0800, Ronald S. Bultje wrote: On Tue, Dec 20, 2011 at 5:02 PM, Janne Grunau janne-li...@jannau.net wrote: Negative number of threads does not make sense and 0 is used for automatic number of threads. ---  libavcodec/options.c |    2 +-  1 files changed, 1

Re: [libav-devel] [PATCH] options: set minimum for threads to zero

2011-12-22 Thread Ronald S. Bultje
Hi, On Thu, Dec 22, 2011 at 12:54 PM, Janne Grunau janne-li...@jannau.net wrote: 2011-12-22 12:24:00 -0800, Ronald S. Bultje wrote: On Tue, Dec 20, 2011 at 5:02 PM, Janne Grunau janne-li...@jannau.net wrote: Negative number of threads does not make sense and 0 is used for automatic number

Re: [libav-devel] [PATCH] libaf: Add SMJPEG demuxer.

2011-12-22 Thread Diego Biurrun
On Thu, Dec 22, 2011 at 06:10:27PM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- Changelog|1 + doc/general.texi |1 + libavformat/Makefile |1 + libavformat/allformats.c |1 + libavformat/smjpeg.c | 183

Re: [libav-devel] [PATCH] adpcm: fix IMA SMJPEG decoding

2011-12-22 Thread Janne Grunau
On 2011-12-22 06:05:17 +0100, Kostya Shishkov wrote: On Wed, Dec 21, 2011 at 08:27:53PM +, Paul B Mahol wrote: --- libavcodec/adpcm.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index

Re: [libav-devel] [PATCH] 4xm: Add a check in decode_i_frame in order to keep in buffer limit

2011-12-22 Thread Janne Grunau
On 2011-12-14 15:36:36 +, Måns Rullgård wrote: Shitiz Garg m...@dragooon.net writes: +if (length bitstream_size + 12) { +av_log(f-avctx, AV_LOG_ERROR, attempting to read from outside the buffer\n); This error message could be better. Something along the lines of

Re: [libav-devel] [PATCH 2/3] build: fix standalone compilation of Microsoft XMV demuxer

2011-12-22 Thread Janne Grunau
On 2011-12-22 21:11:25 +0100, Diego Biurrun wrote: The demuxer depends on the RIFF codec tags code, so link against it. --- libavformat/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index d3a7619..d4054df

Re: [libav-devel] [PATCH 3/3] build: fix standalone compilation of OMA muxer

2011-12-22 Thread Janne Grunau
On 2011-12-22 21:11:26 +0100, Diego Biurrun wrote: The muxer depends on the id3v2 writing code, so link against it. --- libavformat/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index d4054df..36ef2a5 100644

Re: [libav-devel] [PATCH] build: fix standalone compilation of Core Audio Format demuxer

2011-12-22 Thread Janne Grunau
On 2011-12-22 21:50:25 +0100, Diego Biurrun wrote: The demuxer depends on the mov code, which in turn depends on the mov chan tag code, so link against it. Have you loked if functions used from cafdec.c actually depend on something in mov_chan.c? please write channel out and I wouldn't mind a

Re: [libav-devel] [PATCH] kvmc: fix invalid reads

2011-12-22 Thread Janne Grunau
On 2011-12-12 20:24:54 +0530, Gaurav Narula wrote: --- libavcodec/kmvc.c | 82 ++-- 1 files changed, 66 insertions(+), 16 deletions(-) pushed without the trailing whitespace Janne ___ libav-devel

Re: [libav-devel] [PATCH] build: fix standalone compilation of Core Audio Format demuxer

2011-12-22 Thread Diego Biurrun
On Thu, Dec 22, 2011 at 11:58:15PM +0100, Janne Grunau wrote: On 2011-12-22 21:50:25 +0100, Diego Biurrun wrote: The demuxer depends on the mov code, which in turn depends on the mov chan tag code, so link against it. Have you loked if functions used from cafdec.c actually depend on

Re: [libav-devel] [PATCH] build: fix standalone compilation of Core Audio Format demuxer

2011-12-22 Thread Justin Ruggles
On 12/22/2011 06:32 PM, Janne Grunau wrote: On 2011-12-23 00:24:32 +0100, Diego Biurrun wrote: On Thu, Dec 22, 2011 at 11:58:15PM +0100, Janne Grunau wrote: On 2011-12-22 21:50:25 +0100, Diego Biurrun wrote: The demuxer depends on the mov code, which in turn depends on the mov chan tag code,

[libav-devel] [PATCH 1/1] fixup! w32threads: wait for the waked thread in pthread_cond_signal.

2011-12-22 Thread Sergey Radionov
added forgotten ResetEvent to pthread_cond_broadcast. added volatile to broadcast flag (since it using from multiple threads). --- libavcodec/w32pthreads.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavcodec/w32pthreads.h b/libavcodec/w32pthreads.h index

Re: [libav-devel] [PATCH 1/1] fixup! w32threads: wait for the waked thread in pthread_cond_signal.

2011-12-22 Thread Ronald S. Bultje
Hi, On Thu, Dec 22, 2011 at 7:37 PM, Sergey Radionov rsa...@gmail.com wrote: added forgotten ResetEvent to pthread_cond_broadcast. added volatile to broadcast flag (since it using from multiple threads). --- libavcodec/w32pthreads.h |3 ++- 1 files changed, 2 insertions(+), 1

Re: [libav-devel] [PATCH 1/1] fixup! w32threads: wait for the waked thread in pthread_cond_signal.

2011-12-22 Thread Sergey Radionov
2011/12/23 Ronald S. Bultje rsbul...@gmail.com: Hi, On Thu, Dec 22, 2011 at 7:37 PM, Sergey Radionov rsa...@gmail.com wrote: added forgotten ResetEvent to pthread_cond_broadcast. added volatile to broadcast flag (since it using from multiple threads). ---  libavcodec/w32pthreads.h |    3

Re: [libav-devel] [PATCH 1/1] fixup! w32threads: wait for the waked thread in pthread_cond_signal.

2011-12-22 Thread Alexander Strange
On Thu, Dec 22, 2011 at 10:49 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Thu, Dec 22, 2011 at 7:37 PM, Sergey Radionov rsa...@gmail.com wrote: added forgotten ResetEvent to pthread_cond_broadcast. added volatile to broadcast flag (since it using from multiple threads). ---  

Re: [libav-devel] [PATCH 2/4] linux: use number of CPUs as automatic thread count

2011-12-22 Thread Alexander Strange
On Thu, Dec 22, 2011 at 3:22 PM, Janne Grunau janne-li...@jannau.net wrote: Use sched_getaffinity to determine the number of logical CPUs. Try sysconf(_SC_NPROCESSORS_ONLN), which exists on BSD too. Limits the number of threads to 16 since slice threading of H.264 seems to be buggy with more

Re: [libav-devel] [PATCH] h264: Fix a possible overread in decode_nal_units()

2011-12-22 Thread Alexander Strange
On Mon, Dec 12, 2011 at 7:39 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Mon, Dec 12, 2011 at 3:13 PM, Alexander Strange astra...@ithinksw.com wrote: ---  libavcodec/h264.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/h264.c

Re: [libav-devel] [PATCH 1/1] fixup! w32threads: wait for the waked thread in pthread_cond_signal.

2011-12-22 Thread Sergey Radionov
On 23.12.2011 13:55, Alexander Strange wrote: On Thu, Dec 22, 2011 at 10:49 PM, Ronald S. Bultjersbul...@gmail.com wrote: Hi, On Thu, Dec 22, 2011 at 7:37 PM, Sergey Radionovrsa...@gmail.com wrote: added forgotten ResetEvent to pthread_cond_broadcast. added volatile to broadcast flag