[libav-devel] [PATCH] Replace stale Subversion references in APIchanges file

2012-03-07 Thread Diego Biurrun
This has been sitting on my TODO list for a long time, I finally sat down yesterday and did it. I'm attaching the script along with the patch; it probably makes more sense to review the script that generated the changes. Diego replace_svn_references.sh Description: Bourne shell script From

Re: [libav-devel] [PATCH] Cleanup after b24aaabd44d68c6fafbfc476d1b70cc7ff8138ca

2012-03-07 Thread Diego Biurrun
On Wed, Mar 07, 2012 at 12:56:14AM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- libavcodec/parser.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) The subject line is very non-descript. I was expecting some indentation changes. Please be more

Re: [libav-devel] [PATCH] lavf: call update_inital_* for parse_queue too.

2012-03-07 Thread Diego Biurrun
On Wed, Mar 07, 2012 at 08:27:58AM +0100, Anton Khirnov wrote: This restores the previous behavior before 27c7ca9c12bb42d5c44d46f24cd970469d0ef55a. --- libavformat/utils.c | 50 ++ 1 files changed, 30 insertions(+), 20 deletions(-) initIal

Re: [libav-devel] [PATCH] lpcm: fix sample size calculation for 20bit LCPM.

2012-03-07 Thread Benjamin Larsson
On 03/07/2012 05:08 AM, Ronald S. Bultje wrote: Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/pcm-mpeg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/pcm-mpeg.c b/libavcodec/pcm-mpeg.c index

Re: [libav-devel] [PATCH] raw: move buffer size check up.

2012-03-07 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/3] x86: KR prettyprinting cosmetics for dsputil_mmx.c

2012-03-07 Thread Diego Biurrun
Note that this patch depends on the conditional compilation of the QPEL bits. Rebasing this on top of master without that change could turn out to be painful. Everything I don't comment on fixed locally. On Tue, Mar 06, 2012 at 09:50:04PM -0800, Ronald S. Bultje wrote: On Tue, Mar 6, 2012 at

Re: [libav-devel] [PATCH] Fix SSE code to not use SSE2.

2012-03-07 Thread Benjamin Larsson
On 03/06/2012 10:38 PM, Ronald S. Bultje wrote: Hi, On Tue, Mar 6, 2012 at 1:11 PM, Reimar Döffinger reimar.doeffin...@gmx.de wrote: movq from SSE register _to_ memory is an SSE2 instruction. Use the SSE movlps function instead that does the same thing. Signed-off-by: Reimar

Re: [libav-devel] [PATCH] dca: prevent accessing static arrays with invalid indexes.

2012-03-07 Thread Benjamin Larsson
On 03/06/2012 07:57 PM, Ronald S. Bultje wrote: From: Ronald S. Bultjersbul...@gmail.com Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/dca.c | 39 --- libavcodec/dcadata.h |2 +- 2 files changed,

Re: [libav-devel] [PATCH] v4l2: update documentation

2012-03-07 Thread Diego Biurrun
On Tue, Mar 06, 2012 at 04:07:49PM -0800, Luca Barbato wrote: Update the examples and remove stale information in the description. You could mention removing references to v4l1. --- a/doc/indevs.texi +++ b/doc/indevs.texi @@ -254,9 +254,9 @@ command: -@section video4linux and

Re: [libav-devel] [PATCH] cook: extend channel uncoupling tables so the full bit range is covered.

2012-03-07 Thread Benjamin Larsson
On 03/06/2012 10:45 PM, Ronald S. Bultje wrote: From: Ronald S. Bultjersbul...@gmail.com Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/cookdata.h | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) Nice, I like

[libav-devel] [PATCH] parser: remove forward declaration of MpegEncContext

2012-03-07 Thread Paul B Mahol
Signed-off-by: Paul B Mahol one...@gmail.com --- libavcodec/parser.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/libavcodec/parser.h b/libavcodec/parser.h index 024b487..1d029e3 100644 --- a/libavcodec/parser.h +++ b/libavcodec/parser.h @@ -37,8 +37,6 @@ typedef

Re: [libav-devel] [PATCH] parser: remove forward declaration of MpegEncContext

2012-03-07 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] Roundup #2162

2012-03-07 Thread Sean McGovern
Hi folks, While running through Roundup yesterday I ran across this bug which seems to still be valid -- 'make distclean' isn't removing tools/lavfi-showfiltfmts (this is only built after 'make fate'). Anyone with mad Makefile-fu skills care to take this one on? -- Sean McG.

Re: [libav-devel] [PATCH 1/2] aacdec: Fix out of array writes (stack).

2012-03-07 Thread Luca Barbato
On 3/6/12 6:13 PM, Alex Converse wrote: On Tue, Mar 6, 2012 at 6:03 PM, Luca Barbatolu_z...@gentoo.org wrote: yes, zero is unknown channel configuration. Sorry to ask since might be clear for everybody on aac, but might it make a constant so people reading that patch would spot it

Re: [libav-devel] [PATCH] tgq: convert to bytestream2 API.

2012-03-07 Thread Luca Barbato
On 3/6/12 2:18 PM, Ronald S. Bultje wrote: +bytestream2_init(s-gb, buf + 8, buf_size - 8); +if (big_endian) { +s-width = bytestream2_get_be16u(s-gb); +s-height = bytestream2_get_be16u(s-gb); +} else { +s-width = bytestream2_get_le16u(s-gb); +s-height

Re: [libav-devel] [PATCH] cook: extend channel uncoupling tables so the full bit range is covered.

2012-03-07 Thread Ronald S. Bultje
Hi, On Wed, Mar 7, 2012 at 1:38 AM, Benjamin Larsson benja...@southpole.se wrote: On 03/06/2012 10:45 PM, Ronald S. Bultje wrote: From: Ronald S. Bultjersbul...@gmail.com Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org ---  libavcodec/cookdata.h |   22

Re: [libav-devel] [PATCH] cook: extend channel uncoupling tables so the full bit range is covered.

2012-03-07 Thread Benjamin Larsson
On 03/07/2012 04:33 PM, Ronald S. Bultje wrote: Hi, On Wed, Mar 7, 2012 at 1:38 AM, Benjamin Larssonbenja...@southpole.se wrote: On 03/06/2012 10:45 PM, Ronald S. Bultje wrote: From: Ronald S. Bultjersbul...@gmail.com Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC:

[libav-devel] [PATCH] configure: Change dylib install names to include major version

2012-03-07 Thread Gil Pedersen
This patch fixes an issue on Mac OS X/Darwin by preventing dynamic linking against an incorrect major version, thus matching the linux behaviour. Regards, Gil 0001-configure-Change-dylib-install-names-to-include-majo.patch Description:

Re: [libav-devel] [PATCH] configure: Change dylib install names to include major version

2012-03-07 Thread Måns Rullgård
Gil Pedersen g...@cmi.aau.dk writes: This patch fixes an issue on Mac OS X/Darwin by preventing dynamic linking against an incorrect major version, thus matching the linux behaviour. Regards, Gil From 883dcfba6080f4c4297826e0e795199077e75f16 Mon Sep 17 00:00:00 2001 From: Gil Pedersen

[libav-devel] [PATCH] v4l2: update documentation

2012-03-07 Thread Luca Barbato
Update the examples and remove stale information. Video4linux support had been already removed. --- doc/indevs.texi | 34 ++ 1 files changed, 10 insertions(+), 24 deletions(-) diff --git a/doc/indevs.texi b/doc/indevs.texi index e1b4ddd..b0ba6ac 100644 ---

Re: [libav-devel] [PATCH] configure: Change dylib install names to include major version

2012-03-07 Thread Diego Biurrun
On Wed, Mar 07, 2012 at 04:50:24PM +, Måns Rullgård wrote: Gil Pedersen g...@cmi.aau.dk writes: --- a/configure +++ b/configure @@ -2462,12 +2462,12 @@ case $target_os in enable malloc_aligned gas=gas-preprocessor.pl $cc enabled ppc add_asflags

[libav-devel] [PATCH] cook: extend channel uncoupling tables so the full bit range is covered.

2012-03-07 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/cook.c |4 ++-- libavcodec/cookdata.h | 27 ++- 2 files changed, 24 insertions(+), 7 deletions(-) diff --git

[libav-devel] [PATCH] dca: prevent accessing static arrays with invalid indexes.

2012-03-07 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/dca.c | 37 ++--- libavcodec/dcadata.h |2 +- 2 files changed, 27 insertions(+), 12 deletions(-) diff --git

Re: [libav-devel] [PATCH] v4l2: update documentation

2012-03-07 Thread Ronald S. Bultje
Hi, On Wed, Mar 7, 2012 at 9:05 AM, Luca Barbato lu_z...@gentoo.org wrote: Update the examples and remove stale information. Video4linux support had been already removed. ---  doc/indevs.texi |   34 ++  1 files changed, 10 insertions(+), 24 deletions(-) LGTM.

Re: [libav-devel] [PATCH] swscale: clip unscaled output intermediates.

2012-03-07 Thread Ronald S. Bultje
Hi, On Tue, Mar 6, 2012 at 10:30 PM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Tue, Mar 06, 2012 at 02:35:30PM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com Fixes bug 240, as well as several integer overflows (visible as glitches) in other scaling output

Re: [libav-devel] [PATCH] tgq: convert to bytestream2 API.

2012-03-07 Thread Ronald S. Bultje
Hi, On Wed, Mar 7, 2012 at 6:21 AM, Luca Barbato lu_z...@gentoo.org wrote: On 3/6/12 2:18 PM, Ronald S. Bultje wrote: +    bytestream2_init(s-gb, buf + 8, buf_size - 8); +    if (big_endian) { +        s-width  = bytestream2_get_be16u(s-gb); +        s-height = bytestream2_get_be16u(s-gb);

Re: [libav-devel] [PATCH 3/3] x86: KR prettyprinting cosmetics for dsputil_mmx.c

2012-03-07 Thread Ronald S. Bultje
Hi, On Wed, Mar 7, 2012 at 1:23 AM, Diego Biurrun di...@biurrun.de wrote: On Tue, Mar 06, 2012 at 09:50:04PM -0800, Ronald S. Bultje wrote: On Tue, Mar 6, 2012 at 10:09 AM, Diego Biurrun di...@biurrun.de wrote: -    if (mm_flags AV_CPU_FLAG_SSE4 HAVE_SSE) +    if (HAVE_SSE (mm_flags

Re: [libav-devel] [PATCH] parser: remove forward declaration of MpegEncContext

2012-03-07 Thread Ronald S. Bultje
Hi, 2012/3/7 Benjamin Larsson benja...@southpole.se: OK Pushed. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] configure: Change dylib install names to include major version

2012-03-07 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: On Wed, Mar 07, 2012 at 04:50:24PM +, Måns Rullgård wrote: Gil Pedersen g...@cmi.aau.dk writes: --- a/configure +++ b/configure @@ -2462,12 +2462,12 @@ case $target_os in enable malloc_aligned gas=gas-preprocessor.pl $cc

Re: [libav-devel] [PATCH] tgq: convert to bytestream2 API.

2012-03-07 Thread Luca Barbato
On 07/03/12 09:37, Ronald S. Bultje wrote: Hi, On Wed, Mar 7, 2012 at 6:21 AM, Luca Barbato lu_z...@gentoo.org wrote: On 3/6/12 2:18 PM, Ronald S. Bultje wrote: +bytestream2_init(s-gb, buf + 8, buf_size - 8); +if (big_endian) { +s-width = bytestream2_get_be16u(s-gb); +

Re: [libav-devel] [PATCH 1/2] aacdec: Fix out of array writes (stack).

2012-03-07 Thread Alex Converse
On Wed, Mar 7, 2012 at 6:20 AM, Luca Barbato lu_z...@gentoo.org wrote: On 3/6/12 6:13 PM, Alex Converse wrote: On Tue, Mar 6, 2012 at 6:03 PM, Luca Barbatolu_z...@gentoo.org  wrote: yes, zero is unknown channel configuration. Sorry to ask since might be clear for everybody on aac, but might

Re: [libav-devel] [PATCH] smc: port to bytestream2 API.

2012-03-07 Thread Kostya Shishkov
On Tue, Mar 06, 2012 at 04:50:46PM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/smc.c | 74 +++--- 1 file changed,

Re: [libav-devel] [PATCH] roqvideo: convert to bytestream2 API.

2012-03-07 Thread Kostya Shishkov
On Tue, Mar 06, 2012 at 03:58:45PM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/roqvideo.h|4 +-- libavcodec/roqvideodec.c | 69

[libav-devel] [PATCH 1/3] rtmp: support live resources

2012-03-07 Thread Luca Barbato
From: Raffaele Sena raff...@gmail.com Support librtmp-like syntax to set connection parameters. Parse the last url element as the stream name and consider the remaning as the application path. --- libavformat/rtmpproto.c | 115 -- 1 files changed, 110

[libav-devel] [PATCH 2/3] rtmp: update supported audio codecs value

2012-03-07 Thread Luca Barbato
From: Raffaele Sena raff...@gmail.com Tell the server we support all the audio codecs. --- libavformat/rtmpproto.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 86fb501..bebdafd 100644 ---

[libav-devel] [PATCH 3/3] rtmp: implement bandwidth notification

2012-03-07 Thread Luca Barbato
From: Raffaele Sena raff...@gmail.com Improve compatibility with some servers. --- libavformat/rtmpproto.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index bebdafd..b1ba75b 100644 ---

Re: [libav-devel] [PATCH] dv: check buffer size before reading profile.

2012-03-07 Thread Kostya Shishkov
On Tue, Mar 06, 2012 at 02:49:54PM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/dvdata.c | 30 -- 1 file changed, 16 insertions(+), 14

Re: [libav-devel] SBR DSP: use a swap index rather than copy buffers.

2012-03-07 Thread Ronald S. Bultje
Hi, On Tue, Feb 28, 2012 at 10:02 PM, Alex Converse alex.conve...@gmail.com wrote: On Tue, Feb 28, 2012 at 9:26 PM, Alex Converse alex.conve...@gmail.com wrote: On Tue, Feb 28, 2012 at 4:20 AM, Christophe Gisquet christophe.gisq...@gmail.com wrote: 2012/2/24 Christophe Gisquet

Re: [libav-devel] [PATCH] smc: port to bytestream2 API.

2012-03-07 Thread Ronald S. Bultje
Hi, On Wed, Mar 7, 2012 at 10:19 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: nit: why is this check dropped instead of being converted to bytestream2 as well? overall looks OK It can no longer overflow, so the check is unnecessary. For these kind of codecs, I tend to think that

Re: [libav-devel] [PATCH 1/3] rtmp: support live resources

2012-03-07 Thread Kostya Shishkov
On Wed, Mar 07, 2012 at 10:21:14AM -0800, Luca Barbato wrote: From: Raffaele Sena raff...@gmail.com Support librtmp-like syntax to set connection parameters. Parse the last url element as the stream name and consider the remaning as the application path. --- libavformat/rtmpproto.c | 115

Re: [libav-devel] [PATCH] smc: port to bytestream2 API.

2012-03-07 Thread Kostya Shishkov
On Wed, Mar 07, 2012 at 10:27:40AM -0800, Ronald S. Bultje wrote: Hi, On Wed, Mar 7, 2012 at 10:19 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: nit: why is this check dropped instead of being converted to bytestream2 as well? overall looks OK It can no longer overflow, so the

Re: [libav-devel] SBR DSP: use a swap index rather than copy buffers.

2012-03-07 Thread Ronald S. Bultje
Hi, On Wed, Mar 7, 2012 at 10:24 AM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Tue, Feb 28, 2012 at 10:02 PM, Alex Converse alex.conve...@gmail.com wrote: On Tue, Feb 28, 2012 at 9:26 PM, Alex Converse alex.conve...@gmail.com wrote: On Tue, Feb 28, 2012 at 4:20 AM, Christophe

Re: [libav-devel] [PATCH 2/3] rtmp: update supported audio codecs value

2012-03-07 Thread Kostya Shishkov
On Wed, Mar 07, 2012 at 10:21:15AM -0800, Luca Barbato wrote: From: Raffaele Sena raff...@gmail.com Tell the server we support all the audio codecs. --- libavformat/rtmpproto.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavformat/rtmpproto.c

Re: [libav-devel] [PATCH 3/3] rtmp: implement bandwidth notification

2012-03-07 Thread Kostya Shishkov
On Wed, Mar 07, 2012 at 10:21:16AM -0800, Luca Barbato wrote: From: Raffaele Sena raff...@gmail.com Improve compatibility with some servers. --- libavformat/rtmpproto.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/libavformat/rtmpproto.c

[libav-devel] [PATCH] wmall: fix build with -DDEBUG enabled.

2012-03-07 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/wmalosslessdec.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index db2d484..6bd8bfb 100644 --- a/libavcodec/wmalosslessdec.c +++

Re: [libav-devel] [PATCH] wmall: fix build with -DDEBUG enabled.

2012-03-07 Thread Kostya Shishkov
On Wed, Mar 07, 2012 at 10:40:21AM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/wmalosslessdec.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c

[libav-devel] [PATCH] Revert AAC SBR: group some writes.

2012-03-07 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This reverts commit ba36f14e5d34bcca6ecf77ba1c7512d1b51a9740. It broke decoding on x86-32 on some systems. --- libavcodec/aacsbr.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/libavcodec/aacsbr.c

Re: [libav-devel] [PATCH 1/3] rtmp: support live resources

2012-03-07 Thread Luca Barbato
On 07/03/12 10:28, Kostya Shishkov wrote: needs more work I know I just started clean them up and I sent them before I forget again. lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] Multichannel WMA Lossless?

2012-03-07 Thread Mike Melanson
WMA lossless supports up to 8 channels and our new decoder apparently has support. Do we have any multichannel samples (going up to 6 and 8 channels) that we can test against the decoder? Thanks, -- -Mike Melanson ___ libav-devel mailing list

[libav-devel] [PATCH 1/4] rgb2rgb: rgb48to32()

2012-03-07 Thread Paul B Mahol
Signed-off-by: Paul B Mahol one...@gmail.com --- libswscale/rgb2rgb.c | 19 +++ libswscale/rgb2rgb.h |1 + libswscale/swscale_unscaled.c |1 + 3 files changed, 21 insertions(+), 0 deletions(-) diff --git a/libswscale/rgb2rgb.c b/libswscale/rgb2rgb.c

[libav-devel] [PATCH 2/4] rgb2rgb: rgb48to24()

2012-03-07 Thread Paul B Mahol
Signed-off-by: Paul B Mahol one...@gmail.com --- libswscale/rgb2rgb.c | 10 ++ libswscale/rgb2rgb.h |1 + libswscale/swscale_unscaled.c |1 + 3 files changed, 12 insertions(+), 0 deletions(-) diff --git a/libswscale/rgb2rgb.c b/libswscale/rgb2rgb.c index

[libav-devel] [PATCH 3/4] rgb2rgb: rgb48tobgr24()

2012-03-07 Thread Paul B Mahol
Signed-off-by: Paul B Mahol one...@gmail.com --- libswscale/rgb2rgb.c | 14 ++ libswscale/rgb2rgb.h |1 + libswscale/swscale_unscaled.c |1 + 3 files changed, 16 insertions(+), 0 deletions(-) diff --git a/libswscale/rgb2rgb.c b/libswscale/rgb2rgb.c index

[libav-devel] [PATCH 4/4] rgb2rgb: rgb48tobgr32()

2012-03-07 Thread Paul B Mahol
Signed-off-by: Paul B Mahol one...@gmail.com --- libswscale/rgb2rgb.c | 19 +++ libswscale/rgb2rgb.h |1 + libswscale/swscale_unscaled.c |1 + 3 files changed, 21 insertions(+), 0 deletions(-) diff --git a/libswscale/rgb2rgb.c b/libswscale/rgb2rgb.c

[libav-devel] [PATCH] roqvideo: cosmetics.

2012-03-07 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/roqvideodec.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/libavcodec/roqvideodec.c b/libavcodec/roqvideodec.c index 0bf00cf..4b6375c 100644 --- a/libavcodec/roqvideodec.c +++

Re: [libav-devel] [PATCH] roqvideo: convert to bytestream2 API.

2012-03-07 Thread Ronald S. Bultje
Hi, On Wed, Mar 7, 2012 at 10:21 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Tue, Mar 06, 2012 at 03:58:45PM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org ---  

[libav-devel] [PATCH] pngdec: frame multithreading

2012-03-07 Thread Paul B Mahol
Signed-off-by: Paul B Mahol one...@gmail.com --- libavcodec/pngdec.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 66afb0e..2c2d159 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -23,6 +23,7 @@

Re: [libav-devel] Multichannel WMA Lossless?

2012-03-07 Thread Mashiat Sarker Shakkhar
On 3/8/2012 12:54 AM, Mike Melanson wrote: WMA lossless supports up to 8 channels and our new decoder apparently has support. Do we have any multichannel samples (going up to 6 and 8 channels) that we can test against the decoder? I don't think the decoder supports more than 2 channels. The

Re: [libav-devel] [PATCH] roqvideo: cosmetics.

2012-03-07 Thread Paul B Mahol
On 3/7/12, Ronald S. Bultje rsbul...@gmail.com wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/roqvideodec.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) LGTM ___ libav-devel mailing

[libav-devel] [PATCH] dca: don't use av_clip_uintp2().

2012-03-07 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com The argument is not a literal, thus causing the arm build to break. --- libavcodec/dca.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dca.c b/libavcodec/dca.c index 6dbcda0..8e4f819 100644 --- a/libavcodec/dca.c +++

Re: [libav-devel] [PATCH] pngdec: frame multithreading

2012-03-07 Thread Ronald S. Bultje
Hi, On Wed, Mar 7, 2012 at 11:02 AM, Paul B Mahol one...@gmail.com wrote: Signed-off-by: Paul B Mahol one...@gmail.com ---  libavcodec/pngdec.c |   13 +++--  1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index

Re: [libav-devel] [PATCH] dca: don't use av_clip_uintp2().

2012-03-07 Thread Kostya Shishkov
On Wed, Mar 07, 2012 at 11:06:27AM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com The argument is not a literal, thus causing the arm build to break. I'd say ARM v6 or later, otherwise OK (and tested with CodeSourcery crosscompiler to be sure) ---

[libav-devel] [PATCH] dca: include libavutil/mathematics.h for possibly missing M_SQRT1_2

2012-03-07 Thread Kostya Shishkov
--- my old CodeSourcery compiler failed since it doesn't have such definition in its math.h and proper header in lavu wasn't included. --- libavcodec/dca.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libavcodec/dca.c b/libavcodec/dca.c index 6dbcda0..b1b315f 100644

Re: [libav-devel] [PATCH] Revert AAC SBR: group some writes.

2012-03-07 Thread Kostya Shishkov
On Wed, Mar 07, 2012 at 10:52:33AM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com This reverts commit ba36f14e5d34bcca6ecf77ba1c7512d1b51a9740. It broke decoding on x86-32 on some systems. --- libavcodec/aacsbr.c | 18 -- Maybe it's better to fix

Re: [libav-devel] [PATCH] roqvideo: cosmetics.

2012-03-07 Thread Kostya Shishkov
On Wed, Mar 07, 2012 at 07:03:41PM +, Paul B Mahol wrote: On 3/7/12, Ronald S. Bultje rsbul...@gmail.com wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/roqvideodec.c | 32 1 file changed, 16 insertions(+), 16 deletions(-)

Re: [libav-devel] [PATCH] roqvideo: convert to bytestream2 API.

2012-03-07 Thread Kostya Shishkov
On Wed, Mar 07, 2012 at 11:01:09AM -0800, Ronald S. Bultje wrote: Hi, On Wed, Mar 7, 2012 at 10:21 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Tue, Mar 06, 2012 at 03:58:45PM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com Found-by: Mateusz j00ru

Re: [libav-devel] [PATCH] Revert AAC SBR: group some writes.

2012-03-07 Thread Ronald S. Bultje
Hi, On Wed, Mar 7, 2012 at 11:14 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Wed, Mar 07, 2012 at 10:52:33AM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com This reverts commit ba36f14e5d34bcca6ecf77ba1c7512d1b51a9740. It broke decoding on x86-32 on some

Re: [libav-devel] [PATCH] dca: include libavutil/mathematics.h for possibly missing M_SQRT1_2

2012-03-07 Thread Ronald S. Bultje
Hi, On Wed, Mar 7, 2012 at 11:12 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: --- my old CodeSourcery compiler failed since it doesn't have such definition in its math.h and proper header in lavu wasn't included. ---  libavcodec/dca.c |    1 +  1 files changed, 1 insertions(+), 0

[libav-devel] [PATCH] Vorbis: Fix invalid memory access when all channels aren't in the submap

2012-03-07 Thread Aaron Colwell
Hi, This fixes some invalid memory access caused later in the function by res_chan[] not being set for all channels. This happens when a channel doesn't appear a submap. This change simply returns a decoder error when this situation is detected. Aaron --- libavcodec/vorbisdec.c |3 +++ 1

Re: [libav-devel] [PATCH] cook: extend channel uncoupling tables so the full bit range is covered.

2012-03-07 Thread Benjamin Larsson
On 03/07/2012 06:27 PM, Ronald S. Bultje wrote: From: Ronald S. Bultjersbul...@gmail.com Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/cook.c |4 ++-- libavcodec/cookdata.h | 27 ++- 2 files changed, 24

Re: [libav-devel] [PATCH] dca: prevent accessing static arrays with invalid indexes.

2012-03-07 Thread Benjamin Larsson
On 03/07/2012 06:31 PM, Ronald S. Bultje wrote: From: Ronald S. Bultjersbul...@gmail.com OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] udp: Print an error message if bind fails

2012-03-07 Thread Martin Storsjö
--- libavformat/udp.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index 8bb63c6..0a13f67 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -387,8 +387,10 @@ static int udp_open(URLContext *h, const char *uri, int

Re: [libav-devel] [PATCH] udp: Print an error message if bind fails

2012-03-07 Thread Ronald S. Bultje
Hi, On Wed, Mar 7, 2012 at 11:40 AM, Martin Storsjö mar...@martin.st wrote: ---  libavformat/udp.c |    4 +++-  1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index 8bb63c6..0a13f67 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c

[libav-devel] [PATCH] pngdec: frame multithreading

2012-03-07 Thread Paul B Mahol
Signed-off-by: Paul B Mahol one...@gmail.com --- libavcodec/pngdec.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 66afb0e..96bd49b 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -23,6 +23,7

Re: [libav-devel] [PATCH] udp: Print an error message if bind fails

2012-03-07 Thread Martin Storsjö
On Wed, 7 Mar 2012, Ronald S. Bultje wrote: Hi, On Wed, Mar 7, 2012 at 11:40 AM, Martin Storsjö mar...@martin.st wrote: ---  libavformat/udp.c |    4 +++-  1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index 8bb63c6..0a13f67 100644 ---

[libav-devel] acodec-wmav1 FATE failure

2012-03-07 Thread Sean McGovern
Hi, Do we need any more triage done on this failure or is the problem known? -- Sean McG. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] dca: don't use av_clip_uintp2().

2012-03-07 Thread Jason Garrett-Glaser
On Wed, Mar 7, 2012 at 11:11 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Wed, Mar 07, 2012 at 11:06:27AM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com The argument is not a literal, thus causing the arm build to break. Can't we fix the ARM implementation

Re: [libav-devel] [PATCH] Revert AAC SBR: group some writes.

2012-03-07 Thread Alex Converse
On Wed, Mar 7, 2012 at 10:52 AM, Ronald S. Bultje rsbul...@gmail.com wrote: From: Ronald S. Bultje rsbul...@gmail.com This reverts commit ba36f14e5d34bcca6ecf77ba1c7512d1b51a9740. It broke decoding on x86-32 on some systems. ---  libavcodec/aacsbr.c |   18 --  1 file

Re: [libav-devel] [PATCH] pngdec: frame multithreading

2012-03-07 Thread Ronald S. Bultje
Hi, On Wed, Mar 7, 2012 at 11:53 AM, Paul B Mahol one...@gmail.com wrote: Signed-off-by: Paul B Mahol one...@gmail.com ---  libavcodec/pngdec.c |   15 +--  1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index

Re: [libav-devel] acodec-wmav1 FATE failure

2012-03-07 Thread Ronald S. Bultje
Hi, On Wed, Mar 7, 2012 at 12:00 PM, Sean McGovern gsean...@gmail.com wrote: Do we need any more triage done on this failure or is the problem known? Justin had ideas on how to properly fix it. Ronald ___ libav-devel mailing list

[libav-devel] [PATCH] sbrdsp.asm: convert all instructions to float/SSE ones.

2012-03-07 Thread Reimar Döffinger
Since the values are floats, using the float operations makes sense, improves performance on some CPUs and makes the code SSE compatible instead of needing SSE2. Based on suggestion by Jason. Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavcodec/x86/sbrdsp.asm | 16

Re: [libav-devel] [PATCH] sbrdsp.asm: convert all instructions to float/SSE ones.

2012-03-07 Thread Justin Ruggles
On 03/07/2012 03:35 PM, Reimar Döffinger wrote: Since the values are floats, using the float operations makes sense, improves performance on some CPUs and makes the code SSE compatible instead of needing SSE2. Based on suggestion by Jason. Signed-off-by: Reimar Döffinger

[libav-devel] [PATCH] Fix uninitialized reads on malformed ogg files.

2012-03-07 Thread dalecurtis
From: Dale Curtis dalecur...@chromium.org The ogg decoder wasn't padding the input buffer with the appropriate FF_INPUT_BUFFER_PADDING_SIZE bytes. Which led to uninitialized reads in various pieces of parsing code when they thought they had more data than they actually did. Signed-off-by: Dale

Re: [libav-devel] [FFmpeg-devel] [PATCH] sbrdsp.asm: convert all instructions to float/SSE ones.

2012-03-07 Thread Jason Garrett-Glaser
diff --git a/libavcodec/x86/sbrdsp.asm b/libavcodec/x86/sbrdsp.asm index c3b559b..31a1c8b 100644 --- a/libavcodec/x86/sbrdsp.asm +++ b/libavcodec/x86/sbrdsp.asm @@ -82,14 +82,14 @@ cglobal sbr_hf_g_filt, 5, 6, 5     lea         r0, [r0 + r3*8]     neg         r3  .loop4: -    movq        

Re: [libav-devel] Multichannel WMA Lossless?

2012-03-07 Thread Mike Melanson
On 3/8/2012 12:54 AM, Mike Melanson wrote: WMA lossless supports up to 8 channels and our new decoder apparently has support. Do we have any multichannel samples (going up to 6 and 8 channels) that we can test against the decoder? I don't think the decoder supports more than 2 channels. The

Re: [libav-devel] Multichannel WMA Lossless?

2012-03-07 Thread Sean McGovern
On Wed, Mar 7, 2012 at 4:48 PM, Mike Melanson m...@multimedia.cx wrote: On 3/8/2012 12:54 AM, Mike Melanson wrote: WMA lossless supports up to 8 channels and our new decoder apparently has support. Do we have any multichannel samples (going up to 6 and 8 channels) that we can test against the

Re: [libav-devel] [PATCH] sbrdsp.asm: convert all instructions to float/SSE ones.

2012-03-07 Thread Ronald S. Bultje
Hi, On Wed, Mar 7, 2012 at 1:26 PM, Justin Ruggles justin.rugg...@gmail.com wrote: On 03/07/2012 03:35 PM, Reimar Döffinger wrote: Since the values are floats, using the float operations makes sense, improves performance on some CPUs and makes the code SSE compatible instead of needing SSE2.

Re: [libav-devel] [PATCH] Revert AAC SBR: group some writes.

2012-03-07 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Wed, Mar 7, 2012 at 11:14 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Wed, Mar 07, 2012 at 10:52:33AM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com This reverts commit

Re: [libav-devel] [PATCH] Revert AAC SBR: group some writes.

2012-03-07 Thread Ronald S. Bultje
Hi, 2012/3/7 Måns Rullgård m...@mansr.com: Ronald S. Bultje rsbul...@gmail.com writes: On Wed, Mar 7, 2012 at 11:14 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Wed, Mar 07, 2012 at 10:52:33AM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com This reverts

[libav-devel] [PATCH] wma: fix off-by-one in array bounds check.

2012-03-07 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/wmadec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wmadec.c b/libavcodec/wmadec.c index 37feca1..a730059 100644 ---

Re: [libav-devel] [PATCH] Revert AAC SBR: group some writes.

2012-03-07 Thread Jason Garrett-Glaser
On Wed, Mar 7, 2012 at 2:13 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, 2012/3/7 Måns Rullgård m...@mansr.com: Ronald S. Bultje rsbul...@gmail.com writes: On Wed, Mar 7, 2012 at 11:14 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Wed, Mar 07, 2012 at 10:52:33AM -0800,

[libav-devel] [PATCH] Fix uninitialized reads on malformed ogg files.

2012-03-07 Thread dalecurtis
From: Dale Curtis dalecur...@chromium.org The ogg decoder wasn't padding the input buffer with the appropriate FF_INPUT_BUFFER_PADDING_SIZE bytes. Which led to uninitialized reads in various pieces of parsing code when they thought they had more data than they actually did. Signed-off-by: Dale

Re: [libav-devel] [PATCH] Fix uninitialized reads on malformed ogg files.

2012-03-07 Thread Dale Curtis
My original patch missed two allocations, the new one gets them all. Thanks in advance. - dale On Wed, Mar 7, 2012 at 2:26 PM, dalecur...@chromium.org wrote: From: Dale Curtis dalecur...@chromium.org The ogg decoder wasn't padding the input buffer with the appropriate

Re: [libav-devel] Multichannel WMA Lossless?

2012-03-07 Thread Måns Rullgård
Sean McGovern gsean...@gmail.com writes: On Wed, Mar 7, 2012 at 4:48 PM, Mike Melanson m...@multimedia.cx wrote: On 3/8/2012 12:54 AM, Mike Melanson wrote: WMA lossless supports up to 8 channels and our new decoder apparently has support. Do we have any multichannel samples (going up to 6

Re: [libav-devel] [PATCH] Revert AAC SBR: group some writes.

2012-03-07 Thread Måns Rullgård
Jason Garrett-Glaser ja...@x264.com writes: On Wed, Mar 7, 2012 at 2:13 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, 2012/3/7 Måns Rullgård m...@mansr.com: Ronald S. Bultje rsbul...@gmail.com writes: On Wed, Mar 7, 2012 at 11:14 AM, Kostya Shishkov kostya.shish...@gmail.com wrote:

Re: [libav-devel] [PATCH] wma: fix off-by-one in array bounds check.

2012-03-07 Thread Luca Barbato
On 07/03/12 14:18, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/wmadec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wmadec.c

[libav-devel] [PATCH] vorbisdec: avoid invalid memory access

2012-03-07 Thread Luca Barbato
From: Aaron Colwell acolw...@chromium.org This fixes some invalid memory access caused later in the function by res_chan[] not being set for all channels. This happens when a channel doesn't appear a submap. This change simply returns a decoder error when this situation is detected. --- Changed

[libav-devel] [PATCH] rtpenc: Fix the AVRational used for av_rescale_q_rnd

2012-03-07 Thread Martin Storsjö
The current one has a zero denominator - this is what was intended in 14aecc50fae6. --- libavformat/rtpenc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/rtpenc.c b/libavformat/rtpenc.c index 787eba8..5df25e4 100644 --- a/libavformat/rtpenc.c +++

Re: [libav-devel] [PATCH] vorbisdec: avoid invalid memory access

2012-03-07 Thread Aaron Colwell
I believe AVERROR_INVALIDDATA is correct given my understanding of the Vorbis spec. I think all channels must be represented in the submap. Aaron On Wed, Mar 7, 2012 at 2:51 PM, Luca Barbato lu_z...@gentoo.org wrote: From: Aaron Colwell acolw...@chromium.org This fixes some invalid memory

Re: [libav-devel] [PATCH] configure: Change dylib install names to include major version

2012-03-07 Thread Gil Pedersen
On 07/03/2012, at 18.50, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: On Wed, Mar 07, 2012 at 04:50:24PM +, Måns Rullgård wrote: Gil Pedersen g...@cmi.aau.dk writes: --- a/configure +++ b/configure @@ -2462,12 +2462,12 @@ case $target_os in enable

Re: [libav-devel] [PATCH] rtpenc: Fix the AVRational used for av_rescale_q_rnd

2012-03-07 Thread Luca Barbato
On 07/03/12 14:53, Martin Storsjö wrote: The current one has a zero denominator - this is what was intended in 14aecc50fae6. --- libavformat/rtpenc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/rtpenc.c b/libavformat/rtpenc.c index

  1   2   >