On Wed, Aug 1, 2012 at 1:03 AM, Loren Merritt lor...@u.washington.eduwrote:
On Wed, 1 Aug 2012, Luca Barbato wrote:
+%macro OP_MOVH_MMX 3
+movh %3, %2
+pavgb %1, %3
+movh %2, %1
+%endmacro
+
+%macro MOVH_MMX 3
+movh %2, %1
+%endmacro
+
+%macro
---
libavcodec/api-example.c | 137 --
1 file changed, 120 insertions(+), 17 deletions(-)
diff --git a/libavcodec/api-example.c b/libavcodec/api-example.c
index 93d6c22..bef15dd 100644
--- a/libavcodec/api-example.c
+++ b/libavcodec/api-example.c
@@
On 08/01/2012 07:14 AM, Daniel Kang wrote:
On Wed, Aug 1, 2012 at 1:03 AM, Daniel Kang daniel.d.k...@gmail.com wrote:
On Wed, Aug 1, 2012 at 12:57 AM, Loren Merritt
lor...@u.washington.eduwrote:
libavcodec/x86/dsputil_mmx_avg_template.c:58:1: warning:
`put_pixels4_l2_3dnow' defined but
Ronald S. Bultje rsbul...@gmail.com writes:
From: Ronald S. Bultje rsbul...@gmail.com
---
libavcodec/dct-test.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/dct-test.c b/libavcodec/dct-test.c
index 5046544..9e19e0c 100644
--- a/libavcodec/dct-test.c
On 08/01/2012 05:30 AM, Ronald S. Bultje wrote:
From: Ronald S. Bultje rsbul...@gmail.com
---
libavcodec/dct-test.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/dct-test.c b/libavcodec/dct-test.c
index 5046544..9e19e0c 100644
---
Ronald S. Bultje g...@libav.org writes:
Module: libav
Branch: master
Commit: ddbe71b44fc810cc39b576bf0047f89090cfabcb
Author:Ronald S. Bultje rsbul...@gmail.com
Committer: Ronald S. Bultje rsbul...@gmail.com
Date: Tue Jul 31 20:30:29 2012 -0700
dct-test: allow to compile
Luca Barbato lu_z...@gentoo.org writes:
On 08/01/2012 05:30 AM, Ronald S. Bultje wrote:
From: Ronald S. Bultje rsbul...@gmail.com
---
libavcodec/dct-test.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/dct-test.c b/libavcodec/dct-test.c
index
On 08/01/2012 11:12 AM, Måns Rullgård wrote:
Luca Barbato lu_z...@gentoo.org writes:
On 08/01/2012 05:30 AM, Ronald S. Bultje wrote:
From: Ronald S. Bultje rsbul...@gmail.com
---
libavcodec/dct-test.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Wed, Aug 01, 2012 at 10:12:01AM +0100, Måns Rullgård wrote:
Luca Barbato lu_z...@gentoo.org writes:
On 08/01/2012 05:30 AM, Ronald S. Bultje wrote:
From: Ronald S. Bultje rsbul...@gmail.com
---
libavcodec/dct-test.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 08/01/2012 11:11 AM, Måns Rullgård wrote:
Ronald S. Bultje g...@libav.org writes:
Module: libav
Branch: master
Commit: ddbe71b44fc810cc39b576bf0047f89090cfabcb
Author:Ronald S. Bultje rsbul...@gmail.com
Committer: Ronald S. Bultje rsbul...@gmail.com
Date: Tue Jul 31 20:30:29
Daniel Kang daniel.d.k...@gmail.com writes:
Can I have access to a setup that doesn't have inlined assembly?
--extra-cflags=-D__asm__=error should make it fail nicely.
--
Måns Rullgård
m...@mansr.com
___
libav-devel mailing list
On Wed, Aug 1, 2012 at 12:34 AM, Derek Buitenhuis
derek.buitenh...@gmail.com wrote:
On 31/07/2012 12:17 PM, Samuel Pitoiset wrote:
+if (memcmp(pkt-data, \002, 1)) {
+av_log(s, AV_LOG_ERROR, No string method found in invoke
packet\n);
+return AVERROR_INVALIDDATA;
+}
---
libavformat/rtmppkt.c | 45 +
libavformat/rtmppkt.h | 42 ++
2 files changed, 87 insertions(+)
diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c
index 4ce238d..8228e28 100644
---
On Tue, Jul 31, 2012 at 9:22 PM, Luca Barbato lu_z...@gentoo.org wrote:
On 07/31/2012 06:16 PM, Samuel Pitoiset wrote:
+if ((ret = find_tracked_method(rt, pkt_id, tracked_method)) 0) {
+/* Ignore this reply when the method is not tracked. */
+return 0;
+
Luca Barbato lu_z...@gentoo.org writes:
On 08/01/2012 11:12 AM, Måns Rullgård wrote:
Luca Barbato lu_z...@gentoo.org writes:
On 08/01/2012 05:30 AM, Ronald S. Bultje wrote:
From: Ronald S. Bultje rsbul...@gmail.com
---
libavcodec/dct-test.c |2 +-
1 file changed, 1 insertion(+), 1
---
libavcodec/dca.c|2 +-
libavcodec/dca.h|2 +-
libavcodec/dca_parser.c |2 +-
libavcodec/dcadec.c |2 +-
libavformat/spdifenc.c |2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavcodec/dca.c b/libavcodec/dca.c
index
On Wed, Aug 01, 2012 at 11:29:40AM +0200, Diego Biurrun wrote:
---
libavcodec/dca.c|2 +-
libavcodec/dca.h|2 +-
libavcodec/dca_parser.c |2 +-
libavcodec/dcadec.c |2 +-
libavformat/spdifenc.c |2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
---
libavformat/rtmpproto.c | 278
1 file changed, 161 insertions(+), 117 deletions(-)
diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index 4a35319..6044425 100644
--- a/libavformat/rtmpproto.c
+++ b/libavformat/rtmpproto.c
@@
---
libavformat/rtmpproto.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index 6044425..8c0ecb2 100644
--- a/libavformat/rtmpproto.c
+++ b/libavformat/rtmpproto.c
@@ -1038,7 +1038,11 @@ static int
On 08/01/2012 11:27 AM, Måns Rullgård wrote:
You're supposed to actually *read* patches before approving them.
Agreed as I said, I overlooked it.
lu
--
Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero
___
libav-devel mailing list
These functions are not faster than other mmx implementations on
any hardware I have been able to test on, and they are horribly
inaccurate. There is thus no reason to ever use them.
Signed-off-by: Mans Rullgard m...@mansr.com
---
libavcodec/dct-test.c| 4 -
libavcodec/options_table.h
On Tue, Jul 31, 2012 at 04:33:37PM -0700, Ronald S. Bultje wrote:
On Tue, Jul 31, 2012 at 3:17 PM, Diego Biurrun di...@biurrun.de wrote:
---
libavcodec/x86/vp8dsp.asm | 143
+
1 files changed, 66 insertions(+), 77 deletions(-)
This is
On Wed, Aug 01, 2012 at 12:15:05PM +0100, Mans Rullgard wrote:
These functions are not faster than other mmx implementations on
any hardware I have been able to test on, and they are horribly
inaccurate. There is thus no reason to ever use them.
Signed-off-by: Mans Rullgard m...@mansr.com
Hi,
I have a disagreement with Diego about generating doxygen docs.
Currently we generate doxygen for all files in Libav, which IMO leads to
horribly cluttered output.
See e.g.
https://libav.org/doxygen/master/files.html
https://libav.org/doxygen/master/annotated.html
---
libavcodec/x86/vp8dsp.asm | 141 +
1 files changed, 53 insertions(+), 88 deletions(-)
diff --git a/libavcodec/x86/vp8dsp.asm b/libavcodec/x86/vp8dsp.asm
index e0041ec..9d1a9fd 100644
--- a/libavcodec/x86/vp8dsp.asm
+++ b/libavcodec/x86/vp8dsp.asm
On Wed, Aug 01, 2012 at 12:15:05PM +0100, Mans Rullgard wrote:
These functions are not faster than other mmx implementations on
any hardware I have been able to test on, and they are horribly
inaccurate. There is thus no reason to ever use them.
Signed-off-by: Mans Rullgard m...@mansr.com
---
libavcodec/x86/fft_mmx.asm| 19 ---
libavcodec/x86/fmtconvert.asm | 17 ++---
libavutil/x86/x86util.asm | 12
3 files changed, 18 insertions(+), 30 deletions(-)
diff --git a/libavcodec/x86/fft_mmx.asm b/libavcodec/x86/fft_mmx.asm
index
On 8/1/2012 5:48 PM, an...@khirnov.net wrote:
[...]
If there indeed are people who read generated doxy for non-public API,
s/ for non-public API// ;P
I'd like them to speak up and prove their existence.
Speaking as a user, I just open the header file and read the relevant
part. (Also from
On 2012-08-01 01:33:47 +0200, Diego Biurrun wrote:
On Wed, Aug 01, 2012 at 12:00:58AM +0100, Måns Rullgård wrote:
Ronald S. Bultje rsbul...@gmail.com writes:
On Tue, Jul 31, 2012 at 3:17 PM, Diego Biurrun di...@biurrun.de wrote:
[..]
The most important thing is missing: why?
Reordering the members in this struct reduces the holes required
to maintain alignment. With this order, the only remaining, and
unavoidable, hole is 3 bytes following left_nnz.
Signed-off-by: Mans Rullgard m...@mansr.com
---
libavcodec/vp8.h | 34 +-
1 file
On 2012-08-01 00:17:25 +0200, Diego Biurrun wrote:
Currently there is a wild mix of 3dn2/3dnow2/3dnowext. Switching to
3dnowext, which is the actual name of the CPU flag unifies this.
define actual name it is the same name as the linux kernel reports
in /proc/cpuinfo which is also just a name
On Wed, Aug 01, 2012 at 02:01:11PM +0100, Mans Rullgard wrote:
Reordering the members in this struct reduces the holes required
to maintain alignment. With this order, the only remaining, and
unavoidable, hole is 3 bytes following left_nnz.
Signed-off-by: Mans Rullgard m...@mansr.com
---
On 2012-08-01 14:01:11 +0100, Måns Rullgård wrote:
Reordering the members in this struct reduces the holes required
to maintain alignment. With this order, the only remaining, and
unavoidable, hole is 3 bytes following left_nnz.
Signed-off-by: Mans Rullgard m...@mansr.com
---
On Wed, Aug 01, 2012 at 02:46:36PM +0200, Janne Grunau wrote:
On 2012-08-01 01:33:47 +0200, Diego Biurrun wrote:
On Wed, Aug 01, 2012 at 12:00:58AM +0100, Måns Rullgård wrote:
Ronald S. Bultje rsbul...@gmail.com writes:
On Tue, Jul 31, 2012 at 3:17 PM, Diego Biurrun di...@biurrun.de
Currently there is a wild mix of 3dn2/3dnow2/3dnowext. Switching to
3dnowext, which is a more common name of the CPU flag, as reported
e.g. by the Linux kernel, unifies this.
---
libavcodec/x86/dsputil_mmx.c| 14 ++--
libavcodec/x86/fft.c|6 ++--
This allows building dct-test even if aandcttab.o is not pulled in
by any enabled codec. The DCT with which these tables are used does
not use them directly, so building it without the tables is possible.
Signed-off-by: Mans Rullgard m...@mansr.com
---
libavcodec/Makefile | 2 +-
1 file
On Wed, Aug 01, 2012 at 02:32:24PM +0100, Mans Rullgard wrote:
This allows building dct-test even if aandcttab.o is not pulled in
by any enabled codec. The DCT with which these tables are used does
not use them directly, so building it without the tables is possible.
Signed-off-by: Mans
On Wed, Aug 01, 2012 at 02:32:24PM +0100, Mans Rullgard wrote:
This allows building dct-test even if aandcttab.o is not pulled in
by any enabled codec. The DCT with which these tables are used does
not use them directly, so building it without the tables is possible.
---
libavcodec/Makefile
On 2012-08-01 15:24:37 +0200, Diego Biurrun wrote:
On Wed, Aug 01, 2012 at 02:46:36PM +0200, Janne Grunau wrote:
On 2012-08-01 01:33:47 +0200, Diego Biurrun wrote:
On Wed, Aug 01, 2012 at 12:00:58AM +0100, Måns Rullgård wrote:
Ronald S. Bultje rsbul...@gmail.com writes:
On Tue, Jul
On Wed, Aug 01, 2012 at 04:04:50PM +0200, Janne Grunau wrote:
On 2012-08-01 15:24:37 +0200, Diego Biurrun wrote:
On Wed, Aug 01, 2012 at 02:46:36PM +0200, Janne Grunau wrote:
On 2012-08-01 01:33:47 +0200, Diego Biurrun wrote:
On Wed, Aug 01, 2012 at 12:00:58AM +0100, Måns Rullgård wrote:
On 08/01/2012 07:48 AM, an...@khirnov.net wrote:
Hi,
I have a disagreement with Diego about generating doxygen docs.
Currently we generate doxygen for all files in Libav, which IMO leads to
horribly cluttered output.
See e.g.
https://libav.org/doxygen/master/files.html
On 07/31/2012 06:17 PM, Diego Biurrun wrote:
---
libavcodec/x86/h264_intrapred.asm | 27 ---
libavcodec/x86/h264_intrapred_10bit.asm | 16
libavcodec/x86/h264_qpel_10bit.asm |4
libavutil/x86/x86util.asm | 16
Hi,
On Wed, Aug 1, 2012 at 6:24 AM, Diego Biurrun di...@biurrun.de wrote:
On Wed, Aug 01, 2012 at 02:46:36PM +0200, Janne Grunau wrote:
On 2012-08-01 01:33:47 +0200, Diego Biurrun wrote:
On Wed, Aug 01, 2012 at 12:00:58AM +0100, Måns Rullgård wrote:
Ronald S. Bultje rsbul...@gmail.com
On 07/31/2012 06:17 PM, Diego Biurrun wrote:
---
libavcodec/x86/vc1dsp_yasm.asm |3 ---
libavutil/x86/x86util.asm | 22 ++
2 files changed, 10 insertions(+), 15 deletions(-)
patch looks fine.
But I think ideally PABSW should be merged with ABS1. It's quite
Hi,
On Wed, Aug 1, 2012 at 5:08 AM, Diego Biurrun di...@biurrun.de wrote:
+FILTER_BILINEAR 8, 7, m2
INIT_MMX ssse3
-FILTER_BILINEAR_SSSE3 4
+FILTER_BILINEAR 4, 7, m2
INIT_XMM ssse3
-FILTER_BILINEAR_SSSE3 8
+FILTER_BILINEAR 8, 5, m1
So, uhm, we should probably discuss this on IRC before
Hi,
On Wed, Aug 1, 2012 at 5:30 AM, Diego Biurrun di...@biurrun.de wrote:
---
libavcodec/x86/fft_mmx.asm| 19 ---
libavcodec/x86/fmtconvert.asm | 17 ++---
libavutil/x86/x86util.asm | 12
3 files changed, 18 insertions(+), 30
---
libavresample/x86/audio_convert.asm| 51
libavresample/x86/audio_convert_init.c | 15 +
libavresample/x86/util.asm |6
3 files changed, 72 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
---
libavresample/x86/audio_convert.asm| 40
libavresample/x86/audio_convert_init.c | 13 ++
2 files changed, 53 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index
---
libavresample/x86/audio_convert.asm| 47
libavresample/x86/audio_convert_init.c |9 ++
2 files changed, 56 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index
---
libavresample/x86/audio_convert.asm| 33
libavresample/x86/audio_convert_init.c |9
2 files changed, 42 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index
chunk_size is unsigned 32-bit, but av_get_packet() takes a signed int as the
packet size.
---
libavformat/idcin.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/libavformat/idcin.c b/libavformat/idcin.c
index 6a9b0ca..3acbc92 100644
--- a/libavformat/idcin.c
+++
When streaming live streams using the Akamai, Edgecast or Limelight CDN,
players cannot simply connect to the live stream. Instead, they have to
subscribe to it, by sending an FC Subscribe call to the server.
---
libavformat/rtmpproto.c | 28
1 file changed, 28
This option specifies the name of live stream to subscribe.
Defaults to rtmp_playpath.
---
doc/protocols.texi | 3 +++
libavformat/rtmpproto.c | 9 +++--
libavformat/version.h | 2 +-
3 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/doc/protocols.texi
On 01/08/2012 6:13 AM, Samuel Pitoiset wrote:
---
libavformat/rtmpproto.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
Looks OK, but I have no idea where the magic numbers come from
for this or the lines following it. Perhaps you can add comments
in a separate patch?
- Derek
On Wed, Aug 01, 2012 at 07:36:09AM -0700, Ronald S. Bultje wrote:
On Wed, Aug 1, 2012 at 6:24 AM, Diego Biurrun di...@biurrun.de wrote:
On Wed, Aug 01, 2012 at 02:46:36PM +0200, Janne Grunau wrote:
On 2012-08-01 01:33:47 +0200, Diego Biurrun wrote:
On Wed, Aug 01, 2012 at 12:00:58AM +0100,
Signed-off-by: Mans Rullgard m...@mansr.com
---
libavcodec/vc1dec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c
index c6cbfc1..e36cc0d 100644
--- a/libavcodec/vc1dec.c
+++ b/libavcodec/vc1dec.c
@@ -36,7 +36,6 @@
#include vc1acdata.h
#include
---
libavcodec/x86/h264_intrapred.asm | 27 ---
libavcodec/x86/h264_intrapred_10bit.asm | 16
libavcodec/x86/h264_qpel_10bit.asm |4
libavutil/x86/x86util.asm | 16
libswscale/x86/output.asm
On Wed, Aug 01, 2012 at 11:31:23AM -0400, Justin Ruggles wrote:
chunk_size is unsigned 32-bit, but av_get_packet() takes a signed int as the
packet size.
---
libavformat/idcin.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/libavformat/idcin.c
On Wed, Aug 1, 2012 at 6:09 PM, Derek Buitenhuis
derek.buitenh...@gmail.com wrote:
On 01/08/2012 6:13 AM, Samuel Pitoiset wrote:
---
libavformat/rtmpproto.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
Looks OK, but I have no idea where the magic numbers come from
for this or
On Wed, Aug 01, 2012 at 05:15:47PM +0100, Mans Rullgard wrote:
Signed-off-by: Mans Rullgard m...@mansr.com
---
libavcodec/vc1dec.c | 1 -
1 file changed, 1 deletion(-)
OK
Diego
___
libav-devel mailing list
libav-devel@libav.org
From: Ronald S. Bultje rsbul...@gmail.com
This reverts commit ddbe71b44fc810cc39b576bf0047f89090cfabcb.
I forgot to remove it from my tree before pushing another patch.
---
libavcodec/dct-test.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/dct-test.c
---
libavcodec/x86/dct32_sse.asm | 74 ++---
1 files changed, 25 insertions(+), 49 deletions(-)
diff --git a/libavcodec/x86/dct32_sse.asm b/libavcodec/x86/dct32_sse.asm
index 20a5c7b..65fac09 100644
--- a/libavcodec/x86/dct32_sse.asm
+++
On Wed, Aug 01, 2012 at 07:15:13PM +0200, Kostya Shishkov wrote:
On Wed, Aug 01, 2012 at 09:30:33AM -0700, Ronald S. Bultje wrote:
From: Ronald S. Bultje rsbul...@gmail.com
This reverts commit ddbe71b44fc810cc39b576bf0047f89090cfabcb.
I forgot to remove it from my tree before pushing
On 08/01/2012 02:35 AM, Anton Khirnov wrote:
---
libavcodec/api-example.c | 137
--
1 file changed, 120 insertions(+), 17 deletions(-)
LGTM
-Justin
___
libav-devel mailing list
libav-devel@libav.org
On 08/01/2012 12:18 PM, Diego Biurrun wrote:
---
libavcodec/x86/h264_intrapred.asm | 27 ---
libavcodec/x86/h264_intrapred_10bit.asm | 16
libavcodec/x86/h264_qpel_10bit.asm |4
libavutil/x86/x86util.asm | 16
On 01/08/2012 12:27 PM, Samuel Pitoiset wrote:
0x02 is a magic number defined in the rtmp specification which
indicates that data is string.
I don't think a comment is needed here because it's already specified
in the error message.
OK.
- Derek
___
At the moment it only does BGR24, but I plan to add the rest after.
Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com
---
Changelog |1 +
doc/general.texi |1 +
libavcodec/Makefile|1 +
libavcodec/allcodecs.c |1 +
libavcodec/avcodec.h |1 +
---
libavcodec/x86/fft_mmx.asm| 13 -
libavcodec/x86/fmtconvert.asm | 17 ++---
libavutil/x86/x86util.asm | 12
3 files changed, 14 insertions(+), 28 deletions(-)
diff --git a/libavcodec/x86/fft_mmx.asm b/libavcodec/x86/fft_mmx.asm
index
Hi,
On Wed, Aug 1, 2012 at 10:53 AM, Diego Biurrun di...@biurrun.de wrote:
--- a/libavcodec/x86/fft_mmx.asm
[..]
-%elifidn %1, %2
-movd [r0+12], %1
-punpckhdq %1, [r0+8]
-%else
If you remove this macro from this file, the callers with %1==%2 need
to use the code directly, or call a
Hi,
On Wed, Jul 25, 2012 at 10:35 PM, Måns Rullgård m...@mansr.com wrote:
Luca Barbato lu_z...@gentoo.org writes:
From: Ronald S. Bultje rsbul...@gmail.com
---
Here my initial twist about it, ideally I'd consider moving os_support
in libavu and include it automagically from config.h
On Wed, Aug 01, 2012 at 01:50:32PM -0400, Derek Buitenhuis wrote:
At the moment it only does BGR24, but I plan to add the rest after.
Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com
---
Changelog |1 +
doc/general.texi |1 +
libavcodec/Makefile|
On Wed, Aug 01, 2012 at 01:50:32PM -0400, Derek Buitenhuis wrote:
diff --git a/libavcodec/version.h b/libavcodec/version.h
index acad4d4..a74b0ad 100644
--- a/libavcodec/version.h
+++ b/libavcodec/version.h
@@ -27,7 +27,7 @@
*/
#define LIBAVCODEC_VERSION_MAJOR 54
-#define
At the moment it only does BGR24, but I plan to add the rest after.
Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com
---
Changelog |1 +
doc/general.texi |1 +
libavcodec/Makefile|1 +
libavcodec/allcodecs.c |1 +
libavcodec/avcodec.h |1 +
Luca Barbato lu_z...@gentoo.org writes:
+#if !HAVE_SNPRINTF
+#ifdef _MSC_VER
+#define vsnprintf _vsnprintf
+#endif
+
+int snprintf(char *buffer, size_t bufsize, const char *fmt, ...)
+{
+va_list ap;
+int ret;
+
+if ((int)bufsize = 0) return -1;
+va_start(ap, fmt);
+
On Wed, Aug 01, 2012 at 02:46:53PM -0400, Derek Buitenhuis wrote:
At the moment it only does BGR24, but I plan to add the rest after.
Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com
---
Changelog |1 +
doc/general.texi |1 +
libavcodec/Makefile|
Hi,
On Wed, Aug 1, 2012 at 11:58 AM, Måns Rullgård m...@mansr.com wrote:
Luca Barbato lu_z...@gentoo.org writes:
+#if !HAVE_SNPRINTF
+#ifdef _MSC_VER
+#define vsnprintf _vsnprintf
+#endif
+
+int snprintf(char *buffer, size_t bufsize, const char *fmt, ...)
+{
+va_list ap;
+int
+/* the codec gives us the frame size, in samples,
+ * we calculate the size of the samples buffer in bytes */
+buffer_size = av_samples_get_buffer_size(NULL, c-channels,
c-frame_size,
+ c-sample_fmt, 0);
+samples =
On Thu, 2012-07-26 at 07:32 +0200, Luca Barbato wrote:
+int snprintf(char *buffer, size_t bufsize, const char *fmt, ...)
+{
+va_list ap;
+int ret;
+
+if ((int)bufsize = 0) return -1;
bufsize == 0 is valid.
+ret = vsnprintf(buffer, bufsize-1, fmt, ap);
IIRC MSVC (or the C
Ronald S. Bultje rsbul...@gmail.com writes:
Hi,
On Wed, Aug 1, 2012 at 11:58 AM, Måns Rullgård m...@mansr.com wrote:
Luca Barbato lu_z...@gentoo.org writes:
+#if !HAVE_SNPRINTF
+#ifdef _MSC_VER
+#define vsnprintf _vsnprintf
+#endif
+
+int snprintf(char *buffer, size_t bufsize, const
Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com
---
libavcodec/eamad.c |9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/libavcodec/eamad.c b/libavcodec/eamad.c
index ca74393..d7e65db 100644
--- a/libavcodec/eamad.c
+++ b/libavcodec/eamad.c
@@ -57,13 +57,6
Ronald S. Bultje rsbul...@gmail.com writes:
Hi,
On Wed, Aug 1, 2012 at 11:58 AM, Måns Rullgård m...@mansr.com wrote:
Luca Barbato lu_z...@gentoo.org writes:
+#if !HAVE_SNPRINTF
+#ifdef _MSC_VER
+#define vsnprintf _vsnprintf
+#endif
+
+int snprintf(char *buffer, size_t bufsize, const
Uoti Urpala uoti.urp...@pp1.inet.fi writes:
On Thu, 2012-07-26 at 07:32 +0200, Luca Barbato wrote:
+int snprintf(char *buffer, size_t bufsize, const char *fmt, ...)
+{
+va_list ap;
+int ret;
+
+if ((int)bufsize = 0) return -1;
bufsize == 0 is valid.
Of course zero is a
On Wed, 2012-08-01 at 21:22 +0100, Måns Rullgård wrote:
+int snprintf(char *buffer, size_t bufsize, const char *fmt, ...)
+if ((int)bufsize = 0) return -1;
If bufsize INT_MAX, that cast has unspecified behaviour.
No, it's implementation-defined (you're probably confusing it with
On 01/08/12 12:13, Samuel Pitoiset wrote:
---
libavformat/rtmpproto.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index 6044425..8c0ecb2 100644
--- a/libavformat/rtmpproto.c
+++ b/libavformat/rtmpproto.c
@@
On Wed, 2012-08-01 at 21:34 +0100, Måns Rullgård wrote:
Uoti Urpala uoti.urp...@pp1.inet.fi writes:
+ret = vsnprintf(buffer, bufsize-1, fmt, ap);
IIRC MSVC (or the C library) does not support all standard format
modifiers, so unless this vsnprintf comes from elsewhere, you need more
Uoti Urpala uoti.urp...@pp1.inet.fi writes:
On Wed, 2012-08-01 at 21:22 +0100, Måns Rullgård wrote:
+int snprintf(char *buffer, size_t bufsize, const char *fmt, ...)
+if ((int)bufsize = 0) return -1;
If bufsize INT_MAX, that cast has unspecified behaviour.
No, it's
On Wed, 1 Aug 2012 20:39:36 +0100, Kieran Kunhya kier...@ob-encoder.com wrote:
+/* the codec gives us the frame size, in samples,
+ * we calculate the size of the samples buffer in bytes */
+buffer_size = av_samples_get_buffer_size(NULL, c-channels,
c-frame_size,
+
Uoti Urpala uoti.urp...@pp1.inet.fi writes:
On Wed, 2012-08-01 at 21:34 +0100, Måns Rullgård wrote:
Uoti Urpala uoti.urp...@pp1.inet.fi writes:
+ret = vsnprintf(buffer, bufsize-1, fmt, ap);
IIRC MSVC (or the C library) does not support all standard format
modifiers, so unless this
On 01/08/12 12:12, Samuel Pitoiset wrote:
---
libavformat/rtmpproto.c | 278
1 file changed, 161 insertions(+), 117 deletions(-)
Seems better. Let me try it.
___
libav-devel mailing list
On 01/08/12 11:25, Jordi Ortiz wrote:
---
libavformat/rtmppkt.c | 45 +
libavformat/rtmppkt.h | 42 ++
2 files changed, 87 insertions(+)
Seems fine to me. I'd commit it tomorrow.
lu
On Wed, 2012-08-01 at 21:49 +0100, Måns Rullgård wrote:
Uoti Urpala uoti.urp...@pp1.inet.fi writes:
On Wed, 2012-08-01 at 21:22 +0100, Måns Rullgård wrote:
+int snprintf(char *buffer, size_t bufsize, const char *fmt, ...)
+if ((int)bufsize = 0) return -1;
If bufsize INT_MAX,
On 08/01/2012 04:22 PM, Derek Buitenhuis wrote:
Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com
---
libavcodec/eamad.c |9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/libavcodec/eamad.c b/libavcodec/eamad.c
index ca74393..d7e65db 100644
---
On Wed, 2012-08-01 at 21:55 +0100, Måns Rullgård wrote:
Uoti Urpala uoti.urp...@pp1.inet.fi writes:
On Wed, 2012-08-01 at 21:34 +0100, Måns Rullgård wrote:
It is not possible to get those semantics using the regular Windows
functions.
Of course it is, with enough workarounds (this is
---
libavcodec/idcinvideo.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libavcodec/idcinvideo.c b/libavcodec/idcinvideo.c
index c936ebb..65414ee 100644
--- a/libavcodec/idcinvideo.c
+++ b/libavcodec/idcinvideo.c
@@ -166,7 +166,7 @@ static av_cold int
Avoids using unsupported parameters and signed integer overflows.
---
libavformat/idcin.c | 19 +++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/libavformat/idcin.c b/libavformat/idcin.c
index 6a9b0ca..f278f42 100644
--- a/libavformat/idcin.c
+++
---
libavformat/idcin.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/libavformat/idcin.c b/libavformat/idcin.c
index f278f42..113c66e 100644
--- a/libavformat/idcin.c
+++ b/libavformat/idcin.c
@@ -170,6 +170,10 @@ static int idcin_read_header(AVFormatContext
Also, use 1 / sample_rate for audio stream time_base.
---
libavformat/idcin.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/libavformat/idcin.c b/libavformat/idcin.c
index c8b8225..0e93a59 100644
--- a/libavformat/idcin.c
+++ b/libavformat/idcin.c
@@ -82,6
---
libavformat/idcin.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/libavformat/idcin.c b/libavformat/idcin.c
index 0e93a59..638377c 100644
--- a/libavformat/idcin.c
+++ b/libavformat/idcin.c
@@ -292,6 +292,7 @@ static int idcin_read_packet(AVFormatContext *s,
---
libavformat/idcin.c | 21 -
1 files changed, 20 insertions(+), 1 deletions(-)
diff --git a/libavformat/idcin.c b/libavformat/idcin.c
index 638377c..67915e6 100644
--- a/libavformat/idcin.c
+++ b/libavformat/idcin.c
@@ -89,7 +89,7 @@ typedef struct IdcinDemuxContext {
chunk_size is unsigned 32-bit, but av_get_packet() takes a signed int as the
packet size.
---
libavformat/idcin.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/libavformat/idcin.c b/libavformat/idcin.c
index 67915e6..2d506ff 100644
--- a/libavformat/idcin.c
+++
1 - 100 of 122 matches
Mail list logo
