Re: [libav-devel] [PATCH] configure: Drop fastdiv option

2012-08-20 Thread Justin Ruggles
On 08/20/2012 06:54 PM, Diego Biurrun wrote: > There is no point in having the user disable any fastdiv macros. > Besides the condition implementation was broken and only disabled > the C implementation, but no platform specific assembly versions. > --- > configure |3 --- > libavuti

Re: [libav-devel] [PATCH] build: Make the E-AC-3 encoder select the AC-3 encoder

2012-08-20 Thread Justin Ruggles
On 08/20/2012 06:58 PM, Diego Biurrun wrote: > The E-AC-3 encoder depends on almost all of the code of the AC-3 > encoder, so it makes no sense to enable one without the other. > --- > configure |2 +- > libavcodec/Makefile |3 +-- > 2 files changed, 2 insertions(+), 3 deletions(

Re: [libav-devel] [PATCH 1/3] vorbisenc: use float planar sample format

2012-08-20 Thread Justin Ruggles
On 08/20/2012 05:37 PM, Benjamin Larsson wrote: > On 08/20/2012 07:37 PM, Justin Ruggles wrote: >> +const float * const *audio = frame ? (const float * const >> *)frame->extended_data : NULL; > > This looks insane. Yeah, I suppose we could just cast it to (float **) since extended_data doesn'

Re: [libav-devel] [PATCH] build: avcodec: order cosmetics

2012-08-20 Thread Måns Rullgård
Diego Biurrun writes: > --- > libavcodec/Makefile |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index 41f6be5..4fdf475 100644 > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -33,7 +33,6 @@ OBJS = allcodec

[libav-devel] [PATCH] svq1/svq3: Move common code out of SVQ1 decoder-specific file

2012-08-20 Thread Diego Biurrun
--- libavcodec/Makefile |5 +-- libavcodec/svq13.c | 68 ++ libavcodec/svq1dec.c | 45 - 3 files changed, 70 insertions(+), 48 deletions(-) create mode 100644 libavcodec/svq13.c diff --git a/libavcodec/Mak

[libav-devel] [PATCH] build: Factor out mpegaudio dependencies to CONFIG_MPEGAUDIO

2012-08-20 Thread Diego Biurrun
A new hidden config variable is added for the codecs that depend on the mpegaudio parts. Since all codecs depending on the new variable also depend on mpegaudiodsp, the new config variable subsumes that variable. --- configure | 30 ++-- libavcodec/Makefile

[libav-devel] [PATCH] build: avcodec: order cosmetics

2012-08-20 Thread Diego Biurrun
--- libavcodec/Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 41f6be5..4fdf475 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -33,7 +33,6 @@ OBJS = allcodecs.o

Re: [libav-devel] [PATCH 4/6] build: avcodec: order cosmetics

2012-08-20 Thread Måns Rullgård
Diego Biurrun writes: > On Tue, Aug 21, 2012 at 12:07:05AM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> > >> > --- a/libavcodec/Makefile >> > +++ b/libavcodec/Makefile >> > @@ -230,20 +230,20 @@ OBJS-$(CONFIG_MP2_ENCODER) += >> > mpegaudioenc.o mpegaudio.o \ >> >

Re: [libav-devel] [PATCH 4/6] build: avcodec: order cosmetics

2012-08-20 Thread Diego Biurrun
On Tue, Aug 21, 2012 at 12:07:05AM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > > > --- a/libavcodec/Makefile > > +++ b/libavcodec/Makefile > > @@ -230,20 +230,20 @@ OBJS-$(CONFIG_MP2_ENCODER) += > > mpegaudioenc.o mpegaudio.o \ > >

Re: [libav-devel] [PATCH] svq1: Move all common code out of decoder-specific file

2012-08-20 Thread Måns Rullgård
Diego Biurrun writes: > --- > libavcodec/Makefile |3 +-- > libavcodec/svq1.c| 45 + > libavcodec/svq1dec.c | 45 - > 3 files changed, 46 insertions(+), 47 deletions(-) > > diff --git a/libavcode

Re: [libav-devel] [PATCH 4/6] build: avcodec: order cosmetics

2012-08-20 Thread Måns Rullgård
Diego Biurrun writes: > --- > libavcodec/Makefile | 10 +- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index 2988b53..9dec62f 100644 > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -230,20 +230,20 @@ OBJS-

Re: [libav-devel] [PATCH 3/6] build: Factor out acelp dependencies to CONFIG_ACELP

2012-08-20 Thread Måns Rullgård
Diego Biurrun writes: > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index 0de644c..2988b53 100644 > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -33,6 +33,9 @@ OBJS = allcodecs.o > \ > # parts needed for many differ

Re: [libav-devel] [PATCH 1/6] build: avcodec: cosmetics: Reorder entries

2012-08-20 Thread Måns Rullgård
Diego Biurrun writes: > --- > libavcodec/Makefile |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index f8b67b8..95f6b1a 100644 > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -33,10 +33,10 @@ OBJS = allcodec

[libav-devel] [PATCH] svq1: Move all common code out of decoder-specific file

2012-08-20 Thread Diego Biurrun
--- libavcodec/Makefile |3 +-- libavcodec/svq1.c| 45 + libavcodec/svq1dec.c | 45 - 3 files changed, 46 insertions(+), 47 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile inde

[libav-devel] [PATCH] build: Make the E-AC-3 encoder select the AC-3 encoder

2012-08-20 Thread Diego Biurrun
The E-AC-3 encoder depends on almost all of the code of the AC-3 encoder, so it makes no sense to enable one without the other. --- configure |2 +- libavcodec/Makefile |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/configure b/configure index a0f02a5..449

[libav-devel] [PATCH 4/6] build: avcodec: order cosmetics

2012-08-20 Thread Diego Biurrun
--- libavcodec/Makefile | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 2988b53..9dec62f 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -230,20 +230,20 @@ OBJS-$(CONFIG_MP2_ENCODER) += mpeg

[libav-devel] [PATCH 6/6] configure: fix indentation

2012-08-20 Thread Diego Biurrun
--- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 048f67f..59f2f40 100755 --- a/configure +++ b/configure @@ -2894,7 +2894,7 @@ elif enabled sparc; then enabled vis && check_inline_asm vis '"pdist %f0, %f0, %f0"' -mc

[libav-devel] [PATCH 5/6] build: Factor out mpegaudio dependencies to CONFIG_MPEGAUDIO

2012-08-20 Thread Diego Biurrun
A new hidden config variable is added for the codecs that depend on the mpegaudio parts. Since all codecs depending on the new variable also depend on mpegaudiodsp, the new config variable subsumes that variable. --- configure | 30 ++-- libavcodec/Makefile

[libav-devel] [PATCH 2/6] build: Factor out celp dependencies to CONFIG_CELP

2012-08-20 Thread Diego Biurrun
A new hidden config variable is added for the codecs that depend on the celp parts. --- configure | 12 libavcodec/Makefile | 19 +++ 2 files changed, 15 insertions(+), 16 deletions(-) diff --git a/configure b/configure index 18f81e4..6bbe6e2 100755 ---

[libav-devel] [PATCH 3/6] build: Factor out acelp dependencies to CONFIG_ACELP

2012-08-20 Thread Diego Biurrun
A new hidden config variable is added for the codecs that depend on the acelp parts. --- configure |7 --- libavcodec/Makefile | 15 ++- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/configure b/configure index 6bbe6e2..931c300 100755 --- a/config

[libav-devel] [PATCH 1/6] build: avcodec: cosmetics: Reorder entries

2012-08-20 Thread Diego Biurrun
--- libavcodec/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index f8b67b8..95f6b1a 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -33,10 +33,10 @@ OBJS = allcodecs.o

[libav-devel] [PATCH] configure: Drop fastdiv option

2012-08-20 Thread Diego Biurrun
There is no point in having the user disable any fastdiv macros. Besides the condition implementation was broken and only disabled the C implementation, but no platform specific assembly versions. --- configure |3 --- libavutil/intmath.h |6 +- 2 files changed, 1 insertions(

Re: [libav-devel] [PATCH 3/3] vorbisenc: set AVCodecContext.bit_rate to 0

2012-08-20 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/3] vorbisenc: fix quality parameter

2012-08-20 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/3] vorbisenc: use float planar sample format

2012-08-20 Thread Benjamin Larsson
On 08/20/2012 07:37 PM, Justin Ruggles wrote: +const float * const *audio = frame ? (const float * const *)frame->extended_data : NULL; This looks insane. /Benjamin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailm

[libav-devel] [PATCH] http: Only send positive values for the byte range field

2012-08-20 Thread Samuel Pitoiset
RFC 2616 says that byte range specifications in HTTP apply to the sequence of bytes which start at zero. --- libavformat/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index ce4a508..ad38f63 100644 --- a/libavformat/http.c +++ b/l

Re: [libav-devel] [PATCH] fate: make Ut Video encoder tests use bitexact swscale flags

2012-08-20 Thread Måns Rullgård
Jan Ekström writes: > The failures on various architectures and compilers on the RGB(A) > tests seem to have been because of one-off YCbCr->RGB conversion > results. This should make the conversion results match on most if > not all code paths. > --- > tests/fate/utvideo.mak|

Re: [libav-devel] [PATCH] fate: make Ut Video encoder tests use bitexact swscale flags

2012-08-20 Thread Derek Buitenhuis
On 20/08/2012 2:16 PM, Jan Ekström wrote: > The failures on various architectures and compilers on the RGB(A) > tests seem to have been because of one-off YCbCr->RGB conversion > results. This should make the conversion results match on most if > not all code paths. I can confirm this fixes FATE o

[libav-devel] [PATCH] fate: make Ut Video encoder tests use bitexact swscale flags

2012-08-20 Thread Jan Ekström
The failures on various architectures and compilers on the RGB(A) tests seem to have been because of one-off YCbCr->RGB conversion results. This should make the conversion results match on most if not all code paths. --- tests/fate/utvideo.mak|2 +- tests/ref/fate/utvideoenc_rg

Re: [libav-devel] Optimization of decoders for MIPS.

2012-08-20 Thread Luca Barbato
On 8/20/12 1:29 PM, Babic, Nedeljko wrote: And finally, it is easier to maintain the code with inline assembly than the code with external assembly. We had the opposite experience with our codebase and we are actively pushing to reduce the inline assembly usage by converting the most of our i

[libav-devel] [PATCH 3/3] vorbisenc: set AVCodecContext.bit_rate to 0

2012-08-20 Thread Justin Ruggles
The Vorbis encoder is always VBR. --- libavcodec/vorbisenc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libavcodec/vorbisenc.c b/libavcodec/vorbisenc.c index a1461b6..9002351 100644 --- a/libavcodec/vorbisenc.c +++ b/libavcodec/vorbisenc.c @@ -1178,6 +1178,7 @@ static

[libav-devel] [PATCH 2/3] vorbisenc: fix quality parameter

2012-08-20 Thread Justin Ruggles
This generates output with bitrates similar to libvorbis for a given quality value. --- libavcodec/vorbisenc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vorbisenc.c b/libavcodec/vorbisenc.c index 6b92f84..a1461b6 100644 --- a/libavcodec/vorbisenc.c +++

[libav-devel] [PATCH 1/3] vorbisenc: use float planar sample format

2012-08-20 Thread Justin Ruggles
--- libavcodec/vorbisenc.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/libavcodec/vorbisenc.c b/libavcodec/vorbisenc.c index 4fd8c32..6b92f84 100644 --- a/libavcodec/vorbisenc.c +++ b/libavcodec/vorbisenc.c @@ -963,10 +963,10 @@ static int residu

Re: [libav-devel] [PATCH] x86: fmtconvert: port to cpuflags

2012-08-20 Thread Diego Biurrun
On Mon, Aug 20, 2012 at 11:14:08AM -0400, Justin Ruggles wrote: > On 08/09/2012 09:50 AM, Diego Biurrun wrote: > > -INIT_XMM > > -FLOAT_TO_INT16 sse2, 2 > > -INIT_MMX > > -FLOAT_TO_INT16 sse, 0 > > +INIT_XMM sse2 > > +FLOAT_TO_INT16 2 > > +INIT_MMX sse > > +FLOAT_TO_INT16 0 > > %define cvtps2pi pf

Re: [libav-devel] [PATCH] adpcm_swf: Use correct sample offsets when using trellis.

2012-08-20 Thread Kostya Shishkov
On Mon, Aug 20, 2012 at 12:21:37PM -0400, Justin Ruggles wrote: > Fixes invalid reads when encoding mono streams when trellis is used. > --- > libavcodec/adpcmenc.c |7 --- > 1 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c >

[libav-devel] [PATCH] adpcm_swf: Use correct sample offsets when using trellis.

2012-08-20 Thread Justin Ruggles
Fixes invalid reads when encoding mono streams when trellis is used. --- libavcodec/adpcmenc.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index 038dbf1..843b32f 100644 --- a/libavcodec/adpcmenc.c +++ b/libavcodec/adp

Re: [libav-devel] [PATCH] mpeg demuxer: discover streams on open

2012-08-20 Thread Måns Rullgård
Andrey Utkin writes: > This is trial fix, i am far from being sure i did it the right way. > The problem i try to solve is that mpeg (mpegps) demuxer does not try to > discover any elementary streams at read_header(). > The intention is to have VOB file elementary streams recognized without > a

Re: [libav-devel] [PATCH] x86: fmtconvert: port to cpuflags

2012-08-20 Thread Justin Ruggles
On 08/09/2012 09:50 AM, Diego Biurrun wrote: > -INIT_XMM > -FLOAT_TO_INT16 sse2, 2 > -INIT_MMX > -FLOAT_TO_INT16 sse, 0 > +INIT_XMM sse2 > +FLOAT_TO_INT16 2 > +INIT_MMX sse > +FLOAT_TO_INT16 0 > %define cvtps2pi pf2id > -FLOAT_TO_INT16 3dnow, 0 > +INIT_MMX 3dnow > +FLOAT_TO_INT16 0 > %undef cvtps

[libav-devel] [PATCH] mpeg demuxer: discover streams on open

2012-08-20 Thread Andrey Utkin
This is trial fix, i am far from being sure i did it the right way. The problem i try to solve is that mpeg (mpegps) demuxer does not try to discover any elementary streams at read_header(). The intention is to have VOB file elementary streams recognized without avformat_find_stream_info(), which

Re: [libav-devel] [PATCH] fate: fix utvideoenc tests

2012-08-20 Thread Diego Biurrun
On Mon, Aug 20, 2012 at 02:58:08PM +0100, Mans Rullgard wrote: > For some reason, the prerequisites have to be specified like this. > Make works in mysterious ways. > > Signed-off-by: Mans Rullgard > --- > tests/fate/utvideo.mak | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) OK if it

Re: [libav-devel] [PATCH] build: amrwb: Drop redundant lsp dependency declaration

2012-08-20 Thread Benjamin Larsson
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] fate: fix utvideoenc tests

2012-08-20 Thread Anton Khirnov
On Mon, 20 Aug 2012 14:58:08 +0100, Mans Rullgard wrote: > For some reason, the prerequisites have to be specified like this. > Make works in mysterious ways. > > Signed-off-by: Mans Rullgard > --- > tests/fate/utvideo.mak | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --g

[libav-devel] [PATCH] fate: fix utvideoenc tests

2012-08-20 Thread Mans Rullgard
For some reason, the prerequisites have to be specified like this. Make works in mysterious ways. Signed-off-by: Mans Rullgard --- tests/fate/utvideo.mak | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/fate/utvideo.mak b/tests/fate/utvideo.mak index 991072e..4d56e02 1

Re: [libav-devel] [PATCH 2/2] aacdec: add support for matrix mixdown

2012-08-20 Thread Justin Ruggles
On 08/19/2012 09:47 PM, Akihiro TSUKADA wrote: > Hi, Justin > thanks for the comment. > >> This is not how it should be done. The coefficients should be exported >> so that downmixing can be done at the user level using libavresample. > > I understand. > So the right way is adding those two param

Re: [libav-devel] Optimization of decoders for MIPS.

2012-08-20 Thread Måns Rullgård
"Babic, Nedeljko" writes: >> I notice that the patches are very large.  Even though the parts they >> contain are related, the sheer size makes them difficult to evaluate as >> review effort grows more than linearly with patch size.  So if you could >> split them into smaller parts that would red

Re: [libav-devel] Optimization of decoders for MIPS.

2012-08-20 Thread Diego Biurrun
On Mon, Aug 20, 2012 at 11:29:48AM +, Babic, Nedeljko wrote: > > I notice that the patches are very large.  Even though the parts they > > contain are related, the sheer size makes them difficult to evaluate as > > review effort grows more than linearly with patch size.  So if you could > > spl

Re: [libav-devel] [PATCH 2/3] mips/doc: add documentation regarding MIPS optimizations

2012-08-20 Thread Diego Biurrun
On Mon, Aug 20, 2012 at 11:50:00AM +, Babic, Nedeljko wrote: > Basically, it is not so important to us which license will be in headers. > We can use license suggested by Diego, or we can use the same license that is > used > in rest of Libav files and just add developers that worked on those

Re: [libav-devel] [PATCH 2/3] mips/doc: add documentation regarding MIPS optimizations

2012-08-20 Thread Babic, Nedeljko
Basically, it is not so important to us which license will be in headers. We can use license suggested by Diego, or we can use the same license that is used in rest of Libav files and just add developers that worked on those files, or we can use something else. You can suggest what form of lic

Re: [libav-devel] Optimization of decoders for MIPS.

2012-08-20 Thread Babic, Nedeljko
> I notice that the patches are very large.  Even though the parts they > contain are related, the sheer size makes them difficult to evaluate as > review effort grows more than linearly with patch size.  So if you could > split them into smaller parts that would reduce the effort to review and > i

[libav-devel] [PATCH 1/2 v6] Ut Video encoder

2012-08-20 Thread Jan Ekström
Move common code from utvideodec.c to new common files utvideo.c/h. - Slices work, but hardcoded to one for the time being. - All related colorspaces work. - Interlaced encoding is not yet supported. --- Changelog |1 + doc/general.texi|2 +- libavcodec/Makefile

Re: [libav-devel] [PATCH] x86: remove FASTDIV inline asm

2012-08-20 Thread Benjamin Larsson
On 08/18/2012 09:26 PM, Mans Rullgard wrote: GCC 4.3 and later do the right thing with the plain C code. Based on that patch is OK. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav