Re: [libav-devel] [PATCH 3/3] tak: demuxer, parser, and decoder

2012-12-07 Thread Kostya Shishkov
On Thu, Dec 06, 2012 at 05:06:58PM -0500, Justin Ruggles wrote: From: Paul B Mahol one...@gmail.com Signed-off-by: Paul B Mahol one...@gmail.com Signed-off-by: Justin Ruggles justin.rugg...@gmail.com --- - Changed commit message and Changelog as suggested - Handled frame metadata flag as

Re: [libav-devel] [PATCH 11/11] AAC SBR: use AVFloatDSPContext's vector_fmul

2012-12-07 Thread Luca Barbato
On 12/1/12 1:35 PM, Christophe Gisquet wrote: The improvement is really minor, but as the LC AAC decoder already requires it, it seems obvious to use it there too. Looks fine to me. lu ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH] cosmetics: Fix dropable -- droppable typo

2012-12-07 Thread Diego Biurrun
--- libavcodec/flvdec.c|7 --- libavcodec/h263dec.c |4 +++- libavcodec/h264.c | 36 ++-- libavcodec/mpegvideo.c |8 libavcodec/mpegvideo.h |2 +- libavcodec/vc1dec.c|2 +- 6 files changed, 31 insertions(+), 28

Re: [libav-devel] [PATCH 02/10] SBR DSP x86: implement SSE sum64x5

2012-12-07 Thread Diego Biurrun
On Fri, Dec 07, 2012 at 08:42:12AM +0100, Christophe Gisquet wrote: 2012/12/1 Christophe Gisquet christophe.gisq...@gmail.com: 2012/11/30 Loren Merritt lor...@u.washington.edu: LGTM. Corrected 2 vs 4-spaces tabs. The patch was ok'ed, is there a need for another review? No, I'm

Re: [libav-devel] [PATCH 02/10] SBR DSP x86: implement SSE sum64x5

2012-12-07 Thread Christophe Gisquet
2012/12/7 Diego Biurrun di...@biurrun.de: No, I'm queueing it, will push after tests pass. Note that the name of the CPU core is Penryn, not penrynn. In fact, after checking my facts, it is Arrandale, but indeed your spelling is the correct one. At that point, dropping altogether the CPU

Re: [libav-devel] [PATCH 01/10] SBR DSP x86: implement SSE sbr_hf_gen

2012-12-07 Thread Diego Biurrun
On Fri, Dec 07, 2012 at 08:46:54AM +0100, Christophe Gisquet wrote: 2012/12/2 Christophe Gisquet christophe.gisq...@gmail.com: movh generates a SSE2 movq instruction, so explicitly use movlps. Is there a need for another review? No, patch is pushed. Diego

[libav-devel] [PATCH] fate: cover-art: Add dependencies

2012-12-07 Thread Diego Biurrun
--- Add missing dependency on MJPEG decoder for the actual cover images. tests/fate/cover-art.mak | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/fate/cover-art.mak b/tests/fate/cover-art.mak index dadfcd8..d3b78ae 100644 ---

[libav-devel] [PATCH] configure: formatting cosmetics

2012-12-07 Thread Diego Biurrun
--- configure | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 3f67370..8fdc9d0 100755 --- a/configure +++ b/configure @@ -1950,13 +1950,17 @@ do_random(){ for opt do optval=${opt#*=} case $opt in -

Re: [libav-devel] [PATCH] cosmetics: Fix dropable -- droppable typo

2012-12-07 Thread Luca Barbato
On 12/7/12 10:33 AM, Diego Biurrun wrote: --- libavcodec/flvdec.c|7 --- libavcodec/h263dec.c |4 +++- libavcodec/h264.c | 36 ++-- libavcodec/mpegvideo.c |8 libavcodec/mpegvideo.h |2 +- libavcodec/vc1dec.c|

Re: [libav-devel] [PATCH] avpicture: Don't assume a valid pix fmt in avpicture_get_size

2012-12-07 Thread Martin Storsjö
On Fri, 7 Dec 2012, Janne Grunau wrote: On 2012-12-06 23:51:03 +0200, Martin Storsjö wrote: When called from the v4l2 input device, pix_fmt can be AV_PIX_FMT_NONE (for jpeg formats). Before 50ba57e0, this wasn't an issue for avpicture_get_size, but after that commit, this lead to crashes. ---

[libav-devel] [PATCH] avpicture: Don't assume a valid pix fmt in avpicture_get_size

2012-12-07 Thread Martin Storsjö
When called from the v4l2 input device, pix_fmt can be AV_PIX_FMT_NONE (for jpeg formats). Before 50ba57e0, this wasn't an issue for avpicture_get_size, but after that commit, this lead to crashes. --- Alternative approach as suggested by Janne. libavcodec/avpicture.c |2 ++ 1 file changed,

Re: [libav-devel] [PATCH] avpicture: Don't assume a valid pix fmt in avpicture_get_size

2012-12-07 Thread Janne Grunau
On 2012-12-07 12:45:03 +0200, Martin Storsjö wrote: When called from the v4l2 input device, pix_fmt can be AV_PIX_FMT_NONE (for jpeg formats). Before 50ba57e0, this wasn't an issue for avpicture_get_size, but after that commit, this lead to crashes. --- Alternative approach as suggested by

[libav-devel] [PATCH 1/1] cmdutils: align dimensions before adding edges

2012-12-07 Thread Janne Grunau
This allows us to use avcodec_get_edge_width() for the edge width without breaking svq1 fate-vsynth tests. --- cmdutils.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cmdutils.c b/cmdutils.c index 42029d5..c374114 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -1293,7

Re: [libav-devel] [PATCH] fate: cover-art: Add dependencies

2012-12-07 Thread Janne Grunau
On 2012-12-07 11:32:18 +0100, Diego Biurrun wrote: --- Add missing dependency on MJPEG decoder for the actual cover images. tests/fate/cover-art.mak | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/fate/cover-art.mak b/tests/fate/cover-art.mak

Re: [libav-devel] [PATCH 1/1] cmdutils: align dimensions before adding edges

2012-12-07 Thread Måns Rullgård
Janne Grunau janne-li...@jannau.net writes: This allows us to use avcodec_get_edge_width() for the edge width without breaking svq1 fate-vsynth tests. --- cmdutils.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cmdutils.c b/cmdutils.c index 42029d5..c374114

Re: [libav-devel] [PATCH] dsputil: modify scalarproduct_int16 to handle mod8 numbers of loops.

2012-12-07 Thread Måns Rullgård
Christophe Gisquet christophe.gisq...@gmail.com writes: 2012/11/27 Justin Ruggles justin.rugg...@gmail.com: The patch itself looks good. Only the neon version would need to be modified. The altivec version already handles multiples of 8. The (yet to be ported) tak decoder could also use

Re: [libav-devel] [PATCH 1/1] cmdutils: align dimensions before adding edges

2012-12-07 Thread Janne Grunau
On 2012-12-07 12:17:41 +, Måns Rullgård wrote: Janne Grunau janne-li...@jannau.net writes: This allows us to use avcodec_get_edge_width() for the edge width without breaking svq1 fate-vsynth tests. --- cmdutils.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

Re: [libav-devel] [PATCH 1/1] cmdutils: align dimensions before adding edges

2012-12-07 Thread Måns Rullgård
Janne Grunau janne-li...@jannau.net writes: On 2012-12-07 12:17:41 +, Måns Rullgård wrote: Janne Grunau janne-li...@jannau.net writes: This allows us to use avcodec_get_edge_width() for the edge width without breaking svq1 fate-vsynth tests. --- cmdutils.c | 5 +++-- 1 file

[libav-devel] [PATCH] rtpdec: Minor cosmetic cleanup

2012-12-07 Thread Martin Storsjö
--- libavformat/rtpdec.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavformat/rtpdec.c b/libavformat/rtpdec.c index a305dd6..1c9a9f9 100644 --- a/libavformat/rtpdec.c +++ b/libavformat/rtpdec.c @@ -62,12 +62,12 @@ static

[libav-devel] [PATCH] libvpxenc: Support forcing keyframes

2012-12-07 Thread Martin Storsjö
--- libavcodec/libvpxenc.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 9774d5a..17b9800 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -495,6 +495,7 @@ static int vp8_encode(AVCodecContext

[libav-devel] [PATCH] avcodec: Fix a typo in an option description

2012-12-07 Thread Martin Storsjö
--- libavcodec/options_table.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index 624239e..e4be72e 100644 --- a/libavcodec/options_table.h +++ b/libavcodec/options_table.h @@ -306,7 +306,7 @@ static const AVOption

Re: [libav-devel] [PATCH] avcodec: Fix a typo in an option description

2012-12-07 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: --- libavcodec/options_table.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) OK -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH] lavf: fix arithmetic overflows in avformat_seek_file()

2012-12-07 Thread Mans Rullgard
The values compared here can be more than INT64_MAX apart. Since the difference is always positive, converting to uint64_t before subtracting gives the correct result without overflows. Signed-off-by: Mans Rullgard m...@mansr.com --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1

[libav-devel] [PATCH 1/2] configure: Make protocols select instead of depend on networking code

2012-12-07 Thread Diego Biurrun
--- configure | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/configure b/configure index 9b84da1..2475d42 100755 --- a/configure +++ b/configure @@ -1696,11 +1696,9 @@ ffrtmpcrypt_protocol_deps_any=gcrypt nettle openssl

Re: [libav-devel] [PATCH] lavf: fix arithmetic overflows in avformat_seek_file()

2012-12-07 Thread Diego Biurrun
On Fri, Dec 07, 2012 at 01:54:02PM +, Mans Rullgard wrote: The values compared here can be more than INT64_MAX apart. Since the difference is always positive, converting to uint64_t before subtracting gives the correct result without overflows. --- a/libavformat/utils.c +++

Re: [libav-devel] [PATCH 1/2] configure: Make protocols select instead of depend on networking code

2012-12-07 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: --- configure | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/configure b/configure index 9b84da1..2475d42 100755 --- a/configure +++ b/configure @@ -1696,11 +1696,9 @@ ffrtmpcrypt_protocol_deps_any=gcrypt

[libav-devel] [PATCH] rtpdec: KR formatting and spelling cosmetics

2012-12-07 Thread Diego Biurrun
From: Martin Storsjö mar...@martin.st Signed-off-by: Diego Biurrun di...@biurrun.de --- Extended with a number of extra fixups ... libavformat/rtpdec.c | 211 ++ 1 files changed, 109 insertions(+), 102 deletions(-) diff --git

Re: [libav-devel] [PATCH] rtpdec: KR formatting and spelling cosmetics

2012-12-07 Thread Martin Storsjö
On Fri, 7 Dec 2012, Diego Biurrun wrote: From: Martin Storsjö mar...@martin.st Signed-off-by: Diego Biurrun di...@biurrun.de --- Extended with a number of extra fixups ... libavformat/rtpdec.c | 211 ++ 1 files changed, 109 insertions(+), 102

[libav-devel] [PATCH] configure: Make protocols select instead of depend on networking code

2012-12-07 Thread Diego Biurrun
--- Ahem ... :) configure | 20 +--- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/configure b/configure index 9b84da1..4940be9 100755 --- a/configure +++ b/configure @@ -1696,11 +1696,9 @@ ffrtmpcrypt_protocol_deps_any=gcrypt nettle openssl

Re: [libav-devel] [PATCH] avcodec: Fix a typo in an option description

2012-12-07 Thread Diego Biurrun
On Fri, Dec 07, 2012 at 03:50:49PM +0200, Martin Storsjö wrote: --- libavcodec/options_table.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I suggest to hold off on this spelling fix and collect more typo fixes into a larger batch so as to not clutter up the git log too much with

Re: [libav-devel] [PATCH] configure: Make protocols select instead of depend on networking code

2012-12-07 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: --- Ahem ... :) configure | 20 +--- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/configure b/configure index 9b84da1..4940be9 100755 --- a/configure +++ b/configure @@ -1696,11 +1696,9 @@

[libav-devel] [PATCH] configure: Make protocols select instead of depend on networking code

2012-12-07 Thread Diego Biurrun
--- Dropped some stray network dependencies that are covered by tcp_protocol dependencies. configure | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/configure b/configure index 9b84da1..c413c76 100755 --- a/configure +++ b/configure @@ -1696,11 +1696,9

Re: [libav-devel] [PATCH 3/3] tak: demuxer, parser, and decoder

2012-12-07 Thread Justin Ruggles
On 12/07/2012 02:40 AM, Christophe Gisquet wrote: 2012/12/6 Justin Ruggles justin.rugg...@gmail.com: +static int decode_subframe(TAKDecContext *s, int32_t *decoded, + int subframe_size, int prev_subframe_size) +{ [...] +emms_c(); [...] +static int

Re: [libav-devel] [PATCH] configure: Make protocols select instead of depend on networking code

2012-12-07 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: -http_protocol_deps=network -http_protocol_select=tcp_protocol +http_protocol_deps=tcp_protocol This should still be _select. -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] PPC shared library TEXTREL false positive

2012-12-07 Thread Sean McGovern
Hi Måns, Recently a bug was filed with Gentoo regarding a TEXTREL warning when building libav [1]. Luca's patch to force shared libraries to build as PIC should have fixed this, but we're still getting a false positive from libavcodec when AltiVec is enabled. It contains a 0-sized DT_TEXTREL

[libav-devel] [PATCH] configure: Make protocols select instead of depend on networking code

2012-12-07 Thread Diego Biurrun
--- ... and now with simplified http protocol deps ... configure | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/configure b/configure index 9b84da1..e754f2f 100755 --- a/configure +++ b/configure @@ -1696,10 +1696,8 @@ ffrtmpcrypt_protocol_deps_any=gcrypt

Re: [libav-devel] [PATCH 05/10] SBR DSP x86: implement SSE qmf_deint_neg

2012-12-07 Thread Justin Ruggles
On 12/01/2012 06:18 AM, Christophe Gisquet wrote: Corrected 2 vs 4-spaces tabs and base4 constants. 0005-SBR-DSP-x86-implement-SSE-qmf_deint_neg.patch From 50f9cc2718ac7a290f46f3e34a8cf747d107330b Mon Sep 17 00:00:00 2001 From: Christophe Gisquet christophe.gisq...@gmail.com Date:

Re: [libav-devel] [PATCH 07/10] SBR DSP x86: implement SSE qmf_deint_bfly

2012-12-07 Thread Justin Ruggles
On 12/01/2012 06:20 AM, Christophe Gisquet wrote: Corrected 2 vs 4-spaces tabs and base4 constants. 0007-SBR-DSP-x86-implement-SSE-qmf_deint_bfly.patch From cf3326b20caea42b8654b754abb49f6186743501 Mon Sep 17 00:00:00 2001 From: Christophe Gisquet christophe.gisq...@gmail.com Date:

Re: [libav-devel] [PATCH 05/10] SBR DSP x86: implement SSE qmf_deint_neg

2012-12-07 Thread Christophe Gisquet
2012/12/7 Justin Ruggles justin.rugg...@gmail.com: +cglobal sbr_qmf_deint_neg, 2,3,4,v,src,vrev needs INIT_XMM sse Is one needed for each cglobal? Because there's already one prior to that function, and no other one. I don't quite get the use of m2 here. It looks unnecessary. Indeed, but

Re: [libav-devel] [PATCH] dsputil: modify scalarproduct_int16 to handle mod8 numbers of loops.

2012-12-07 Thread Justin Ruggles
On 12/07/2012 07:20 AM, Måns Rullgård wrote: Christophe Gisquet christophe.gisq...@gmail.com writes: 2012/11/27 Justin Ruggles justin.rugg...@gmail.com: The patch itself looks good. Only the neon version would need to be modified. The altivec version already handles multiples of 8. The

Re: [libav-devel] [PATCH 07/10] SBR DSP x86: implement SSE qmf_deint_bfly

2012-12-07 Thread Christophe Gisquet
2012/12/7 Justin Ruggles justin.rugg...@gmail.com: +cglobal sbr_qmf_deint_bfly, 3,5,8, v,src0,src1,vrev,c needs INIT_XMM sse Same question as previous patch, so I'm postponing sending a new patch. shufps m2, m0, m0, q0123 shufps m3, m1, m1, q0123 shufps m6, m4, m4, q0123 shufps m7, m5,

Re: [libav-devel] [PATCH] dsputil: modify scalarproduct_int16 to handle mod8 numbers of loops.

2012-12-07 Thread Christophe Gisquet
Hi, 2012/12/7 Måns Rullgård m...@mansr.com: Can the buffers be padded to allow some overread? Indeed, and the same can be asked about scalarprod_and_madd_int16 and wma lossless, once I can find back a sample that triggers the interesting cases. -- Christophe

Re: [libav-devel] [PATCH] configure: Make protocols select instead of depend on networking code

2012-12-07 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: --- ... and now with simplified http protocol deps ... configure | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) Probably OK. -- Måns Rullgård m...@mansr.com ___ libav-devel

Re: [libav-devel] [PATCH 05/10] SBR DSP x86: implement SSE qmf_deint_neg

2012-12-07 Thread Justin Ruggles
On 12/07/2012 12:01 PM, Christophe Gisquet wrote: 2012/12/7 Justin Ruggles justin.rugg...@gmail.com: +cglobal sbr_qmf_deint_neg, 2,3,4,v,src,vrev needs INIT_XMM sse Is one needed for each cglobal? Because there's already one prior to that function, and no other one. Not technically, but

Re: [libav-devel] [PATCH] libvpxenc: Support forcing keyframes

2012-12-07 Thread Luca Barbato
On 12/7/12 2:50 PM, Martin Storsjö wrote: --- libavcodec/libvpxenc.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Looks fine. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCHES] scalarproduct_and_madd_int16 and wma lossless

2012-12-07 Thread Christophe Gisquet
2012/11/30 Christophe Gisquet christophe.gisq...@gmail.com: Moved to a macro. This was mimicking apedec codec. If the patches are declared ok, someone should check the neon code. All samples (stereo, 44100Hz) I have (found on samples.mplayerhq, provided or self-encoded) seem to only use orders

Re: [libav-devel] [PATCH] lavr: add option for dithering during sample format conversion to s16

2012-12-07 Thread Justin Ruggles
On 12/05/2012 12:52 PM, Kostya Shishkov wrote: On Wed, Nov 28, 2012 at 03:00:10PM -0500, Justin Ruggles wrote: --- libavresample/Makefile|1 + libavresample/audio_convert.c | 33 - libavresample/audio_convert.h | 22 ++- libavresample/avresample.h|9 +

Re: [libav-devel] [PATCH] lavr: add option for dithering during sample format conversion to s16

2012-12-07 Thread Måns Rullgård
Justin Ruggles justin.rugg...@gmail.com writes: On 12/05/2012 12:52 PM, Kostya Shishkov wrote: On Wed, Nov 28, 2012 at 03:00:10PM -0500, Justin Ruggles wrote: +static inline float lfg_get_flt(AVLFG *lfg) +{ +return av_lfg_get(lfg) / (float)UINT32_MAX; +} Make it generic? I think some

Re: [libav-devel] [PATCH 3/3] tak: demuxer, parser, and decoder

2012-12-07 Thread Kostya Shishkov
On Fri, Dec 07, 2012 at 01:18:08PM -0500, Justin Ruggles wrote: From: Paul B Mahol one...@gmail.com Signed-off-by: Paul B Mahol one...@gmail.com Signed-off-by: Justin Ruggles justin.rugg...@gmail.com --- Simplified filtering by padding the residues buffer and zeroing the filter coeff

Re: [libav-devel] [PATCH] lavr: add option for dithering during sample format conversion to s16

2012-12-07 Thread Justin Ruggles
On 12/07/2012 02:57 PM, Måns Rullgård wrote: Justin Ruggles justin.rugg...@gmail.com writes: On 12/05/2012 12:52 PM, Kostya Shishkov wrote: On Wed, Nov 28, 2012 at 03:00:10PM -0500, Justin Ruggles wrote: +static inline float lfg_get_flt(AVLFG *lfg) +{ +return av_lfg_get(lfg) /

Re: [libav-devel] [PATCH 3/3] tak: demuxer, parser, and decoder

2012-12-07 Thread Justin Ruggles
On 12/07/2012 02:57 PM, Kostya Shishkov wrote: On Fri, Dec 07, 2012 at 01:18:08PM -0500, Justin Ruggles wrote: From: Paul B Mahol one...@gmail.com Signed-off-by: Paul B Mahol one...@gmail.com Signed-off-by: Justin Ruggles justin.rugg...@gmail.com --- Simplified filtering by padding the

Re: [libav-devel] [PATCH] lavr: add option for dithering during sample format conversion to s16

2012-12-07 Thread Måns Rullgård
Justin Ruggles justin.rugg...@gmail.com writes: On 12/07/2012 02:57 PM, Måns Rullgård wrote: Justin Ruggles justin.rugg...@gmail.com writes: On 12/05/2012 12:52 PM, Kostya Shishkov wrote: On Wed, Nov 28, 2012 at 03:00:10PM -0500, Justin Ruggles wrote: +static inline float lfg_get_flt(AVLFG

[libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-07 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Use this in VP8/H264-8bit loopfilter functions so they can be used if there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). --- libavcodec/x86/h264_deblock.asm | 27 ++ libavcodec/x86/h264dsp_init.c | 4 +- libavcodec/x86/vp8dsp.asm |

[libav-devel] [PATCH 1/3] lavu: add av_lfg_get_flt() to get a random float

2012-12-07 Thread Justin Ruggles
--- doc/APIchanges |3 +++ libavutil/lfg.h | 10 ++ libavutil/version.h |2 +- 3 files changed, 14 insertions(+), 1 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 1c6247e..4fb94c8 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -13,6 +13,9 @@

[libav-devel] [PATCH 3/3] eac3dec: use av_lfg_get_flt() for SPX noise generation

2012-12-07 Thread Justin Ruggles
--- This will require changing 2 FATE pcm references due to different noise being generated. libavcodec/eac3dec.c |4 ++-- tests/fate/ac3.mak |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/eac3dec.c b/libavcodec/eac3dec.c index 639e061..55c8987

[libav-devel] [PATCH 2/3] lavr: add option for dithering during sample format conversion to s16

2012-12-07 Thread Justin Ruggles
--- Now using av_lfg_get_flt() libavresample/Makefile|1 + libavresample/audio_convert.c | 33 - libavresample/audio_convert.h | 22 ++- libavresample/avresample.h|9 + libavresample/dither.c| 387 +

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-07 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: +%if mmsize = 16 HAVE_ALIGNED_STACK How much overhead would it be to drop HAVE_ALIGNED_STACK entirely? -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH] Check for invalid VLC code in zeros_left before writing coefficients.

2012-12-07 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This prevents an invalid write into coeffs[scantable[-1]] if zeros_left itself was an invalid VLC code (and thus -1). --- libavcodec/h264_cavlc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/h264_cavlc.c

Re: [libav-devel] [PATCH 1/3] lavu: add av_lfg_get_flt() to get a random float

2012-12-07 Thread Måns Rullgård
Justin Ruggles justin.rugg...@gmail.com writes: /** + * Get the next random float, in the range -0.5 to 0.5, using an ALFG. + */ +static inline float av_lfg_get_flt(AVLFG *lfg) +{ +return (av_lfg_get(lfg) / (float)UINT32_MAX) - 0.5f; +} The float subtraction can be avoided by first

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-07 Thread Ronald S. Bultje
Hi, On Fri, Dec 7, 2012 at 1:01 PM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: +%if mmsize = 16 HAVE_ALIGNED_STACK How much overhead would it be to drop HAVE_ALIGNED_STACK entirely? Well, for now, we still have a ton of functions that don't

Re: [libav-devel] [PATCH 1/1] golomb: use unsigned arithmetics in svq3_get_ue_golomb()

2012-12-07 Thread Ronald S. Bultje
Hi, On Fri, Nov 30, 2012 at 10:56 AM, Janne Grunau janne-li...@jannau.net wrote: This prevents undefined behaviour of signed left shift if the coded value is larger than 2^31. Large values are most likely invalid and caused errors or by feeding random. Validate every use of

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-07 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Fri, Dec 7, 2012 at 1:01 PM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: +%if mmsize = 16 HAVE_ALIGNED_STACK How much overhead would it be to drop HAVE_ALIGNED_STACK entirely? Well, for

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-07 Thread Ronald S. Bultje
Hi, On Fri, Dec 7, 2012 at 2:01 PM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: On Fri, Dec 7, 2012 at 1:01 PM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: +%if mmsize = 16 HAVE_ALIGNED_STACK How much

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-07 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Fri, Dec 7, 2012 at 2:01 PM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: On Fri, Dec 7, 2012 at 1:01 PM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: +%if

Re: [libav-devel] [libav-commits] tak: demuxer, parser, and decoder

2012-12-07 Thread Måns Rullgård
Paul B Mahol g...@libav.org writes: +LOCAL_ALIGNED_16(int16_t, filter, [MAX_PREDICTORS]) = { 0, }; LOCAL_ALIGNED arrays can't be initialised like that. You must use memset. -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-07 Thread Ronald S. Bultje
Hi, On Fri, Dec 7, 2012 at 2:08 PM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Fri, Dec 7, 2012 at 2:01 PM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: On Fri, Dec 7, 2012 at 1:01 PM, Måns Rullgård

Re: [libav-devel] [PATCH] takdec: fix initialisation of LOCAL_ALIGNED array

2012-12-07 Thread Josh Allmann
On 7 December 2012 14:23, Martin Storsjö mar...@martin.st wrote: On Fri, 7 Dec 2012, Mans Rullgard wrote: When LOCAL_ALIGNED uses manual alignment initialisation is not possible. There's another case further down. diff --git a/libavcodec/takdec.c b/libavcodec/takdec.c index 0ac870c..d47db48

Re: [libav-devel] [PATCH] takdec: fix initialisation of LOCAL_ALIGNED array

2012-12-07 Thread Måns Rullgård
Josh Allmann joshua.allm...@gmail.com writes: On 7 December 2012 14:23, Martin Storsjö mar...@martin.st wrote: On Fri, 7 Dec 2012, Mans Rullgard wrote: When LOCAL_ALIGNED uses manual alignment initialisation is not possible. There's another case further down. diff --git

[libav-devel] [PATCH 2/2] Make LCOAL_ALIGNED syntactically similar on all systems

2012-12-07 Thread Mans Rullgard
This changes the LOCAL_ALIGNED definition on systems where DECLARE_ALIGNED is used such it matches the manual alignment case, ensuring invalid use will not compile on x86 only to fail on everything else. Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/dsputil.h | 4 +++- 1 file

[libav-devel] [PATCH 1/2] takdec: fix remaining LOCAL_ALIGNED initialisation

2012-12-07 Thread Mans Rullgard
Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/takdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/takdec.c b/libavcodec/takdec.c index 0ac870c..d47db48 100644 --- a/libavcodec/takdec.c +++ b/libavcodec/takdec.c @@ -601,10 +601,12 @@ static int

Re: [libav-devel] [PATCH] takdec: fix initialisation of LOCAL_ALIGNED array

2012-12-07 Thread Janne Grunau
On 2012-12-07 14:30:30 -0800, Josh Allmann wrote: On 7 December 2012 14:23, Martin Storsjö mar...@martin.st wrote: On Fri, 7 Dec 2012, Mans Rullgard wrote: When LOCAL_ALIGNED uses manual alignment initialisation is not possible. There's another case further down. diff --git

Re: [libav-devel] [PATCH 1/2] takdec: fix remaining LOCAL_ALIGNED initialisation

2012-12-07 Thread Janne Grunau
On 2012-12-07 23:03:06 +, Måns Rullgård wrote: Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/takdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/takdec.c b/libavcodec/takdec.c index 0ac870c..d47db48 100644 --- a/libavcodec/takdec.c

Re: [libav-devel] [PATCH 2/2] Make LCOAL_ALIGNED syntactically similar on all systems

2012-12-07 Thread Janne Grunau
On 2012-12-07 23:03:07 +, Måns Rullgård wrote: This changes the LOCAL_ALIGNED definition on systems where DECLARE_ALIGNED is used such it matches the manual alignment case, ensuring invalid use will not compile on x86 only to fail on everything else. Signed-off-by: Mans Rullgard

[libav-devel] [PATCH] h264: check for invalid zeros_left before writing

2012-12-07 Thread Luca Barbato
From: Ronald S. Bultje rsbul...@gmail.com Prevent an invalid write into coeffs[scantable[-1]] if zeros_left itself was an invalid VLC code (and thus -1). Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavcodec/h264_cavlc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-)

Re: [libav-devel] [PATCH 2/2] Make LCOAL_ALIGNED syntactically similar on all systems

2012-12-07 Thread Måns Rullgård
Janne Grunau janne-li...@jannau.net writes: On 2012-12-07 23:03:07 +, Måns Rullgård wrote: This changes the LOCAL_ALIGNED definition on systems where DECLARE_ALIGNED is used such it matches the manual alignment case, ensuring invalid use will not compile on x86 only to fail on everything

Re: [libav-devel] [PATCH] h264: KR formatting cosmetics

2012-12-07 Thread Clément Bœsch
On Sat, Dec 08, 2012 at 02:17:04AM +0100, Luca Barbato wrote: [...] -static const uint8_t run_bits[7][16]={ -{1,0}, -{1,1,0}, -{3,2,1,0}, -{3,2,1,1,0}, -{3,2,3,2,1,0}, -{3,0,1,3,2,5,4}, -{7,6,5,4,3,2,1,1,1,1,1,1,1,1,1}, +static const uint8_t run_bits[7][16] = {

Re: [libav-devel] [PATCH 2/2] Make LCOAL_ALIGNED syntactically similar on all systems

2012-12-07 Thread Janne Grunau
On 2012-12-08 00:53:56 +, Måns Rullgård wrote: Janne Grunau janne-li...@jannau.net writes: I wouldn't be surprised there some memsets or memcpys arround using sizeof(array) of a LOCAL_ALIGNED variable. I made sure there were none when we introduced LOCAL_ALIGNED, but I can't be sure

Re: [libav-devel] [PATCH] h264: KR formatting cosmetics

2012-12-07 Thread Luca Barbato
On 12/8/12 2:45 AM, Clément Bœsch wrote: On Sat, Dec 08, 2012 at 02:17:04AM +0100, Luca Barbato wrote: Review in form of patches mostly welcome for this one It is an uncrustify pass with some of the glaring ugliness removed, I was expecting to miss some and thus I asked for updated patches as

[libav-devel] [PATCH 1/3] lavu: add av_lfg_get_flt() to get a random float

2012-12-07 Thread Justin Ruggles
--- doc/APIchanges |3 +++ libavutil/lfg.h | 15 +++ libavutil/version.h |2 +- 3 files changed, 19 insertions(+), 1 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 1c6247e..4fb94c8 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -13,6 +13,9 @@

Re: [libav-devel] [PATCH] h264: KR formatting cosmetics

2012-12-07 Thread Luca Barbato
On 12/8/12 2:51 AM, Luca Barbato wrote: On 12/8/12 2:45 AM, Clément Bœsch wrote: On Sat, Dec 08, 2012 at 02:17:04AM +0100, Luca Barbato wrote: Review in form of patches mostly welcome for this one It is an uncrustify pass with some of the glaring ugliness removed, I was expecting to miss some

Re: [libav-devel] [PATCH] x86: float_dsp: fix loading of the len parameter on x86-32

2012-12-07 Thread Justin Ruggles
On 12/06/2012 12:38 PM, Justin Ruggles wrote: --- libavutil/x86/float_dsp.asm |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/libavutil/x86/float_dsp.asm b/libavutil/x86/float_dsp.asm index 4a1742f..4113fd9 100644 --- a/libavutil/x86/float_dsp.asm +++

Re: [libav-devel] [PATCH 1/3] lavu: add av_lfg_get_flt() to get a random float

2012-12-07 Thread Måns Rullgård
Justin Ruggles justin.rugg...@gmail.com writes: /** + * Get the next random float, in the range -0.5 to 0.5, using an ALFG. + */ +static inline float av_lfg_get_flt(AVLFG *lfg) +{ +union { +unsigned u; +signed s; +} r; +r.u = av_lfg_get(lfg); +return

[libav-devel] [PATCH 1/3] lavu: add av_lfg_get_flt() to get a random float

2012-12-07 Thread Justin Ruggles
--- doc/APIchanges |3 +++ libavutil/lfg.h | 15 +++ libavutil/version.h |2 +- 3 files changed, 19 insertions(+), 1 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 1c6247e..4fb94c8 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -13,6 +13,9 @@

Re: [libav-devel] [PATCH] Check for invalid VLC code in zeros_left before writing coefficients.

2012-12-07 Thread Luca Barbato
On 12/7/12 10:09 PM, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com This prevents an invalid write into coeffs[scantable[-1]] if zeros_left itself was an invalid VLC code (and thus -1). --- libavcodec/h264_cavlc.c | 10 +- 1 file changed, 5 insertions(+), 5

[libav-devel] [PATCH 1/4] hls: add start_number option

2012-12-07 Thread Luca Barbato
--- doc/muxers.texi | 1 + libavformat/hlsenc.c | 1 + 2 files changed, 2 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 570041d..a2a9ce4 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -109,6 +109,7 @@ avconv -i in.nut out.m3u8 @item -hls_time segment length in

[libav-devel] [PATCH 2/4] hls: use a meaningful long name

2012-12-07 Thread Luca Barbato
--- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 1003b85..9d3b466 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -312,7 +312,7 @@ static const AVClass hls_class = { AVOutputFormat

[libav-devel] [PATCH 3/4] hls: improve options description

2012-12-07 Thread Luca Barbato
--- doc/muxers.texi | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index a2a9ce4..4104137 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -106,10 +106,14 @@ avconv -i in.nut out.m3u8 @end example @table @option -@item

[libav-devel] [PATCH 4/4] img2: document the options available

2012-12-07 Thread Luca Barbato
--- doc/demuxers.texi | 13 + doc/muxers.texi | 5 + 2 files changed, 18 insertions(+) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index c3049dd..2d5c425 100644 --- a/doc/demuxers.texi +++ b/doc/demuxers.texi @@ -64,6 +64,19 @@ Note that the pattern must not necessarily