Re: [libav-devel] [PATCH] tiff: decode grayscale 8bit images

On 2014-07-21 01:19:15 +0200, Luca Barbato wrote: On 20/07/14 13:57, Luca Barbato wrote: On 20/07/14 13:47, Vittorio Giovara wrote: From: Carl Eugen Hoyos ceho...@ag.or.at --- libavcodec/tiff.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/tiff.c

[libav-devel] [PATCH] mjpegenc: return proper error code

--- libavcodec/mjpegenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mjpegenc.c b/libavcodec/mjpegenc.c index 9ce07de..fdb882e 100644 --- a/libavcodec/mjpegenc.c +++ b/libavcodec/mjpegenc.c @@ -46,7 +46,7 @@ av_cold int ff_mjpeg_encode_init(MpegEncContext *s)

[libav-devel] [PATCH] mjpeg: return proper error code

--- corrected commit tag libavcodec/mjpegenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mjpegenc.c b/libavcodec/mjpegenc.c index 9ce07de..fdb882e 100644 --- a/libavcodec/mjpegenc.c +++ b/libavcodec/mjpegenc.c @@ -46,7 +46,7 @@ av_cold int

Re: [libav-devel] Travis

On 2014-07-19 18:26:22 +0200, Diego Biurrun wrote: On Sat, Jul 19, 2014 at 12:23:58PM -0400, Reinhard Tartler wrote: For release branches, we currently don't have any FATE Farm. It would be great to have something like that, but as far as I understand, it is a lot of effort to setup FATE

Re: [libav-devel] [PATCH] mjpeg: return proper error code

On Mon, Jul 21, 2014 at 12:41:46PM +0530, Nidhi Makhijani wrote: --- corrected commit tag libavcodec/mjpegenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) LGTM, queueing Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] dct-test: Move arch-specific bits into arch-specific subdirectories

On Sun, Jul 20, 2014 at 01:33:23PM -0700, Diego Biurrun wrote: --- Rebased now that the patch to deduplicate IDCT tables was dropped. libavcodec/arm/dct-test.c | 40 ++ libavcodec/dct-test.c | 105 ++

Re: [libav-devel] Pull requests on github

On 2014-07-19 10:42:55 -0400, Reinhard Tartler wrote: Hi, I notice that we currently have 6 open pull requests on github: https://github.com/libav/libav/pulls Interestingly, there are also 8 closed requests:

Re: [libav-devel] [PATCH] matroskaenc: Don't set language to empty string, use und

On 07/20/2014 03:28 PM, j...@v2v.cc wrote: On 07/20/2014 03:13 PM, Anton Khirnov wrote: Could you share the sample? This really sounds like a bug elsewhere that should be fixed. Here a short clip http://v2v.cc/~j/samples/emtpy_language.mpg Found the issue for this sample in mpegts.c,

Re: [libav-devel] Fwd: Bug#753528: libav-tools: Floating point exception is raised when recording vom video4linux2

On 2014-07-20 14:50:59 -0400, Reinhard Tartler wrote: Control: forwarded -1 libav-devel@libav.org Hi, In Debian, we've received this bugreport regarding a bugfix in our video4linux2 handling. Is the patch below acceptable for master? looks ok to me Janne

Re: [libav-devel] [PATCH] mjpegenc: return proper error code

On Mon, Jul 21, 2014 at 8:08 AM, Nidhi Makhijani nidhim...@gmail.com wrote: --- libavcodec/mjpegenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mjpegenc.c b/libavcodec/mjpegenc.c index 9ce07de..fdb882e 100644 --- a/libavcodec/mjpegenc.c +++

Re: [libav-devel] [PATCH 1/5] avutil: rename AV_PIX_FMT_Y400A to AV_PIX_FMT_GRAY8A

On Mon, Jul 21, 2014 at 12:25 AM, Luca Barbato lu_z...@gentoo.org wrote: On 21/07/14 00:59, Vittorio Giovara wrote: An alias is provided for compatibility. --- I would propose this change because all present (and future) grayscale format somehow have GRAY in their name, which makes them more

Re: [libav-devel] [PATCH] matroskaenc: Don't set language to empty string, use und

On 21/07/14 10:24, Jan Gerber wrote: On 07/20/2014 03:28 PM, j...@v2v.cc wrote: On 07/20/2014 03:13 PM, Anton Khirnov wrote: Could you share the sample? This really sounds like a bug elsewhere that should be fixed. Here a short clip http://v2v.cc/~j/samples/emtpy_language.mpg Found the

[libav-devel] [PATCH 2/3] build: Conditionally build and run DCT test program

--- libavcodec/Makefile | 4 ++-- libavcodec/dct-test.c | 5 - tests/fate/libavcodec.mak | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 684269c..7caddd6 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile

[libav-devel] [PATCH 3/3] build: Conditionally compile all avcodec test programs

--- libavcodec/Makefile | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 7caddd6..9ce37a8 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -711,13 +711,11 @@ SKIPHEADERS-$(CONFIG_VAAPI)+=

[libav-devel] [PATCH 1/3] build: Conditionally build and test iirfilter

--- configure | 3 ++- libavcodec/Makefile | 7 --- tests/fate/libavcodec.mak | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/configure b/configure index e401711..26e1e82 100755 --- a/configure +++ b/configure @@ -1548,6 +1548,7 @@ CONFIG_EXTRA=

Re: [libav-devel] [PATCH 1/3] build: Conditionally build and test iirfilter

On 21/07/14 14:33, Diego Biurrun wrote: --- configure | 3 ++- libavcodec/Makefile | 7 --- tests/fate/libavcodec.mak | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) The set looks fine to me. lu ___

[libav-devel] [PATCH 3/4] vc-1: Add platform-specific start code search routine to VC1DSPContext.

Initialise VC1DSPContext for parser as well as for decoder. Note, the VC-1 code doesn't actually use the function pointer yet. --- configure|4 ++-- libavcodec/Makefile |2 +- libavcodec/arm/vc1dsp_init_arm.c |3 +++ libavcodec/vc1.c

[libav-devel] [PATCH 4/4] vc-1: Optimise parser (with special attention to ARM)

The previous implementation of the parser made four passes over each input buffer (reduced to two if the container format already guaranteed the input buffer corresponded to frames, such as with MKV). But these buffers are often 200K in size, certainly enough to flush the data out of L1 cache, and

[libav-devel] [PATCH 2/4] h264: Move start code search functions into separate source files.

This permits re-use with parsers for codecs which use similar start codes. --- configure |3 +- libavcodec/Makefile|1 + libavcodec/arm/Makefile|2 +- libavcodec/arm/h264dsp_init_arm.c

[libav-devel] [PATCH 1/4] arm: Macroize the test for 'setend' CPU instruction support

--- libavcodec/arm/h264dsp_init_arm.c |6 +- libavutil/arm/cpu.h |4 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/arm/h264dsp_init_arm.c b/libavcodec/arm/h264dsp_init_arm.c index f9712d8..7cb1312 100644 ---

Re: [libav-devel] [PATCH 1/4] arm: Macroize the test for 'setend' CPU instruction support

On Mon, Jul 21, 2014 at 02:53:06PM +0100, Ben Avison wrote: --- libavcodec/arm/h264dsp_init_arm.c |6 +- libavutil/arm/cpu.h |4 2 files changed, 5 insertions(+), 5 deletions(-) LGTM Diego ___ libav-devel mailing

Re: [libav-devel] [PATCH 2/4] h264: Move start code search functions into separate source files.

On Mon, Jul 21, 2014 at 02:53:07PM +0100, Ben Avison wrote: --- /dev/null +++ b/libavcodec/arm/startcode.h @@ -0,0 +1,27 @@ +/* + * Copyright (c) 2014 RISC OS Open Ltd + * Author: Ben Avison bavi...@riscosopen.org I suggest dropping copyright notices for such completely trivial files.

Re: [libav-devel] Travis

Hi Reinhard, Great job ;-) If you want to enable build on MacOSX you need to send an email to the Travis Team. You can keep the github repository for testing the OSX build. An example of our testing environment on MacOSX can be found here: https://github.com/tuttleofx/TuttleOFX/pull/335 Just a

[libav-devel] [PATCH 2/4] h264: Move start code search functions into separate source files.

This permits re-use with parsers for codecs which use similar start codes. --- configure |3 +- libavcodec/Makefile|1 + libavcodec/arm/Makefile|2 +- libavcodec/arm/h264dsp_init_arm.c

[libav-devel] [PATCH 1/8] dct/rdft: Add missing typedefs for context structs

Without the typedefs there can be trouble depending on #include order. --- libavcodec/dct.h | 4 ++-- libavcodec/rdft.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/dct.h b/libavcodec/dct.h index 3fd4e27..24926a7 100644 --- a/libavcodec/dct.h +++

[libav-devel] [PATCH 7/8] fft-test: Make global exptab variable static

--- libavcodec/fft-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/fft-test.c b/libavcodec/fft-test.c index 9fdc210..14d1804 100644 --- a/libavcodec/fft-test.c +++ b/libavcodec/fft-test.c @@ -59,7 +59,7 @@ # define FMT %6d #endif -struct { +static

[libav-devel] [PATCH 2/8] fft-test: Drop unnecessary #ifdefs around header includes

--- libavcodec/fft-test.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/fft-test.c b/libavcodec/fft-test.c index 142a61d..d4d3f55 100644 --- a/libavcodec/fft-test.c +++ b/libavcodec/fft-test.c @@ -29,10 +29,8 @@ #include libavutil/log.h #include libavutil/time.h #include

[libav-devel] [PATCH 5/8] fft-test: Drop unnecessary pointer indirection for context structs

--- libavcodec/fft-test.c | 47 +++ 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/libavcodec/fft-test.c b/libavcodec/fft-test.c index 6493ba8..19ec696 100644 --- a/libavcodec/fft-test.c +++ b/libavcodec/fft-test.c @@ -226,11 +226,10 @@

[libav-devel] [PATCH 6/8] fft-test: Check memory allocations

--- libavcodec/fft-test.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/libavcodec/fft-test.c b/libavcodec/fft-test.c index 19ec696..9fdc210 100644 --- a/libavcodec/fft-test.c +++ b/libavcodec/fft-test.c @@ -63,11 +63,13 @@ struct { float re, im; }

[libav-devel] [PATCH 8/8] fft-test: KR formatting cosmetics

--- libavcodec/fft-test.c | 161 ++ 1 file changed, 83 insertions(+), 78 deletions(-) diff --git a/libavcodec/fft-test.c b/libavcodec/fft-test.c index 14d1804..4ca93d6 100644 --- a/libavcodec/fft-test.c +++ b/libavcodec/fft-test.c @@ -23,14 +23,8

[libav-devel] [PATCH 4/8] fft-test: Reduce variable scope where sensibly possible

Also merge variable declaration and initialization. --- libavcodec/fft-test.c | 85 +-- 1 file changed, 34 insertions(+), 51 deletions(-) diff --git a/libavcodec/fft-test.c b/libavcodec/fft-test.c index 2f2f2e9..6493ba8 100644 ---

[libav-devel] [PATCH 3/8] fft-test: Comment some #endifs

--- libavcodec/fft-test.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/fft-test.c b/libavcodec/fft-test.c index d4d3f55..2f2f2e9 100644 --- a/libavcodec/fft-test.c +++ b/libavcodec/fft-test.c @@ -183,7 +183,7 @@ static void dct_ref(float *output,

[libav-devel] [PATCH] fate: Split audio- and video-related RealMedia targets

From: Katerina Barone-Adesi kateri...@gmail.com Signed-off-by: Diego Biurrun di...@biurrun.de --- Improved log message, more compact variable names. tests/fate/real.mak | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tests/fate/real.mak

[libav-devel] [PATCH 2/2] aarch64: NEON intrinsics dct_unquantize_h263.

From: James Yu james...@linaro.org Intrinsics only used on aarch64 since the existing ARMv7 NEON asm is slightly faster (Cortex-A9, gcc-4.8, micro-benchmarks and full decoding time). Signed-off-by: James Yu james...@linaro.org Signed-off-by: Janne Grunau janne-li...@jannau.net ---

[libav-devel] [PATCH 1/2] configure: add support for neon intrinsics

--- Makefile | 1 + configure | 12 2 files changed, 13 insertions(+) diff --git a/Makefile b/Makefile index 6302997..b8d1034 100644 --- a/Makefile +++ b/Makefile @@ -130,6 +130,7 @@ $(foreach V,$(SUBDIR_VARS),$(eval $(call RESET,$(V SUBDIR := $(1)/ include

Re: [libav-devel] [PATCH] fate: Split audio- and video-related RealMedia targets

On 21/07/14 19:43, Diego Biurrun wrote: From: Katerina Barone-Adesi kateri...@gmail.com Signed-off-by: Diego Biurrun di...@biurrun.de --- Improved log message, more compact variable names. Probably Ok. ___ libav-devel mailing list

Re: [libav-devel] [PATCH 2/2] Added two tests for the old RealAudio formats, and their refs.

On Sun, Jul 13, 2014 at 11:47:06PM +0200, Katerina Barone-Adesi wrote: New tests: fate-ra3-144 for RealAudio 1.0 fate-ra4-28_8 for RealAudio 2.0 containing the 28.8 codec. New targets: fate-real, fate-realaudio --- tests/fate/real.mak | 13 +++-- tests/ref/fate/ra3-144

Re: [libav-devel] [PATCH 1/2] configure: add support for neon intrinsics

On Mon, Jul 21, 2014 at 07:55:55PM +0200, Janne Grunau wrote: --- Makefile | 1 + configure | 12 2 files changed, 13 insertions(+) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 1/5] avutil: rename AV_PIX_FMT_Y400A to AV_PIX_FMT_GRAY8A

On Sun, 20 Jul 2014 23:59:17 +0100, Vittorio Giovara vittorio.giov...@gmail.com wrote: @@ -256,6 +256,7 @@ enum AVPixelFormat { #define AV_PIX_FMT_XYZ12 AV_PIX_FMT_NE(XYZ12BE, XYZ12LE) #define AV_PIX_FMT_NV20 AV_PIX_FMT_NE(NV20BE, NV20LE) +#define AV_PIX_FMT_Y400A

Re: [libav-devel] [PATCH 2/5] avutil: add AV_PIX_FMT_GRAY16A pixel format

On Sun, 20 Jul 2014 23:59:18 +0100, Vittorio Giovara vittorio.giov...@gmail.com wrote: --- Black and white gradients never looked better! Vittorio doc/APIchanges | 3 +++ libavutil/pixdesc.c | 19 +++ libavutil/pixfmt.h | 5 + libavutil/version.h | 4 ++--

Re: [libav-devel] [PATCH 4/5] png: support reading gray+alpha at 16 bits

On Sun, 20 Jul 2014 23:59:20 +0100, Vittorio Giovara vittorio.giov...@gmail.com wrote: --- libavcodec/pngdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 6b085ac..79baf4a 100644 --- a/libavcodec/pngdec.c +++

Re: [libav-devel] [PATCH 5/5] tiff: support reading gray+alpha at 16 bits

On Sun, 20 Jul 2014 23:59:21 +0100, Vittorio Giovara vittorio.giov...@gmail.com wrote: --- libavcodec/tiff.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 69d55c6..71ba5c8 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@

Re: [libav-devel] [PATCH 2/2] aarch64: NEON intrinsics dct_unquantize_h263.

On 21/07/14 19:55, Janne Grunau wrote: From: James Yu james...@linaro.org Intrinsics only used on aarch64 since the existing ARMv7 NEON asm is slightly faster (Cortex-A9, gcc-4.8, micro-benchmarks and full decoding time). Signed-off-by: James Yu james...@linaro.org Signed-off-by: Janne

[libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

From: Marvin Scholz epira...@gmail.com This adds the Icecast protocol to libav, this is basically a convenience wrapper for the http protocol --- libavformat/icecast.c | 230 ++ 1 file changed, 230 insertions(+) create mode 100644

[libav-devel] [PATCH] Fate: Add tests for RealAudio 1.0 (14.4) and RealAudio 2.0 (with 28.8)

--- tests/fate/real.mak | 11 ++-- tests/ref/fate/ra3-14_4 | 51 ++ tests/ref/fate/ra4-28_8 | 73 + 3 files changed, 133 insertions(+), 2 deletions(-) create mode 100644 tests/ref/fate/ra3-14_4 create mode

Re: [libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

On Mon, Jul 21, 2014 at 10:20:52PM +0200, epira...@gmail.com wrote: From: Marvin Scholz epira...@gmail.com This adds the Icecast protocol to libav, this is basically a convenience wrapper for the http protocol Just Icecast is basically a convenience wrapper around the HTTP protocol.

[libav-devel] [PATCH 1/5] imgconvert: cosmetics: Reshuffle defines to reduce ifdeffery

--- Since this also moves the ifdef below the FF_API condition, it should reduce the chance of getting left behind with the next API bump. libavcodec/imgconvert.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/libavcodec/imgconvert.c

[libav-devel] Arch-specific bits hiding in general C code

Now that I excised arch-specific bits from dct-test, I figured I might as well clean out the remaining arch-specific bits from libavcodec. It's just five little pieces left ... [PATCH 1/5] imgconvert: cosmetics: Reshuffle defines to reduce [PATCH 2/5] libxvid: Drop PPC-specific CPU detection hack

[libav-devel] [PATCH 5/5] build: Add define for SIMD extensions requiring 16-byte aligned buffers

--- I'm slightly unsure about this one. MMX does not require 16-byte aligned buffers, nor does PowerPC IIRC, but SSE and AltiVec do, so I believe my solution is closer to the original intention. Please do correct me if I am wrong... configure | 2 ++ libavcodec/utils.c | 2 +- 2

[libav-devel] [PATCH 4/5] msmpeg$: Drop inline assembly from ff_msmpeg4_pred_dc

Inline assembly has no place in the general C code and the utility of this microoptimization is doubtful. --- This is a troll patch, I did not bother to benchmark. libavcodec/msmpeg4.c | 27 +-- 1 file changed, 1 insertion(+), 26 deletions(-) diff --git

[libav-devel] [PATCH 3/5] mpeg4video: Drop unnecessary MMX ifdefs around DCT init call

The DCT init code takes care of MMX and other arch details on its own. --- libavcodec/mpeg4videodec.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index a4e7725..97dbcf6 100644 --- a/libavcodec/mpeg4videodec.c +++

[libav-devel] [PATCH 2/5] libxvid: Drop PPC-specific CPU detection hack

It is doubtful if the hack (still) works and PPC is obsolete for encoding. --- libavcodec/libxvid.c | 12 1 file changed, 12 deletions(-) diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c index eab61be..ddeceac 100644 --- a/libavcodec/libxvid.c +++ b/libavcodec/libxvid.c @@

[libav-devel] [PATCH v3] fate: Add tests for RealAudio 1.0 (14.4) and RealAudio 2.0 (with 28.8)

--- tests/fate/real.mak| 10 ++- tests/ref/fate/ra3-144 | 51 +++ tests/ref/fate/ra4-288 | 73 ++ 3 files changed, 133 insertions(+), 1 deletion(-) create mode 100644 tests/ref/fate/ra3-144 create mode

Re: [libav-devel] [PATCH 3/5] mpeg4video: Drop unnecessary MMX ifdefs around DCT init call

On 2014-07-21 14:21:08 -0700, Diego Biurrun wrote: The DCT init code takes care of MMX and other arch details on its own. yes and no --- libavcodec/mpeg4videodec.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavcodec/mpeg4videodec.c

Re: [libav-devel] [PATCH 1/5] imgconvert: cosmetics: Reshuffle defines to reduce ifdeffery

On 21/07/14 23:21, Diego Biurrun wrote: --- Since this also moves the ifdef below the FF_API condition, it should reduce the chance of getting left behind with the next API bump. Ok. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 2/5] libxvid: Drop PPC-specific CPU detection hack

On 2014-07-21 14:21:07 -0700, Diego Biurrun wrote: It is doubtful if the hack (still) works and PPC is obsolete for encoding. not so sure about the latter but xvid had enough time to fix it. no need to keep this ugly workaround. --- libavcodec/libxvid.c | 12 1 file changed,

[libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

From: ePirat epira...@gmail.com Icecast is basically a convenience wrapper around the HTTP protocol. --- Changelog| 1 + configure| 1 + doc/general.texi | 1 + doc/protocols.texi | 40 libavformat/Makefile | 1 +

Re: [libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

On Tue, Jul 22, 2014 at 12:12:34AM +0200, epira...@gmail.com wrote: From: ePirat epira...@gmail.com Something seems to be amiss in your Git setup wrt your name. --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -138,6 +138,46 @@ Set initial byte offset. +@item ice_url +Set the stream

Re: [libav-devel] [PATCH 5/5] build: Add define for SIMD extensions requiring 16-byte aligned buffers

On 21/07/14 6:21 PM, Diego Biurrun wrote: --- I'm slightly unsure about this one. MMX does not require 16-byte aligned buffers, nor does PowerPC IIRC, but SSE and AltiVec do, so I believe my solution is closer to the original intention. Please do correct me if I am wrong... configure

[libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

From: ePirat epira...@gmail.com --- Changelog| 1 + configure| 1 + doc/general.texi | 1 + doc/protocols.texi | 40 libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/icecast.c| 234

[libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

From: ePirat epira...@gmail.com Icecast is basically a convenience wrapper around the HTTP protocol. --- Changelog| 1 + configure| 1 + doc/general.texi | 1 + doc/protocols.texi | 40 libavformat/Makefile | 1 +