Re: [libav-devel] [PATCH 5/5] build: Add define for SIMD extensions requiring 16-byte aligned buffers

2014-07-22 Thread Diego Biurrun
On Mon, Jul 21, 2014 at 08:13:16PM -0300, James Almer wrote: On 21/07/14 6:21 PM, Diego Biurrun wrote: --- I'm slightly unsure about this one. MMX does not require 16-byte aligned buffers, nor does PowerPC IIRC, but SSE and AltiVec do, so I believe my solution is closer to the

Re: [libav-devel] [PATCH 2/5] libxvid: Drop PPC-specific CPU detection hack

2014-07-22 Thread Diego Biurrun
On Tue, Jul 22, 2014 at 12:04:38AM +0200, Janne Grunau wrote: On 2014-07-21 14:21:07 -0700, Diego Biurrun wrote: It is doubtful if the hack (still) works and PPC is obsolete for encoding. not so sure about the latter but xvid had enough time to fix it. no need to keep this ugly workaround.

Re: [libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

2014-07-22 Thread Diego Biurrun
On Tue, Jul 22, 2014 at 03:42:21AM +0200, epira...@gmail.com wrote: From: ePirat epira...@gmail.com Please set your name in ~/.gitconfig. Icecast is basically a convenience wrapper around the HTTP protocol. --- Changelog| 1 + configure| 1 +

Re: [libav-devel] [PATCH 2/2] aarch64: NEON intrinsics dct_unquantize_h263.

2014-07-22 Thread Diego Biurrun
On Mon, Jul 21, 2014 at 07:55:56PM +0200, Janne Grunau wrote: --- libavcodec/mpegvideo.c | 3 + libavcodec/mpegvideo.h | 1 + libavcodec/neon/Makefile| 1 + libavcodec/neon/mpegvideo.c | 134 4 files changed, 139

[libav-devel] [PATCH] build: Add define for SIMD extensions requiring 16-byte aligned buffers

2014-07-22 Thread Diego Biurrun
--- Changed to also replace the need_memalign variable in configure, which essentially indicates the same thing. I've followed the git-blame path of STRIDE_ALIGN and an now confident this is the correct solution for a number of hacks that were cargo-culted around. configure | 6 +++---

[libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

2014-07-22 Thread epirat07
From: Marvin Scholz epira...@gmail.com Icecast is basically a convenience wrapper around the HTTP protocol. --- Changelog| 1 + configure| 1 + doc/general.texi | 1 + doc/protocols.texi | 40 libavformat/Makefile | 1 +

[libav-devel] [PATCH] http: Use a constant for the supported header size

2014-07-22 Thread Luca Barbato
Would make much easier enlarge it when needed. --- libavformat/http.c | 2 +- libavformat/http.h | 2 ++ libavformat/mmsh.c | 2 +- libavformat/rtmphttp.c | 2 +- libavformat/rtsp.c | 2 +- 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libavformat/http.c

[libav-devel] [PATCH] configure: Extend the neon intrinsics check

2014-07-22 Thread Martin Storsjö
This instruction causes the (very old) apple gcc 4.2 to error out (unrecognizable insn). --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1cc2265..d90c44e 100755 --- a/configure +++ b/configure @@ -3935,7 +3935,7 @@ EOF fi

Re: [libav-devel] [PATCH] http: Use a constant for the supported header size

2014-07-22 Thread Martin Storsjö
On Tue, 22 Jul 2014, Luca Barbato wrote: Would make much easier enlarge it when needed. --- libavformat/http.c | 2 +- libavformat/http.h | 2 ++ libavformat/mmsh.c | 2 +- libavformat/rtmphttp.c | 2 +- libavformat/rtsp.c | 2 +- 5 files changed, 6 insertions(+), 4 deletions(-)

Re: [libav-devel] [PATCH] configure: Extend the neon intrinsics check

2014-07-22 Thread Luca Barbato
On 22/07/14 14:29, Martin Storsjö wrote: This instruction causes the (very old) apple gcc 4.2 to error out (unrecognizable insn). --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1cc2265..d90c44e 100755 --- a/configure +++

Re: [libav-devel] [PATCH] http: Use a constant for the supported header size

2014-07-22 Thread Luca Barbato
On 22/07/14 14:39, Martin Storsjö wrote: On Tue, 22 Jul 2014, Luca Barbato wrote: Would make much easier enlarge it when needed. --- libavformat/http.c | 2 +- libavformat/http.h | 2 ++ libavformat/mmsh.c | 2 +- libavformat/rtmphttp.c | 2 +- libavformat/rtsp.c | 2 +- 5

Re: [libav-devel] [PATCH] http: Use a constant for the supported header size

2014-07-22 Thread Martin Storsjö
On Tue, 22 Jul 2014, Luca Barbato wrote: On 22/07/14 14:39, Martin Storsjö wrote: On Tue, 22 Jul 2014, Luca Barbato wrote: Would make much easier enlarge it when needed. --- libavformat/http.c | 2 +- libavformat/http.h | 2 ++ libavformat/mmsh.c | 2 +- libavformat/rtmphttp.c | 2

Re: [libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

2014-07-22 Thread Martin Storsjö
On Tue, 22 Jul 2014, epira...@gmail.com wrote: From: Marvin Scholz epira...@gmail.com Icecast is basically a convenience wrapper around the HTTP protocol. --- Changelog| 1 + configure| 1 + doc/general.texi | 1 + doc/protocols.texi | 40

[libav-devel] [PATCH] detect Vanc/Vbi SMPTE-436M mxf track

2014-07-22 Thread Marc-Antoine Arnaud
--- libavformat/mxfdec.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 58d9027..2d7ac48 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -971,6 +971,15 @@ static const MXFCodecUL

Re: [libav-devel] [PATCH] detect Vanc/Vbi SMPTE-436M mxf track

2014-07-22 Thread Katerina Barone-Adesi
LGTM, but I'd like it to be thirded. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

2014-07-22 Thread epirat07
From: Marvin Scholz epira...@gmail.com Icecast is basically a convenience wrapper around the HTTP protocol. --- Changelog| 1 + configure| 1 + doc/general.texi | 1 + doc/protocols.texi | 40 + libavformat/Makefile | 1 +

Re: [libav-devel] [PATCH] detect Vanc/Vbi SMPTE-436M mxf track

2014-07-22 Thread Luca Barbato
On 22/07/14 15:12, Marc-Antoine Arnaud wrote: --- libavformat/mxfdec.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 58d9027..2d7ac48 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -971,6 +971,15 @@

Re: [libav-devel] [PATCH] detect Vanc/Vbi SMPTE-436M mxf track

2014-07-22 Thread Marc-Antoine ARNAUD
I need to change to 1 for the mxf_data_essence_descriptor. It test some others kings but actually I don't have. And I add the check of the size of the mxf_data_essence_descriptor. I update and re-submit the patch. thx 2014-07-22 15:26 GMT+02:00 Luca Barbato lu_z...@gentoo.org: On 22/07/14

Re: [libav-devel] [PATCH 8/8] fft-test: KR formatting cosmetics

2014-07-22 Thread Katerina Barone-Adesi
LGTM. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/8] fft-test: Comment some #endifs

2014-07-22 Thread Katerina Barone-Adesi
LGTM. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 6/8] fft-test: Check memory allocations

2014-07-22 Thread Katerina Barone-Adesi
Shouldn't cleanup also contain av_free(tab_ref)? ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/8] dct/rdft: Add missing typedefs for context structs

2014-07-22 Thread Katerina Barone-Adesi
LGTM. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/8] fft-test: Drop unnecessary #ifdefs around header includes

2014-07-22 Thread Katerina Barone-Adesi
LGTM. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 7/8] fft-test: Make global exptab variable static

2014-07-22 Thread Katerina Barone-Adesi
LGTM. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] configure: Extend the neon intrinsics check

2014-07-22 Thread Diego Biurrun
On Tue, Jul 22, 2014 at 03:29:52PM +0300, Martin Storsjö wrote: This instruction causes the (very old) apple gcc 4.2 to error out (unrecognizable insn). --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I'd say Check for an instruction that causes the (very old) Apple GCC

Re: [libav-devel] [PATCH 5/8] fft-test: Drop unnecessary pointer indirection for context structs

2014-07-22 Thread Katerina Barone-Adesi
LGTM. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] detect Vanc/Vbi SMPTE-436M mxf track

2014-07-22 Thread Marc-Antoine Arnaud
--- libavformat/mxfdec.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 58d9027..a4f8802 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -971,6 +971,17 @@ static const MXFCodecUL

Re: [libav-devel] [PATCH 4/8] fft-test: Reduce variable scope where sensibly possible

2014-07-22 Thread Katerina Barone-Adesi
I'm not entirely convinced stylistically by int i, j, n = 1 nbits, n2 = n 1; - it's a bit cluttered for a declaration line; maybe split it into two lines? Aside from that, LGTM. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] detect Vanc/Vbi SMPTE-436M mxf track

2014-07-22 Thread Luca Barbato
On 22/07/14 16:08, Marc-Antoine Arnaud wrote: --- libavformat/mxfdec.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 58d9027..a4f8802 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -971,6 +971,17

Re: [libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

2014-07-22 Thread Diego Biurrun
On Tue, Jul 22, 2014 at 03:16:28PM +0200, epira...@gmail.com wrote: --- /dev/null +++ b/libavformat/icecast.c @@ -0,0 +1,228 @@ +static int icecast_open(URLContext *h, const char *uri, int flags) +{ +IcecastContext *s = h-priv_data; + +// Dict to set options that we pass to HTTP

[libav-devel] [PATCH] extract origin information from material and source track

2014-07-22 Thread Marc-Antoine Arnaud
--- libavformat/mxfdec.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 58d9027..631705cd 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -111,6 +111,7 @@ typedef struct { UID *structural_components_refs;

Re: [libav-devel] [PATCH 2/5] libxvid: Drop PPC-specific CPU detection hack

2014-07-22 Thread Janne Grunau
On 2014-07-22 10:01:35 +0200, Diego Biurrun wrote: On Tue, Jul 22, 2014 at 12:04:38AM +0200, Janne Grunau wrote: On 2014-07-21 14:21:07 -0700, Diego Biurrun wrote: It is doubtful if the hack (still) works and PPC is obsolete for encoding. not so sure about the latter but xvid had enough

Re: [libav-devel] [PATCH] build: Add define for SIMD extensions requiring 16-byte aligned buffers

2014-07-22 Thread Janne Grunau
On 2014-07-22 04:03:02 -0700, Diego Biurrun wrote: --- Changed to also replace the need_memalign variable in configure, which essentially indicates the same thing. I've followed the git-blame path of STRIDE_ALIGN and an now confident this is the correct solution for a number of hacks that

[libav-devel] [PATCH] libavformat/icecast: Add Icecast protocol

2014-07-22 Thread epirat07
From: Marvin Scholz epira...@gmail.com Icecast is basically a convenience wrapper around the HTTP protocol. --- Changelog| 1 + configure| 1 + doc/general.texi | 1 + doc/protocols.texi | 40 + libavformat/Makefile | 1 +

Re: [libav-devel] [PATCH] build: Add define for SIMD extensions requiring 16-byte aligned buffers

2014-07-22 Thread Hendrik Leppkes
Am 22.07.2014 19:49 schrieb Janne Grunau janne-li...@jannau.net: On 2014-07-22 04:03:02 -0700, Diego Biurrun wrote: --- Changed to also replace the need_memalign variable in configure, which essentially indicates the same thing. I've followed the git-blame path of STRIDE_ALIGN and an

Re: [libav-devel] [PATCH] build: Add define for SIMD extensions requiring 16-byte aligned buffers

2014-07-22 Thread Diego Biurrun
On Tue, Jul 22, 2014 at 08:28:35PM +0200, Hendrik Leppkes wrote: Am 22.07.2014 19:49 schrieb Janne Grunau janne-li...@jannau.net: On 2014-07-22 04:03:02 -0700, Diego Biurrun wrote: --- Changed to also replace the need_memalign variable in configure, which essentially indicates the

[libav-devel] [PATCH] http: KR formatting cosmetics

2014-07-22 Thread Diego Biurrun
Also comment some #endifs and sort headers into canonical order. --- libavformat/http.c | 220 +++-- 1 file changed, 113 insertions(+), 107 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index 6c390e8..9507f0d 100644 ---

[libav-devel] [PATCH] mpegvideo: Move QUANT_BIAS_SHIFT define to the only place it is used

2014-07-22 Thread Diego Biurrun
--- libavcodec/mpegvideo.h | 2 +- libavcodec/mpegvideo_enc.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h index 3bd87df..1a7c1b1 100644 --- a/libavcodec/mpegvideo.h +++ b/libavcodec/mpegvideo.h @@ -430,7 +430,7 @@

Re: [libav-devel] [PATCH] http: KR formatting cosmetics

2014-07-22 Thread Luca Barbato
On 22/07/14 20:44, Diego Biurrun wrote: Also comment some #endifs and sort headers into canonical order. --- libavformat/http.c | 220 +++-- 1 file changed, 113 insertions(+), 107 deletions(-) diff --git a/libavformat/http.c

Re: [libav-devel] [PATCH 6/8] fft-test: Check memory allocations

2014-07-22 Thread Diego Biurrun
On Tue, Jul 22, 2014 at 03:44:17PM +0200, Katerina Barone-Adesi wrote: Shouldn't cleanup also contain av_free(tab_ref)? It does if you look at the file, it's just that the diff has only three lines of context. Diego ___ libav-devel mailing list

[libav-devel] [PATCH] fft-test: Reduce variable scope where sensibly possible

2014-07-22 Thread Diego Biurrun
Also merge variable declaration and initialization. --- Uncluttered a declaration line according to Katerina's preference. libavcodec/fft-test.c | 86 +-- 1 file changed, 35 insertions(+), 51 deletions(-) diff --git a/libavcodec/fft-test.c

[libav-devel] [PATCH 1/2] fft: Expose both fixed and float variant of FFTSample in public header

2014-07-22 Thread Diego Biurrun
This allows unconditionally including the public header and cleaning up some duplicated declarations. It also allows cleanly eliminating redefined typedefs for fft-related context structs. --- This is the cleanest solution to the redefined typedefs that I found. All headers work standalone now

[libav-devel] [PATCH 2/2] fft: Restructure includes in internal header to compile standalone

2014-07-22 Thread Diego Biurrun
--- libavcodec/Makefile | 1 - libavcodec/fft-internal.h | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 9ce37a8..a9a64a9 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -700,7 +700,6 @@

[libav-devel] [PATCH] fft-test: Reduce variable scope where sensibly possible

2014-07-22 Thread Diego Biurrun
Also merge variable declaration and initialization. --- Updated again after feedback from Katerina and Martin. libavcodec/fft-test.c | 86 +-- 1 file changed, 35 insertions(+), 51 deletions(-) diff --git a/libavcodec/fft-test.c

[libav-devel] [PATCH] fft-test: Reduce variable scope where sensibly possible

2014-07-22 Thread Diego Biurrun
Also merge variable declaration and initialization. --- Ahem, correct patch sent now ... libavcodec/fft-test.c | 87 +-- 1 file changed, 36 insertions(+), 51 deletions(-) diff --git a/libavcodec/fft-test.c b/libavcodec/fft-test.c index