[libav-devel] [PATCH] mov: add more udta meta data recognition

From: Xidorn Quan --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 39e6883..6c20fc2 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -280,6 +280,8 @@ static int mov_read_udta_string(MOVContext *c, AVIOContext *pb, M

Re: [libav-devel] [PATCH] libavformat: reaplace old ASF demuxer (asfdec.c) with new code written according to the specification

Quoting Alexandra Hájková (2014-11-21 20:03:15) > From: alexandra Broken git configuration. > > This work is part of Outreach Program for Women Summer 2014 activities. > --- > libavformat/asfdec.c | 1522 > - > libavformat/asfdec2.c | 1425

[libav-devel] [PATCH] lavf: Replace the ASF demuxer

From: alexandra The old one is result of reverse engineering and guesswork. The new one had been written following the now-available specification. This work is part of Outreach Program for Women Summer 2014 activities. Signed-off-by: Luca Barbato --- https://github.com/lu-zero/libav/blob/1c8

[libav-devel] [PATCH] libavformat: reaplace old ASF demuxer (asfdec.c) with new code written according to the specification

From: alexandra This work is part of Outreach Program for Women Summer 2014 activities. --- libavformat/asfdec.c | 1522 - libavformat/asfdec2.c | 1425 + 2 files changed, 1425 insertions(+), 1522 deleti

Re: [libav-devel] [PATCH 09/10] mpegenc: prevent a NULL pointer dereference

g On Fri, Nov 21, 2014 at 3:55 PM, Martin Storsjö wrote: > On Fri, 21 Nov 2014, Vittorio Giovara wrote: > >> On Fri, Nov 21, 2014 at 1:26 PM, Luca Barbato wrote: >>> >>> On 21/11/14 13:57, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 29261 --- libavfor

Re: [libav-devel] [PATCH 09/10] mpegenc: prevent a NULL pointer dereference

On Fri, 21 Nov 2014, Vittorio Giovara wrote: On Fri, Nov 21, 2014 at 1:26 PM, Luca Barbato wrote: On 21/11/14 13:57, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 29261 --- libavformat/mpegenc.c | 2 +- tests/ref/lavf/mpg | 6 +++--- tests/ref/lavf/ts | 4 ++-

Re: [libav-devel] [PATCH 01/10] vc1: fix bad shift operations

On Fri, Nov 21, 2014 at 1:23 PM, Luca Barbato wrote: > On 21/11/14 13:57, Vittorio Giovara wrote: >> From: Michael Niedermayer >> >> CC: libav-sta...@libav.org >> Bug-Id: CID 1194380 / CID 1194381 >> --- >> libavcodec/vc1_block.c | 12 >> libavcodec/vc1_loopfilter.c | 14 ++

Re: [libav-devel] [PATCH 09/10] mpegenc: prevent a NULL pointer dereference

On Fri, Nov 21, 2014 at 1:26 PM, Luca Barbato wrote: > On 21/11/14 13:57, Vittorio Giovara wrote: >> CC: libav-sta...@libav.org >> Bug-Id: CID 29261 >> --- >> libavformat/mpegenc.c | 2 +- >> tests/ref/lavf/mpg | 6 +++--- >> tests/ref/lavf/ts | 4 ++-- >> tests/ref/seek/lavf-mpg

Re: [libav-devel] [PATCH 10/10] lavu: move internal define to the only places where it is used

On 21/11/14 13:57, Vittorio Giovara wrote: > --- > libavcodec/h263.h | 1 + > libavcodec/h264_cabac.c | 1 + > libavutil/internal.h| 4 > 3 files changed, 2 insertions(+), 4 deletions(-) > Ok. ___ libav-devel mailing list libav-devel@li

Re: [libav-devel] [PATCH 08/10] motion_est: x86: convert stride to ptrdiff_t

On 21/11/14 13:57, Vittorio Giovara wrote: > CC: libav-sta...@libav.org > Bug-Id: CID 700556 / CID 700557 / CID700558 drop x86. the patch itself seems fine to me (oracle hopefully agrees). lu ___ libav-devel mailing list libav-devel@libav.org https://li

Re: [libav-devel] [PATCH 09/10] mpegenc: prevent a NULL pointer dereference

On 21/11/14 13:57, Vittorio Giovara wrote: > CC: libav-sta...@libav.org > Bug-Id: CID 29261 > --- > libavformat/mpegenc.c | 2 +- > tests/ref/lavf/mpg | 6 +++--- > tests/ref/lavf/ts | 4 ++-- > tests/ref/seek/lavf-mpg | 12 ++-- > tests/ref/seek/lavf-ts | 16 -

Re: [libav-devel] [PATCH 07/10] aacdec: avoid an out-of-bounds write

On 21/11/14 13:57, Vittorio Giovara wrote: > Also move the check in the case it is actually used. > > CC: libav-sta...@libav.org > Bug-Id: CID 1087090 > --- > libavcodec/aacdec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.

Re: [libav-devel] [PATCH 02/10] sol: simplify sol_codec_id()

On 21/11/14 13:57, Vittorio Giovara wrote: > Bug-Id: CID 1238993 > --- > libavformat/sol.c | 19 --- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/libavformat/sol.c b/libavformat/sol.c > index 92599b1..30f0547 100644 > --- a/libavformat/sol.c > +++ b/libavfor

Re: [libav-devel] [PATCH 01/10] vc1: fix bad shift operations

On 21/11/14 13:57, Vittorio Giovara wrote: > From: Michael Niedermayer > > CC: libav-sta...@libav.org > Bug-Id: CID 1194380 / CID 1194381 > --- > libavcodec/vc1_block.c | 12 > libavcodec/vc1_loopfilter.c | 14 +++--- > 2 files changed, 15 insertions(+), 11 deletions(-)

Re: [libav-devel] [PATCH 09/11] cook: fix use of uninitialized variable

On 21/11/14 13:35, Vittorio Giovara wrote: > On Wed, Nov 12, 2014 at 12:57 PM, Luca Barbato wrote: >> On 12/11/14 11:13, Vittorio Giovara wrote: >>> From: Michael Niedermayer >>> >>> CC: libav-sta...@libav.org >>> Bug-Id: CID 741418 >>> --- >>> libavcodec/cook.c | 2 +- >>> 1 file changed, 1 ins

[libav-devel] [PATCH 09/10] mpegenc: prevent a NULL pointer dereference

CC: libav-sta...@libav.org Bug-Id: CID 29261 --- libavformat/mpegenc.c | 2 +- tests/ref/lavf/mpg | 6 +++--- tests/ref/lavf/ts | 4 ++-- tests/ref/seek/lavf-mpg | 12 ++-- tests/ref/seek/lavf-ts | 16 5 files changed, 20 insertions(+), 20 deletions(-) di

[libav-devel] [PATCH 03/10] aac: Simplify decode_mid_side_stereo

From: Luca Barbato Might spare few cycles if the compiler is naive and makes the function more readable. --- libavcodec/aacdec.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index d2d51f5..6968102 100644 --- a/libavcodec/aac

[libav-devel] [PATCH 08/10] motion_est: x86: convert stride to ptrdiff_t

CC: libav-sta...@libav.org Bug-Id: CID 700556 / CID 700557 / CID700558 --- libavcodec/arm/me_cmp_init_arm.c | 10 +-- libavcodec/me_cmp.c | 116 +- libavcodec/me_cmp.h | 3 +- libavcodec/ppc/me_cmp.c | 56 - lib

[libav-devel] [PATCH 06/10] tiff: Use the same type for add_entry and check_size

From: Luca Barbato Bug-Id: CID 700699 CC: libav-sta...@libav.org --- libavcodec/tiffenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/tiffenc.c b/libavcodec/tiffenc.c index b28f72b..0f9ac80 100644 --- a/libavcodec/tiffenc.c +++ b/libavcodec/tiffenc.c @@ -113,7

[libav-devel] [PATCH 05/10] prores: Evaluate all the quantizers

From: Luca Barbato Prevent an uninitialized data access. CC: libav-sta...@libav.org Bug-Id: CID 703824 / CID 703825 Signed-off-by: Vittorio Giovara --- libavcodec/proresenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/proresenc.c b/libavcodec/prorese

[libav-devel] [PATCH 10/10] lavu: move internal define to the only places where it is used

--- libavcodec/h263.h | 1 + libavcodec/h264_cabac.c | 1 + libavutil/internal.h| 4 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/h263.h b/libavcodec/h263.h index dbbe7ce..c5e3020 100644 --- a/libavcodec/h263.h +++ b/libavcodec/h263.h @@ -29,6 +29,7 @@

[libav-devel] [PATCH 04/10] aacsbr: always initialize max_qmf_subbands

Fixes a wordly warning from clang -Wsometimes-uninitialized. --- libavcodec/aacsbr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c index 76c1014..52ebe65 100644 --- a/libavcodec/aacsbr.c +++ b/libavcodec/aacsbr.c @@ -321,7 +321,7 @@ s

[libav-devel] [PATCH 07/10] aacdec: avoid an out-of-bounds write

Also move the check in the case it is actually used. CC: libav-sta...@libav.org Bug-Id: CID 1087090 --- libavcodec/aacdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index 6968102..9c0a46d 100644 --- a/libavcodec/aacdec.c +++

[libav-devel] [PATCH 02/10] sol: simplify sol_codec_id()

Bug-Id: CID 1238993 --- libavformat/sol.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/libavformat/sol.c b/libavformat/sol.c index 92599b1..30f0547 100644 --- a/libavformat/sol.c +++ b/libavformat/sol.c @@ -50,18 +50,15 @@ static int sol_probe(AVProbeDat

[libav-devel] [PATCH 01/10] vc1: fix bad shift operations

From: Michael Niedermayer CC: libav-sta...@libav.org Bug-Id: CID 1194380 / CID 1194381 --- libavcodec/vc1_block.c | 12 libavcodec/vc1_loopfilter.c | 14 +++--- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/libavcodec/vc1_block.c b/libavcodec/vc1_bloc

[libav-devel] [PATCH 00/10] fatb - last round

And this is (really) the last set of coverity-related fixes. We got more than 100 fixes that were not applied anywhere else and hopefully made sure to dissipate any rumor claiming that Libav does not care about security. We got a very nice triaging for each 'false positive' bug and new releases wi

Re: [libav-devel] [PATCH 06/11] mpegenc: prevent a NULL pointer dereference

On Fri, Nov 21, 2014 at 12:32 PM, Luca Barbato wrote: > On 19/11/14 07:28, Vittorio Giovara wrote: >> On Mon, Nov 17, 2014 at 12:22 AM, Vittorio Giovara >> wrote: >>> CC: libav-sta...@libav.org >>> Bug-Id: CID 29261 >>> --- >>> libavformat/mpegenc.c | 2 +- >>> tests/ref/lavf/mpg | 6 ++

Re: [libav-devel] [PATCH 09/11] cook: fix use of uninitialized variable

On Wed, Nov 12, 2014 at 12:57 PM, Luca Barbato wrote: > On 12/11/14 11:13, Vittorio Giovara wrote: >> From: Michael Niedermayer >> >> CC: libav-sta...@libav.org >> Bug-Id: CID 741418 >> --- >> libavcodec/cook.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcode

Re: [libav-devel] [PATCH 13/13] dvdsub: Do not leak on failure path

On 21/11/14 12:51, Vittorio Giovara wrote: > On Sat, Nov 15, 2014 at 11:54 AM, Vittorio Giovara > wrote: >> On Wed, Nov 12, 2014 at 1:48 PM, Luca Barbato wrote: >>> On 12/11/14 11:14, Vittorio Giovara wrote: On Sun, Nov 9, 2014 at 8:48 AM, Vittorio Giovara wrote: > From: Luca Barba

Re: [libav-devel] [PATCH 08/10] vp9: Use the correct upper bound for seg_id

On 21/11/14 12:58, Vittorio Giovara wrote: > On Sat, Nov 15, 2014 at 11:51 AM, Vittorio Giovara > wrote: >> On Tue, Nov 11, 2014 at 1:27 PM, Vittorio Giovara >> wrote: >>> From: Luca Barbato >>> >>> And use a macro to make apparent why the value. >>> >>> Bug-Id: CID 1108595 >>> --- >>> libavcod

Re: [libav-devel] [PATCH 07/10] qdm2: avoid integer overflow

On 21/11/14 13:01, Vittorio Giovara wrote: > On Fri, Nov 14, 2014 at 11:09 AM, Luca Barbato wrote: >> On 12/11/14 19:10, Vittorio Giovara wrote: >>> CC: libav-sta...@libav.org >>> Bug-Id: CID 700555 >>> --- >>> libavcodec/qdm2.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> di

Re: [libav-devel] [PATCH 06/11] mpegenc: prevent a NULL pointer dereference

On 19/11/14 07:28, Vittorio Giovara wrote: > On Mon, Nov 17, 2014 at 12:22 AM, Vittorio Giovara > wrote: >> CC: libav-sta...@libav.org >> Bug-Id: CID 29261 >> --- >> libavformat/mpegenc.c | 2 +- >> tests/ref/lavf/mpg | 6 +++--- >> tests/ref/lavf/ts | 4 ++-- >> tests/ref/seek/la

Re: [libav-devel] [PATCH 05/11] matroskaenc: check av_rescale_q() return value

On 21/11/14 12:52, Vittorio Giovara wrote: > On Sun, Nov 16, 2014 at 11:58 PM, Luca Barbato wrote: >> On 17/11/14 00:22, Vittorio Giovara wrote: >>> Do not write negative values in CodecDelay as the embl accepts only >>> unsigned integers. >>> >>> CC: libav-sta...@libav.org >>> Bug-Id: CID 1238790

Re: [libav-devel] [PATCH 03/10] utvideoenc: avoid integer overflow

On 21/11/14 13:05, Vittorio Giovara wrote: > On Fri, Nov 14, 2014 at 10:34 AM, Luca Barbato wrote: >> On 12/11/14 19:10, Vittorio Giovara wrote: >>> CC: libav-sta...@libav.org >>> Bug-Id: CID 732245 >>> --- >>> libavcodec/utvideoenc.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>

Re: [libav-devel] [PATCH] lavc: Move the libtwolame encoder registration to the list for external libraries

On Fri, Nov 21, 2014 at 12:23 PM, Martin Storsjö wrote: > This makes sure the default behaviour of using the internal encoder > stays the same regardless if libtwolame is enabled or not (as for > any external library). > > This fixes fate-lavf-mpg if libav is built with libtwolame enabled. > --- >

Re: [libav-devel] [PATCH 09/11] lzwenc: check for negative indexes

On 21/11/14 13:09, Vittorio Giovara wrote: > On Wed, Nov 12, 2014 at 12:59 PM, Luca Barbato wrote: >> On 12/11/14 11:06, Vittorio Giovara wrote: >>> On Tue, Nov 11, 2014 at 6:08 PM, Luca Barbato wrote: On 11/11/14 17:40, Vittorio Giovara wrote: > CC: libav-sta...@libav.org > Bug-Id:

[libav-devel] [PATCH] lavc: Move the libtwolame encoder registration to the list for external libraries

This makes sure the default behaviour of using the internal encoder stays the same regardless if libtwolame is enabled or not (as for any external library). This fixes fate-lavf-mpg if libav is built with libtwolame enabled. --- libavcodec/allcodecs.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [libav-devel] [PATCH 09/11] lzwenc: check for negative indexes

On Wed, Nov 12, 2014 at 12:59 PM, Luca Barbato wrote: > On 12/11/14 11:06, Vittorio Giovara wrote: >> On Tue, Nov 11, 2014 at 6:08 PM, Luca Barbato wrote: >>> On 11/11/14 17:40, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 700465 / CID 1240206 --- libavcodec

Re: [libav-devel] [PATCH 03/10] utvideoenc: avoid integer overflow

On Fri, Nov 14, 2014 at 10:34 AM, Luca Barbato wrote: > On 12/11/14 19:10, Vittorio Giovara wrote: >> CC: libav-sta...@libav.org >> Bug-Id: CID 732245 >> --- >> libavcodec/utvideoenc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/utvideoenc.c b/libavcodec

Re: [libav-devel] [PATCH] libtwolame: prevent a NULL pointer dereference

On Fri, 21 Nov 2014, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 1250330 / CID 1250335 --- Followed Martin's suggestion. Vittorio libavcodec/libtwolame.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libtwolame.c b/libavcodec/libtwolame.c index

Re: [libav-devel] [PATCH 07/10] qdm2: avoid integer overflow

On Fri, Nov 14, 2014 at 11:09 AM, Luca Barbato wrote: > On 12/11/14 19:10, Vittorio Giovara wrote: >> CC: libav-sta...@libav.org >> Bug-Id: CID 700555 >> --- >> libavcodec/qdm2.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/qdm2.c b/libavcodec/qdm2.c >> i

Re: [libav-devel] [PATCH 08/10] vp9: Use the correct upper bound for seg_id

On Sat, Nov 15, 2014 at 11:51 AM, Vittorio Giovara wrote: > On Tue, Nov 11, 2014 at 1:27 PM, Vittorio Giovara > wrote: >> From: Luca Barbato >> >> And use a macro to make apparent why the value. >> >> Bug-Id: CID 1108595 >> --- >> libavcodec/vp9.h | 3 ++- >> libavcodec/vp9block.c | 3 ++-

[libav-devel] [PATCH] libtwolame: prevent a NULL pointer dereference

CC: libav-sta...@libav.org Bug-Id: CID 1250330 / CID 1250335 --- Followed Martin's suggestion. Vittorio libavcodec/libtwolame.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libtwolame.c b/libavcodec/libtwolame.c index 400985a..ce32941 100644 --- a/libavcodec/libt

Re: [libav-devel] [PATCH 06/11] mpegenc: prevent a NULL pointer dereference

On Wed, Nov 19, 2014 at 6:28 AM, Vittorio Giovara wrote: > On Mon, Nov 17, 2014 at 12:22 AM, Vittorio Giovara > wrote: >> CC: libav-sta...@libav.org >> Bug-Id: CID 29261 >> --- >> libavformat/mpegenc.c | 2 +- >> tests/ref/lavf/mpg | 6 +++--- >> tests/ref/lavf/ts | 4 ++-- >> te

Re: [libav-devel] [PATCH 05/11] matroskaenc: check av_rescale_q() return value

On Sun, Nov 16, 2014 at 11:58 PM, Luca Barbato wrote: > On 17/11/14 00:22, Vittorio Giovara wrote: >> Do not write negative values in CodecDelay as the embl accepts only >> unsigned integers. >> >> CC: libav-sta...@libav.org >> Bug-Id: CID 1238790 >> --- >> libavformat/matroskaenc.c | 11 +++-

Re: [libav-devel] [PATCH 13/13] dvdsub: Do not leak on failure path

On Sat, Nov 15, 2014 at 11:54 AM, Vittorio Giovara wrote: > On Wed, Nov 12, 2014 at 1:48 PM, Luca Barbato wrote: >> On 12/11/14 11:14, Vittorio Giovara wrote: >>> On Sun, Nov 9, 2014 at 8:48 AM, Vittorio Giovara >>> wrote: From: Luca Barbato >> > > ping ping -- Vittorio ___

Re: [libav-devel] [PATCH 10/11] roqaudioenc: Fix crash with very small roq files

On Sat, Nov 15, 2014 at 11:52 AM, Vittorio Giovara wrote: > On Wed, Nov 12, 2014 at 11:13 AM, Vittorio Giovara > wrote: >> From: Michael Niedermayer >> >> Also remove redundant check. >> >> CC: libav-sta...@libav.org >> Bug-Id: CID 703669 >> --- >> libavcodec/roqaudioenc.c | 4 +++- >> 1 file c

Re: [libav-devel] [PATCH 08/11] hnm4video: change width/height to int to fix hypothetical integer overflows

On Sat, Nov 15, 2014 at 11:56 AM, Vittorio Giovara wrote: > On Wed, Nov 12, 2014 at 1:50 PM, Luca Barbato wrote: >> On 12/11/14 11:13, Vittorio Giovara wrote: >>> From: Michael Niedermayer >>> >>> CC: libav-sta...@libav.org >>> Bug-Id: CID 1135770 / CID 1135771 >>> --- >>> libavcodec/hnm4video.

Re: [libav-devel] [PATCH 01/10] apedec: fix bit shift typo check, prevent undefined behavior

On Sat, Nov 15, 2014 at 11:59 AM, Vittorio Giovara wrote: > On Fri, Nov 14, 2014 at 12:07 PM, Luca Barbato wrote: >> On 12/11/14 19:10, Vittorio Giovara wrote: >>> From: Michael Niedermayer >>> >>> CC: libav-sta...@libav.org >>> Bug-Id: CID 1206639 >>> Signed-off-by: Vittorio Giovara >>> --- >>

Re: [libav-devel] DSS demuxer and dss_sp decoder

On 21/11/14 11:36, Luca Barbato wrote: > Review in patch form: > > - The demuxer had a couple of small mistakes asan spotted > - Applied coding [style][1] using [uncrustify][2] > > Somebody with more audio experience might figure out what to use of our > already-optimized routines, some code look

[libav-devel] DSS demuxer and dss_sp decoder

Review in patch form: - The demuxer had a couple of small mistakes asan spotted - Applied coding [style][1] using [uncrustify][2] Somebody with more audio experience might figure out what to use of our already-optimized routines, some code looks quite similar to others. [1]: https://wiki.libav.o

[libav-devel] [PATCH 2/2] lavf: Add DSS demuxer

From: Oleksij Rempel Signed-off-by: Oleksij Rempel Signed-off-by: Luca Barbato --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/dss.c| 326 +++ 3 files changed, 328 insertions(+) create mode 100644 libavfor

[libav-devel] [PATCH 1/2] lavc: Add dss_sp decoder

From: Oleksij Rempel Signed-off-by: Oleksij Rempel Signed-off-by: Luca Barbato --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavcodec/dss_sp_dec.c | 793