Re: [libav-devel] [PATCH 2/2] rtsp: free opts dictionary on failure of getnameinfo

2015-12-06 Thread Martin Storsjö
On Mon, 7 Dec 2015, Anton Khirnov wrote: Quoting Ganesh Ajjanagadde (2015-12-07 00:44:37) On Sun, Dec 6, 2015 at 6:17 PM, Luca Barbato wrote: > On 06/12/15 20:30, Martin Storsjö wrote: >> From: Ganesh Ajjanagadde >> >> --- >> libavformat/rtsp.c | 1 + >> 1 file changed, 1 insertion(+) >> >>

Re: [libav-devel] [PATCH 2/2] rtsp: free opts dictionary on failure of getnameinfo

2015-12-06 Thread Anton Khirnov
Quoting Ganesh Ajjanagadde (2015-12-07 00:44:37) > On Sun, Dec 6, 2015 at 6:17 PM, Luca Barbato wrote: > > On 06/12/15 20:30, Martin Storsjö wrote: > >> From: Ganesh Ajjanagadde > >> > >> --- > >> libavformat/rtsp.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/libavformat/rt

Re: [libav-devel] [PATCH 2/2] rtsp: free opts dictionary on failure of getnameinfo

2015-12-06 Thread Ganesh Ajjanagadde
On Sun, Dec 6, 2015 at 6:17 PM, Luca Barbato wrote: > On 06/12/15 20:30, Martin Storsjö wrote: >> From: Ganesh Ajjanagadde >> >> --- >> libavformat/rtsp.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c >> index 2c616e8..4beb275 100644 >> --- a

Re: [libav-devel] [PATCH 2/2] rtsp: free opts dictionary on failure of getnameinfo

2015-12-06 Thread Luca Barbato
On 06/12/15 20:30, Martin Storsjö wrote: > From: Ganesh Ajjanagadde > > --- > libavformat/rtsp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c > index 2c616e8..4beb275 100644 > --- a/libavformat/rtsp.c > +++ b/libavformat/rtsp.c > @@ -2279,6 +2

Re: [libav-devel] [PATCH 1/2] movenc-test: add a missing va_end call

2015-12-06 Thread Luca Barbato
On 06/12/15 20:30, Martin Storsjö wrote: > From: Ganesh Ajjanagadde > > --- > libavformat/movenc-test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/movenc-test.c b/libavformat/movenc-test.c > index 0c40b3a..6520aea 100644 > --- a/libavformat/movenc-test.c > +++ b/libavf

[libav-devel] [PATCH 1/2] movenc-test: add a missing va_end call

2015-12-06 Thread Martin Storsjö
From: Ganesh Ajjanagadde --- libavformat/movenc-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/movenc-test.c b/libavformat/movenc-test.c index 0c40b3a..6520aea 100644 --- a/libavformat/movenc-test.c +++ b/libavformat/movenc-test.c @@ -137,6 +137,7 @@ static void check_fun

[libav-devel] [PATCH 2/2] rtsp: free opts dictionary on failure of getnameinfo

2015-12-06 Thread Martin Storsjö
From: Ganesh Ajjanagadde --- libavformat/rtsp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 2c616e8..4beb275 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -2279,6 +2279,7 @@ static int sdp_read_header(AVFormatContext *s)

Re: [libav-devel] [PATCH] diracdec: Move strides to bytes, and pointer types to uint8_t.

2015-12-06 Thread Diego Biurrun
On Sun, Dec 06, 2015 at 12:36:24PM +, Kieran Kunhya wrote: > Start templating functions for move to support 10-bit > Parts of this patch were written by Rostislav Pehlivanov > --- a/libavcodec/diracdec.c > +++ b/libavcodec/diracdec.c > @@ -507,6 +479,38 @@ static inline int coeff_unpack_golomb(

[libav-devel] [PATCH] diracdec: Move strides to bytes, and pointer types to uint8_t.

2015-12-06 Thread Kieran Kunhya
Start templating functions for move to support 10-bit Parts of this patch were written by Rostislav Pehlivanov --- libavcodec/dirac.c | 10 +- libavcodec/dirac.h | 3 +- libavcodec/diracdec.c | 227 ++-- libavformat/oggparsedirac.c

Re: [libav-devel] [PATCH 028/264] vocdec: do not create the stream in read_header()

2015-12-06 Thread Luca Barbato
On 06/12/15 10:59, Anton Khirnov wrote: > The stream parameters are not known until we read a packet, so postpone > creating it until then. > --- > libavformat/vocdec.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > Ok. ___ li

Re: [libav-devel] [PATCH 027/264] vocdec: put the code not shared with other demuxers under appropriate ifdef

2015-12-06 Thread Luca Barbato
On 06/12/15 10:59, Anton Khirnov wrote: > --- > libavformat/vocdec.c | 77 > ++-- > 1 file changed, 39 insertions(+), 38 deletions(-) Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.

Re: [libav-devel] [PATCH 024/264] mp3dec: replace avpriv_mpa_decode_header with avpriv_mpegaudio_decode_header

2015-12-06 Thread Luca Barbato
On 06/12/15 10:59, Anton Khirnov wrote: > The latter does not require a full AVCodecContext and still provides all > the functionality needed here. > --- > libavformat/mp3dec.c | 17 ++--- > 1 file changed, 6 insertions(+), 11 deletions(-) Sounds ok. _

Re: [libav-devel] [PATCH 023/264] mpegaudiodecheader: check the header in avpriv_mpegaudio_decode_header

2015-12-06 Thread Luca Barbato
On 06/12/15 10:59, Anton Khirnov wrote: > Almost all the places from which this function is called already check > the header manually and in the two that don't (the mp3 muxer) the check > should not cause any problems. > --- > libavcodec/libmp3lame.c| 7 --- > libavcodec/mpegaudi

Re: [libav-devel] [PATCH 025/264] lavc: make avpriv_mpa_decode_header private on next bump

2015-12-06 Thread Luca Barbato
On 06/12/15 10:59, Anton Khirnov wrote: > It's not used by anything outside of lavc anymore. > --- > libavcodec/mpegaudio_parser.c | 2 +- > libavcodec/mpegaudiodecheader.c | 10 +- > libavcodec/mpegaudiodecheader.h | 5 + > 3 files changed, 15 insertions(+), 2 deletions(-) > Ok.

Re: [libav-devel] [PATCH 2/2] aacdec: fix aac_static_table_init() prototype

2015-12-06 Thread Diego Biurrun
On Sun, Dec 06, 2015 at 11:02:49AM +0100, Anton Khirnov wrote: > --- > libavcodec/aacdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) OK I have the same locally in a large branch that eliminates almost all compiler warnings, btw. Diego __

Re: [libav-devel] [PATCH 022/264] lavc: get the profile name through the codec descriptor in avcodec_string()

2015-12-06 Thread Luca Barbato
On 06/12/15 10:58, Anton Khirnov wrote: > --- > libavcodec/utils.c | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-) > Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 021/264] lavc: add profiles to AVCodecDescriptor

2015-12-06 Thread Luca Barbato
On 06/12/15 10:58, Anton Khirnov wrote: > The profiles are a property of the codec, so it makes sense to export > them through AVCodecDescriptors, not just the codec implementations. > --- Ok. ___ libav-devel mailing list libav-devel@libav.org https://l

Re: [libav-devel] [PATCH 020/264] lavc: print the name of the codec, not its implementation, in avcodec_string

2015-12-06 Thread Luca Barbato
On 06/12/15 10:58, Anton Khirnov wrote: > --- > libavcodec/utils.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 019/264] r3d: do not create the audio stream until we know the sample rate

2015-12-06 Thread Luca Barbato
On 06/12/15 10:58, Anton Khirnov wrote: > --- > libavformat/r3d.c | 37 + > 1 file changed, 25 insertions(+), 12 deletions(-) > Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/

Re: [libav-devel] [PATCH 018/264] ff_parse_specific_params: do not use AVCodecContext.frame_size

2015-12-06 Thread Luca Barbato
On 06/12/15 10:58, Anton Khirnov wrote: > It will not be set unless the muxing codec context is also the encoding > context, which is discouraged. When the frame size is not known from > av_get_audio_frame_duration(), the fallback should still be good enough. > --- > libavformat/riffenc.c | 5

Re: [libav-devel] [PATCH 017/264] rmenc: do not use AVCodecContext.frame_size

2015-12-06 Thread Luca Barbato
On 06/12/15 10:58, Anton Khirnov wrote: > It will not be set if the stream codec context is not the encoding > context. Use av_get_audio_frame_duration() instead, it should work for > all audio codecs supported by the muxer. > --- > libavformat/rmenc.c | 7 +-- > 1 file changed, 5 insertions(+

Re: [libav-devel] [PATCH 1/2] avpacket: use ERANGE instead of EOVERFLOW

2015-12-06 Thread Luca Barbato
On 06/12/15 11:02, Anton Khirnov wrote: > EOVERFLOW seems to be unavailable on certain platforms. > --- > libavcodec/avpacket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c > index f8268b9..87454d5 100644 > --- a/libavcodec

[libav-devel] [PATCH 2/2] aacdec: fix aac_static_table_init() prototype

2015-12-06 Thread Anton Khirnov
--- libavcodec/aacdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index e2e02b4..966a2ee 100644 --- a/libavcodec/aacdec.c +++ b/libavcodec/aacdec.c @@ -1005,7 +1005,7 @@ static void reset_predictor_group(PredictorState *ps, int g

[libav-devel] [PATCH 1/2] avpacket: use ERANGE instead of EOVERFLOW

2015-12-06 Thread Anton Khirnov
EOVERFLOW seems to be unavailable on certain platforms. --- libavcodec/avpacket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index f8268b9..87454d5 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -243,7 +243,7

[libav-devel] [PATCH 027/264] vocdec: put the code not shared with other demuxers under appropriate ifdef

2015-12-06 Thread Anton Khirnov
--- libavformat/vocdec.c | 77 ++-- 1 file changed, 39 insertions(+), 38 deletions(-) diff --git a/libavformat/vocdec.c b/libavformat/vocdec.c index 2fb8440..35ced25 100644 --- a/libavformat/vocdec.c +++ b/libavformat/vocdec.c @@ -23,44 +23,6 @@ #i

[libav-devel] [PATCH 028/264] vocdec: do not create the stream in read_header()

2015-12-06 Thread Anton Khirnov
The stream parameters are not known until we read a packet, so postpone creating it until then. --- libavformat/vocdec.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavformat/vocdec.c b/libavformat/vocdec.c index 35ced25..4599522 100644 --- a/libavformat/voc

[libav-devel] [PATCH 023/264] mpegaudiodecheader: check the header in avpriv_mpegaudio_decode_header

2015-12-06 Thread Anton Khirnov
Almost all the places from which this function is called already check the header manually and in the two that don't (the mp3 muxer) the check should not cause any problems. --- libavcodec/libmp3lame.c| 7 --- libavcodec/mpegaudiodec_template.c | 20 +--- libavcode

[libav-devel] [PATCH 024/264] mp3dec: replace avpriv_mpa_decode_header with avpriv_mpegaudio_decode_header

2015-12-06 Thread Anton Khirnov
The latter does not require a full AVCodecContext and still provides all the functionality needed here. --- libavformat/mp3dec.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 6876c2c..e1b0bb2 100644 --- a/li

[libav-devel] [PATCH 018/264] ff_parse_specific_params: do not use AVCodecContext.frame_size

2015-12-06 Thread Anton Khirnov
It will not be set unless the muxing codec context is also the encoding context, which is discouraged. When the frame size is not known from av_get_audio_frame_duration(), the fallback should still be good enough. --- libavformat/riffenc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/li

[libav-devel] [PATCH 025/264] lavc: make avpriv_mpa_decode_header private on next bump

2015-12-06 Thread Anton Khirnov
It's not used by anything outside of lavc anymore. --- libavcodec/mpegaudio_parser.c | 2 +- libavcodec/mpegaudiodecheader.c | 10 +- libavcodec/mpegaudiodecheader.h | 5 + 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpegaudio_parser.c b/libavcodec/mp

[libav-devel] [PATCH 021/264] lavc: add profiles to AVCodecDescriptor

2015-12-06 Thread Anton Khirnov
The profiles are a property of the codec, so it makes sense to export them through AVCodecDescriptors, not just the codec implementations. --- doc/APIchanges | 3 ++ libavcodec/Makefile| 1 + libavcodec/avcodec.h | 18 +++ libavcodec/codec_desc.c| 10 l

[libav-devel] [PATCH 019/264] r3d: do not create the audio stream until we know the sample rate

2015-12-06 Thread Anton Khirnov
--- libavformat/r3d.c | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/libavformat/r3d.c b/libavformat/r3d.c index c56bdc6..fb066a6 100644 --- a/libavformat/r3d.c +++ b/libavformat/r3d.c @@ -29,6 +29,8 @@ typedef struct R3DContext { u

[libav-devel] [PATCH 022/264] lavc: get the profile name through the codec descriptor in avcodec_string()

2015-12-06 Thread Anton Khirnov
--- libavcodec/utils.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 78ce0dc..29ba85f 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -1749,25 +1749,15 @@ void avcodec_string(char *buf, int buf_size, AVCo

[libav-devel] [PATCH 017/264] rmenc: do not use AVCodecContext.frame_size

2015-12-06 Thread Anton Khirnov
It will not be set if the stream codec context is not the encoding context. Use av_get_audio_frame_duration() instead, it should work for all audio codecs supported by the muxer. --- libavformat/rmenc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/rmenc.c

[libav-devel] TEP ][: Part 2: Preliminaries cont.

2015-12-06 Thread Anton Khirnov
The second batch of the preliminary patches. The next set should start with the actual codec parameter stuff. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 020/264] lavc: print the name of the codec, not its implementation, in avcodec_string

2015-12-06 Thread Anton Khirnov
--- libavcodec/utils.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 4f2f951..af2835e 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -1754,6 +1754,7 @@ void avcodec_string(char *buf, int buf_size, AVCodecConte

[libav-devel] [PATCH 026/264] flvdec: do not create any streams in read_header()

2015-12-06 Thread Anton Khirnov
The current muxer behaviour is to create streams in read_header() based on the audio/video presence flags, but fill in the stream parameters later when we actually get some packets for them. This is rather shady, since other demuxers set the stream parameters immediately when the stream is created

Re: [libav-devel] [PATCH 3/4] h264: do not call frame_start() for missing frames

2015-12-06 Thread Luca Barbato
On 05/12/15 12:25, Luca Barbato wrote: > On 05/12/15 08:56, Anton Khirnov wrote: >> -ff_h264_unref_picture(h, &h->cur_pic); > > Seems lost in the refactoring, if it is intentional might be mentioned > in the commit message. > > lu > ___ > libav-deve

Re: [libav-devel] [PATCH 3/4] h264: do not call frame_start() for missing frames

2015-12-06 Thread Anton Khirnov
Quoting Luca Barbato (2015-12-05 12:25:42) > On 05/12/15 08:56, Anton Khirnov wrote: > > -ff_h264_unref_picture(h, &h->cur_pic); > > Seems lost in the refactoring, if it is intentional might be mentioned > in the commit message. > It's not lost, just moved higher up. -- Anton Khirnov _