Re: [libav-devel] [PATCH 19/25] intrax8: Use the generic horizband function

On 25/02/16 00:31, Vittorio Giovara wrote: > According to mpegutils.c it used only if lowdealy is true. However > that might not be always the case so, I'll just set the current frame > for both. > Ok, I guess. ___ libav-devel mailing list

Re: [libav-devel] [PATCH] concat: disable by default

On 19/02/16 00:51, Sean McGovern wrote: > It is a known security issue. > > Also, issue a Big Fat Warning if the user explicity requests it. > > Original patch by Luca Barbato > --- > Please feel free to re-word the warning text. > --- > configure |5 + > 1 file

Re: [libav-devel] [PATCH 19/25] intrax8: Use the generic horizband function

On Tue, Feb 23, 2016 at 2:53 PM, Luca Barbato wrote: > On 23/02/16 02:17, Vittorio Giovara wrote: >> This is assuming that intrax8 has no support for interlacing >> (hence PICT_FRAME is set and last_frame is NULL). >> --- >> libavcodec/intrax8.c | 5 - >> 1 file changed,

Re: [libav-devel] [PATCH] mov: Trim dref absolute path

On 24/02/16 18:23, Vittorio Giovara wrote: > Which way? Patch as is or the other version that trims by 1 character only? > As is, it is fine. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] fate: Add test for indeo2 with delta frames

Rename to keep indeo2 target separate. --- tests/fate/indeo.mak| 12 +++- tests/ref/fate/indeo2-delta | 115 tests/ref/fate/{indeo2 => indeo2-intra} | 0 3 files changed, 124 insertions(+), 3 deletions(-) create mode 100644

[libav-devel] [PATCH 4/4] vc1dec: Check group allocations separatedly

This avoids summing offsets to NULL pointers in case of error. --- libavcodec/vc1dec.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 5c2cf9f..67c14c2 100644 --- a/libavcodec/vc1dec.c +++

[libav-devel] [PATCH 2/4] vc1dec: Properly call deinit function on error

This functions allocates tons of buffers, free on error in a separate one. --- libavcodec/vc1dec.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 2cd7a03..104c3a3 100644 --- a/libavcodec/vc1dec.c +++

Re: [libav-devel] [PATCH 2/3] idct: Only build prores IDCT if ProRes decoder is enabled

On Tue, Feb 23, 2016 at 1:13 PM, Diego Biurrun wrote: > --- > libavcodec/simple_idct.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/simple_idct.c b/libavcodec/simple_idct.c > index f61e9e6..6ee1320 100644 > --- a/libavcodec/simple_idct.c > +++

Re: [libav-devel] [PATCH] qsv: Move down the implementation query

On Wed, Feb 24, 2016 at 9:14 AM, Luca Barbato wrote: > The plugin loaded may not match the general implementation capability > wise. > --- > libavcodec/qsv.c | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git

[libav-devel] [PATCH 3/4] vc1dec: Fix leak on error for array allocations

The deinit function in the 'error' section will correctly free everything. --- libavcodec/vc1dec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 104c3a3..5c2cf9f 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c

[libav-devel] [PATCH 1/4] vc1dec: Drop commented out cruft

--- libavcodec/vc1dec.c | 8 1 file changed, 8 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index d65c68a..2cd7a03 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -352,14 +352,6 @@ av_cold int ff_vc1_decode_init_alloc_tables(VC1Context *v)

[libav-devel] [PATCH] lavf: Handle query parameters when checking extensions

A webserver omits the Content-Type or if mime-magic fails for unexpected reasons, probing an image HTTP URL with query parameters will fail in the extension match. So check the protocol used is http or https, and drop anything after the first query parameter when evaluating an image URL.

Re: [libav-devel] [PATCH] img2dec: Handle query parameters when checking extensions

On Wed, Feb 24, 2016 at 1:43 PM, Vittorio Giovara wrote: > A webserver omits the Content-Type or if mime-magic fails for unexpected > reasons, probing an image HTTP URL with query parameters will fail in > the extension match. > > So check the protocol used is http or

[libav-devel] [PATCH] img2dec: Handle query parameters when checking extensions

A webserver omits the Content-Type or if mime-magic fails for unexpected reasons, probing an image HTTP URL with query parameters will fail in the extension match. So check the protocol used is http or https, and drop anything after the first query parameter when evaluating an image URL.

Re: [libav-devel] [PATCH] build: Add idct dependency to dct test

On Tue, Feb 23, 2016 at 03:26:18PM +0100, Luca Barbato wrote: > On 23/02/16 08:14, Luca Barbato wrote: > > Not ok, the problem is quite interesting, the linker might not be > > completely at fault here. > > I was late for a meeting so I didn't get you more context, some > explanations: > >

Re: [libav-devel] [RFC] lavfi: add an NVIDIA NPP-based scaling filter

On Wed, Feb 24, 2016 at 01:35:57PM +0100, Anton Khirnov wrote: > --- /dev/null > +++ b/libavfilter/vf_scale_npp.c > @@ -0,0 +1,660 @@ > + > +#include > +#include > +#include > + > +#include "avfilter.h" > +#include "formats.h" > +#include "internal.h" > +#include "video.h" > + > +#include

Re: [libav-devel] [PATCH 01/25] fate: Add test for WMV2 with jframes

On Tue, Feb 23, 2016 at 3:36 PM, Derek Buitenhuis wrote: > On 2/23/2016 1:17 AM, Vittorio Giovara wrote: >> --- >> The test sample is already on FATE strangely enough. >> Vittorio >> >> tests/fate/microsoft.mak| 3 + >> tests/ref/fate/wmv8-intrax8 | 475 >>

Re: [libav-devel] [PATCH] mov: Trim dref absolute path

On Wed, Feb 17, 2016 at 2:41 AM, Luca Barbato wrote: > On 16/02/16 22:26, Vittorio Giovara wrote: >> On Tue, Feb 16, 2016 at 2:19 AM, Luca Barbato wrote: >>> On 16/02/16 03:44, Vittorio Giovara wrote: Samples produced by Omneon (Harmonic) store

Re: [libav-devel] [PATCH 4/4] avprobe: switch to codecpar

On Wed, Feb 24, 2016 at 10:36 AM, Anton Khirnov wrote: > --- > avprobe.c | 107 > ++ > 1 file changed, 65 insertions(+), 42 deletions(-) lgtm thanks -- Vittorio ___

Re: [libav-devel] [PATCH 3/4] avprobe: add local per-stream state

On Wed, Feb 24, 2016 at 10:36 AM, Anton Khirnov wrote: > This will be useful in the following commits. > --- > avprobe.c | 20 > 1 file changed, 20 insertions(+) probably ok -- Vittorio ___ libav-devel mailing

Re: [libav-devel] [PATCH 2/4] avprobe: add local per-file state

On Wed, Feb 24, 2016 at 10:36 AM, Anton Khirnov wrote: > Do not pass just a bare AVFormatContext pointer around, wrap it in > struct. This will be useful in the following commits. > --- > avprobe.c | 38 +++--- > 1 file changed, 23

Re: [libav-devel] [PATCH 1/4] mpegvideo_enc: use avcodec_free_context() instead of av_free()

On Wed, Feb 24, 2016 at 10:36 AM, Anton Khirnov wrote: > --- > libavcodec/mpegvideo_enc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c > index d16e408..96f49ef 100644 > ---

[libav-devel] [PATCH 2/4] avprobe: add local per-file state

Do not pass just a bare AVFormatContext pointer around, wrap it in struct. This will be useful in the following commits. --- avprobe.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/avprobe.c b/avprobe.c index 1fdcd01..b395e93 100644

[libav-devel] [PATCH 3/4] avprobe: add local per-stream state

This will be useful in the following commits. --- avprobe.c | 20 1 file changed, 20 insertions(+) diff --git a/avprobe.c b/avprobe.c index b395e93..189574f 100644 --- a/avprobe.c +++ b/avprobe.c @@ -32,8 +32,15 @@ #include "libavdevice/avdevice.h" #include "cmdutils.h"

[libav-devel] [PATCH 4/4] avprobe: switch to codecpar

--- avprobe.c | 107 ++ 1 file changed, 65 insertions(+), 42 deletions(-) diff --git a/avprobe.c b/avprobe.c index 189574f..a0e14d4 100644 --- a/avprobe.c +++ b/avprobe.c @@ -34,6 +34,8 @@ typedef struct InputStream { AVStream

[libav-devel] [PATCH 1/4] mpegvideo_enc: use avcodec_free_context() instead of av_free()

--- libavcodec/mpegvideo_enc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index d16e408..96f49ef 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@ -1343,8 +1343,7 @@ static int

Re: [libav-devel] [PATCH 1/3] idct: Move jpeg ref idct put/add wrappers to the only place they are used

On 24/02/16 10:01, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-02-23 19:13:05) >> --- >> libavcodec/dct.h | 2 -- >> libavcodec/idctdsp.c | 16 ++-- >> libavcodec/jrevdct.c | 12 >> 3 files changed, 14 insertions(+), 16 deletions(-) >> > > This does not

Re: [libav-devel] [RFC] lavfi: add an NVIDIA NPP-based scaling filter

On 24/02/16 13:35, Anton Khirnov wrote: > +static int nppscale_filter_frame(AVFilterLink *link, AVFrame *in) > +{ > +AVFilterContext *ctx = link->dst; > +NPPScaleContext*s = ctx->priv; > +AVFilterLink *outlink = ctx->outputs[0]; > +

Re: [libav-devel] [RFC] [PATCH 2/2] img2dec: Handle query parameters when checking extensions

On 24/02/16 09:22, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-02-24 01:44:19) >> A webserver omits the Content-Type or if mime-magic fails for unexpected >> reasons, probing an image HTTP URL with query parameters will fail in >> the extension match. >> >> So check the protocol used is

[libav-devel] [PATCH] qsv: Move down the implementation query

The plugin loaded may not match the general implementation capability wise. --- libavcodec/qsv.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c index ee6b262..3e892e8 100644 --- a/libavcodec/qsv.c +++

Re: [libav-devel] [PATCH 2/2] APIchanges: add missing hashes and dates

On Wed, Feb 24, 2016 at 5:01 AM, Anton Khirnov wrote: > Also, remove a stray line (apparently fallout from conflict resolution). > --- > doc/APIchanges | 72 > -- > 1 file changed, 35 insertions(+), 37 deletions(-)

Re: [libav-devel] [PATCH 1/2] lavf: add a missing bump and APIchanges for the codecpar switch

On Wed, Feb 24, 2016 at 5:01 AM, Anton Khirnov wrote: > --- > doc/APIchanges| 3 +++ > libavformat/version.h | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index 70fce18..2db39de 100644 > ---

[libav-devel] [RFC] lavfi: add an NVIDIA NPP-based scaling filter

--- configure | 5 + doc/filters.texi | 38 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_scale_npp.c | 660 + 5 files changed, 705 insertions(+) create mode 100644

Re: [libav-devel] [PATCH 2/4] lavu: VAAPI hwcontext implementation

Quoting Mark Thompson (2016-02-21 00:24:37) > On 20/02/16 22:46, Diego Biurrun wrote: > > On Sat, Feb 20, 2016 at 06:31:01PM +, Mark Thompson wrote: > >> --- a/libavutil/Makefile > >> +++ b/libavutil/Makefile > >> @@ -25,6 +25,7 @@ HEADERS = adler32.h > >>

Re: [libav-devel] [PATCH 2/2] indeo2: Fix banding artefacts

On Wed, Feb 24, 2016 at 10:04:45AM +0100, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-02-23 01:58:19) > > From: Luca Barbato > > > > Rename luma table to delta table and change how it is used. > > > > CC: libav-sta...@libav.org > > Signed-off-by: Vittorio Giovara

[libav-devel] [PATCH 1/2] lavf: add a missing bump and APIchanges for the codecpar switch

--- doc/APIchanges| 3 +++ libavformat/version.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 70fce18..2db39de 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -13,6 +13,9 @@ libavutil: 2015-08-28 API changes, most

[libav-devel] [PATCH 2/2] APIchanges: add missing hashes and dates

Also, remove a stray line (apparently fallout from conflict resolution). --- doc/APIchanges | 72 -- 1 file changed, 35 insertions(+), 37 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 2db39de..20fecb9 100644 ---

Re: [libav-devel] [PATCH 2/2] indeo2: Fix banding artefacts

Quoting Vittorio Giovara (2016-02-23 01:58:19) > From: Luca Barbato > > Rename luma table to delta table and change how it is used. > > CC: libav-sta...@libav.org > Signed-off-by: Vittorio Giovara No corresponding FATE tests? -- Anton Khirnov

Re: [libav-devel] [PATCH 1/3] idct: Move jpeg ref idct put/add wrappers to the only place they are used

Quoting Diego Biurrun (2016-02-23 19:13:05) > --- > libavcodec/dct.h | 2 -- > libavcodec/idctdsp.c | 16 ++-- > libavcodec/jrevdct.c | 12 > 3 files changed, 14 insertions(+), 16 deletions(-) > This does not strike me as an improvement. The function logically

Re: [libav-devel] [PATCH 13/25] intrax8: Use a local buffer instead of a ScratchpadContext

Quoting Vittorio Giovara (2016-02-23 16:25:55) > On Tue, Feb 23, 2016 at 8:22 AM, Diego Biurrun wrote: > > On Mon, Feb 22, 2016 at 08:17:37PM -0500, Vittorio Giovara wrote: > >> Sustain possible size changes via av_fast_malloc(). > > > > Sustain? That's not the right word, but

Re: [libav-devel] [PATCH 11/25] intrax8: Carry over the loopfilter value in ff_intrax8_decode_picture

Quoting Diego Biurrun (2016-02-23 14:08:13) > On Mon, Feb 22, 2016 at 08:17:35PM -0500, Vittorio Giovara wrote: > > --- > > libavcodec/intrax8.c | 5 +++-- > > libavcodec/intrax8.h | 7 +-- > > libavcodec/vc1_block.c | 2 +- > > libavcodec/wmv2dec.c | 3 ++- > > 4 files changed, 11

Re: [libav-devel] [RFC] [PATCH 2/2] img2dec: Handle query parameters when checking extensions

Quoting Vittorio Giovara (2016-02-24 01:44:19) > A webserver omits the Content-Type or if mime-magic fails for unexpected > reasons, probing an image HTTP URL with query parameters will fail in > the extension match. > > So check the protocol used is http or https, and drop anything after > the

Re: [libav-devel] [PATCH 1/2] img2: Drop av_ prefix for a static function

Quoting Vittorio Giovara (2016-02-24 01:44:18) > This prefix is reserved for public functions only. > --- > libavformat/img2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/img2.c b/libavformat/img2.c > index 9f462d0..3cfc08e 100644 > ---