[libav-devel] [PATCH 1/4] h264_slice: Drop pointless assert

2016-11-22 Thread Diego Biurrun
--- libavcodec/h264_slice.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index 8d79740..87d6582 100644 --- a/libavcodec/h264_slice.c +++ b/libavcodec/h264_slice.c @@ -286,8 +286,6 @@ static int initialize_cur_frame(

Re: [libav-devel] [PATCH] fate.sh: Allow setting other make flags for running tests

2016-11-22 Thread Diego Biurrun
On Tue, Nov 22, 2016 at 10:10:09PM +0200, Martin Storsjö wrote: > If makeopts_fate is set, these makeopts are used for running the > tests instead of the normal makeopts. If it isn't set, the normal > makeopts variable is used as before. > > This is useful if remote testing on a lesser machine whe

[libav-devel] [PATCH 3/4] ac3enc: Reshuffle functions to avoid forward declarations

2016-11-22 Thread Diego Biurrun
--- libavcodec/ac3enc_fixed.c| 58 ++-- libavcodec/ac3enc_float.c| 70 +++- libavcodec/ac3enc_template.c | 9 -- 3 files changed, 64 insertions(+), 73 deletions(-) diff --git a/libavcodec/ac3enc_fixed.c b/libavco

[libav-devel] [PATCH 4/4] ac3enc: Avoid unnecessary macro indirections

2016-11-22 Thread Diego Biurrun
--- libavcodec/ac3enc_fixed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/ac3enc_fixed.c b/libavcodec/ac3enc_fixed.c index c1cf825..cb1c58d 100644 --- a/libavcodec/ac3enc_fixed.c +++ b/libavcodec/ac3enc_fixed.c @@ -104,7 +104,7 @@ static CoefType calc_cpl_coo

[libav-devel] [PATCH 2/4] ac3enc: Reshuffle some float/fixed-mode ifdefs to avoid a dummy function

2016-11-22 Thread Diego Biurrun
--- libavcodec/ac3enc_fixed.c| 2 ++ libavcodec/ac3enc_float.c| 10 -- libavcodec/ac3enc_template.c | 4 +--- 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/libavcodec/ac3enc_fixed.c b/libavcodec/ac3enc_fixed.c index 2bb82ef..c26f9c0 100644 --- a/libavcodec/ac3en

Re: [libav-devel] [PATCH 1/3] ape: Restructure DEBUG ifdefs to avoid unused function parameter warnings

2016-11-22 Thread Diego Biurrun
On Mon, Nov 21, 2016 at 03:57:08PM +0100, Diego Biurrun wrote: > --- > > Now with 'do {} while(0)' as suggested by Luca. > > libavformat/ape.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Set OKed by Luca on IRC. Diego ___ libav-deve

Re: [libav-devel] [PATCH] utils: Add av_stream_add_side_data()

2016-11-22 Thread Luca Barbato
On 23/11/2016 05:10, James Almer wrote: > To make av_stream_add_side_data return error codes consistent with > av_packet_add_side_data's. I'd go the other way round, but sure, staying consistent is good. lu ___ libav-devel mailing list libav-devel@libav

Re: [libav-devel] [PATCH] utils: Add av_stream_add_side_data()

2016-11-22 Thread James Almer
On 11/23/2016 12:39 AM, Luca Barbato wrote: > On 22/11/2016 23:16, Vittorio Giovara wrote: >> -tmp = av_realloc_array(st->side_data, st->nb_side_data + 1, >> sizeof(*tmp)); >> +if ((unsigned) st->nb_side_data + 1 >= INT_MAX / sizeof(*st->side_data)) >> +return AVERROR(ERANGE); >> +

Re: [libav-devel] [PATCH] utils: Add av_stream_add_side_data()

2016-11-22 Thread Luca Barbato
On 22/11/2016 23:16, Vittorio Giovara wrote: > -tmp = av_realloc_array(st->side_data, st->nb_side_data + 1, > sizeof(*tmp)); > +if ((unsigned) st->nb_side_data + 1 >= INT_MAX / sizeof(*st->side_data)) > +return AVERROR(ERANGE); > + > +tmp = av_realloc(st->side_data, (st->nb_sid

Re: [libav-devel] [PATCH] matroska: use av_stream_add_side_data() for stereo3d side data

2016-11-22 Thread Luca Barbato
On 22/11/2016 21:50, Vittorio Giovara wrote: > From: James Almer > > Signed-off-by: James Almer > Signed-off-by: Vittorio Giovara > --- > libavformat/matroska.c | 22 -- > 1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/libavformat/matroska.c b/libavforma

Re: [libav-devel] [PATCH] fate.sh: Allow setting other make flags for running tests

2016-11-22 Thread Luca Barbato
On 22/11/2016 21:10, Martin Storsjö wrote: > If makeopts_fate is set, these makeopts are used for running the > tests instead of the normal makeopts. If it isn't set, the normal > makeopts variable is used as before. > > This is useful if remote testing on a lesser machine where a large > number o

Re: [libav-devel] [PATCH] doc: Add libxavs section

2016-11-22 Thread Vittorio Giovara
On Tue, Nov 22, 2016 at 5:16 PM, Vittorio Giovara wrote: > From: Diego Biurrun > > --- > doc/general.texi | 8 > 1 file changed, 8 insertions(+) Never mind this email, sorry for the spam. -- Vittorio ___ libav-devel mailing list libav-devel@

[libav-devel] [PATCH] utils: Add av_stream_add_side_data()

2016-11-22 Thread Vittorio Giovara
From: James Almer Functionally similar to av_packet_add_side_data(). Allows the use of an already allocated buffer as stream side data. Signed-off-by: James Almer Signed-off-by: Vittorio Giovara --- Updated according to James' review. Vittorio doc/APIchanges | 3 +++ libavformat/avf

[libav-devel] [PATCH] doc: Add libxavs section

2016-11-22 Thread Vittorio Giovara
From: Diego Biurrun --- doc/general.texi | 8 1 file changed, 8 insertions(+) diff --git a/doc/general.texi b/doc/general.texi index 7b1f11c..d232300 100644 --- a/doc/general.texi +++ b/doc/general.texi @@ -95,6 +95,14 @@ Go to @url{http://www.wavpack.com/} and follow the instructions

Re: [libav-devel] [PATCH] utils: Add av_stream_add_side_data()

2016-11-22 Thread Vittorio Giovara
On Tue, Nov 22, 2016 at 5:09 PM, James Almer wrote: > On 11/22/2016 5:32 PM, Vittorio Giovara wrote: >> On Tue, Nov 22, 2016 at 10:04 AM, James Almer wrote: >>> On 11/21/2016 8:49 PM, Vittorio Giovara wrote: From: James Almer Functionally similar to av_packet_add_side_data(). Allo

Re: [libav-devel] [PATCH] utils: Add av_stream_add_side_data()

2016-11-22 Thread James Almer
On 11/22/2016 5:32 PM, Vittorio Giovara wrote: > On Tue, Nov 22, 2016 at 10:04 AM, James Almer wrote: >> On 11/21/2016 8:49 PM, Vittorio Giovara wrote: >>> From: James Almer >>> >>> Functionally similar to av_packet_add_side_data(). Allows the use of an >>> already allocated buffer as stream side

[libav-devel] [PATCH] matroska: use av_stream_add_side_data() for stereo3d side data

2016-11-22 Thread Vittorio Giovara
From: James Almer Signed-off-by: James Almer Signed-off-by: Vittorio Giovara --- libavformat/matroska.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/libavformat/matroska.c b/libavformat/matroska.c index 8842d7c..a8f5e98 100644 --- a/libavformat/ma

Re: [libav-devel] [PATCH] utils: Add av_stream_add_side_data()

2016-11-22 Thread Vittorio Giovara
On Tue, Nov 22, 2016 at 10:04 AM, James Almer wrote: > On 11/21/2016 8:49 PM, Vittorio Giovara wrote: >> From: James Almer >> >> Functionally similar to av_packet_add_side_data(). Allows the use of an >> already allocated buffer as stream side data. >> >> Signed-off-by: James Almer >> Signed-off

[libav-devel] [PATCH] fate.sh: Allow setting other make flags for running tests

2016-11-22 Thread Martin Storsjö
If makeopts_fate is set, these makeopts are used for running the tests instead of the normal makeopts. If it isn't set, the normal makeopts variable is used as before. This is useful if remote testing on a lesser machine where a large number of parallel jobs might be undesireable, while wanting to

Re: [libav-devel] [PATCH 1/1] fate: report ignored tests but ignore the test result

2016-11-22 Thread Janne Grunau
On 2016-11-22 16:43:50 +0100, Diego Biurrun wrote: > On Mon, Nov 21, 2016 at 12:31:24AM +0100, Janne Grunau wrote: > > --- a/configure > > +++ b/configure > > @@ -348,9 +348,8 @@ Developer options (useful when working on Libav itself): > > - --ignore-tests=TESTS whitespace-separated list (with

Re: [libav-devel] [PATCH 2/2] colorspace: Move cm macro where it belongs

2016-11-22 Thread Diego Biurrun
On Mon, Nov 21, 2016 at 10:46:45AM -0500, Vittorio Giovara wrote: > On Mon, Nov 21, 2016 at 8:52 AM, Diego Biurrun wrote: > > --- a/libavcodec/dvbsubdec.c > > +++ b/libavcodec/dvbsubdec.c > > @@ -32,8 +32,6 @@ > > #define DVBSUB_DISPLAYDEFINITION_SEGMENT 0x14 > > #define DVBSUB_DISPLAY_SEGMENT

Re: [libav-devel] [PATCH 4/9] decode: be more explicit about storing the last packet properties

2016-11-22 Thread Vittorio Giovara
On Tue, Nov 22, 2016 at 8:36 AM, Anton Khirnov wrote: > The current code stores a pointer to the packet passed to the decoder, > which is then used during get_buffer() for timestamps and side data > passthrough. However, since this is a pointer to user data which we do > not own, storing it is pot

Re: [libav-devel] [PATCH 2/9] lavc: move encoding-related code from utils.c to a new file

2016-11-22 Thread Vittorio Giovara
On Tue, Nov 22, 2016 at 8:36 AM, Anton Khirnov wrote: > + > +int ff_alloc_packet(AVPacket *avpkt, int size) > +{ > +if (size > INT_MAX - AV_INPUT_BUFFER_PADDING_SIZE) > +return AVERROR(EINVAL); > + > +if (avpkt->data) { > +AVBufferRef *buf = avpkt->buf; > + > +if (a

Re: [libav-devel] [PATCH 1/1] fate: report ignored tests but ignore the test result

2016-11-22 Thread Diego Biurrun
On Tue, Nov 22, 2016 at 04:43:50PM +0100, Diego Biurrun wrote: > On Mon, Nov 21, 2016 at 12:31:24AM +0100, Janne Grunau wrote: > > --- a/tests/Makefile > > +++ b/tests/Makefile > > @@ -143,11 +143,17 @@ endif > > > > -fate: $(filter-out $(addprefix fate-,$(IGNORE_TESTS)),$(FATE)) > > +define FATE

Re: [libav-devel] [PATCH 1/1] fate: report ignored tests but ignore the test result

2016-11-22 Thread Diego Biurrun
On Mon, Nov 21, 2016 at 12:31:24AM +0100, Janne Grunau wrote: > --- a/configure > +++ b/configure > @@ -348,9 +348,8 @@ Developer options (useful when working on Libav itself): > - --ignore-tests=TESTS whitespace-separated list (without "fate-" prefix > - in the name)

Re: [libav-devel] [PATCH 1/9] lavc: add a null bitstream filter

2016-11-22 Thread Luca Barbato
On 22/11/2016 14:36, Anton Khirnov wrote: > --- > doc/bitstream_filters.texi | 3 +++ > libavcodec/Makefile| 1 + > libavcodec/bitstream_filters.c | 1 + > libavcodec/null_bsf.c | 44 > ++ > 4 files changed, 49 insertions(+) > c

Re: [libav-devel] [PATCH 7/9] qsvdec_h2645: switch to the new generic filtering mechanism

2016-11-22 Thread Luca Barbato
On 22/11/2016 14:36, Anton Khirnov wrote: > Drop the internal manual conversion from the MP4 format to Annex B. > --- > libavcodec/qsvdec_h2645.c | 74 > +++ > 1 file changed, 11 insertions(+), 63 deletions(-) > Looks good. __

Re: [libav-devel] [PATCH 9/9] vp9: split superframes in the filtering stage before actual decoding

2016-11-22 Thread Luca Barbato
On 22/11/2016 14:36, Anton Khirnov wrote: > Significantly increases the efficiency of frame threading, since > individual frames in a superframe can now be decoded in parallel. > --- > configure| 2 +- > libavcodec/vp9.c | 74 > ++-- >

Re: [libav-devel] [PATCH 5/9] decode: restructure the core decoding code

2016-11-22 Thread Luca Barbato
On 22/11/2016 14:36, Anton Khirnov wrote: > Currently, the new decoding API is pretty much just a wrapper around > the old deprecated one. This is problematic, since it interferes with > making full use of the flexibility added by the new API. The old API > should also be removed at some future poi

Re: [libav-devel] [PATCH] utils: Add av_stream_add_side_data()

2016-11-22 Thread James Almer
On 11/21/2016 8:49 PM, Vittorio Giovara wrote: > From: James Almer > > Functionally similar to av_packet_add_side_data(). Allows the use of an > already allocated buffer as stream side data. > > Signed-off-by: James Almer > Signed-off-by: Vittorio Giovara > --- > Needed to clean up the new sid

Re: [libav-devel] [PATCH 3/9] lavc: move decoding-related code from utils.c to a new file

2016-11-22 Thread Diego Biurrun
On Tue, Nov 22, 2016 at 02:36:33PM +0100, Anton Khirnov wrote: > --- > libavcodec/Makefile | 1 + > libavcodec/decode.c | 924 > > libavcodec/utils.c | 889 -- > 3 files changed, 925 insertions

Re: [libav-devel] [PATCH 2/9] lavc: move encoding-related code from utils.c to a new file

2016-11-22 Thread Diego Biurrun
On Tue, Nov 22, 2016 at 02:36:32PM +0100, Anton Khirnov wrote: > --- > libavcodec/Makefile | 1 + > libavcodec/encode.c | 360 > > libavcodec/utils.c | 331 --- > 3 files changed, 361 insertions(+)

Re: [libav-devel] [PATCH 7/9] qsvdec_h2645: switch to the new generic filtering mechanism

2016-11-22 Thread Diego Biurrun
On Tue, Nov 22, 2016 at 02:36:37PM +0100, Anton Khirnov wrote: > Drop the internal manual conversion from the MP4 format to Annex B. > --- > libavcodec/qsvdec_h2645.c | 74 > +++ > 1 file changed, 11 insertions(+), 63 deletions(-) The libopenh264 decod

Re: [libav-devel] [PATCH 6/9] lavc: add support for filtering packets before decoding

2016-11-22 Thread Diego Biurrun
On Tue, Nov 22, 2016 at 02:36:36PM +0100, Anton Khirnov wrote: > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -3235,6 +3235,12 @@ typedef struct AVCodec { > * See FF_CODEC_CAP_* in internal.h > */ > int caps_internal; > + > +/** > + * Decoding only, a comma-

Re: [libav-devel] [PATCH 1/9] lavc: add a null bitstream filter

2016-11-22 Thread Diego Biurrun
On Tue, Nov 22, 2016 at 02:36:31PM +0100, Anton Khirnov wrote: > --- > doc/bitstream_filters.texi | 3 +++ > libavcodec/Makefile| 1 + > libavcodec/bitstream_filters.c | 1 + > libavcodec/null_bsf.c | 44 > ++ > 4 files changed,

[libav-devel] [PATCH 1/9] lavc: add a null bitstream filter

2016-11-22 Thread Anton Khirnov
--- doc/bitstream_filters.texi | 3 +++ libavcodec/Makefile| 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/null_bsf.c | 44 ++ 4 files changed, 49 insertions(+) create mode 100644 libavcodec/null_bsf.c diff --git a/doc/b

[libav-devel] [PATCH 3/9] lavc: move decoding-related code from utils.c to a new file

2016-11-22 Thread Anton Khirnov
--- libavcodec/Makefile | 1 + libavcodec/decode.c | 924 libavcodec/utils.c | 889 -- 3 files changed, 925 insertions(+), 889 deletions(-) create mode 100644 libavcodec/decode.c diff --git a/

[libav-devel] [PATCH 7/9] qsvdec_h2645: switch to the new generic filtering mechanism

2016-11-22 Thread Anton Khirnov
Drop the internal manual conversion from the MP4 format to Annex B. --- libavcodec/qsvdec_h2645.c | 74 +++ 1 file changed, 11 insertions(+), 63 deletions(-) diff --git a/libavcodec/qsvdec_h2645.c b/libavcodec/qsvdec_h2645.c index a26f150..8ac403b 10064

[libav-devel] [PATCH 9/9] vp9: split superframes in the filtering stage before actual decoding

2016-11-22 Thread Anton Khirnov
Significantly increases the efficiency of frame threading, since individual frames in a superframe can now be decoded in parallel. --- configure| 2 +- libavcodec/vp9.c | 74 ++-- 2 files changed, 14 insertions(+), 62 deletions(-) diff

[libav-devel] [PATCH 4/9] decode: be more explicit about storing the last packet properties

2016-11-22 Thread Anton Khirnov
The current code stores a pointer to the packet passed to the decoder, which is then used during get_buffer() for timestamps and side data passthrough. However, since this is a pointer to user data which we do not own, storing it is potentially dangerous. It is also ill defined for the new decoding

[libav-devel] [PATCH 6/9] lavc: add support for filtering packets before decoding

2016-11-22 Thread Anton Khirnov
--- configure | 1 + libavcodec/avcodec.h | 6 ++ libavcodec/decode.c | 172 ++ libavcodec/internal.h | 8 +++ libavcodec/utils.c| 2 + 5 files changed, 177 insertions(+), 12 deletions(-) diff --git a/configure b/configure

[libav-devel] [PATCH 8/9] lavc: add a bitstream filter for splitting VP9 superframes

2016-11-22 Thread Anton Khirnov
Partially based on code by Ronald S. Bultje . --- doc/bitstream_filters.texi| 4 + libavcodec/Makefile | 1 + libavcodec/bitstream_filters.c| 1 + libavcodec/vp9_superframe_split_bsf.c | 143 ++ 4 files changed, 149 insert

[libav-devel] [PATCH 5/9] decode: restructure the core decoding code

2016-11-22 Thread Anton Khirnov
Currently, the new decoding API is pretty much just a wrapper around the old deprecated one. This is problematic, since it interferes with making full use of the flexibility added by the new API. The old API should also be removed at some future point. Reorganize the code so that the new send_pack

[libav-devel] [PATCH 2/9] lavc: move encoding-related code from utils.c to a new file

2016-11-22 Thread Anton Khirnov
--- libavcodec/Makefile | 1 + libavcodec/encode.c | 360 libavcodec/utils.c | 331 --- 3 files changed, 361 insertions(+), 331 deletions(-) create mode 100644 libavcodec/encode.c diff --git a/lib

Re: [libav-devel] [PATCH] mov: Use av_stream_add_side_data() for displaymatrix side data

2016-11-22 Thread Luca Barbato
On 22/11/2016 00:54, Vittorio Giovara wrote: > From: James Almer > > Signed-off-by: James Almer > Signed-off-by: Vittorio Giovara > --- > libavformat/mov.c | 18 +- > 1 file changed, 5 insertions(+), 13 deletions(-) > Shouldn't hurt as well. _

Re: [libav-devel] [PATCH] utils: Add av_stream_add_side_data()

2016-11-22 Thread Luca Barbato
On 22/11/2016 00:49, Vittorio Giovara wrote: > From: James Almer > > Functionally similar to av_packet_add_side_data(). Allows the use of an > already allocated buffer as stream side data. > > Signed-off-by: James Almer > Signed-off-by: Vittorio Giovara > --- > Needed to clean up the new side