[libav-devel] [PATCH] libavformat: Fix a faulty api deprecation guard in prepare_input_packet

2016-12-14 Thread Martin Storsjö
This seems to have been added by mistake in 11de006b, by not noticing the negation for the existing condition. This block does not contain any code that accesses the codec field in AVStream. This function is meant to serve as a complement to compute_pkt_fields2, which is guarded by

Re: [libav-devel] [PATCH] configure: fix linking with MSVC when using --disable-optimizations

2016-12-14 Thread Steve Lhomme
On Wed, Dec 14, 2016 at 5:12 PM, Diego Biurrun wrote: > On Wed, Dec 14, 2016 at 04:46:54PM +0100, Steve Lhomme wrote: >> From: Steve Lhomme >> >> Without any optimization flags, MSVC does no dead code elimination (DCE) at >> all, even for the most trivial

[libav-devel] [PATCH] configure: Disentangle vfw32 and user32 lib handling

2016-12-14 Thread Diego Biurrun
Also fix the missing dependency of dxva2 on user32. --- This should be the correct solution, also happens to fix linking of dxva2 with vfwcap disabled. configure | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/configure b/configure index fb82fc4..aa4396e 100755

Re: [libav-devel] [PATCH] build: Add name parameter to check_lib() helper function

2016-12-14 Thread Luca Barbato
On 10/12/2016 17:23, Diego Biurrun wrote: > This allows enabling or disabling the library-related variables from > within the function instead of doing it manually outside of it. > --- > > Now with a proper log message. > Fixed a bug where disabling the name variable at the end of check_lib >

Re: [libav-devel] [PATCH] configure: Map -O[3-9] CFLAGS to -O2 for MSVC

2016-12-14 Thread Diego Biurrun
On Wed, Dec 14, 2016 at 06:15:08PM +0100, Hendrik Leppkes wrote: > On Wed, Dec 14, 2016 at 6:06 PM, Diego Biurrun wrote: > > On Wed, Dec 14, 2016 at 05:22:52PM +0100, Hendrik Leppkes wrote: > >> On Wed, Dec 14, 2016 at 5:15 PM, Diego Biurrun wrote: > >> > -O2

Re: [libav-devel] [PATCH] configure: Map -O[3-9] CFLAGS to -O2 for MSVC

2016-12-14 Thread Hendrik Leppkes
On Wed, Dec 14, 2016 at 6:06 PM, Diego Biurrun wrote: > On Wed, Dec 14, 2016 at 05:22:52PM +0100, Hendrik Leppkes wrote: >> On Wed, Dec 14, 2016 at 5:15 PM, Diego Biurrun wrote: >> > -O2 is the highest warning level understood by MSVC, higher warning >> >

Re: [libav-devel] [PATCH] configure: Map -O[3-9] CFLAGS to -O2 for MSVC

2016-12-14 Thread Diego Biurrun
On Wed, Dec 14, 2016 at 05:22:52PM +0100, Hendrik Leppkes wrote: > On Wed, Dec 14, 2016 at 5:15 PM, Diego Biurrun wrote: > > -O2 is the highest warning level understood by MSVC, higher warning > > levels produce warnings. > > s/warning/optimization/ ? Indeed, thanks. > > ---

Re: [libav-devel] [PATCH] configure: Map -O[3-9] CFLAGS to -O2 for MSVC

2016-12-14 Thread Hendrik Leppkes
On Wed, Dec 14, 2016 at 5:15 PM, Diego Biurrun wrote: > -O2 is the highest warning level understood by MSVC, higher warning > levels produce warnings. s/warning/optimization/ ? > --- > configure | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configure b/configure >

[libav-devel] [PATCH] configure: Map -O[3-9] CFLAGS to -O2 for MSVC

2016-12-14 Thread Diego Biurrun
-O2 is the highest warning level understood by MSVC, higher warning levels produce warnings. --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 0fc7388..d2c256d 100755 --- a/configure +++ b/configure @@ -3214,6 +3214,7 @@ msvc_common_flags(){

Re: [libav-devel] [PATCH] configure: fix linking with MSVC when using --disable-optimizations

2016-12-14 Thread Diego Biurrun
On Wed, Dec 14, 2016 at 04:46:54PM +0100, Steve Lhomme wrote: > From: Steve Lhomme > > Without any optimization flags, MSVC does no dead code elimination (DCE) at > all, even for the most trivial cases. DCE is a prerequisite for building libav > correctly, otherwise there are

[libav-devel] [PATCH] configure: fix linking with MSVC when using --disable-optimizations

2016-12-14 Thread Steve Lhomme
From: Steve Lhomme Without any optimization flags, MSVC does no dead code elimination (DCE) at all, even for the most trivial cases. DCE is a prerequisite for building libav correctly, otherwise there are undefined references to functions for other architectures and disabled

Re: [libav-devel] [PATCH] v4l2: use codec descriptors for mapping a codec name to id

2016-12-14 Thread Luca Barbato
On 14/12/2016 13:24, Anton Khirnov wrote: > This mapping has nothing to do with decoder implementations, so using > decoder names is wrong. > --- > libavdevice/v4l2.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c > index

Re: [libav-devel] [PATCH] decode.h: Add missing headers to fix standalone compilation

2016-12-14 Thread Luca Barbato
On 14/12/2016 14:06, Diego Biurrun wrote: > --- > > Stab, stab, and doublestab... > > libavcodec/decode.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/decode.h b/libavcodec/decode.h > index c1e6457..2f29cf6 100644 > --- a/libavcodec/decode.h > +++ b/libavcodec/decode.h

[libav-devel] [PATCH] decode.h: Add missing headers to fix standalone compilation

2016-12-14 Thread Diego Biurrun
--- Stab, stab, and doublestab... libavcodec/decode.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/decode.h b/libavcodec/decode.h index c1e6457..2f29cf6 100644 --- a/libavcodec/decode.h +++ b/libavcodec/decode.h @@ -21,6 +21,8 @@ #ifndef AVCODEC_DECODE_H #define

[libav-devel] [PATCH] v4l2: use codec descriptors for mapping a codec name to id

2016-12-14 Thread Anton Khirnov
This mapping has nothing to do with decoder implementations, so using decoder names is wrong. --- libavdevice/v4l2.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c index 0479121..a8afe8a 100644 --- a/libavdevice/v4l2.c +++

Re: [libav-devel] [PATCH] avconv: add avconv_d3d11va

2016-12-14 Thread Diego Biurrun
On Wed, Dec 14, 2016 at 10:54:10AM +0100, Hendrik Leppkes wrote: > On Wed, Dec 14, 2016 at 9:04 AM, Steve Lhomme wrote: > > On Tue, Dec 13, 2016 at 5:16 PM, Luca Barbato wrote: > >> On 13/12/2016 14:19, Steve Lhomme wrote: > >>>

[libav-devel] [PATCH] qsv: Set the correct range for la_depth

2016-12-14 Thread Luca Barbato
Setting an invalid range for it makes the encoder behave inconsistently. --- If someone has better ideas I'm all ears. libavcodec/qsvenc.c | 2 +- libavcodec/qsvenc.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index

Re: [libav-devel] [PATCH] avconv: add avconv_d3d11va

2016-12-14 Thread Anton Khirnov
Quoting Anton Khirnov (2016-12-14 11:05:49) > Quoting Steve Lhomme (2016-12-13 14:19:03) > > From: Steve Lhomme > > > > The code is similar to avconv_dxva2. The decoded output needs to be copied > > into > > a staging texture that can be accessed by the CPU as the decoder

Re: [libav-devel] [PATCH] avconv: add avconv_d3d11va

2016-12-14 Thread Luca Barbato
On 14/12/2016 09:04, Steve Lhomme wrote: > On Tue, Dec 13, 2016 at 5:16 PM, Luca Barbato wrote: >> On 13/12/2016 14:19, Steve Lhomme wrote: >>> +DEFINE_GUID(DXVA2_ModeMPEG2_VLD, 0xee27417f, >>> 0x5e28,0x4e65,0xbe,0xea,0x1d,0x26,0xb5,0x08,0xad,0xc9); >>>

Re: [libav-devel] [libav-commits] fate: Add h264 test for frame num gaps

2016-12-14 Thread Anton Khirnov
Quoting Derek Buitenhuis (2016-12-14 11:31:30) > Module: libav > Branch: master > Commit: e94b9313b21c3d91a36ef064f7fe3e867616f47f > > Author:Derek Buitenhuis > Committer: Anton Khirnov > Date: Mon Dec 12 14:33:28 2016 + > > fate:

Re: [libav-devel] [PATCH] pthread_frame: use better memory orders for frame progress

2016-12-14 Thread Anton Khirnov
Quoting Wan-Teh Chang (2016-12-09 18:54:47) > This improves commit 59c70227405c214b29971e6272f3a3ff6fcce3d0. > > In ff_thread_report_progress(), the fast code path can load > progress[field] with the relaxed memory order, and the slow code path > can store progress[field] with the release memory

Re: [libav-devel] [PATCH] avconv: add avconv_d3d11va

2016-12-14 Thread Anton Khirnov
Quoting Steve Lhomme (2016-12-13 14:19:03) > From: Steve Lhomme > > The code is similar to avconv_dxva2. The decoded output needs to be copied > into > a staging texture that can be accessed by the CPU as the decoder texture can't > be accessed by the CPU. > --- > Makefile

Re: [libav-devel] [PATCH 1/2] h264_slice: Wait for refs to be available before we use them in error concealment

2016-12-14 Thread Anton Khirnov
Quoting Derek Buitenhuis (2016-12-12 15:33:27) > This could happen when there was a frame number gap and frame threading was > used. > > Debugging-by: Ronald S. Bultje > Debugging-by: Justin Ruggles > Signed-off-by: Derek Buitenhuis

Re: [libav-devel] [PATCH] avconv: add avconv_d3d11va

2016-12-14 Thread Hendrik Leppkes
On Wed, Dec 14, 2016 at 9:04 AM, Steve Lhomme wrote: > On Tue, Dec 13, 2016 at 5:16 PM, Luca Barbato wrote: >> On 13/12/2016 14:19, Steve Lhomme wrote: >>> +DEFINE_GUID(DXVA2_ModeMPEG2_VLD, 0xee27417f, >>>

Re: [libav-devel] [PATCH] configure: Add the full parser to the codec dependencies

2016-12-14 Thread Luca Barbato
On 14/12/2016 10:00, Anton Khirnov wrote: > Quoting Luca Barbato (2016-12-02 22:01:11) >> Matches h263. > > And? I don't see how that implies that this is the correct thing to > do. The h264 decoder does not invoke the parser, so it should not > depend on it. > Alternatively the h264 ES demuxer

Re: [libav-devel] [PATCH] configure: use -O1 with MSVC by default

2016-12-14 Thread Steve Lhomme
LGTM On Wed, Dec 14, 2016 at 9:22 AM, Martin Storsjö wrote: > On Tue, 13 Dec 2016, Steve Lhomme wrote: > >> From: Steve Lhomme >> >> Otherwise some ARM and other unsupported CPU/OS is linked with -O0 >> --- >> configure | 1 + >> 1 file changed, 1 insertion(+)

Re: [libav-devel] [PATCH] configure: Add the full parser to the codec dependencies

2016-12-14 Thread Anton Khirnov
Quoting Luca Barbato (2016-12-02 22:01:11) > Matches h263. And? I don't see how that implies that this is the correct thing to do. The h264 decoder does not invoke the parser, so it should not depend on it. -- Anton Khirnov ___ libav-devel mailing

[libav-devel] [PATCH] pthread_frame: do not run hwaccel decoding asynchronously unless it's safe

2016-12-14 Thread Anton Khirnov
Certain hardware decoding APIs are not guaranteed to be thread-safe, so having the user access decoded hardware surfaces while the decoder is running in another thread can cause failures (this is mainly known to happen with DXVA2). For such hwaccels, only allow the decoding thread to run while

[libav-devel] [PATCH] pthread_frame: ensure the threads don't run simultaneously with hwaccel

2016-12-14 Thread Anton Khirnov
--- libavcodec/h263dec.c | 2 +- libavcodec/h264dec.c | 2 +- libavcodec/pthread_frame.c | 35 +++ 3 files changed, 37 insertions(+), 2 deletions(-) diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c index e4a7227..921ff5f 100644 ---

Re: [libav-devel] [PATCH] vaapi: Support PAL8

2016-12-14 Thread Anton Khirnov
Quoting Luca Barbato (2016-12-12 16:01:18) > On 12/12/2016 13:09, Anton Khirnov wrote: > > Quoting Luca Barbato (2016-12-10 19:29:44) > >> On 10/12/2016 18:44, Mark Thompson wrote: > >>> Um, what? The internet thinks that P208 is a YUV 4:2:2 two-plane format > >>> analogous to NV12 (I guess

Re: [libav-devel] [PATCH] configure: use -O1 with MSVC by default

2016-12-14 Thread Martin Storsjö
On Tue, 13 Dec 2016, Steve Lhomme wrote: From: Steve Lhomme Otherwise some ARM and other unsupported CPU/OS is linked with -O0 --- configure | 1 + 1 file changed, 1 insertion(+) I find the commit message quite hard to understand and easily misleading. Would this make more

Re: [libav-devel] [PATCH] avconv: add avconv_d3d11va

2016-12-14 Thread Steve Lhomme
On Tue, Dec 13, 2016 at 5:36 PM, Diego Biurrun wrote: > Just a few cursory remarks as I only have a short moment right now. > > On Tue, Dec 13, 2016 at 02:19:03PM +0100, Steve Lhomme wrote: >> --- /dev/null >> +++ b/avconv_d3d11va.c >> @@ -0,0 +1,410 @@ >> + >> +/* define all

Re: [libav-devel] [PATCH] avconv: add avconv_d3d11va

2016-12-14 Thread Steve Lhomme
On Tue, Dec 13, 2016 at 5:16 PM, Luca Barbato wrote: > On 13/12/2016 14:19, Steve Lhomme wrote: >> +DEFINE_GUID(DXVA2_ModeMPEG2_VLD, 0xee27417f, >> 0x5e28,0x4e65,0xbe,0xea,0x1d,0x26,0xb5,0x08,0xad,0xc9); >> +DEFINE_GUID(DXVA2_ModeMPEG2and1_VLD, 0x86695f12, >>

Re: [libav-devel] [PATCH] configure: use -O1 with MSVC by default

2016-12-14 Thread Steve Lhomme
On Tue, Dec 13, 2016 at 5:17 PM, Diego Biurrun wrote: > On Tue, Dec 13, 2016 at 04:23:02PM +0100, Steve Lhomme wrote: >> On Tue, Dec 13, 2016 at 3:33 PM, Hendrik Leppkes wrote: >> > On Tue, Dec 13, 2016 at 2:24 PM, Steve Lhomme wrote: >>