Re: [libav-devel] [PATCH] http: Check for negative chunk sizes

2016-12-19 Thread Vittorio Giovara
On Mon, Dec 19, 2016 at 9:56 PM, Martin Storsjö wrote: > A negative chunk size is illegal and would end up used as > length for memcpy, where it would lead to memory accesses > out of bounds. > > Found-by: Paul Cher > > CC: libav-sta...@libav.org > --- >

[libav-devel] [PATCH] http: Check for negative chunk sizes

2016-12-19 Thread Martin Storsjö
A negative chunk size is illegal and would end up used as length for memcpy, where it would lead to memory accesses out of bounds. Found-by: Paul Cher CC: libav-sta...@libav.org --- libavformat/http.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/http.c

Re: [libav-devel] [PATCH 1/1] NVENC: Update check for Lookahead

2016-12-19 Thread Luca Barbato
On 19/12/2016 15:36, Yogender Gupta wrote: > I found one small bug in NVENC, the value of rc_lookahead is initialized to > -1 but the check in nvenc.c checks for if (ctx->rc_lookahead) rather than if > (ctx->rc_lookahead > 0) , thereby considering lookahead enabled all the time. > Looks fine,

[libav-devel] [PATCH 1/1] NVENC: Update check for Lookahead

2016-12-19 Thread Yogender Gupta
I found one small bug in NVENC, the value of rc_lookahead is initialized to -1 but the check in nvenc.c checks for if (ctx->rc_lookahead) rather than if (ctx->rc_lookahead > 0) , thereby considering lookahead enabled all the time. Thanks,

Re: [libav-devel] Skipping checkasm on MSVC DLL setups?

2016-12-19 Thread Luca Barbato
On 19/12/2016 10:51, Martin Storsjö wrote: > Since checkasm in MSVC DLL builds isn't that important, since it's > covered pretty well in other test setups anyway, I would suggest to just > disable checkasm in this case. We easily have got CONFIG_SHARED > available in makefile, but I guess we'd

Re: [libav-devel] [PATCH] aarch64: vp9itxfm: Use the offset parameter to movrel

2016-12-19 Thread Luca Barbato
On 19/12/2016 09:42, Martin Storsjö wrote: > This fixes build failures for iOS, broken since cad42fadcd2c. > --- > libavcodec/aarch64/vp9itxfm_neon.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/aarch64/vp9itxfm_neon.S >

Re: [libav-devel] [PATCH 1/4] frame: add left/top cropping fields to AVFrame

2016-12-19 Thread Vittorio Giovara
On Mon, Dec 19, 2016 at 1:02 PM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-12-19 10:11:29) >> I have a couple of points about this, in random order: >> >> 1. I had thought agreement was more towards a side data type rather >> than full types, is there any advantage

Re: [libav-devel] [PATCH 01/41] Bump major versions of all libraries

2016-12-19 Thread Anton Khirnov
Quoting Diego Biurrun (2016-12-19 13:11:24) > On Mon, Dec 19, 2016 at 12:57:23PM +0100, Anton Khirnov wrote: > > Quoting Diego Biurrun (2016-12-06 23:15:48) > > > On Tue, Dec 06, 2016 at 04:23:09PM -0500, Vittorio Giovara wrote: > > > > On Tue, Dec 6, 2016 at 2:43 AM, Diego Biurrun

Re: [libav-devel] [PATCH 01/41] Bump major versions of all libraries

2016-12-19 Thread Diego Biurrun
On Mon, Dec 19, 2016 at 12:57:23PM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-12-06 23:15:48) > > On Tue, Dec 06, 2016 at 04:23:09PM -0500, Vittorio Giovara wrote: > > > On Tue, Dec 6, 2016 at 2:43 AM, Diego Biurrun wrote: > > > > On Tue, Dec 06, 2016 at

Re: [libav-devel] [PATCH 03/41] lavfi: Drop deprecated functions to open a filter or a filterchain

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:24) > Deprecated in 03/2013. > --- > libavfilter/avfilter.c | 8 > libavfilter/avfilter.h | 30 -- > libavfilter/avfiltergraph.c | 17 - > libavfilter/version.h | 3 --- > 4 files

Re: [libav-devel] [PATCH 01/41] Bump major versions of all libraries

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:22) > This disable everything that was deprecated in the past 18 months, > with a couple of minor (but sensible) exceptions. > Postpone any API-incompatible changes until the next bump. > > Signed-off-by: Vittorio Giovara >

Re: [libav-devel] [PATCH 04/41] lavfi: Drop deprecated filter initialization

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:25) > Deprecated in 03/2013. > --- > libavfilter/avfilter.c | 7 --- > libavfilter/avfilter.h | 15 --- > libavfilter/version.h | 3 --- > 3 files changed, 25 deletions(-) Ok -- Anton Khirnov

Re: [libav-devel] [PATCH 06/41] lavfi: Drop deprecated non-const filter retrieval

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:27) > Deprecated in 10/2013. > --- > libavfilter/avfilter.c | 5 + > libavfilter/avfilter.h | 5 + > libavfilter/version.h | 3 --- > 3 files changed, 2 insertions(+), 11 deletions(-) > Ok -- Anton Khirnov

Re: [libav-devel] [PATCH 09/41] lavf: Drop deprecated hint to set muxer timebase

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:30) > Deprecated in 05/2014. > --- > libavformat/mux.c | 11 --- > libavformat/version.h | 4 +--- > 2 files changed, 1 insertion(+), 14 deletions(-) > Ok -- Anton Khirnov ___ libav-devel

Re: [libav-devel] [PATCH] unary: Convert to the new bitstream reader

2016-12-19 Thread Anton Khirnov
Quoting Diego Biurrun (2016-12-09 09:42:02) > From: Alexandra Hájková > > --- > > Sending now because it is a prerequisite for the already approved tta patch. > > libavcodec/aic.c | 2 +- > libavcodec/alac.c | 2 +- >

Re: [libav-devel] [PATCH 05/41] lavfi: Drop deprecated filter registration

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:26) > Deprecated in 04/2013. > --- > libavfilter/avfilter.c | 11 --- > libavfilter/avfilter.h | 18 -- > libavfilter/version.h | 3 --- > 3 files changed, 32 deletions(-) Ok -- Anton Khirnov

Re: [libav-devel] [PATCH 1/4] frame: add left/top cropping fields to AVFrame

2016-12-19 Thread Anton Khirnov
Quoting Hendrik Leppkes (2016-12-18 21:37:44) > On Sun, Dec 18, 2016 at 9:27 PM, Anton Khirnov wrote: > > --- > > doc/APIchanges | 4 > > libavutil/frame.c | 2 ++ > > libavutil/frame.h | 14 ++ > > libavutil/version.h | 2 +- > > 4 files changed,

Re: [libav-devel] [PATCH 2/5] libautil: add support for AV_HWDEVICE_TYPE_D3D11VA

2016-12-19 Thread Anton Khirnov
Quoting Steve Lhomme (2016-12-16 11:05:40) > From: Steve Lhomme > > --- > libavutil/Makefile | 3 + > libavutil/hwcontext.c | 3 + > libavutil/hwcontext.h | 1 + > libavutil/hwcontext_d3d11va.c | 456 >

Re: [libav-devel] [PATCH 01/31] Bump major versions of all libraries

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-17 09:31:05) > This disables everything that was deprecated in the past 18 months, > with a couple of minor (but sensible) exceptions. > > Every major version number is aligned to 60, to facilitate distributions > and downstream users in identifying which release

Re: [libav-devel] [PATCH 07/41] lavf: Drop deprecated bitexact functionality

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:28) > Deprecated in 05/2014. > --- > libavformat/mux.c | 7 --- > libavformat/version.h | 3 --- > 2 files changed, 10 deletions(-) > Ok -- Anton Khirnov ___ libav-devel mailing list

Re: [libav-devel] [PATCH 07/12] mlp: Convert to the new bitstream reader

2016-12-19 Thread Anton Khirnov
Quoting Diego Biurrun (2016-11-27 17:32:38) > From: Alexandra Hájková > > --- > libavcodec/mlp_parser.c | 63 +++ > libavcodec/mlp_parser.h | 4 +- > libavcodec/mlpdec.c | 201 > > 3 files changed, 136

Re: [libav-devel] [PATCH 1/4] frame: add left/top cropping fields to AVFrame

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-19 10:11:29) > On Sun, Dec 18, 2016 at 9:27 PM, Anton Khirnov wrote: > > --- > > doc/APIchanges | 4 > > libavutil/frame.c | 2 ++ > > libavutil/frame.h | 14 ++ > > libavutil/version.h | 2 +- > > 4 files changed,

Re: [libav-devel] [PATCH 02/41] lavfi: Drop deprecated way of passing options for a few filters

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:23) > Deprecated in 02/2013. > --- > libavfilter/af_channelmap.c | 7 - > libavfilter/af_join.c | 8 - > libavfilter/avfilter.c | 76 > - > libavfilter/buffersrc.c | 8 - >

Re: [libav-devel] [PATCH 08/41] lavf: Drop deprecated AVFract type and related field

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:29) > Deprecated in 05/2014. > --- > libavformat/avformat.h | 21 - > libavformat/version.h | 3 --- > 2 files changed, 24 deletions(-) > Ok -- Anton Khirnov ___ libav-devel mailing

Re: [libav-devel] [PATCH 01/41] Bump major versions of all libraries

2016-12-19 Thread Anton Khirnov
Quoting Diego Biurrun (2016-12-06 23:15:48) > On Tue, Dec 06, 2016 at 04:23:09PM -0500, Vittorio Giovara wrote: > > On Tue, Dec 6, 2016 at 2:43 AM, Diego Biurrun wrote: > > > On Tue, Dec 06, 2016 at 12:27:22AM -0500, Vittorio Giovara wrote: > > >> --- a/libavdevice/version.h > >

Re: [libav-devel] [PATCH] ratecontrol: Drop xvid-rc-related struct members unused after a6901b9c6

2016-12-19 Thread Vittorio Giovara
On Mon, Dec 19, 2016 at 12:21 PM, Diego Biurrun wrote: > --- > > Thanks to Vittorio for noticing. > > libavcodec/ratecontrol.h | 4 > 1 file changed, 4 deletions(-) > > diff --git a/libavcodec/ratecontrol.h b/libavcodec/ratecontrol.h > index 2976806..7c289c6 100644 > ---

[libav-devel] [PATCH] ratecontrol: Drop xvid-rc-related struct members unused after a6901b9c6

2016-12-19 Thread Diego Biurrun
--- Thanks to Vittorio for noticing. libavcodec/ratecontrol.h | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/ratecontrol.h b/libavcodec/ratecontrol.h index 2976806..7c289c6 100644 --- a/libavcodec/ratecontrol.h +++ b/libavcodec/ratecontrol.h @@ -79,10 +79,6 @@ typedef struct

[libav-devel] Skipping checkasm on MSVC DLL setups?

2016-12-19 Thread Martin Storsjö
Hi, It seems like checkasm has started failing to build in MSVC DLL setups recently, see e.g. this instance: https://fate.libav.org/i686-msvc-10-dll-wine The reason is that once you build with --enable-shared with MSVC, you can't link those object files via static libraries any longer. (See

Re: [libav-devel] [PATCH 1/4] frame: add left/top cropping fields to AVFrame

2016-12-19 Thread Vittorio Giovara
On Sun, Dec 18, 2016 at 9:27 PM, Anton Khirnov wrote: > --- > doc/APIchanges | 4 > libavutil/frame.c | 2 ++ > libavutil/frame.h | 14 ++ > libavutil/version.h | 2 +- > 4 files changed, 21 insertions(+), 1 deletion(-) > > diff --git

[libav-devel] [PATCH] aarch64: vp9itxfm: Use the offset parameter to movrel

2016-12-19 Thread Martin Storsjö
This fixes build failures for iOS, broken since cad42fadcd2c. --- libavcodec/aarch64/vp9itxfm_neon.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aarch64/vp9itxfm_neon.S b/libavcodec/aarch64/vp9itxfm_neon.S index 053d46f..7ce6df0 100644 ---