[libav-devel] [PATCH] opt: Do not clip numerator / denominator arbitrarily in write_number

2014-02-18 Thread Mashiat Sarker Shakkhar
It is not clear why this has to be `1 << 24` and can't be INT_MAX. --- libavutil/opt.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index ede4a49..d50e631 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -76,7 +76,7 @@ static int wri

Re: [libav-devel] [PATCH] vc1: Use codec ID from AVCodecContext while parsing frame header

2012-10-12 Thread Mashiat Sarker Shakkhar
On 10/11/2012 1:23 PM, Kostya Shishkov wrote: On Thu, Oct 11, 2012 at 01:13:56PM -0400, Mashiat Sarker Shakkhar wrote: This fixes a segfault with samples that I have (both of them MPEG-TS). Looks like avctx->codec is not being set during parsing. --- libavcodec/vc1.c |2 +- 1 f

[libav-devel] [PATCH] vc1: Use codec ID from AVCodecContext while parsing frame header

2012-10-11 Thread Mashiat Sarker Shakkhar
This fixes a segfault with samples that I have (both of them MPEG-TS). Looks like avctx->codec is not being set during parsing. --- libavcodec/vc1.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vc1.c b/libavcodec/vc1.c index c7edc25..a8dd38a 100644 --- a/libav

Re: [libav-devel] [PATCH 2/5] vc1dec: Invoke edge emulation regardless of MV precision for 1-MV chroma

2012-10-09 Thread Mashiat Sarker Shakkhar
On 10/9/2012 7:37 PM, Ronald S. Bultje wrote: Hi, On Tue, Oct 9, 2012 at 1:38 PM, Mashiat Sarker Shakkhar wrote: This is required due to the way VC-1 handles chroma pull-back which may end up causing negative chroma MV for zero luma MV. Edge emulation needs to be invoked in such cases. This

[libav-devel] [PATCH 5/5] Double motion vector range for HPEL interlaced picture in proper place

2012-10-09 Thread Mashiat Sarker Shakkhar
The existing code is not in the right place and it should cover both interlaced frame and field pictures. --- libavcodec/vc1.c|5 + libavcodec/vc1dec.c |4 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/vc1.c b/libavcodec/vc1.c index b04d570..c7edc25

[libav-devel] [PATCH 4/5] vc1dec: Set opposite to the correct value for 1REF field pictures

2012-10-09 Thread Mashiat Sarker Shakkhar
--- libavcodec/vc1dec.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 491e200..40164cc 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -1458,10 +1458,16 @@ static inline void vc1_pred_mv(VC1Contex

[libav-devel] [PATCH 3/5] vc1dec: Use correct spelling of "opposite"

2012-10-09 Thread Mashiat Sarker Shakkhar
--- libavcodec/vc1dec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 2683c86..491e200 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -1350,7 +1350,7 @@ static inline void vc1_pred_mv(VC1Context *v, i

[libav-devel] [PATCH 2/5] vc1dec: Invoke edge emulation regardless of MV precision for 1-MV chroma

2012-10-09 Thread Mashiat Sarker Shakkhar
This is required due to the way VC-1 handles chroma pull-back which may end up causing negative chroma MV for zero luma MV. Edge emulation needs to be invoked in such cases. This problem only affects chroma Y motion vector. --- libavcodec/vc1dec.c |2 +- 1 file changed, 1 insertion(+), 1 dele

[libav-devel] [PATCH 1/5] vc1dec: Set chroma reference field from REFFIELD for 1REF field pictures

2012-10-09 Thread Mashiat Sarker Shakkhar
Interlaced field pictures can have one or two reference pictures, signaled by NUMREF syntax element. For single reference pictures, reference picture is determined by REFFIELD syntax element. --- libavcodec/vc1dec.c |1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/vc1dec.c b/libav

[libav-devel] Libav stickers for GSoC mentor summit

2012-09-30 Thread Mashiat Sarker Shakkhar
Hi guys Since I might be the only one going to the GSoC mentor summit from Libav, I take the responsibility of getting some Libav stickers printed (time permitting). For those of you who don't know, at mentor summit they have this thing where all orgs exchange stickers; and I wouldn't want Li

Re: [libav-devel] [PATCH 1/2] wmalosslessdec: increase WMALL_BLOCK_MAX_BITS to 14.

2012-09-29 Thread Mashiat Sarker Shakkhar
On 9/29/2012 3:13 AM, Anton Khirnov wrote: --- libavcodec/wmalosslessdec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 56e9aad..8300b17 100644 --- a/libavcodec/wmalosslessdec.c +++ b/libavcodec/wmalossle

Re: [libav-devel] [PATCH] riff: Add SVQ3 fourcc

2012-09-14 Thread Mashiat Sarker Shakkhar
On 9/14/2012 9:16 PM, Måns Rullgård wrote: Derek Buitenhuis writes: On 14/09/2012 11:12 AM, Kostya Shishkov wrote: probably OK, do you have working samples? I do. I don't know if I am allowed to distribute it though. We all know that's just newspeak for "I don't want you to see my porn ha

Re: [libav-devel] Optimization of decoders for MIPS.

2012-08-24 Thread Mashiat Sarker Shakkhar
On 8/24/2012 11:07 PM, Diego Biurrun wrote: On Fri, Aug 24, 2012 at 04:55:25PM +, Babic, Nedeljko wrote: We were asked (from our customers) to optimized some codecs from FFmpeg and are in process of submitting patches to FFmpeg maintainers (some of them are already integrated). That will

Re: [libav-devel] [PATCH 1/4] vc1dec: Fix motion vector scaling for field pictures

2012-08-19 Thread Mashiat Sarker Shakkhar
Patch dropped for now. Some concerns have been raised by Kostya and Diego; I will try to address them when I have time. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 4/4] vc1dec: Invoke edge emulation regardless of MV precision for 1-MV blocks

2012-08-19 Thread Mashiat Sarker Shakkhar
On 8/19/2012 12:07 AM, Kostya Shishkov wrote: On Sat, Aug 18, 2012 at 11:25:54PM +0600, Mashiat Sarker Shakkhar wrote: On 8/18/2012 11:13 PM, Kostya Shishkov wrote: [...] Maybe the same thing (chroma MV pullback) happens? Please investigate and update the log message. "I just apply some

[libav-devel] [PATCH 2/2] vc1dec: Set opposite to the correct value for 1REF field pictures

2012-08-18 Thread Mashiat Sarker Shakkhar
--- libavcodec/vc1dec.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index a9043a5..58e106a 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -1458,10 +1458,16 @@ static inline void vc1_pred_mv(VC1Contex

[libav-devel] [PATCH 1/2] vc1dec: Use correct spelling of "opposite"

2012-08-18 Thread Mashiat Sarker Shakkhar
--- libavcodec/vc1dec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 6951072..a9043a5 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -1350,7 +1350,7 @@ static inline void vc1_pred_mv(VC1Context *v, i

Re: [libav-devel] [PATCH 4/4] vc1dec: Invoke edge emulation regardless of MV precision for 1-MV blocks

2012-08-18 Thread Mashiat Sarker Shakkhar
On 8/18/2012 11:13 PM, Kostya Shishkov wrote: [...] Maybe the same thing (chroma MV pullback) happens? Please investigate and update the log message. "I just apply some magic and it works" sounds wrong in commit. It's not magic. We have already discussed this. Sometimes chroma MVs require edge

Re: [libav-devel] [PATCH 1/4] vc1dec: Fix motion vector scaling for field pictures

2012-08-18 Thread Mashiat Sarker Shakkhar
On 8/18/2012 11:06 PM, Kostya Shishkov wrote: On Sat, Aug 18, 2012 at 10:57:12PM +0600, Mashiat Sarker Shakkhar wrote: Current scaling code is buggy and twisted. This patch re-implements it. This fixes visible artifacts in a number of samples. The code in scale_field_mv follows corresponding

[libav-devel] [PATCH 4/4] vc1dec: Invoke edge emulation regardless of MV precision for 1-MV blocks

2012-08-18 Thread Mashiat Sarker Shakkhar
This is very close to 8379ea5e9f6bf3d50663ffb655ba5dd6a11652b4 and same description applies. The issue probably warrants further investigation, but for now this fix seems to work without breaking anything else. --- libavcodec/vc1dec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[libav-devel] [PATCH 3/4] vc1dec: Set chroma reference field from REFFIELD for 1REF field pictures

2012-08-18 Thread Mashiat Sarker Shakkhar
Interlaced field pictures can have one or two reference pictures, signaled by NUMREF syntax element. For single reference pictures, reference picture is determined by REFFIELD syntax element. --- libavcodec/vc1dec.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libavcode

[libav-devel] [PATCH 2/4] vc1dec: Set opposite to the correct value for 1REF field pictures

2012-08-18 Thread Mashiat Sarker Shakkhar
--- libavcodec/vc1dec.c | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 22ad325..3e73a1c 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -1229,7 +1229,7 @@ static inline void vc1_pred_mv(VC1Con

[libav-devel] [PATCH 1/4] vc1dec: Fix motion vector scaling for field pictures

2012-08-18 Thread Mashiat Sarker Shakkhar
Current scaling code is buggy and twisted. This patch re-implements it. This fixes visible artifacts in a number of samples. The code in scale_field_mv follows corresponding code from reference decoder. I do not take credit for the code itself. --- libavcodec/vc1.c | 34 +-- libavcodec/

Re: [libav-devel] VDD and FOMS 2012

2012-08-04 Thread Mashiat Sarker Shakkhar
On 8/4/2012 11:58 PM, Diego Biurrun wrote: So who else is going to attend the VideoLAN Dev Days? I know that Luca, Mans, Kostya and myself will be there. Register and come to Paris :) I know Ronald will be there. Derek should be there too. I will be there if I can get a visa. I will attend

[libav-devel] [PATCH 2/2] vc1dec: Remove separate scaling function for interlaced field MVs

2012-08-03 Thread Mashiat Sarker Shakkhar
The scaling process for obtaining direct MVs from co-located field MVs are same for interlaced field and progressive pictures. --- libavcodec/vc1dec.c | 30 -- 1 files changed, 8 insertions(+), 22 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c in

[libav-devel] [PATCH 1/2] vc1dec: Invoke edge_emulation regardless of MV precision

2012-08-03 Thread Mashiat Sarker Shakkhar
In VC-1 interlaced field pictures, chroma motion vectors can extend beyond picture boundary even if luma vectors are bounded. The problem shows up only for hpel interpolated MVs, and may be due to the way motion vectors are scaled / cropped. Thanks to Konstantin Shishkov for suggesting the fix. Th

Re: [libav-devel] [PATCH 1/2] vc1dec: Invoke edge_emulation regardless of MV precision

2012-08-03 Thread Mashiat Sarker Shakkhar
On 8/3/2012 8:04 PM, Kostya Shishkov wrote: [...] if (v->rangeredfrm || (v->mv_mode == MV_PMODE_INTENSITY_COMP) || s->h_edge_pos < 22 || v_edge_pos < 22 -|| (unsigned)(src_x - s->mspel) > s->h_edge_pos - (mx&3) - 16 - s->mspel * 3 -|| (unsigned)(src_y - s->mspel)

[libav-devel] [PATCH 2/2] vc1dec: Remove separate scaling function for interlaced field MVs

2012-08-03 Thread Mashiat Sarker Shakkhar
The scaling process for obtaining direct MVs from co-located field MVs are same for interlaced field and progressive pictures. --- libavcodec/vc1dec.c | 30 -- 1 files changed, 8 insertions(+), 22 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c in

[libav-devel] [PATCH 1/2] vc1dec: Invoke edge_emulation regardless of MV precision

2012-08-03 Thread Mashiat Sarker Shakkhar
In VC-1 interlaced field pictures, chroma motion vectors can extend beyond picture boundary even if luma vectors are bounded. The problem shows up only for hpel MVs, and may be due to the way motion vectors are scaled / cropped. Thanks to Konstantin Shishkov for suggesting the fix. This fixes long

Re: [libav-devel] [RFC] doxy for internal API

2012-08-01 Thread Mashiat Sarker Shakkhar
On 8/1/2012 5:48 PM, an...@khirnov.net wrote: [...] If there indeed are people who read generated doxy for non-public API, s/ for non-public API// ;P I'd like them to speak up and prove their existence. Speaking as a user, I just open the header file and read the relevant part. (Also from

[libav-devel] [PATCH] vc1dec: Override invalid macroblock quantizer

2012-07-28 Thread Mashiat Sarker Shakkhar
From: Michael Niedermayer Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index fd515c7..c6cbfc1 100644 --- a/libavcodec/vc1dec

[libav-devel] [PATCH] vc1dec: Override invalid macroblock quantizer

2012-07-28 Thread Mashiat Sarker Shakkhar
From: Michael Niedermayer Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index f49fff8..0c031b7 100644 --- a/libavcodec/vc1dec

[libav-devel] [PATCH 4/4] vc1dec: check that coded slice positions and interlacing match.

2012-07-28 Thread Mashiat Sarker Shakkhar
From: Michael Niedermayer This fixes out of array writes Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 0c031b7..0027b

[libav-devel] [PATCH 3/4] vc1dec: Override invalid macroblock quantizer

2012-07-28 Thread Mashiat Sarker Shakkhar
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index f49fff8..0c031b7 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c

[libav-devel] [PATCH 2/4] vc1dec: Do not ignore ff_vc1_parse_frame_header_adv return value

2012-07-28 Thread Mashiat Sarker Shakkhar
From: Michael Niedermayer Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 51124cf..f49fff8 1006

[libav-devel] [PATCH 1/4] vc1: avoid reading beyond the last line in vc1_draw_sprites()

2012-07-28 Thread Mashiat Sarker Shakkhar
From: Michael Niedermayer Fixes overread Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 51124cf..3f

Re: [libav-devel] [PATCH 3/6] vc1dec: Sanity-check macroblock quantizer

2012-07-27 Thread Mashiat Sarker Shakkhar
On 7/28/2012 1:15 AM, Luca Barbato wrote: On 07/27/2012 02:49 PM, Mashiat Sarker Shakkhar wrote: From: Michael Niedermayer Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |3 +++ 1 files changed, 3 insert

Re: [libav-devel] [PATCH 1/4] vc1: avoid reading beyond the last line in vc1_draw_sprites()

2012-07-27 Thread Mashiat Sarker Shakkhar
On 7/27/2012 9:23 PM, Derek Buitenhuis wrote: On 27/07/2012 11:10 AM, Mashiat Sarker Shakkhar wrote: Fixes overread Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |8 ++-- 1 files changed, 6 insert

[libav-devel] [PATCH 4/4] vc1dec: check that coded slice positions and interlacing match.

2012-07-27 Thread Mashiat Sarker Shakkhar
This fixes out of array writes Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 5b0fe46..851485c 100644 ---

[libav-devel] [PATCH 3/4] vc1dec: Sanity-check macroblock quantizer

2012-07-27 Thread Mashiat Sarker Shakkhar
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 2ff1315..5b0fe46 100644 --- a/libavcodec/vc1dec.c +++ b/lib

[libav-devel] [PATCH 2/4] vc1dec: Do not ignore ff_vc1_parse_frame_header_adv return value

2012-07-27 Thread Mashiat Sarker Shakkhar
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 3feb312..2ff1315 100644 --- a/libavcodec/vc1dec.

[libav-devel] [PATCH 1/4] vc1: avoid reading beyond the last line in vc1_draw_sprites()

2012-07-27 Thread Mashiat Sarker Shakkhar
Fixes overread Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 51124cf..3feb312 100644 --- a/libavcode

Re: [libav-devel] [PATCH 4/6] vc1dec: check end_mb_y / start_mb_y validity

2012-07-27 Thread Mashiat Sarker Shakkhar
On 7/27/2012 7:01 PM, Kostya Shishkov wrote: On Fri, Jul 27, 2012 at 06:49:42PM +0600, Mashiat Sarker Shakkhar wrote: From: Michael Niedermayer Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |4 1 files

Re: [libav-devel] [PATCH 6/6] vc1dec: dont apply the loop filter on fields

2012-07-27 Thread Mashiat Sarker Shakkhar
On 7/27/2012 7:04 PM, Kostya Shishkov wrote: On Fri, Jul 27, 2012 at 06:49:44PM +0600, Mashiat Sarker Shakkhar wrote: From: Michael Niedermayer Fixes read of uninitialized memory Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c|2 +- tests/ref/fate/vc1_sa10143

[libav-devel] [PATCH 6/6] vc1dec: dont apply the loop filter on fields

2012-07-27 Thread Mashiat Sarker Shakkhar
From: Michael Niedermayer Fixes read of uninitialized memory Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c|2 +- tests/ref/fate/vc1_sa10143 | 58 ++-- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/libavcodec/

[libav-devel] [PATCH 5/6] vc1dec: check that coded slice positions and interlacing match.

2012-07-27 Thread Mashiat Sarker Shakkhar
From: Michael Niedermayer This fixes out of array writes Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index

[libav-devel] [PATCH 4/6] vc1dec: check end_mb_y / start_mb_y validity

2012-07-27 Thread Mashiat Sarker Shakkhar
From: Michael Niedermayer Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index e34e8d2..c63ccf1 100644 --- a/l

[libav-devel] [PATCH 3/6] vc1dec: Sanity-check macroblock quantizer

2012-07-27 Thread Mashiat Sarker Shakkhar
From: Michael Niedermayer Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index ac5bfe5..e34e8d2 100644 --- a/li

[libav-devel] [PATCH 2/6] vc1dec: dont ignore ff_vc1_parse_frame_header_advs return value

2012-07-27 Thread Mashiat Sarker Shakkhar
From: Michael Niedermayer Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index b76fc76..ac5bfe5 100

[libav-devel] [PATCH 1/6] vc1: avoid reading beyond the last line in vc1_draw_sprites()

2012-07-27 Thread Mashiat Sarker Shakkhar
From: Michael Niedermayer Fixes overread Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 51124cf..b76fc7

[libav-devel] VC-1 security fixes cherry-picked from FFmpeg git

2012-07-27 Thread Mashiat Sarker Shakkhar
These patches won't probably improve anything in terms of decoded picture. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] vc1: Add a test for interlaced field pictures

2012-07-23 Thread Mashiat Sarker Shakkhar
On 7/23/2012 8:39 AM, Derek Buitenhuis wrote: On 22/07/2012 10:22 PM, Mashiat Sarker Shakkhar wrote: OK PING Thanks to Anton, the sample is in FATE now. Ran through FATE locally and pushed. It's been on the fate-suite servers for ~2 days now, so it should be synched everywhere. Tha

Re: [libav-devel] [PATCH] vc1: Add a test for interlaced field pictures

2012-07-22 Thread Mashiat Sarker Shakkhar
Benjamin Larsson writes: > > OK > PING Thanks to Anton, the sample is in FATE now. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] libopenjpeg: introduce lowres and lowqual private options

2012-07-19 Thread Mashiat Sarker Shakkhar
On 7/20/2012 2:36 AM, Johan Andersson wrote: On Thu, Jul 19, 2012 at 08:59:45PM +0200, Luca Barbato wrote: OpenJPEG can decode in lower resolution or decode only a number of enhancement layers. Didnt we remove lowres couple of month ago for some reason? This one is a private option. The prev

Re: [libav-devel] VC-1 interlaced FATE tests

2012-07-16 Thread Mashiat Sarker Shakkhar
On 7/16/2012 7:34 PM, Diego Biurrun wrote: On Mon, Jul 16, 2012 at 02:45:22PM +0600, Mashiat Sarker Shakkhar wrote: These framecrcs are not bitexact with reference decoder. Why? Because of the unimplemented loop filter and deblocking filter as far as I remember

Re: [libav-devel] [PATCH] vc1: Add a test for interlaced field pictures

2012-07-16 Thread Mashiat Sarker Shakkhar
Sample uploaded to ftp://upload.libav.org/incoming/fate-vc1/ ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] vc1: Add a test for interlaced field pictures

2012-07-16 Thread Mashiat Sarker Shakkhar
--- tests/fate/microsoft.mak |3 +++ tests/ref/fate/vc1_sa10143 | 31 +++ 2 files changed, 34 insertions(+), 0 deletions(-) create mode 100644 tests/ref/fate/vc1_sa10143 diff --git a/tests/fate/microsoft.mak b/tests/fate/microsoft.mak index 515f6ab..48bdb95 10

[libav-devel] (no subject)

2012-07-16 Thread Mashiat Sarker Shakkhar
These framecrcs are not bitexact with reference decoder. But currently we have no test whatsoever for VC1 interlaced. So having one seemed useful to me. I would like to add some more in the future. ___ libav-devel mailing list libav-devel@libav.org https

[libav-devel] [PATCH] vc1dec: Do not use random pred_flag if motion vector data is skipped

2012-07-14 Thread Mashiat Sarker Shakkhar
This fixes SA10143.vc1 from test-suite. Also partially fixes MC-VC1.ts from videolan streams archive. --- libavcodec/vc1dec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 0f56e22..51124cf 100644 --- a/libavcodec/vc1dec.c

[libav-devel] [PATCH 2/2] image2: Add "start_number" private option to the demuxer

2012-06-22 Thread Mashiat Sarker Shakkhar
Currently if a pattern is given we look for up to the fifth file name in the sequence. This option sets that limit to an arbitrary number. --- libavformat/img2dec.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index b

[libav-devel] [PATCH 1/2] image2: Add "start_number" private option to the muxer

2012-06-22 Thread Mashiat Sarker Shakkhar
This adds the capability to start counting file number from an arbitrary integer. This includes a few lines of trivial code from FFmpeg codebase. --- libavformat/img2enc.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/libavformat/img2enc.c b/libavform

[libav-devel] [PATCH 2/2] image2: Add "startat" private option to the demuxer

2012-06-22 Thread Mashiat Sarker Shakkhar
Currently if a pattern is given we look for up to the fifth file name in the sequence. This option sets that limit to an arbitrary number. --- libavformat/img2dec.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index b

[libav-devel] [PATCH 1/2] image2: Add "startat" private option to the muxer

2012-06-22 Thread Mashiat Sarker Shakkhar
This adds the capability to start counting file number from an arbitrary integer. This includes a few lines of trivial code from FFmpeg codebase. --- libavformat/img2enc.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/libavformat/img2enc.c b/libavform

Re: [libav-devel] LinuxTag

2012-05-17 Thread Mashiat Sarker Shakkhar
On 5/18/2012 4:47 AM, Diego Biurrun wrote: On Sun, May 13, 2012 at 05:30:22PM +0200, Diego Biurrun wrote: So who is coming? I expect to be there from start to finish. Janne will be away from Friday noon, Mans Saturday noon. Do we have posters or so to decorate the booth? We'll need a small s

Re: [libav-devel] [PATCH] WMAL: Restore removed code in mclms_predict()

2012-05-05 Thread Mashiat Sarker Shakkhar
Kostya Shishkov writes: > > On Thu, May 03, 2012 at 10:14:47AM -0700, Mashiat Sarker Shakkhar wrote: > > Based on observations made by Jakub Stachowski > > --- > > libavcodec/wmalosslessdec.c |2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) [...

Re: [libav-devel] [PATCH v2] zerocodec: check if there is previous frame

2012-05-04 Thread Mashiat Sarker Shakkhar
On 5/4/2012 10:54 PM, Derek Buitenhuis wrote: On 04/05/2012 12:48 PM, Diego Biurrun wrote: I admittedly don't know the surrounding code, but the error message does not make much sense to me. Why is the lack of a previous frame an error condition? And when does this happen except on the first f

[libav-devel] [PATCH] WMAL: Restore removed code in mclms_predict()

2012-05-03 Thread Mashiat Sarker Shakkhar
Based on observations made by Jakub Stachowski --- libavcodec/wmalosslessdec.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index ff63083..7510b12 100644 --- a/libavcodec/wmalosslessdec.c +++ b/libavcodec/wmalo

[libav-devel] (no subject)

2012-05-03 Thread Mashiat Sarker Shakkhar
This restores code that was removed in 0e23b508214611659fc459ed6e5d6704b907694b Fixes this sample: http://stream1.criteriamx.com:8080/part.wma ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] WMAL Cosmetics: Fix indentation

2012-05-02 Thread Mashiat Sarker Shakkhar
--- libavcodec/wmalosslessdec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 13b706e..81b5cc5 100644 --- a/libavcodec/wmalosslessdec.c +++ b/libavcodec/wmalosslessdec.c @@ -1227,7 +1227,7 @@ static int dec

Re: [libav-devel] [PATCH] WMAL: Fix reconstruction of audio with uncoded channel(s)

2012-05-01 Thread Mashiat Sarker Shakkhar
On 5/2/2012 3:27 AM, Mashiat Sarker Shakkhar wrote: From: Kostya Shishkov Signed-off-by: Mashiat Sarker Shakkhar --- libavcodec/wmalosslessdec.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) [...] For the record, fixes decoding of a sample for me. (There are other broken

[libav-devel] [PATCH] WMAL: Fix reconstruction of audio with uncoded channel(s)

2012-05-01 Thread Mashiat Sarker Shakkhar
From: Kostya Shishkov Signed-off-by: Mashiat Sarker Shakkhar --- libavcodec/wmalosslessdec.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 913271e..25599c4 100644 --- a/libavcodec/wmalosslessdec.c

Re: [libav-devel] [PATCH] wmall: fix reconstructing audio with uncoded channels

2012-05-01 Thread Mashiat Sarker Shakkhar
On 5/2/2012 1:12 AM, Kostya Shishkov wrote: --- not that I care, just for the reference --- libavcodec/wmalosslessdec.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 1520a06..1f6581e 100644 --- a/li

[libav-devel] [PATCH] WMAL: Do not start decoding if frame does not end in current packet

2012-04-30 Thread Mashiat Sarker Shakkhar
This fixes decoding of frames which span more than two packets. Tested with recit24.wma. --- libavcodec/wmalosslessdec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 1520a06..e86645e 100644 --- a/libavco

Re: [libav-devel] [PATCH 1/2] WMAL: Do not start decoding if frame does not end in current packet

2012-04-28 Thread Mashiat Sarker Shakkhar
On 4/29/2012 1:09 AM, Kostya Shishkov wrote: [...] approach seems OK but please add braces it's not Python and it will compile to if(num_bits){ if(!s->packet_loss) ... else ... } I have no excuse :( I don't know what I was thinking. Curiously, I am actually learning python these days

[libav-devel] [PATCH 2/2] wmalossless: Ensure that last frame is not written again if nothing was decoded in current packet.

2012-04-28 Thread Mashiat Sarker Shakkhar
From: Jakub Stachowski Reviewed-by: Mashiat Sarker Shakkhar Signed-off-by: Michael Niedermayer --- libavcodec/wmalosslessdec.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index bc1a19c..59bebad 100644

[libav-devel] [PATCH 1/2] WMAL: Do not start decoding if frame does not end in current packet

2012-04-28 Thread Mashiat Sarker Shakkhar
This fixes decoding of frames which span more than two packets. Tested with recit24.wma. --- libavcodec/wmalosslessdec.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 1520a06..bc1a19c 100644 --- a/liba

[libav-devel] [PATCH] segment: fix null pointer dereference

2012-04-27 Thread Mashiat Sarker Shakkhar
From: Paul B Mahol Signed-off-by: Paul B Mahol Signed-off-by: Michael Niedermayer --- libavformat/segment.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 1af412a..05f76a7 100644 --- a/libavformat/segment.c ++

Re: [libav-devel] [PATCH] ARM: allow runtime masking of CPU features

2012-04-21 Thread Mashiat Sarker Shakkhar
On 4/21/2012 8:32 PM, Mans Rullgard wrote: This allows masking CPU features with the -cpuflags avconv option which is useful for testing different optimisations without rebuilding. Signed-off-by: Mans Rullgard What happened to the umlaut? [...] ___

Re: [libav-devel] [PATCH 4/4] dwt: Cosmetic changes

2012-04-15 Thread Mashiat Sarker Shakkhar
On 4/16/2012 12:48 AM, Måns Rullgård wrote: Diego Biurrun writes: Please read the developer guidelines about K&R style again. This is not worth reviewing until it has less obvious mistakes. This is a good illustration of the difference between less and fewer. You should have said "fewer obv

Re: [libav-devel] [2/2] libschroedingerdec: Use SchroTag to store pts

2012-04-15 Thread Mashiat Sarker Shakkhar
On 4/13/2012 11:42 PM, Jordi Ortiz wrote: --- libavcodec/libschroedingerdec.c | 117 +-- 1 file changed, 50 insertions(+), 67 deletions(-) diff --git a/libavcodec/libschroedingerdec.c b/libavcodec/libschroedingerdec.c index 5911d8a..60b7f8e 100644 --- a/l

Re: [libav-devel] [1/2] libschroedingerdec: Change AVPicture to AVFrame

2012-04-15 Thread Mashiat Sarker Shakkhar
Hi Please note that my review is mostly non-technical. On 4/13/2012 11:42 PM, Jordi Ortiz wrote: --- libavcodec/libschroedingerdec.c | 93 +++ 1 file changed, 74 insertions(+), 19 deletions(-) diff --git a/libavcodec/libschroedingerdec.c b/libavcodec/l

[libav-devel] [PATCH 4/4] WMAL: Cosmetics

2012-04-13 Thread Mashiat Sarker Shakkhar
The alignment does not look good after dropping seekable_frame_in_packet. --- libavcodec/wmalosslessdec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index f2e1c70..aaf71c8 100644 --- a/libavcodec/wmalossless

[libav-devel] [PATCH 3/4] WMAL: Warn about missing bitstream splicing feature and ask for sample

2012-04-13 Thread Mashiat Sarker Shakkhar
--- libavcodec/wmalosslessdec.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 2103f88..f2e1c70 100644 --- a/libavcodec/wmalosslessdec.c +++ b/libavcodec/wmalosslessdec.c @@ -1177,6 +1177,8 @@ static int dec

[libav-devel] [PATCH 2/4] Skip seekable_frame_in_packet

2012-04-13 Thread Mashiat Sarker Shakkhar
There is no point in storing it in a variable, since it is not used anywhere else in the decoder. --- libavcodec/wmalosslessdec.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 4e2d28b..2103f88 100644 ---

[libav-devel] [PATCH 1/4] WMAL: Drop unused variable num_possible_block_size

2012-04-13 Thread Mashiat Sarker Shakkhar
This is probably a leftover from WMAP. --- libavcodec/wmalosslessdec.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 4eb9ebe..4e2d28b 100644 --- a/libavcodec/wmalosslessdec.c +++ b/libavcodec/wmalosslessde

[libav-devel] WMA Lossless cleanup

2012-04-13 Thread Mashiat Sarker Shakkhar
The following patch-series silences some gcc warnings about unused variables. [PATCH 1/4] WMAL: Drop unused variable num_possible_block_size [PATCH 2/4] Skip seekable_frame_in_packet [PATCH 3/4] WMAL: Warn about missing bitstream splicing feature and [PATCH 4/4] WMAL: Cosmetics ___

[libav-devel] [PATCH] WMAL: Do not try to read rawpcm coefficients if bits is invalid

2012-04-13 Thread Mashiat Sarker Shakkhar
From: Michael Niedermayer --- libavcodec/wmalosslessdec.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 4eb9ebe..feea6ef 100644 --- a/libavcodec/wmalosslessdec.c +++ b/libavcodec/wmalosslessdec.c @@ -9

[libav-devel] [PATCH] WMAL: Do not try to read rawpcm coefficients if bits is invalid

2012-04-13 Thread Mashiat Sarker Shakkhar
From: Michael Niedermayer --- libavcodec/wmalosslessdec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 4eb9ebe..3682d05 100644 --- a/libavcodec/wmalosslessdec.c +++ b/libavcodec/wmalosslessdec.c @@ -93

Re: [libav-devel] [PATCH] build: Remove the trailing backslash of the last line of Makefiles

2012-04-12 Thread Mashiat Sarker Shakkhar
On 4/12/2012 6:27 PM, Martin Storsjö wrote: The trailing backslash at the last line allegedly causes issues for make on msys. --- libavcodec/arm/Makefile |2 +- libavcodec/mips/Makefile |2 +- libavcodec/ppc/Makefile |2 +- libavcodec/sparc/Makefile |2 +- libavcodec/x8

Re: [libav-devel] [PATCH] avconv: allow '-async -1' to disable timestamp sync for audio encoding

2012-04-08 Thread Mashiat Sarker Shakkhar
On 4/9/2012 1:08 AM, Justin Ruggles wrote: This will allow a workaround for cases where input timestamps are invalid or when decoder delay of 1 packet or more confuses avconv into using the wrong timestamps as a sync reference. --- avconv.c |4 ++-- 1 files changed, 2 insertions(+), 2 dele

Re: [libav-devel] Interested in GSoC with libav!

2012-03-30 Thread Mashiat Sarker Shakkhar
On 3/31/2012 3:07 AM, Mike Melanson wrote: [...] I'm reading for a Bachelor's Degree in Computer Science. I'm interested in taking part in this year's Google Summer of Code and your project has especially caught my attention (specifically the HEVC/H265 decoder with Mr. Bultje). I apologise for no

Re: [libav-devel] [PATCH] WMAL: Remove inaccurate and unnecessary doxy

2012-03-29 Thread Mashiat Sarker Shakkhar
On 3/29/2012 2:04 PM, Kostya Shishkov wrote: On Thu, Mar 29, 2012 at 10:35:25AM +0300, Martin Storsjö wrote: On Thu, 29 Mar 2012, Diego Biurrun wrote: On Wed, Mar 28, 2012 at 11:12:13AM -0700, Mashiat Sarker Shakkhar wrote: A call to decode_packet() does not always decode a complete WMA

[libav-devel] [PATCH] WMAL: Remove inaccurate and unnecessary doxy

2012-03-28 Thread Mashiat Sarker Shakkhar
A call to decode_packet() does not always decode a complete WMA packet. Moreover, this is not the correct place to document calls that are part of the public API. --- libavcodec/wmalosslessdec.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/libavcodec/wmalosslessd

Re: [libav-devel] [PATCH] asf: only set index_read if the index contained entries.

2012-03-28 Thread Mashiat Sarker Shakkhar
On 3/28/2012 11:36 PM, Ronald S. Bultje wrote: From: "Ronald S. Bultje" This allows falling back to a binary search if the file contains no index, thus fixing seeking in such files (e.g. luckynight.wma). --- libavformat/asfdec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [libav-devel] [PATCH] wmall: fix seeking.

2012-03-28 Thread Mashiat Sarker Shakkhar
On 3/28/2012 11:21 PM, Ronald S. Bultje wrote: Hi, On Wed, Mar 28, 2012 at 8:51 AM, Mashiat Sarker Shakkhar wrote: On 3/28/2012 8:06 PM, Ronald S. Bultje wrote: --- libavcodec/wmalosslessdec.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) [...] This does not

Re: [libav-devel] [PATCH] wmall: fix seeking.

2012-03-28 Thread Mashiat Sarker Shakkhar
On 3/28/2012 8:06 PM, Ronald S. Bultje wrote: --- libavcodec/wmalosslessdec.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) [...] This does not fix seeking for me, at least not with avplay. I thought I had already reported the issue. Benjamin and Kostya, can you s

Re: [libav-devel] [PATCH] wmalossless: error out on invalid values for order.

2012-03-21 Thread Mashiat Sarker Shakkhar
On 3/22/2012 1:41 AM, Ronald S. Bultje wrote: From: "Ronald S. Bultje" Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/wmalosslessdec.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) [...]

Re: [libav-devel] [PATCH] VC1: Do not read from array if index is invalid

2012-03-19 Thread Mashiat Sarker Shakkhar
On 3/20/2012 5:52 AM, Ronald S. Bultje wrote: From: Mashiat Sarker Shakkhar Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org Signed-off-by: Ronald S. Bultje --- libavcodec/vc1.c|2 +- libavcodec/vc1dec.c | 36 +-

Re: [libav-devel] [PATCH 2/2] dxva2_vc1: pass the overlap flag to the decoder

2012-03-12 Thread Mashiat Sarker Shakkhar
On 3/12/2012 4:51 PM, Anton Khirnov wrote: From: Hendrik Leppkes Signed-off-by: Anton Khirnov --- libavcodec/dxva2_vc1.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavcodec/dxva2_vc1.c b/libavcodec/dxva2_vc1.c index 53c205e..2b0480b 100644 --- a/libavcodec/dx

Re: [libav-devel] [PATCH 1/2] dxva2_vc1: fix decoding of BI frames

2012-03-12 Thread Mashiat Sarker Shakkhar
On 3/12/2012 4:51 PM, Anton Khirnov wrote: From: Hendrik Leppkes Signed-off-by: Anton Khirnov --- libavcodec/dxva2_vc1.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/dxva2_vc1.c b/libavcodec/dxva2_vc1.c index 64447ad..53c205e 100644 --- a/libavcod

  1   2   >