Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-10-05 Thread Ronald S. Bultje
Hi, On Fri, Oct 5, 2012 at 1:46 PM, Diego Biurrun wrote: > On Fri, Oct 05, 2012 at 01:38:44PM -0700, Ronald S. Bultje wrote: >> From: "Ronald S. Bultje" >> >> Use this in VP8/H264-8bit loopfilter functions so they can be used if >> there is no align

[libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-10-05 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Use this in VP8/H264-8bit loopfilter functions so they can be used if there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). --- libavcodec/x86/h264_deblock.asm | 27 ++- libavcodec/x86/h264dsp_init.c | 4 +- libavcodec/x86/vp8dsp.asm

[libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-10-05 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Use this in VP8/H264-8bit loopfilter functions so they can be used if there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). --- libavcodec/x86/h264_deblock.asm | 27 ++- libavcodec/x86/h264dsp_init.c | 4 +- libavcodec/x86/vp8dsp.asm

[libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-10-05 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Use this in VP8/H264-8bit loopfilter functions so they can be used if there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). --- libavcodec/x86/h264_deblock.asm | 27 ++- libavcodec/x86/h264dsp_init.c | 4 +- libavcodec/x86/vp8dsp.asm

Re: [libav-devel] [PATCH] h264: don't touch H264Context->ref_count[] during MB decoding.

2012-10-05 Thread Ronald S. Bultje
Hi, On Fri, Oct 5, 2012 at 12:25 AM, Diego Biurrun wrote: > On Fri, Oct 05, 2012 at 02:48:20AM +0200, Luca Barbato wrote: >> On 10/05/2012 01:29 AM, Ronald S. Bultje wrote: >> > On Thu, Oct 4, 2012 at 4:27 PM, Ronald S. Bultje >> > wrote: >> >> > Oh

Re: [libav-devel] [PATCH] Drop broken and unused CABAC test program.

2012-10-05 Thread Ronald S. Bultje
Hi, On Fri, Oct 5, 2012 at 3:50 AM, Diego Biurrun wrote: > --- > The test program is of doubtful utility, fails to compile on x86_32 and > was never part of our test suite. > libavcodec/Makefile |3 +- > libavcodec/cabac.c | 147 > --- > 2 f

Re: [libav-devel] [PATCH] h264: don't touch H264Context->ref_count[] during MB decoding.

2012-10-04 Thread Ronald S. Bultje
On Thu, Oct 4, 2012 at 4:27 PM, Ronald S. Bultje wrote: > Hi, > > On Thu, Oct 4, 2012 at 12:59 PM, Luca Barbato wrote: >> On 10/04/2012 01:46 AM, Luca Barbato wrote: >>> From: "Ronald S. Bultje" >>> >>> The variable is copied to subsequent t

Re: [libav-devel] [PATCH] h264: don't touch H264Context->ref_count[] during MB decoding.

2012-10-04 Thread Ronald S. Bultje
Hi, On Thu, Oct 4, 2012 at 12:59 PM, Luca Barbato wrote: > On 10/04/2012 01:46 AM, Luca Barbato wrote: >> From: "Ronald S. Bultje" >> >> The variable is copied to subsequent threads at the same time, so this >> may cause wrong ref_count[] values to be cop

[libav-devel] [PATCH] h264: don't touch H264Context->ref_count[] during MB decoding.

2012-10-03 Thread Ronald S. Bultje
From: "Ronald S. Bultje" The variable is copied to subsequent threads at the same time, so this may cause wrong ref_count[] values to be copied to subsequent threads. This bug was found using TSAN. --- libavcodec/h264_cabac.c | 41 -

[libav-devel] [PATCH] h264: don't touch H264Context->ref_count[] during MB decoding.

2012-10-03 Thread Ronald S. Bultje
From: "Ronald S. Bultje" The variable is copied to subsequent threads at the same time, so this may cause wrong ref_count[] values to be copied to subsequent threads. --- libavcodec/h264_cabac.c | 41 - libavcodec/h264_cavl

[libav-devel] [PATCH] h264: don't touch H264Context->ref_count[] during MB decoding.

2012-10-03 Thread Ronald S. Bultje
From: "Ronald S. Bultje" The variable is copied to subsequent threads at the same time, so this may cause wrong ref_count[] values to be copied to subsequent threads. --- libavcodec/h264_cabac.c | 41 - libavcodec/h264_cavl

[libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Ronald S. Bultje
From: "Ronald S. Bultje" This patch adds support for .dll shared library generation using MSVC's native build tools. To properly load non-function symbols from DLL files, we prefix them with __declspec(dllimport) on MSVC for shared library builds when accessed from outside the .d

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Ronald S. Bultje
Hi, On Wed, Oct 3, 2012 at 9:07 AM, Diego Biurrun wrote: > On Wed, Oct 03, 2012 at 08:49:30AM -0700, Ronald S. Bultje wrote: >> On Wed, Oct 3, 2012 at 8:43 AM, Diego Biurrun wrote: >> > On Wed, Oct 03, 2012 at 08:31:43AM -0700, Ronald S. Bultje wrote: >> >> On Wed

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Ronald S. Bultje
Hi, On Wed, Oct 3, 2012 at 8:43 AM, Diego Biurrun wrote: > On Wed, Oct 03, 2012 at 08:31:43AM -0700, Ronald S. Bultje wrote: >> On Wed, Oct 3, 2012 at 7:44 AM, Måns Rullgård wrote: >> > "Ronald S. Bultje" writes: >> >> These AVCODEC_SYMBOL things

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Ronald S. Bultje
Hi, On Wed, Oct 3, 2012 at 8:27 AM, Diego Biurrun wrote: > On Wed, Oct 03, 2012 at 07:37:29AM -0700, Ronald S. Bultje wrote: >> >> --- a/libavcodec/golomb.h >> >> +++ b/libavcodec/golomb.h >> >> @@ -33,13 +33,14 @@ >> >> >> >> -e

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Ronald S. Bultje
Hi, On Wed, Oct 3, 2012 at 7:44 AM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: >> These AVCODEC_SYMBOL things will be used in public headers, thus the >> definition needs t exist in a public header. Since I need to use >> __declspec(dllimport) only for .dl

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Ronald S. Bultje
Hi, On Wed, Oct 3, 2012 at 4:02 AM, Diego Biurrun wrote: > On Tue, Oct 02, 2012 at 05:48:26PM -0700, Ronald S. Bultje wrote: >> 2) a lot of ff_ symbols, and dsputil_init, are accessed from outside >> the library in which they exist. These are bugs and should be fixed (i.e. >&

Re: [libav-devel] Explicit symbol visibility Was: [PATCH] Shared library support for MSVC build.

2012-10-02 Thread Ronald S. Bultje
Hi, On Tue, Oct 2, 2012 at 7:07 PM, Luca Barbato wrote: > On 10/03/2012 03:47 AM, Diego Elio Pettenò wrote: >> On 02/10/2012 18:40, Luca Barbato wrote: >>> >>> The patch was rejected since it was _really_ invasive and after lots of >>> back and forth we ended up with pattern matching and code w/o

[libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-02 Thread Ronald S. Bultje
From: "Ronald S. Bultje" This patch adds support for .dll shared library generation using MSVC's native build tools. To properly load non-function symbols from DLL files, we prefix them with __declspec(dllimport) on MSVC for shared library builds when accessed from outside the .d

Re: [libav-devel] [PATCH 5/6] x86: af_volume: add SSE2-optimized s16 volume scaling

2012-10-02 Thread Ronald S. Bultje
Hi, On Tue, Oct 2, 2012 at 10:54 AM, Justin Ruggles wrote: > On 09/29/2012 01:17 AM, Justin Ruggles wrote: >> --- >> libavfilter/af_volume.c |3 ++ >> libavfilter/x86/Makefile |3 ++ >> libavfilter/x86/af_volume.asm| 56 >> ++ >>

Re: [libav-devel] [PATCH 08/11] mpegaudioenc: use planar sample format

2012-10-01 Thread Ronald S. Bultje
Hi, On Tue, Sep 11, 2012 at 2:40 AM, Benjamin Larsson wrote: > On 09/11/2012 06:32 AM, Ronald S. Bultje wrote: >> >> Hi, >> >> On Sat, Aug 25, 2012 at 8:01 PM, Justin Ruggles >> wrote: >>> >>> --- >>> libavcodec/mpegaudioenc.c

Re: [libav-devel] [PATCH] avutil: add yuva444p10 pixel format

2012-10-01 Thread Ronald S. Bultje
Hi, On Mon, Oct 1, 2012 at 5:03 AM, Luca Barbato wrote: > From: Paul B Mahol > > Signed-off-by: Luca Barbato > --- > libavutil/pixdesc.c | 26 ++ > libavutil/pixfmt.h| 3 ++- > libswscale/utils.c| 2 ++ > tests/ref/lavfi/pixdesc

Re: [libav-devel] [PATCH] avutil: add yuva422p and yuva444p formats

2012-09-30 Thread Ronald S. Bultje
Hi, On Sun, Sep 30, 2012 at 7:18 PM, Luca Barbato wrote: > --- > > Here my initial take with those two formats I consider sort of useful. > > libavcodec/utils.c| 2 ++ > libavutil/pixdesc.c | 26 ++ > libavutil/pixfmt.h| 3 +++ > libsws

Re: [libav-devel] FFv1.3 support

2012-09-30 Thread Ronald S. Bultje
Hi, On Sun, Sep 30, 2012 at 1:00 PM, Peter B. wrote: > +PIX_FMT_0RGB=0x123+4, ///< packed RGB 8:8:8, 32bpp, 0RGB0RGB... > +PIX_FMT_RGB0, ///< packed RGB 8:8:8, 32bpp, RGB0RGB0... > +PIX_FMT_0BGR, ///< packed BGR 8:8:8, 32bpp, 0BGR0BGR... > +PIX_FMT_BGR0, ///< p

Re: [libav-devel] [PATCH] mpegaudiodec: fix short_start calculation

2012-09-28 Thread Ronald S. Bultje
Hi, On Fri, Sep 28, 2012 at 6:58 AM, Luca Barbato wrote: > The value should be always 3, as it follows from the specification. > > Fix a stack buffer overflow in exponents_from_scale_factors as reported > by asan. Thanks to Dale Curtis for the sample vector. Please include sample name (crash1.mp

Re: [libav-devel] [PATCH] mpegaudiodec: fix short_start calculation

2012-09-28 Thread Ronald S. Bultje
Hi, On Sep 28, 2012 5:42 AM, "Luca Barbato" wrote: > > The value should never be 2 according to the specification. > --- > libavcodec/mpegaudiodec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mpegaudiodec.c b/libavcodec/mpegaudiodec.c > index 03094f6..ead

Re: [libav-devel] [PATCH] x86: get_cpu_flags: add necessary ifdefs around function body

2012-09-27 Thread Ronald S. Bultje
Hi, On Wed, Sep 26, 2012 at 5:12 PM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> Hi, >> >> On Wed, Sep 26, 2012 at 11:00 AM, Diego Biurrun wrote: >>> On Tue, Sep 11, 2012 at 10:29:08AM +0200, Diego Biurrun wrote: >>>> On Thu

Re: [libav-devel] [PATCH] infinite loop in try_decode_frame

2012-09-27 Thread Ronald S. Bultje
Hi, On Thu, Sep 27, 2012 at 12:44 PM, Jindřich Makovička wrote: > On Thu, Sep 27, 2012 at 6:23 PM, Justin Ruggles > wrote: >> On 09/27/2012 11:16 AM, Jindřich Makovička wrote: >>> Hi, >>> >>> I encountered $subj, with a (possibly broken, but I am not sure) h264 >>> stream, where the packet (or r

Re: [libav-devel] [PATCH 4/5] doc/platform: Replace Visual Studio section with build instructions

2012-09-27 Thread Ronald S. Bultje
Hi, On Thu, Sep 27, 2012 at 12:39 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > doc/platform.texi | 71 > +++-- > 1 file changed, 58 insertions(+), 13 deletions(-) [..] > +@item @uref{https://github.com/rbultje/c99-to-c8

Re: [libav-devel] [PATCH 5/5 v2] doc/faq: Change the Visual Studio entry to reflect current status

2012-09-27 Thread Ronald S. Bultje
Hi, On Thu, Sep 27, 2012 at 1:19 PM, Derek Buitenhuis wrote: > On 27/09/2012 4:16 PM, Luca Barbato wrote: >> Point to all the options available not just msvc, the rest look fine. > > Fixed locally. I won't bother sending a v3 patch unless people really want > me to. No, it's fine otherwise. Plea

Re: [libav-devel] [PATCH 2/5] doc/platform: Remove false claim about MinGW installer

2012-09-27 Thread Ronald S. Bultje
Hi, On Thu, Sep 27, 2012 at 12:39 PM, Derek Buitenhuis wrote: > This works just fine, and has for quite a while, using the mingw-get > installer. > > Signed-off-by: Derek Buitenhuis > --- > doc/platform.texi |6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/doc/p

Re: [libav-devel] [PATCH 1/5] doc/platform: Mention MinGW-w64

2012-09-27 Thread Ronald S. Bultje
Hi, On Thu, Sep 27, 2012 at 12:38 PM, Derek Buitenhuis wrote: > This is the toolchain most, including Libav's nightlies, use to build. > > Signed-off-by: Derek Buitenhuis > --- > doc/platform.texi |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/doc/platform.texi

Re: [libav-devel] [PATCH] dsputil_mmx: fix reading prior of the src array in sub_hfyu_median_prediction()

2012-09-27 Thread Ronald S. Bultje
Hi, On Thu, Sep 27, 2012 at 8:06 AM, Derek Buitenhuis wrote: > From: Michael Niedermayer > > This should fix the utvideoenc valgrind failure > > Signed-off-by: Michael Niedermayer > --- > libavcodec/x86/dsputilenc_mmx.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) LGTM. Rona

Re: [libav-devel] [PATCH] x86: get_cpu_flags: add necessary ifdefs around function body

2012-09-26 Thread Ronald S. Bultje
Hi, On Wed, Sep 26, 2012 at 11:00 AM, Diego Biurrun wrote: > On Tue, Sep 11, 2012 at 10:29:08AM +0200, Diego Biurrun wrote: >> On Thu, Sep 06, 2012 at 11:42:45AM +0100, Måns Rullgård wrote: >> > "Ronald S. Bultje" writes: >> > > On Wed, Sep

Re: [libav-devel] [PATCH] cbrt_tablegen: Include libm.h

2012-09-24 Thread Ronald S. Bultje
Hi, On Mon, Sep 24, 2012 at 5:22 PM, Derek Buitenhuis wrote: > Needed for cbrtf fallback on systems which lack it. > > Signed-off-by: Derek Buitenhuis > --- > libavcodec/cbrt_tablegen.c |1 + > 1 file changed, 1 insertion(+) lgtm. Ronald ___ lib

Re: [libav-devel] [PATCH] libx264: add open_gop option

2012-09-22 Thread Ronald S. Bultje
Hi, On Sat, Sep 22, 2012 at 12:13 PM, John Van Sickle wrote: > On Thu, Sep 20, 2012 at 6:36 PM, Ronald S. Bultje wrote: >> Hi, >> >> On Thu, Sep 20, 2012 at 2:33 PM, wrote: >>> From: John Van Sickle >>> >>> x264 doesn't

Re: [libav-devel] [PATCH] libx264: add open_gop option

2012-09-20 Thread Ronald S. Bultje
Hi, On Thu, Sep 20, 2012 at 2:33 PM, wrote: > From: John Van Sickle > > x264 doesn't enable open-gop by default and neither should avconv. > --- > libavcodec/libx264.c |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) [..] > -x4->params.b_open_gop = !(avctx->flags & CO

Re: [libav-devel] [PATCH] pixdesc: Fix YUV 4:1:0 subsampling.

2012-09-19 Thread Ronald S. Bultje
Hi, On Wed, Sep 19, 2012 at 2:53 PM, Alex Converse wrote: > On Wed, Sep 19, 2012 at 1:15 PM, Luca Barbato wrote: >> On 09/19/2012 10:09 PM, Alex Converse wrote: >>> YUV 4:1:0 has 1 chroma sample for a 4x2 block so the vertical resolution >>> is 1/2 not 1/4. >>> --- >>> libavutil/pixdesc.c |

Re: [libav-devel] [PATCH 07/13] matroskadec: validate lace_size when parsed

2012-09-19 Thread Ronald S. Bultje
Hi, On Mon, Sep 17, 2012 at 10:39 AM, Luca Barbato wrote: > --- > libavformat/matroskadec.c | 13 - > 1 files changed, 8 insertions(+), 5 deletions(-) What does this fix? Crashes on invalid files? Or is this just slightly more strict parsing with no practical side-effects? Please

Re: [libav-devel] [PATCH 12/13] matroskadec: split frame parsing

2012-09-19 Thread Ronald S. Bultje
Hi, On Wed, Sep 19, 2012 at 9:14 AM, Luca Barbato wrote: > On 09/17/2012 07:39 PM, Luca Barbato wrote: >> --- >> libavformat/matroskadec.c | 288 >> + >> 1 files changed, 158 insertions(+), 130 deletions(-) >> > > Ping. OK. Ronald _

Re: [libav-devel] [PATCH 2/2] configure: add --toolchain option

2012-09-17 Thread Ronald S. Bultje
Hi, On Sun, Sep 16, 2012 at 2:09 PM, Mans Rullgard wrote: > This allows creating canned shorthands for common combinations > of cc, ld etc. > > Signed-off-by: Mans Rullgard > --- > configure | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/configure b/configure > index 29

Re: [libav-devel] [RFC] warning silencing

2012-09-16 Thread Ronald S. Bultje
Hi, On Sun, Sep 16, 2012 at 1:02 PM, Måns Rullgård wrote: > Benjamin Larsson writes: > >> Should we (me) aim to get rid of the "may be used uninitialized" and >> other warnings in the code? Most of the cases we just need to >> initialize the offending variable to silence the warning. For example

Re: [libav-devel] [PATCH] configure: make ARFLAGS and AR_O configurable for MSVC

2012-09-15 Thread Ronald S. Bultje
Hi, On Sat, Sep 15, 2012 at 4:59 AM, Martin Storsjö wrote: > > > Hendrik Leppkes wrote: > >>On Sat, Sep 15, 2012 at 1:36 PM, Måns Rullgård wrote: >> >>> Hendrik Leppkes writes: >>> >>> > On Fri, Sep 14, 2012 at 11:46 PM, Måns Rullgård >>wrote: >>> >> >>> >> Now, can we all work together to fi

Re: [libav-devel] [PATCH 5/8] matroskadec: return meaningful errors in matroska_decode_buffer

2012-09-14 Thread Ronald S. Bultje
Hi, On Fri, Sep 14, 2012 at 6:22 PM, Luca Barbato wrote: > --- > libavformat/matroskadec.c | 25 +++-- > 1 files changed, 19 insertions(+), 6 deletions(-) Nice, OK. Ronald ___ libav-devel mailing list libav-devel@libav.org https

Re: [libav-devel] [PATCH 4/8] matroskadec: fix incorrect unsigned->signed conversion

2012-09-14 Thread Ronald S. Bultje
Hi, On Fri, Sep 14, 2012 at 6:22 PM, Luca Barbato wrote: > From: Dale Curtis > > --- > libavformat/matroskadec.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) OK. Ronald ___ libav-devel mailing list libav-devel@libav.org https://list

Re: [libav-devel] [PATCH 1/8] matroska: honor error_recognition on unknown doctypes

2012-09-14 Thread Ronald S. Bultje
Hi, On Fri, Sep 14, 2012 at 6:22 PM, Luca Barbato wrote: > --- > libavformat/matroskadec.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index 7792b4c..95130fc 100644 > --- a/libavformat/matroskadec.c > ++

Re: [libav-devel] [PATCH 2/8] matroskadec: check realloc in lzo encoding

2012-09-14 Thread Ronald S. Bultje
Hi, On Fri, Sep 14, 2012 at 6:22 PM, Luca Barbato wrote: > Make all the compression encodings behave the same way. > --- > libavformat/matroskadec.c |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) LGTM. Ronald ___ libav-devel mailin

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-09-14 Thread Ronald S. Bultje
Hi, On Fri, Sep 14, 2012 at 6:19 PM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> From: "Ronald S. Bultje" >> >> Use this in VP8 DSP functions so they can be used if there is no >> aligned stack (e.g. MSVC 32bit). >> >> No

[libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-09-14 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Use this in VP8 DSP functions so they can be used if there is no aligned stack (e.g. MSVC 32bit). Note: it is currently slightly ugly, we need a register to store the unaligned stack; there may be better solutions for this. Please comment. --- libavcodec/x86/

Re: [libav-devel] [PATCH] Allow use of strncpy()

2012-09-14 Thread Ronald S. Bultje
Hi, On Fri, Sep 14, 2012 at 2:07 PM, Måns Rullgård wrote: > Luca Barbato writes: > >> On 09/09/2012 03:07 PM, Mans Rullgard wrote: >>> There are cases where strncpy() does exactly what is required. >>> A blanket ban forces more convoluted solutions to be used in those >>> cases, and has been a c

Re: [libav-devel] [PATCH-VERSION1 1/2] msvc: Add a va_copy compatability macro for msvc

2012-09-14 Thread Ronald S. Bultje
Hi, On Fri, Sep 14, 2012 at 12:20 PM, Derek Buitenhuis wrote: > On 14/09/2012 3:18 PM, Derek Buitenhuis wrote: >> Signed-off-by: Derek Buitenhuis >> --- >> compat/msvcrt/snprintf.c |1 + >> compat/va_copy.h | 26 ++ >> 2 files changed, 27 insertions(+) >>

Re: [libav-devel] [PATCH] configure: make ARFLAGS and AR_O configurable for MSVC

2012-09-14 Thread Ronald S. Bultje
Hi, On Fri, Sep 14, 2012 at 2:36 PM, Måns Rullgård wrote: > Derek Buitenhuis writes: > >> On 14/09/2012 5:16 PM, Måns Rullgård wrote: >>> ar does not touch the contents of the individual files. Does lib.exe >>> add something extra to the archive that ar does not? >> >> The linker needs it in MS

Re: [libav-devel] [PATCH] x86: dsputil: Move IDCT initialization to a separate file

2012-09-14 Thread Ronald S. Bultje
Hi, On Thu, Sep 13, 2012 at 5:42 PM, Diego Biurrun wrote: > --- > This iteration fixes some #includes. I'd like to repeat something I said on IRC, because I feel it's relevant to this discussion. Assertion 1: dsputil is an infinite mess. Assertion 2: in the ideal state, dspcontext is split in a

Re: [libav-devel] [PATCH] trasher: Include all the necessary headers

2012-09-13 Thread Ronald S. Bultje
Hi, On Sep 13, 2012 4:16 AM, "Martin Storsjö" wrote: > > On Thu, 13 Sep 2012, Martin Storsjö wrote: > >> This fixes building of this tool on mingw32ce. >> --- >> tools/trasher.c |2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tools/trasher.c b/tools/trasher.c >> index 11605b8..356

Re: [libav-devel] [PATCH 2/2] x86: avcodec: Rename dsputil_mmx.h ---> dsputil.h

2012-09-12 Thread Ronald S. Bultje
Hi, On Wed, Sep 12, 2012 at 1:02 PM, Måns Rullgård wrote: > Diego Biurrun writes: > >> On Tue, Sep 11, 2012 at 05:17:11PM +0300, Martin Storsjö wrote: >>> On Tue, 11 Sep 2012, Diego Biurrun wrote: >>> >On Mon, Sep 03, 2012 at 11:54:20AM +0200, Diego Biurrun wrote: >>> >>--- >>> >> libavcodec/img

Re: [libav-devel] [PATCH] compat/vsnprintf: return number of bytes required on truncation.

2012-09-11 Thread Ronald S. Bultje
Hi, On Tue, Sep 11, 2012 at 2:53 PM, Derek Buitenhuis wrote: > On 11/09/2012 4:43 PM, Måns Rullgård wrote: >> Accessing the va_list after passing it to another function is undefined. >> You need to either reinitialise it (not possible since it was received >> as an argument) or make a copy before

Re: [libav-devel] [RFC] [PATCH] swscale: Remove two bogus asserts

2012-09-11 Thread Ronald S. Bultje
Hi, On Tue, Sep 11, 2012 at 1:12 PM, Diego Biurrun wrote: > --- > This fixes FATE with -DDEBUG, but I don't understand the code well > enough to know if this is correct. Also, a better log msg could help. > libswscale/swscale.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > d

[libav-devel] [PATCH] compat/vsnprintf: return number of bytes required on truncation.

2012-09-11 Thread Ronald S. Bultje
From: "Ronald S. Bultje" This conforms to C99, but requires Windows >= XP. --- compat/msvcrt/snprintf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/compat/msvcrt/snprintf.c b/compat/msvcrt/snprintf.c index 2cdec74..b9c1619 100644 --- a/compat/msvcrt/snp

Re: [libav-devel] [PATCH] configure: Only disable aligned stack on MSVC on 32 bit

2012-09-11 Thread Ronald S. Bultje
Hi, On Tue, Sep 11, 2012 at 2:25 PM, Måns Rullgård wrote: > Diego Biurrun writes: > >> On Tue, Sep 11, 2012 at 11:35:59AM +0300, Martin Storsjö wrote: >>> --- a/configure >>> +++ b/configure >>> @@ -2330,7 +2330,7 @@ probe_cc(){ >>> if [ $pfx = hostcc ]; then >>> append _cf

Re: [libav-devel] 0.9 release

2012-09-11 Thread Ronald S. Bultje
Hi, On Tue, Sep 11, 2012 at 2:16 PM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> Hi, >> >> On Tue, Sep 11, 2012 at 1:54 PM, Måns Rullgård wrote: >>> Hendrik Leppkes writes: >>> >>>> On Tue, Sep 11, 2012 at 12

Re: [libav-devel] [PATCH] configure: Only disable aligned stack on MSVC on 32 bit

2012-09-11 Thread Ronald S. Bultje
Hi, On Tue, Sep 11, 2012 at 1:39 PM, Hendrik Leppkes wrote: > > > On Tue, Sep 11, 2012 at 12:48 PM, Måns Rullgård wrote: >> >> Martin Storsjö writes: >> >> > On 64 bit, the stack seems to be aligned enough for our needs. >> > --- >> > configure |2 +- >> > 1 file changed, 1 insertion(+), 1

Re: [libav-devel] 0.9 release

2012-09-11 Thread Ronald S. Bultje
Hi, On Tue, Sep 11, 2012 at 1:54 PM, Måns Rullgård wrote: > Hendrik Leppkes writes: > >> On Tue, Sep 11, 2012 at 12:56 PM, Måns Rullgård wrote: >> >>> >>> Does msvc support additional alignment for local variables? >> >> Using __declspec(align(...)) should do just that with MSVC. Seems it is >>

Re: [libav-devel] [PATCH 08/11] mpegaudioenc: use planar sample format

2012-09-10 Thread Ronald S. Bultje
Hi, On Sat, Aug 25, 2012 at 8:01 PM, Justin Ruggles wrote: > --- > libavcodec/mpegaudioenc.c | 10 -- > 1 files changed, 4 insertions(+), 6 deletions(-) Is there a speed loss / gain with common tasks (e.g. playback)? My understanding for most of these was that the interleaving is a se

Re: [libav-devel] 0.9 release

2012-09-10 Thread Ronald S. Bultje
Hi, On Fri, Sep 7, 2012 at 4:33 PM, Derek Buitenhuis wrote: > On 06/09/2012 6:34 PM, Diego Biurrun wrote: >> So, could we make a new release soon? I know there are a few issues here >> and there, but nothing serious should be blocking it. gstreamer is about >> to release 1.0, they would benefit

Re: [libav-devel] [PATCH 1/2] configure: msvc: Always cause an error on implicit function declarations.

2012-09-10 Thread Ronald S. Bultje
>>On Sat, Sep 8, 2012 at 1:40 PM, Martin Storsjö wrote: > >> >>>On Sat, 8 Sep 2012, Måns Rullgård wrote: > >> >>> Hendrik Leppkes writes: > >> >>>> On Sat, Sep 8, 2012 at 12:09 PM, Ronald S. Bultje < rsbul...@gmail.com > >> >&

Re: [libav-devel] [PATCH] swscale: Provide the right alignment for external mmx asm

2012-09-08 Thread Ronald S. Bultje
Hi, On Sep 9, 2012 12:46 AM, "Martin Storsjö" wrote: > > This reverts parts of e0c6cce4472. There is external mmx asm that > requires this alignment. > > This fixes crashes when using swscale in builds with external mmx, > without inline assembly. > --- > libswscale/utils.c |6 -- > 1 fi

Re: [libav-devel] [PATCH 1/2] configure: msvc: Always cause an error on implicit function declarations.

2012-09-08 Thread Ronald S. Bultje
te: >>>> >>>> Hendrik Leppkes writes: >>>>> >>>>> >>>>> On Sat, Sep 8, 2012 at 12:09 PM, Ronald S. Bultje >>>>>> >>>>>>> wrote: >>>>>> >>>>>> >>&g

Re: [libav-devel] [PATCH] x86: mlpdsp: mlp_filter_channel_x86 requires inline asm

2012-09-08 Thread Ronald S. Bultje
Hi, On Sep 8, 2012 12:10 PM, "Hendrik Leppkes" wrote: > > > > On Sat, Sep 8, 2012 at 12:07 PM, Ronald S. Bultje wrote: >> >> Why is have_7regs set? Are you building for 64 bits? I haven't tested that yet. :-). >> >> Ronald > > > Yes

Re: [libav-devel] [PATCH 1/2] configure: msvc: Always cause an error on implicit function declarations.

2012-09-08 Thread Ronald S. Bultje
Hi, On Sep 8, 2012 8:42 AM, "Hendrik Leppkes" wrote: > > Currently, implicit function declarations are only considered an error during building, > but not during configure, which can result in configure mis-detecting the availability > of some functions (most notably "log2" on amd64). > > Instead

Re: [libav-devel] [PATCH] x86: mlpdsp: mlp_filter_channel_x86 requires inline asm

2012-09-08 Thread Ronald S. Bultje
Hi, On Sep 8, 2012 8:41 AM, "Hendrik Leppkes" wrote: > > --- > libavcodec/x86/mlpdsp.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/x86/mlpdsp.c b/libavcodec/x86/mlpdsp.c > index f81c329..8f886aa 100644 > --- a/libavcodec/x86/mlpdsp.c > +++ b/libav

Re: [libav-devel] Resolution changes during frame based multithreading

2012-09-07 Thread Ronald S. Bultje
Hi, On Sep 6, 2012 10:47 PM, "Janne Grunau" wrote: > > On 2012-09-06 15:25:23 +0200, Janne Grunau wrote: > > On 2012-09-06 15:00:03 +0200, Ronald S. Bultje wrote: > > > > > > Did you test https://roundup.libav.org/issue2393 then? > > > > no.

Re: [libav-devel] Resolution changes during frame based multithreading

2012-09-06 Thread Ronald S. Bultje
Hi, On Thu, Sep 6, 2012 at 2:27 PM, Janne Grunau wrote: > On 2012-09-06 14:06:43 +0200, Ronald S. Bultje wrote: >> >> On Thu, Sep 6, 2012 at 2:00 PM, Janne Grunau wrote: >> > >> > I have a completely untested patch for h263dec.c since I have problems >>

Re: [libav-devel] Resolution changes during frame based multithreading

2012-09-06 Thread Ronald S. Bultje
Hi, On Thu, Sep 6, 2012 at 2:00 PM, Janne Grunau wrote: > Hi, > > following patchset adds support to resolution changes during > frame-based multithreading. > > The RV34 change is well tested with multiple samples and zzuf > (although not with the last version of the patches). It fixes > http://b

Re: [libav-devel] [PATCH 5/5] [RFC] h264: support resolution changes during frame-mt

2012-09-06 Thread Ronald S. Bultje
Hi, On Thu, Sep 6, 2012 at 2:00 PM, Janne Grunau wrote: > Only lightly tested. > --- > libavcodec/h264.c | 276 > ++--- > 1 files changed, 156 insertions(+), 120 deletions(-) > > diff --git a/libavcodec/h264.c b/libavcodec/h264.c > index 99cf5dc.

Re: [libav-devel] Resolution changes during frame based multithreading

2012-09-06 Thread Ronald S. Bultje
Hi, On Thu, Sep 6, 2012 at 2:00 PM, Janne Grunau wrote: > Hi, > > following patchset adds support to resolution changes during > frame-based multithreading. > > The RV34 change is well tested with multiple samples and zzuf > (although not with the last version of the patches). It fixes > http://b

Re: [libav-devel] [PATCH] x86: get_cpu_flags: add necessary ifdefs around function body

2012-09-06 Thread Ronald S. Bultje
Hi, On Wed, Sep 5, 2012 at 9:12 PM, Diego Biurrun wrote: > ff_get_cpu_flags_x86() requires cpuid(), which is conditionally defined > elsewhere in the file. Surrounding the function body with ifdefs allows > building even when cpuid is not defined. An empty cpuflags mask is > returned in this ca

Re: [libav-devel] [PATCH 2/4] dsputil: workaround __VA_ARGS__ missing tokenization for MSVC

2012-09-05 Thread Ronald S. Bultje
Hi, On Tue, Sep 4, 2012 at 1:47 PM, Martin Storsjö wrote: > From: Luca Barbato > > A second expansion forces the preprocessor to tokenize properly. > --- > libavcodec/dsputil.h | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) this was already OK'ed previously (by Mans, in f

Re: [libav-devel] [PATCH 2/6] avopt: Store defaults for AV_OPT_TYPE_FLAGS in the i64 union member

2012-09-05 Thread Ronald S. Bultje
Hi, On Mon, Sep 3, 2012 at 11:23 AM, Martin Storsjö wrote: > --- > libavcodec/g722dec.c|2 +- > libavcodec/libvpxenc.c |2 +- > libavcodec/mpegvideo.h |2 +- > libavcodec/options_table.h | 14 +++--- > libavdevice/libcdio.c |2 +- > libavfilter/

Re: [libav-devel] [PATCH] x86: Fix linking with some or all of yasm, mmx, optimizations disabled

2012-08-29 Thread Ronald S. Bultje
Hi, On Wed, Aug 29, 2012 at 10:50 AM, Diego Biurrun wrote: > +#if HAVE_MMX > +if (mm_flags & AV_CPU_FLAG_MMX && HAVE_MMX) > +s->dct_quantize = dct_quantize_MMX; > +#endif > +#if HAVE_MMXEXT > +if (mm_flags & AV_CPU_FLAG_MMXEXT && HAVE_MMXEXT) > +s->dct_quan

[libav-devel] [PATCH] yuv2rgb: handle line widths that are not a multiple of 4.

2012-08-27 Thread Ronald S. Bultje
From: "Ronald S. Bultje" This introduces support for width%4==2 in addition to width%4==0. For odd widths, some more checks are needed, since the current code always handles two luma items in a row, thus there is a possibility of an overread by one. --- libswscale/yuv2

Re: [libav-devel] [PATCH] utvideoenc: use ff_huff_gen_len_table()

2012-08-27 Thread Ronald S. Bultje
Hi, On Mon, Aug 27, 2012 at 8:04 AM, Luca Barbato wrote: > On 8/27/12 4:39 PM, Måns Rullgård wrote: >> >> Luca Barbato writes: >> >>> From: Michael Niedermayer >>> >>> 19% faster and better compression. >> >> >> Has this been verified? On what hardware? How much better? > > > Tested a bit on

[libav-devel] [PATCH] lavu: add snprintf(), vsnprint() and strtod() replacements for MS runtime.

2012-08-25 Thread Ronald S. Bultje
From: "Ronald S. Bultje" --- compat/snprintf.c | 62 + compat/snprintf.h | 46 +++ compat/strtod.c| 91 ++ compat/strtod.h| 37 ++

Re: [libav-devel] [PATCH 06/15] lavr: x86: optimized 6-channel fltp to s16 conversion

2012-08-23 Thread Ronald S. Bultje
Hi, On Thu, Aug 23, 2012 at 3:02 PM, Justin Ruggles wrote: > For future use... the best I can come up with is 6x vpperm. > > m3 = 0, 1, x, 3, 4, x, 6, 7 > m4 = x, 9, 10, x, 12, 13, x, 15 > m5 = 16, 17, x, 19, 20, x, 22, 23 > > Then 3x vpperm to fill-in the gaps. Well, the reason I

Re: [libav-devel] [PATCH 06/15] lavr: x86: optimized 6-channel fltp to s16 conversion

2012-08-23 Thread Ronald S. Bultje
Hi, On Thu, Aug 23, 2012 at 12:37 PM, Justin Ruggles wrote: > On 08/21/2012 03:53 PM, Ronald S. Bultje wrote: >> On Mon, Aug 6, 2012 at 9:22 AM, Justin Ruggles >> wrote: >>> +%if cpuflag(sse2) >>> +mulps m0, m6, [srcq ] >>&

Re: [libav-devel] [PATCH 1/2] H264: Remove 3dnow qpel code.

2012-08-22 Thread Ronald S. Bultje
Hi, On Tue, Aug 21, 2012 at 8:08 PM, wrote: > From: Daniel Kang > > The only CPUs that have 3dnow and don't have mmxext are 12 years old. > > Moreover, AMD has deprecated 3dnow. > --- > libavcodec/x86/dsputil_mmx.c | 142 > + > libavcodec/x86/dsputil_

Re: [libav-devel] [PATCH 14/15] lavr: x86: optimized 2-channel flt to fltp conversion

2012-08-21 Thread Ronald S. Bultje
Hi, On Wed, Aug 1, 2012 at 7:43 AM, Justin Ruggles wrote: > --- > libavresample/x86/audio_convert.asm| 33 > > libavresample/x86/audio_convert_init.c |9 > 2 files changed, 42 insertions(+), 0 deletions(-) LGTM. Ronald __

Re: [libav-devel] [PATCH 13/15] lavr: x86: optimized 6-channel flt to s16p conversion

2012-08-21 Thread Ronald S. Bultje
Hi, On Sun, Aug 5, 2012 at 9:52 PM, Justin Ruggles wrote: > --- > libavresample/x86/audio_convert.asm| 74 > > libavresample/x86/audio_convert_init.c | 13 ++ > 2 files changed, 87 insertions(+), 0 deletions(-) LGTM. Ronald

Re: [libav-devel] [PATCH 12/15] lavr: x86: optimized 2-channel flt to s16p conversion

2012-08-21 Thread Ronald S. Bultje
Hi, On Sun, Aug 5, 2012 at 9:52 PM, Justin Ruggles wrote: > --- > libavresample/x86/audio_convert.asm| 46 > > libavresample/x86/audio_convert_init.c |9 ++ > 2 files changed, 55 insertions(+), 0 deletions(-) LGTM. Ronald

Re: [libav-devel] [PATCH 11/15] lavr: x86: optimized 6-channel s16 to fltp conversion

2012-08-21 Thread Ronald S. Bultje
Hi, On Sun, Aug 5, 2012 at 9:52 PM, Justin Ruggles wrote: > --- > libavresample/x86/audio_convert.asm| 83 > > libavresample/x86/audio_convert_init.c | 17 +++ > libavutil/x86/x86util.asm | 12 + > 3 files changed, 112 insertions(+

Re: [libav-devel] [PATCH 10/15] lavr: x86: optimized 2-channel s16 to fltp conversion

2012-08-21 Thread Ronald S. Bultje
Hi, On Mon, Aug 6, 2012 at 9:16 AM, Justin Ruggles wrote: > --- > libavresample/x86/audio_convert.asm| 39 > > libavresample/x86/audio_convert_init.c |9 +++ > 2 files changed, 48 insertions(+), 0 deletions(-) LGTM. Ronald ___

Re: [libav-devel] [PATCH 09/15] lavr: x86: optimized 6-channel s16 to s16p conversion

2012-08-21 Thread Ronald S. Bultje
Hi, On Sun, Aug 5, 2012 at 9:52 PM, Justin Ruggles wrote: > --- > libavresample/x86/audio_convert.asm| 61 > > libavresample/x86/audio_convert_init.c | 13 +++ > 2 files changed, 74 insertions(+), 0 deletions(-) I think this looks good - just remind

Re: [libav-devel] [PATCH 08/15] lavr: x86: optimized 2-channel s16 to s16p conversion

2012-08-21 Thread Ronald S. Bultje
Hi, On Sun, Aug 5, 2012 at 9:52 PM, Justin Ruggles wrote: > --- > libavresample/x86/audio_convert.asm| 50 > > libavresample/x86/audio_convert_init.c | 15 + > libavresample/x86/util.asm |6 > 3 files changed, 71 insertions(+

Re: [libav-devel] [PATCH 07/15] lavr: x86: optimized 2-channel fltp to flt conversion

2012-08-21 Thread Ronald S. Bultje
Hi, On Sun, Aug 5, 2012 at 9:52 PM, Justin Ruggles wrote: > --- > libavresample/x86/audio_convert.asm| 37 > > libavresample/x86/audio_convert_init.c |7 ++ > 2 files changed, 44 insertions(+), 0 deletions(-) LGTM. Ronald

Re: [libav-devel] [PATCH 06/15] lavr: x86: optimized 6-channel fltp to s16 conversion

2012-08-21 Thread Ronald S. Bultje
Hi, On Mon, Aug 6, 2012 at 9:22 AM, Justin Ruggles wrote: > +%if cpuflag(sse2) > +mulps m0, m6, [srcq ] > +mulps m1, m6, [srcq+src1q] > +mulps m2, m6, [srcq+src2q] > +mulps m3, m6, [srcq+src3q] > +mulps m4, m6, [srcq+src4q] > +m

Re: [libav-devel] [PATCH 05/15] lavr: x86: optimized 2-channel fltp to s16 conversion

2012-08-21 Thread Ronald S. Bultje
Hi, On Sun, Aug 5, 2012 at 9:52 PM, Justin Ruggles wrote: > --- > libavresample/x86/audio_convert.asm| 43 > > libavresample/x86/audio_convert_init.c |9 ++ > 2 files changed, 52 insertions(+), 0 deletions(-) LGTM. (I wonder if unroll x2 makes th

Re: [libav-devel] [PATCH 04/15] lavr: x86: optimized 6-channel s16p to flt conversion

2012-08-21 Thread Ronald S. Bultje
Hi, On Sun, Aug 5, 2012 at 9:52 PM, Justin Ruggles wrote: > --- > libavresample/x86/audio_convert.asm| 106 > > libavresample/x86/audio_convert_init.c | 15 + > 2 files changed, 121 insertions(+), 0 deletions(-) LGTM. Ronald

Re: [libav-devel] [PATCH 03/15] lavr: x86: optimized 2-channel s16p to flt conversion

2012-08-21 Thread Ronald S. Bultje
Hi, On Sun, Aug 5, 2012 at 9:52 PM, Justin Ruggles wrote: > --- > libavresample/x86/audio_convert.asm| 49 > > libavresample/x86/audio_convert_init.c |9 ++ > 2 files changed, 58 insertions(+), 0 deletions(-) LGTM. Ronald

Re: [libav-devel] [PATCH 02/15] lavr: x86: optimized 6-channel s16p to s16 conversion

2012-08-21 Thread Ronald S. Bultje
Hi, On Sun, Aug 5, 2012 at 9:52 PM, Justin Ruggles wrote: > --- > libavresample/x86/audio_convert.asm| 123 > > libavresample/x86/audio_convert_init.c | 14 > 2 files changed, 137 insertions(+), 0 deletions(-) > > diff --git a/libavresample/x86/audio

Re: [libav-devel] [PATCH 01/15] lavr: x86: optimized 2-channel s16p to s16 conversion

2012-08-21 Thread Ronald S. Bultje
Hi, On Sun, Aug 5, 2012 at 9:52 PM, Justin Ruggles wrote: > --- > libavresample/x86/audio_convert.asm| 37 > > libavresample/x86/audio_convert_init.c | 13 +++ > 2 files changed, 50 insertions(+), 0 deletions(-) LGTM. Ronald ___

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Ronald S. Bultje
Hi, On Sun, Aug 19, 2012 at 3:08 PM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> Hi, >> >> On Sat, Aug 18, 2012 at 11:09 PM, Anton Khirnov wrote: >>> >>> On Sat, 18 Aug 2012 22:32:15 -0700, "Ronald S. Bultje" >>&g

<    1   2   3   4   5   6   7   8   9   10   >