[libav-devel] [PATCH] snow: remove a VLA.

2012-06-14 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/snowenc.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c index 7b010e1..3c06f8e 100644 --- a/libavcodec/snowenc.c +++ b/libavcodec/snowenc.c @@ -1074,8 +1074,9 @@ static

[libav-devel] [PATCH] dsputilenc_mmx: split assignment of ff_sse16_sse2 to SSE2 section.

2012-06-14 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/x86/dsputilenc_mmx.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/x86/dsputilenc_mmx.c b/libavcodec/x86/dsputilenc_mmx.c index 2a403ba..d8a60e1 100644 --- a/libavcodec/x86/dsputilenc_mmx.c

Re: [libav-devel] [PATCH] dxva2: add missing dxva.h include.

2012-06-14 Thread Ronald S. Bultje
Hi, On Thu, Jun 14, 2012 at 4:02 PM, Jean-Baptiste Kempf j...@videolan.org wrote: On Thu, Jun 14, 2012 at 03:59:06PM -0700, Ronald S. Bultje wrote : +#include dxva.h This should break every mingw compilation. Why? Is the header un-mingw'y? Ronald

Re: [libav-devel] [PATCH] Support for MSVC.

2012-06-13 Thread Ronald S. Bultje
Hi, On Wed, Jun 13, 2012 at 8:40 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 13/06/2012 7:59 PM, Ronald S. Bultje wrote: - the include of mathematics.h, avconfig.h and avstring.h everywhere is (I think) legit, to account for snprintf(), M_PI or inline. We don't need to do

Re: [libav-devel] [PATCH] Support for MSVC.

2012-06-13 Thread Ronald S. Bultje
Hi, On Wed, Jun 13, 2012 at 8:49 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 13/06/2012 11:40 PM, Derek Buitenhuis wrote: On 13/06/2012 7:59 PM, Ronald S. Bultje wrote: - the include of mathematics.h, avconfig.h and avstring.h everywhere is (I think) legit, to account

Re: [libav-devel] [PATCH] golomb: check remaining bits during unary decoding in get_ur_golomb_jpegls()

2012-06-11 Thread Ronald S. Bultje
Hi, On Jun 11, 2012 10:33 AM, Justin Ruggles justin.rugg...@gmail.com wrote: Fixes infinite loop in FLAC decoding in case of a truncated bitstream due to the safe bitstream reader returning 0's at the end. Fixes Bug 310. --- libavcodec/golomb.h |2 +- 1 files changed, 1

Re: [libav-devel] [PATCH] avconv: support only native pthreads.

2012-06-11 Thread Ronald S. Bultje
Hi, On Jun 11, 2012 9:36 AM, Anton Khirnov an...@khirnov.net wrote: Our w32pthreads wrapper has various issues and is only supposed to be used in libavcodec. Can you elaborate on the issue? It is supposed to work. Ronald ___ libav-devel mailing

Re: [libav-devel] [PATCH] iac: generate codec tables as they are supposed to be

2012-06-08 Thread Ronald S. Bultje
Hi, On Fri, Jun 8, 2012 at 1:42 PM, Kostya Shishkov kostya.shish...@gmail.com wrote: Unlike its predecessor, Indeo Audio codec generates tables depending on sampling rate. Previously decoder used pre-generated tables for 22050 Hz which obviously doesn't work with other frequencies. Many

Re: [libav-devel] [PATCH] iac: generate codec tables as they are supposed to be

2012-06-08 Thread Ronald S. Bultje
Hi, On Fri, Jun 8, 2012 at 2:55 PM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Fri, Jun 08, 2012 at 02:53:08PM -0400, Ronald S. Bultje wrote: On Fri, Jun 8, 2012 at 1:42 PM, Kostya Shishkov kostya.shish...@gmail.com wrote: Unlike its predecessor, Indeo Audio codec generates tables

Re: [libav-devel] [PATCH 5/6] lavr: Add x86-optimized function for flt to s16 conversion

2012-06-06 Thread Ronald S. Bultje
Hi, On Wed, Jun 6, 2012 at 8:22 AM, Justin Ruggles justin.rugg...@gmail.com wrote: --- Separated loads from muls. It's slightly faster for SSE2. If making this an AVX function is ever faster on some system, we can change it to 3-arg mulps.  libavresample/x86/audio_convert.asm    |   33

Re: [libav-devel] [PATCH] mpegts: Remove disabled extension matching probe.

2012-06-05 Thread Ronald S. Bultje
Hi, On Tue, Jun 5, 2012 at 11:16 AM, Alex Converse alex.conve...@gmail.com wrote: ---  libavformat/mpegts.c |    8  1 files changed, 0 insertions(+), 8 deletions(-) LGTM. Ronald ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 4/6] lavr: Add x86-optimized functions for s32 to flt conversion

2012-06-05 Thread Ronald S. Bultje
Hi, On Tue, Jun 5, 2012 at 10:35 AM, Justin Ruggles justin.rugg...@gmail.com wrote: On 06/01/2012 05:26 PM, Ronald S. Bultje wrote: On Tue, May 1, 2012 at 1:49 PM, Justin Ruggles justin.rugg...@gmail.com wrote: +.loop: +    cvtdq2ps  m1, [srcq+lenq       ] +    cvtdq2ps  m2, [srcq+lenq

Re: [libav-devel] [PATCH] Rename libavcodec/libavformat options table files.

2012-06-03 Thread Ronald S. Bultje
Hi, On Sun, Jun 3, 2012 at 3:04 PM, Anton Khirnov an...@khirnov.net wrote: On Sun, 03 Jun 2012 23:56:29 +0200, Diego Biurrun di...@biurrun.de wrote: On Sun, Jun 03, 2012 at 11:43:23PM +0200, Anton Khirnov wrote: On Sun, 03 Jun 2012 17:53:22 +0200, Diego Biurrun di...@biurrun.de wrote:

Re: [libav-devel] [PATCH] projects: add reference to jlibav

2012-06-02 Thread Ronald S. Bultje
Hi, On Sat, Jun 2, 2012 at 9:46 AM, Luca Barbato lu_z...@gentoo.org wrote: ---  src/projects |    1 +  1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/projects b/src/projects index fa3e2ed..342a9c8 100644 --- a/src/projects +++ b/src/projects @@ -73,6 +73,7 @@ an email

Re: [libav-devel] [PATCH 2/6] lavr: Add x86-optimized functions for s16 to flt conversion

2012-06-01 Thread Ronald S. Bultje
Hi, On Fri, Jun 1, 2012 at 12:08 PM, Justin Ruggles justin.rugg...@gmail.com wrote: ---  libavresample/x86/audio_convert.asm    |   36  libavresample/x86/audio_convert_init.c |    9  2 files changed, 45 insertions(+), 0 deletions(-) OK. Ronald

Re: [libav-devel] [PATCH 1/6] lavr: Add x86-optimized function for s16 to s32 conversion

2012-06-01 Thread Ronald S. Bultje
Hi, On Tue, May 1, 2012 at 1:49 PM, Justin Ruggles justin.rugg...@gmail.com wrote: --- Athlon64   C - 6217 SSE2 - 1742 SandyBridge   C - 4728 SSE2 -  892  libavresample/x86/audio_convert.asm    |   23 +++  libavresample/x86/audio_convert_init.c |    6 ++  2

Re: [libav-devel] [PATCH 3/6] lavr: Add x86-optimized functions for s32 to s16 conversion

2012-06-01 Thread Ronald S. Bultje
Hi, On Tue, May 1, 2012 at 1:49 PM, Justin Ruggles justin.rugg...@gmail.com wrote: --- Athlon64   C - 3127  MMX -  861 SSE2 -  924 SandyBridge   C - 2950  MMX -  837 SSE2 -  366  libavresample/x86/audio_convert.asm    |   38  

Re: [libav-devel] [PATCH 4/6] lavr: Add x86-optimized functions for s32 to flt conversion

2012-06-01 Thread Ronald S. Bultje
Hi, On Tue, May 1, 2012 at 1:49 PM, Justin Ruggles justin.rugg...@gmail.com wrote: +.loop: +    cvtdq2ps  m1, [srcq+lenq       ] +    cvtdq2ps  m2, [srcq+lenq+mmsize] +    mulps     m1, m1, m0 +    mulps     m2, m2, m0 Move to two-arg instead of 3-arg, otherwise OK. Ronald

Re: [libav-devel] [PATCH 3/3] Add a float DSP framework to libavutil

2012-06-01 Thread Ronald S. Bultje
Hi, On Fri, Jun 1, 2012 at 1:58 PM, Justin Ruggles justin.rugg...@gmail.com wrote: On 05/26/2012 12:31 PM, Justin Ruggles wrote: On 05/21/2012 06:52 PM, Justin Ruggles wrote: Move vector_fmul() from DSPContext to AVFloatDSPContext. ---  libavcodec/aac.h                    |    2 +  

Re: [libav-devel] [PATCH] bmv: add stricter checks for invalid decoded length

2012-06-01 Thread Ronald S. Bultje
Hi, On Fri, Jun 1, 2012 at 11:55 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: This makes decoder handle random data passed as BMV frame data. ---  libavcodec/bmv.c |   10 +++---  1 files changed, 7 insertions(+), 3 deletions(-) LGTM. Ronald

Re: [libav-devel] [PATCH] Announce 0.5.8 very very late

2012-05-31 Thread Ronald S. Bultje
Hi On Thu, May 31, 2012 at 9:12 AM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: ---  src/download |   24  1 file changed, 12 insertions(+), 12 deletions(-) OK. Ronald ___ libav-devel mailing list

Re: [libav-devel] [PATCH 2/6] lavr: Add x86-optimized functions for s16 to flt conversion

2012-05-31 Thread Ronald S. Bultje
Hi, On Thu, May 31, 2012 at 6:58 PM, Justin Ruggles justin.rugg...@gmail.com wrote: ---  libavresample/x86/audio_convert.asm    |   36  libavresample/x86/audio_convert_init.c |    9  2 files changed, 45 insertions(+), 0 deletions(-) diff --git

Re: [libav-devel] [PATCH 1/1] avfilter: include required header file avfilter.h in video.h

2012-05-29 Thread Ronald S. Bultje
Hi, On Tue, May 29, 2012 at 8:11 AM, Anton Khirnov an...@khirnov.net wrote: On Tue, 29 May 2012 11:02:37 -0400, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 29/05/2012 9:37 AM, Janne Grunau wrote: ---  libavfilter/video.h |    2 ++  1 files changed, 2 insertions(+), 0

Re: [libav-devel] [PATCH] avprobe: move formatter functions in the context

2012-05-29 Thread Ronald S. Bultje
Hi, On Sun, May 27, 2012 at 7:36 PM, Luca Barbato lu_z...@gentoo.org wrote: Avoid possible clashes. ---  avprobe.c |  116 -  1 files changed, 61 insertions(+), 55 deletions(-) OK. Ronald

Re: [libav-devel] [PATCH v2] fate: convert codec-regression.sh to makefile rules

2012-05-29 Thread Ronald S. Bultje
Hi, On Tue, May 29, 2012 at 4:43 PM, Luca Barbato lu_z...@gentoo.org wrote: On 29/05/12 16:20, Sean McGovern wrote: This caused me to lose 200+ FATE tests on my Solaris boxes (verified via git bisect). How? dhcp-172-22-79-197:x86-64-gpl-2 rbultje$ make fate-acodec-pcm-s8 V=1TEST

Re: [libav-devel] [PATCH 1/2] h264: allow cropping to AVCodecContext.width/height

2012-05-29 Thread Ronald S. Bultje
Hi, On Tue, May 29, 2012 at 8:09 PM, Mans Rullgard m...@mansr.com wrote: Override the frame size from the SPS with AVCodecContext values of the latter specify a smaller size.  This is required for correct cropping of MOV files from Canon cameras. Signed-off-by: Mans Rullgard m...@mansr.com

Re: [libav-devel] [PATCH 2/3] lavr: add x86-optimized functions for mixing 2 to 1 s16p with float coeffs

2012-05-28 Thread Ronald S. Bultje
Hi, On Thu, May 24, 2012 at 2:09 PM, Justin Ruggles justin.rugg...@gmail.com wrote: On 05/15/2012 03:21 PM, Justin Ruggles wrote: ---  libavresample/x86/audio_mix.asm    |   44  libavresample/x86/audio_mix_init.c |   13 ++  

Re: [libav-devel] [PATCH 3/3] lavr: add x86-optimized function for mixing 2 to 1 s16p with q8 coeffs

2012-05-28 Thread Ronald S. Bultje
Hi, On Thu, May 24, 2012 at 2:09 PM, Justin Ruggles justin.rugg...@gmail.com wrote: On 05/15/2012 03:21 PM, Justin Ruggles wrote: ---  libavresample/x86/audio_mix.asm    |   41  libavresample/x86/audio_mix_init.c |    5  2 files changed, 46

Re: [libav-devel] [PATCH 1/3] x86: use new schema for ASM macros

2012-05-27 Thread Ronald S. Bultje
Hi, On Fri, May 11, 2012 at 1:31 PM, Vitor Sessak vitor1...@gmail.com wrote: -    FFT_DISPATCH %1, r1 +    FFT_DISPATCH _ %+ cpuname, r1 I think you're supposed to use SUFFIX here, not cpuname? But in general, patch looks OK. Ronald ___ libav-devel

Re: [libav-devel] [PATCH 1/3] x86: use new schema for ASM macros

2012-05-27 Thread Ronald S. Bultje
Hi, On Sun, May 27, 2012 at 11:43 AM, Vitor Sessak vitor1...@gmail.com wrote: On 05/27/2012 05:20 PM, Ronald S. Bultje wrote: On Fri, May 11, 2012 at 1:31 PM, Vitor Sessakvitor1...@gmail.com  wrote: -    FFT_DISPATCH %1, r1 +    FFT_DISPATCH _ %+ cpuname, r1 I think you're supposed to use

Re: [libav-devel] [PATCH] vp8: move block coeff arithcoder on stack.

2012-05-24 Thread Ronald S. Bultje
Hi, On Fri, Apr 22, 2011 at 5:49 PM, Ronald S. Bultje rsbul...@gmail.com wrote: On Fri, Apr 22, 2011 at 7:17 PM, Alexander Strange astra...@ithinksw.com wrote: On Fri, Apr 22, 2011 at 6:38 PM, Ronald S. Bultje rsbul...@gmail.com wrote: This prevents gcc from assuming that contents of it may

Re: [libav-devel] [PATCH] fate: Hardcode the native NUT muxer/demuxer in the NUT regression test.

2012-05-20 Thread Ronald S. Bultje
Hi, On Sun, May 20, 2012 at 2:43 PM, Måns Rullgård m...@mansr.com wrote: Diego Biurrun di...@biurrun.de writes: libnut is known to be buggy and throw off the test results. ---  tests/lavf-regression.sh |    3 ++-  1 files changed, 2 insertions(+), 1 deletions(-) diff --git

Re: [libav-devel] [PATCH] mp3: fix start band index for block type 2 in 8kHz audio

2012-05-19 Thread Ronald S. Bultje
Hi, On May 19, 2012 7:17 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Wed, May 16, 2012 at 07:26:16PM +0200, Kostya Shishkov wrote: In hybrid frames long window part ends at 36 samples for most of the cases but at 72 for 8kHz case. For some reason decoder assumed it's 48 or even

Re: [libav-devel] [PATCH] x86: h264: prevent yasm from issuing a i686 nopl instruction on i586 machines

2012-05-16 Thread Ronald S. Bultje
Hi, On Wed, May 16, 2012 at 5:34 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, May 14, 2012 at 12:41:45PM +0200, Diego Biurrun wrote: From: Michael Kostylev michael.kosty...@gmail.com ---  libavcodec/x86/h264_intrapred.asm |    4  1 files changed, 4 insertions(+), 0 deletions(-)

Re: [libav-devel] [PATCH 2/5] x86: rv40: Mark rv40_weight functions as MMX2; they use MMX2 instructions.

2012-05-15 Thread Ronald S. Bultje
Hi, On Tue, May 15, 2012 at 6:20 AM, Christophe Gisquet christophe.gisq...@gmail.com wrote: 2012/5/11 Ronald S. Bultje rsbul...@gmail.com: I agree a cpuflags-based SPLATW implementation would be wonderful. Do you have time to go through all current users of SPLATW to ensure we don't break

Re: [libav-devel] [PATCH 1/4] indeo3: ensure that decoded cell data is in 7-bit range as presumed by decoder

2012-05-15 Thread Ronald S. Bultje
Hi, On Mon, May 14, 2012 at 10:49 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: ---  libavcodec/indeo3.c |   30 --  1 files changed, 16 insertions(+), 14 deletions(-) OK. Ronald ___ libav-devel mailing list

Re: [libav-devel] [PATCH 2/4] indeo3: initialise pixel planes on allocation

2012-05-15 Thread Ronald S. Bultje
Hi, On Mon, May 14, 2012 at 10:49 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: This prevents decoder from reading garbage from it in case of errors later. ---  libavcodec/indeo3.c |    2 ++  1 files changed, 2 insertions(+), 0 deletions(-) OK. Ronald

Re: [libav-devel] [PATCH 05/12] rv40dsp x86: start implementing loop filtering

2012-05-15 Thread Ronald S. Bultje
Hi, On Fri, May 11, 2012 at 9:13 AM, Christophe Gisquet christophe.gisq...@gmail.com wrote: 2012/5/11 Ronald S. Bultje rsbul...@gmail.com: Will look sometime this weekend. OK, I thought indeed it was too much work for a quick reply, but I preferred pinging instead of risking to let it slip

Re: [libav-devel] [PATCH 5/5] x86: h264: Ensure that the cmov instruction is not issued on i586 processors.

2012-05-15 Thread Ronald S. Bultje
Hi, On Tue, May 15, 2012 at 10:31 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, May 14, 2012 at 12:11:09PM +0100, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: On Fri, May 11, 2012 at 12:01:23PM -0700, Ronald S. Bultje wrote: On Fri, May 11, 2012 at 10:23 AM, Jason

Re: [libav-devel] [PATCH 5/5] x86: h264: Ensure that the cmov instruction is not issued on i586 processors.

2012-05-15 Thread Ronald S. Bultje
Hi, On Tue, May 15, 2012 at 4:21 PM, Jason Garrett-Glaser ja...@x264.com wrote: On Tue, May 15, 2012 at 4:01 PM, Ronald S. Bultje rsbul...@gmail.com wrote: On Tue, May 15, 2012 at 10:31 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, May 14, 2012 at 12:11:09PM +0100, Måns Rullgård wrote

Re: [libav-devel] [PATCH 3/3] x86: add XOP code for FFT

2012-05-14 Thread Ronald S. Bultje
Hi, On Sun, May 13, 2012 at 10:56 PM, Luca Barbato lu_z...@gentoo.org wrote: On 13/05/12 22:19, Vitor Sessak wrote: On 05/13/2012 11:40 PM, Diego Elio Pettenò wrote: Il 12/05/2012 01:15, Vitor Sessak ha scritto: Here is a version with 128-bit regs (again, completely untested). The patch

Re: [libav-devel] [PATCH 2/5] x86: rv40: Mark rv40_weight functions as MMX2; they use MMX2 instructions.

2012-05-14 Thread Ronald S. Bultje
Hi, On Mon, May 14, 2012 at 3:45 AM, Diego Biurrun di...@biurrun.de wrote: On Fri, May 11, 2012 at 07:16:24PM +0200, Christophe Gisquet wrote: 2012/5/11 Diego Biurrun di...@biurrun.de: 0x089c6039 ff_rv40_weight_func_rnd_16_mmx+57: pshufw $0x0,%mm2,%mm2 This is one of the instructions

Re: [libav-devel] [PATCH] mtv: do not byteswap raw video in demuxer

2012-05-14 Thread Ronald S. Bultje
Hi, On Mon, May 14, 2012 at 8:48 AM, Mans Rullgard m...@mansr.com wrote: Signed-off-by: Mans Rullgard m...@mansr.com ---  libavformat/mtv.c  |   16 +--  tests/ref/fate/mtv |   80 ++--  2 files changed, 41 insertions(+), 55

Re: [libav-devel] [PATCH] ac3dsp: use cpuflags and a new macro to simplify ac3_max_msb_abs_int16

2012-05-14 Thread Ronald S. Bultje
Hi, On Mon, May 14, 2012 at 1:15 PM, Justin Ruggles justin.rugg...@gmail.com wrote: This also fixes the invalid use of the pshufw operation in the MMX-only function. ---  libavcodec/x86/ac3dsp.asm   |   59 +++---  libavcodec/x86/ac3dsp_mmx.c |   10 +++---

Re: [libav-devel] [PATCH] sws: fix planar RGB input conversions for 9/10/16 bpp.

2012-05-12 Thread Ronald S. Bultje
Hi, On Sat, May 12, 2012 at 2:54 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 12/05/2012 10:21 AM, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com Fixes bug 282. Do you plan on working on high bit depth gbrp-rgb too? (See commit

Re: [libav-devel] [PATCH 3/5] x86: vc1: drop MMX loop filter, which uses MMX2 instructions.

2012-05-11 Thread Ronald S. Bultje
Hi, On Fri, May 11, 2012 at 7:58 AM, Diego Biurrun di...@biurrun.de wrote: From: Michael Kostylev michael.kosty...@gmail.com ---  libavcodec/x86/vc1dsp_mmx.c    |    2 --  libavcodec/x86/vc1dsp_yasm.asm |   11 ---  2 files changed, 0 insertions(+), 13 deletions(-) LGTM. I wonder

Re: [libav-devel] [PATCH 2/5] x86: rv40: Mark rv40_weight functions as MMX2; they use MMX2 instructions.

2012-05-11 Thread Ronald S. Bultje
Hi, On Fri, May 11, 2012 at 8:31 AM, Christophe Gisquet christophe.gisq...@gmail.com wrote: Hi, 2012/5/11 Diego Biurrun di...@biurrun.de: [...] Not limited to that patch: could the reporter state instead on what instruction the sigill occurred? It may be possible to do something else.

Re: [libav-devel] [PATCH 2/5] x86: rv40: Mark rv40_weight functions as MMX2; they use MMX2 instructions.

2012-05-11 Thread Ronald S. Bultje
Hi, On Fri, May 11, 2012 at 8:35 AM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Fri, May 11, 2012 at 8:31 AM, Christophe Gisquet christophe.gisq...@gmail.com wrote: Hi, 2012/5/11 Diego Biurrun di...@biurrun.de: [...] Not limited to that patch: could the reporter state instead

Re: [libav-devel] [PATCH 4/5] x86: h264: prevent gcc from issuing a i686 nopl instruction on i586 machines

2012-05-11 Thread Ronald S. Bultje
Hi, On Fri, May 11, 2012 at 7:58 AM, Diego Biurrun di...@biurrun.de wrote: From: Michael Kostylev michael.kosty...@gmail.com ---  libavcodec/x86/h264_intrapred.asm |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/x86/h264_intrapred.asm

Re: [libav-devel] [PATCH 5/5] x86: h264: Ensure that the cmov instruction is not issued on i586 processors.

2012-05-11 Thread Ronald S. Bultje
Hi, On Fri, May 11, 2012 at 7:58 AM, Diego Biurrun di...@biurrun.de wrote: +%macro CMOV 3 +%if HAVE_CMOV +  cmov%+1 %2, %3 +%else +  j%-1 %%label +  mov %2, %3 +  %%label: +%endif +%endmacro Who sets HAVE_CMOV? Seems like a compile-time constant, i.e. this won't work unless we detect

Re: [libav-devel] [PATCH 05/12] rv40dsp x86: start implementing loop filtering

2012-05-11 Thread Ronald S. Bultje
Hi, On Fri, May 11, 2012 at 8:42 AM, Christophe Gisquet christophe.gisq...@gmail.com wrote: 2012/4/18 Christophe Gisquet christophe.gisq...@gmail.com: Here's an updated patch following these recommandations. Note: it may be superseded by the patches next in the series, cf. rv40dsp:

Re: [libav-devel] [PATCH 2/5] x86: rv40: Mark rv40_weight functions as MMX2; they use MMX2 instructions.

2012-05-11 Thread Ronald S. Bultje
Hi, On Fri, May 11, 2012 at 9:12 AM, Christophe Gisquet christophe.gisq...@gmail.com wrote: Hi and thanks, 2012/5/11 Ronald S. Bultje rsbul...@gmail.com: The problem is the pshufw emitted by SPLATW (see libavutil/x86/x86util.asm). It should use punpcklwd+punpckldq on mmx. Then I guess

Re: [libav-devel] [PATCH 3/3] x86: add XOP code for FFT

2012-05-11 Thread Ronald S. Bultje
Hi, On Fri, May 11, 2012 at 1:44 PM, Jason Garrett-Glaser ja...@x264.com wrote: On Fri, May 11, 2012 at 1:35 PM, Vitor Sessak vitor1...@gmail.com wrote: On 05/11/2012 10:31 PM, Vitor Sessak wrote: ---  libavcodec/x86/fft.c       |    9 +++-  libavcodec/x86/fft.h       |    2 +  

Re: [libav-devel] [PATCH 12/12] rv40dsp: defer pixel access and computations untill they are needed

2012-05-10 Thread Ronald S. Bultje
Hi, On Thu, May 10, 2012 at 7:07 AM, Christophe Gisquet christophe.gisq...@gmail.com wrote: 2012/4/28 Ronald S. Bultje rsbul...@gmail.com: I don't really have an opinion, but I feel general consensus is to drop the patch and defer the optimizations by writing x86 simd? Is that correct? Fine

Re: [libav-devel] [PATCH 01/12] rv40dsp x86: MMX/MMX2/3DNow/SSE2/SSSE3 implementations of MC

2012-05-10 Thread Ronald S. Bultje
Hi, On Thu, May 10, 2012 at 7:06 AM, Christophe Gisquet christophe.gisq...@gmail.com wrote: Hi, 2012/4/28 Ronald S. Bultje rsbul...@gmail.com: Patch looks good, but crashes on Mac64 when running e.g. fate-real-rv40 (Mac32 works fine): +%macro LOAD  2 +%ifdef PIC +   add      %1d, picregd

Re: [libav-devel] [PATCH 2/2] tta: Use optimized int32 to int16 function.

2012-05-10 Thread Ronald S. Bultje
Hi, On Wed, May 9, 2012 at 11:00 PM, Aneesh Dogra lionane...@gmail.com wrote: @@ -433,8 +440,7 @@ static int tta_decode_frame(AVCodecContext *avctx, void *data,     // convert to output buffer     if (s-bps == 2) {         int16_t *samples = (int16_t *)s-frame.data[0]; -        for (p =

Re: [libav-devel] [PATCH 2/2] tta: Use optimized int32 to int16 function.

2012-05-10 Thread Ronald S. Bultje
Hi, On Thu, May 10, 2012 at 9:35 AM, Ronald S. Bultje rsbul...@gmail.com wrote: On Wed, May 9, 2012 at 11:00 PM, Aneesh Dogra lionane...@gmail.com wrote: @@ -433,8 +440,7 @@ static int tta_decode_frame(AVCodecContext *avctx, void *data,     // convert to output buffer     if (s-bps == 2

Re: [libav-devel] [PATCH 1/2] Dirac: Dirac Native Decoder Base. No asm optimizations

2012-05-08 Thread Ronald S. Bultje
Hi, On Tue, May 8, 2012 at 7:16 AM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 07/05/2012 4:15 PM, Jordi Ortiz wrote: +#if HAVE_FAST_CMOV +    low   -= range_times_prob 16; +    range -= range_times_prob; +    bit = 0; +    __asm__( +        cmpl   %5, %4 \n\t +        setae  

Re: [libav-devel] [PATCH 1/3] mp3/ac3 probe: search for PES headers to prevent probing MPEG-PS as MP3.

2012-05-08 Thread Ronald S. Bultje
Hi, On Mon, May 7, 2012 at 10:20 AM, Ronald S. Bultje rsbul...@gmail.com wrote: On Thu, May 3, 2012 at 6:16 PM, Ronald S. Bultje rsbul...@gmail.com wrote: On Thu, May 3, 2012 at 11:00 AM, Ronald S. Bultje rsbul...@gmail.com wrote: From: Ronald S. Bultje rsbul...@gmail.com ---  libavformat

Re: [libav-devel] [PATCH 1/3] mp3/ac3 probe: search for PES headers to prevent probing MPEG-PS as MP3.

2012-05-07 Thread Ronald S. Bultje
Hi, On Thu, May 3, 2012 at 6:16 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Thu, May 3, 2012 at 11:00 AM, Ronald S. Bultje rsbul...@gmail.com wrote: From: Ronald S. Bultje rsbul...@gmail.com ---  libavformat/ac3dec.c |   30 +-  libavformat/mp3dec.c

Re: [libav-devel] [PATCH] fate: Make oneline comparison ignore CR

2012-05-07 Thread Ronald S. Bultje
Hi, On Mon, May 7, 2012 at 5:04 PM, Måns Rullgård m...@mansr.com wrote: Alex Converse alex.conve...@gmail.com writes: On Mon, May 7, 2012 at 4:32 PM, Måns Rullgård m...@mansr.com wrote: Alex Converse alex.conve...@gmail.com writes: ---  tests/fate-run.sh |    2 +-  1 files changed, 1

Re: [libav-devel] [PATCH] pthread: warn on high thread counts

2012-05-06 Thread Ronald S. Bultje
Hi, On Sun, May 6, 2012 at 9:13 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Mar 19, 2012 at 09:45:08AM -0700, Ronald S. Bultje wrote: On Mon, Mar 19, 2012 at 7:10 AM, Sean McGovern gsean...@gmail.com wrote: On 3/19/12, Ronald S. Bultje rsbul...@gmail.com wrote: On Sun, Mar 18, 2012

Re: [libav-devel] [PATCH] qdm2: clip array indices returned by qdm2_get_vlc().

2012-05-04 Thread Ronald S. Bultje
Hi, On Wed, May 2, 2012 at 10:12 AM, Ronald S. Bultje rsbul...@gmail.com wrote: From: Ronald S. Bultje rsbul...@gmail.com Prevents subsequent overreads when these numbers are used as indices in arrays. Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org

Re: [libav-devel] [PATCH] mp3/ac3 probe: search for PES headers to prevent probing MPEG-PS as MP3.

2012-05-03 Thread Ronald S. Bultje
Hi, On Thu, May 3, 2012 at 1:18 AM, Vladimir Pantelic vlado...@gmail.com wrote: Ronald S. Bultje wrote: Hi guys, On Wed, May 2, 2012 at 4:06 PM, Ronald S. Bultjersbul...@gmail.com  wrote:  From: Ronald S. Bultjersbul...@gmail.com  ---   libavformat/ac3dec.c |   29

[libav-devel] [PATCH 1/3] mp3/ac3 probe: search for PES headers to prevent probing MPEG-PS as MP3.

2012-05-03 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavformat/ac3dec.c | 30 +- libavformat/mp3dec.c | 30 +- 2 files changed, 50 insertions(+), 10 deletions(-) diff --git a/libavformat/ac3dec.c b/libavformat/ac3dec.c index 60c3cf9

[libav-devel] [PATCH 2/3] avprobe: allow showing only one container/stream property.

2012-05-03 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This is useful for writing unit tests. --- avprobe.c | 67 +++-- 1 file changed, 47 insertions(+), 20 deletions(-) diff --git a/avprobe.c b/avprobe.c index fe2b6e2..55dbc2a 100644 --- a/avprobe.c

[libav-devel] [PATCH 3/3] Add probe fate tests to test for regressions in detecting media types.

2012-05-03 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- tests/Makefile |1 + tests/fate-run.sh|4 tests/fate/probe.mak | 11 +++ tests/ref/fate/probe-roundup1383 |1 + tests/ref/fate/probe-roundup1414 |1 + tests/ref/fate/probe

Re: [libav-devel] [PATCH 3/3] Add probe fate tests to test for regressions in detecting media types.

2012-05-03 Thread Ronald S. Bultje
Hi, On Thu, May 3, 2012 at 11:01 AM, Ronald S. Bultje rsbul...@gmail.com wrote: [..] FYI, files are small cuts of roundup samples that reproduced the described issues for me. I will upload to the fate server once the patch is OK'ed. Ronald ___ libav

Re: [libav-devel] [PATCH 3/3] Add probe fate tests to test for regressions in detecting media types.

2012-05-03 Thread Ronald S. Bultje
Hi, On Thu, May 3, 2012 at 11:14 AM, Alex Converse alex.conve...@gmail.com wrote: On Thu, May 3, 2012 at 11:01 AM, Ronald S. Bultje rsbul...@gmail.com wrote: From: Ronald S. Bultje rsbul...@gmail.com Thank you so much ---  tests/Makefile                   |    1 +  tests/fate-run.sh

[libav-devel] [PATCH] avprobe: allow showing only one container/stream property.

2012-05-03 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This is useful for writing unit tests. --- avprobe.c| 67 ++ doc/avprobe.texi |4 2 files changed, 51 insertions(+), 20 deletions(-) diff --git a/avprobe.c b/avprobe.c index fe2b6e2

[libav-devel] [PATCH] png: check bit depth for PAL8/Y400A pixel formats.

2012-05-02 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Wrong bit depth can lead to invalid rowsize values, which crashes the decoder further down. Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/pngdec.c |6 -- 1 file changed, 4 insertions(+), 2

[libav-devel] [PATCH] ea: check chunk_size for validity.

2012-05-02 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavformat/electronicarts.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c

Re: [libav-devel] [PATCH] motionpixels: Clip YUV values after applying a gradient.

2012-05-02 Thread Ronald S. Bultje
Hi, On Wed, May 2, 2012 at 12:11 PM, Alex Converse alex.conve...@gmail.com wrote: Prevents illegal reads on truncated and malformed input. ---  libavcodec/motionpixels.c |    6 ++  1 files changed, 6 insertions(+), 0 deletions(-) OK. Ronald

[libav-devel] [PATCH] mp3/ac3 probe: search for PES headers to prevent probing MPEG-PS as MP3.

2012-05-02 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavformat/ac3dec.c | 29 - libavformat/mp3dec.c | 29 - 2 files changed, 48 insertions(+), 10 deletions(-) diff --git a/libavformat/ac3dec.c b/libavformat/ac3dec.c index 60c3cf9..0fc2ff3

Re: [libav-devel] [PATCH] mp3/ac3 probe: search for PES headers to prevent probing MPEG-PS as MP3.

2012-05-02 Thread Ronald S. Bultje
Hi guys, On Wed, May 2, 2012 at 4:06 PM, Ronald S. Bultje rsbul...@gmail.com wrote: From: Ronald S. Bultje rsbul...@gmail.com ---  libavformat/ac3dec.c |   29 -  libavformat/mp3dec.c |   29 -  2 files changed, 48 insertions(+), 10

Re: [libav-devel] [PATCH 13/14] mpeg12: fixed parsing in some mpeg2 streams

2012-05-02 Thread Ronald S. Bultje
Hi, On Sun, Apr 29, 2012 at 10:33 AM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: From: Hendrik Leppkes h.lepp...@gmail.com Signed-off-by: Michael Niedermayer michae...@gmx.at ---  libavcodec/mpeg12.c |    1 +  1 file changed, 1 insertion(+) diff --git a/libavcodec/mpeg12.c

Re: [libav-devel] [PATCH 07/14] Add SMPTE240M transfer characteristics flag.

2012-05-02 Thread Ronald S. Bultje
Hi, On Sun, Apr 29, 2012 at 10:33 AM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: From: Hendrik Leppkes h.lepp...@gmail.com Signed-off-by: Michael Niedermayer michae...@gmx.at ---  libavcodec/avcodec.h |    1 +  1 file changed, 1 insertion(+) diff --git a/libavcodec/avcodec.h

Re: [libav-devel] [PATCH 05/14] mpegts: Some additional HDMV types and reg descriptors for mpegts

2012-05-02 Thread Ronald S. Bultje
Hi, On Sun, Apr 29, 2012 at 10:33 AM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: From: Joakim Plate elu...@ecce.se Signed-off-by: Michael Niedermayer michae...@gmx.at ---  libavformat/mpegts.c |    6 ++  1 file changed, 6 insertions(+) diff --git a/libavformat/mpegts.c

[libav-devel] [PATCH] vp8: update frame size changes on thread context switches.

2012-05-01 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This properly synchronizes frame size changes between threads if subsequent threads abort decoding before frame size is initialized, i.e. it prevents the thread after that from ping-ponging back to the original value. Found-by: Mateusz j00ru Jurczyk

Re: [libav-devel] [PATCH] twinvq: fix out of bounds array access

2012-05-01 Thread Ronald S. Bultje
Hi, On Tue, May 1, 2012 at 10:27 AM, Mans Rullgard m...@mansr.com wrote: ModeTab.fmode has only 3 elements, so indexing it with ftype in the initialier for 'size' is invalid when ftype == FT_PPC. This fixes crashes with gcc 4.8. Signed-off-by: Mans Rullgard m...@mansr.com ---  

Re: [libav-devel] [PATCH 2/6] lavr: Add x86-optimized functions for s16 to flt conversion

2012-05-01 Thread Ronald S. Bultje
Hi, On Tue, May 1, 2012 at 2:21 PM, Jason Garrett-Glaser ja...@x264.com wrote: +%if cpuflag(sse4) +    pmovsxwd   m0, [srcq+lenq         ] +    pmovsxwd   m1, [srcq+lenq+mmsize/2] +%else +    mova       m1, [srcq+lenq] Did you forget to load m0 in the non-sse4 version? punpcklwd m0, m1

Re: [libav-devel] [PATCH] adpcm-thp: fix invalid array indexing

2012-04-30 Thread Ronald S. Bultje
Hi, On Mon, Apr 30, 2012 at 6:40 AM, Mans Rullgard m...@mansr.com wrote: Indexing outside array limits is invalid and breaks with gcc 4.8. Signed-off-by: Mans Rullgard m...@mansr.com ---  libavcodec/adpcm.c |   10 ++  1 file changed, 6 insertions(+), 4 deletions(-) LGTM. Ronald

[libav-devel] [PATCH] configure: remove malloc_aligned.

2012-04-29 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com It was to signal that allocations are 16-byte aligned, but AVX requires 32-byte alignment, thus the check is no longer useful (and causes crashes). --- configure |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/configure b

[libav-devel] [PATCH] aac sbr: align struct member by 32 byte.

2012-04-29 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Required because it's used in a call to imdct_half(), which is an AVX function. --- libavcodec/sbr.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/sbr.h b/libavcodec/sbr.h index 459ee9c..23534b1 100644 --- a/libavcodec

Re: [libav-devel] [libav-commits] rv34: set mb_num_left to 0 after finishing a frame

2012-04-29 Thread Ronald S. Bultje
Hi Reinhard, On Sun, Apr 29, 2012 at 12:00 PM, Reinhard Tartler siret...@gmail.com wrote: Hi Ronald, unfortunately, this patch does not apply cleanly to the 0.8 branch. In order to have it for 0.8.2, I'd therefore require your assistance with this backport. Does 0.8 have -mt for rv34? If

Re: [libav-devel] [PATCH] avcodec: introduce YCoCg colorspace

2012-04-29 Thread Ronald S. Bultje
Hi, On Sun, Apr 29, 2012 at 2:01 PM, Luca Barbato lu_z...@gentoo.org wrote: From: Hendrik Leppkes h.lepp...@gmail.com Non perceptual color model that aims to have an increase effectiveness in compression like the normal YCbCr while having near-lossless/lossless mapping to RGB.

Re: [libav-devel] [PATCH 2/2] mkv: mark corrupted packets and return them

2012-04-29 Thread Ronald S. Bultje
Hi, On Sun, Apr 29, 2012 at 5:56 PM, Luca Barbato lu_z...@gentoo.org wrote: Do return error if memory allocation or I/O fails. ---  libavformat/matroskadec.c |    5 +  1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c

Re: [libav-devel] [PATCH] avcodec: introduce YCoCg colorspace

2012-04-29 Thread Ronald S. Bultje
Hi, On Sun, Apr 29, 2012 at 6:34 PM, Luca Barbato lu_z...@gentoo.org wrote: On 29/04/12 16:25, Ronald S. Bultje wrote: On Sun, Apr 29, 2012 at 2:01 PM, Luca Barbato lu_z...@gentoo.org wrote: From: Hendrik Leppkes h.lepp...@gmail.com Non perceptual color model that aims to have an increase

Re: [libav-devel] [PATCH 2/2] mkv: mark corrupted packets and return them

2012-04-29 Thread Ronald S. Bultje
Hi, On Sun, Apr 29, 2012 at 6:28 PM, Luca Barbato lu_z...@gentoo.org wrote: On 29/04/12 18:11, Ronald S. Bultje wrote: On Sun, Apr 29, 2012 at 5:56 PM, Luca Barbato lu_z...@gentoo.org wrote: Do return error if memory allocation or I/O fails. ---  libavformat/matroskadec.c |    5 +  1

Re: [libav-devel] [PATCH 3/3] h264: new assembly version of get_cabac for x86_64 with PIC

2012-04-28 Thread Ronald S. Bultje
, thanks to Ronald S. Bultje for helping me with this). ---  libavcodec/h264_cabac.c    |    2 +-  libavcodec/x86/cabac.h     |   90 ---  libavcodec/x86/h264_i386.h |   53 ++  3 files changed, 121 insertions(+), 24 deletions(-) Speedup

Re: [libav-devel] [PATCH 01/12] rv40dsp x86: MMX/MMX2/3DNow/SSE2/SSSE3 implementations of MC

2012-04-28 Thread Ronald S. Bultje
Hi, On Thu, Apr 19, 2012 at 2:26 PM, Christophe Gisquet christophe.gisq...@gmail.com wrote: 2012/4/19 Jason Garrett-Glaser ja...@x264.com: All else equal, add is better.  On most CPUs, lea is either 1/1 or 1/0.5, while add is 1/0.33.  3-argument lea is 3/1 on some CPUs. Ok, I guess I misread

Re: [libav-devel] [PATCH 01/12] rv40dsp x86: MMX/MMX2/3DNow/SSE2/SSSE3 implementations of MC

2012-04-28 Thread Ronald S. Bultje
Hi, On Sat, Apr 28, 2012 at 10:47 AM, Ronald S. Bultje rsbul...@gmail.com wrote: On Thu, Apr 19, 2012 at 2:26 PM, Christophe Gisquet christophe.gisq...@gmail.com wrote: 2012/4/19 Jason Garrett-Glaser ja...@x264.com: All else equal, add is better.  On most CPUs, lea is either 1/1 or 1/0.5

Re: [libav-devel] [PATCH 02/12] rv34dsp x86: implement MMX2 inverse transform

2012-04-28 Thread Ronald S. Bultje
Hi, On Wed, Apr 18, 2012 at 3:25 AM, Jason Garrett-Glaser ja...@x264.com wrote: On Wed, Apr 18, 2012 at 12:03 AM, Christophe Gisquet christophe.gisq...@gmail.com wrote: 2012/4/18 Jason Garrett-Glaser ja...@x264.com: +    movq        mm0, [%1+ 0*8] +    movq        mm1, [%1+ 1*8] +    movq  

Re: [libav-devel] [PATCH] dsputil x86: revert a test back to its previous value

2012-04-28 Thread Ronald S. Bultje
Hi, On Wed, Apr 18, 2012 at 2:55 PM, Ronald S. Bultje rsbul...@gmail.com wrote: On Wed, Apr 18, 2012 at 12:41 PM, Christophe Gisquet christophe.gisq...@gmail.com wrote: 2012/4/18 Luca Barbato lu_z...@gentoo.org: You mean if ((mm_flags (AV_CPU_FLAG_SSE2 | AV_CPU_FLAG_SSE2SLOW

Re: [libav-devel] [PATCH 04/12] rv34dsp: rearrange parameters to loop filter strength functions.

2012-04-28 Thread Ronald S. Bultje
Hi, 2012/4/17 Måns Rullgård m...@mansr.com: Christophe Gisquet christophe.gisq...@gmail.com writes: 2012/4/17 Måns Rullgård m...@mansr.com: Christophe GISQUET christophe.gisq...@gmail.com writes: This breaks the NEON asm. Indeed, that's why I tagged it as controversial in the first mail,

Re: [libav-devel] [PATCH 06/12] rv40dsp x86: distinguish non-edge/edge versions.

2012-04-28 Thread Ronald S. Bultje
Hi, 2012/4/18 Måns Rullgård m...@mansr.com: Christophe Gisquet christophe.gisq...@gmail.com writes: 2012/4/17 Måns Rullgård m...@mansr.com: Christophe Gisquet christophe.gisq...@gmail.com writes: This will also break the NEON asm. Which means the x86 tag is incorrect. So how should I go

Re: [libav-devel] [PATCH 08/12] rv40: don't always do the full prev_type search

2012-04-28 Thread Ronald S. Bultje
Hi, On Tue, Apr 17, 2012 at 4:33 PM, Ronald S. Bultje rsbul...@gmail.com wrote: On Tue, Apr 17, 2012 at 11:44 AM, Christophe GISQUET christophe.gisq...@gmail.com wrote: From: Christophe Gisquet christophe.gisq...@gmail.com 120-100 cycles. ---  libavcodec/rv40.c |   25

Re: [libav-devel] [PATCH 09/12] rv40: cosmetics

2012-04-28 Thread Ronald S. Bultje
Hi, On Thu, Apr 19, 2012 at 2:21 PM, Christophe Gisquet christophe.gisq...@gmail.com wrote: 2012/4/17 Måns Rullgård m...@mansr.com: The change looks OK, but it is more than cosmetics. OK. Patch with new title rv34: remove constant parameter attached. Pushed. Ronald

[libav-devel] [PATCH] rv34: remove inline keyword from rv34_decode_block().

2012-04-28 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Force-inlining increases object size by 8kB and causes a 2% slowdown. --- libavcodec/rv34.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/rv34.c b/libavcodec/rv34.c index a3d3fcd..beecf67 100644 --- a/libavcodec/rv34.c

Re: [libav-devel] [PATCH 10/12] rv40: change a logical test into a bitwise one.

2012-04-28 Thread Ronald S. Bultje
Hi, 2012/4/19 Måns Rullgård m...@mansr.com: Christophe Gisquet christophe.gisq...@gmail.com writes: 2012/4/17 Måns Rullgård m...@mansr.com: Is this function not actually inlined?  I would not expect this to make a difference where it is. Good question: it is not inlined, and if it is forced

<    3   4   5   6   7   8   9   10   11   12   >