[libav-devel] [PATCH 2/2] avidec: Set palette alpha as fully opaque

2016-10-02 Thread Vittorio Giovara
Palette format is always in RGBA. --- libavformat/avidec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index e8a19f5..92ff428 100644 --- a/libavformat/avidec.c +++ b/libavformat/avidec.c @@ -653,7 +653,7 @@ static int avi_read_hea

Re: [libav-devel] [PATCH] vaapi_encode: Write sequence header as extradata

2016-10-02 Thread Vittorio Giovara
On Sun, Oct 2, 2016 at 4:19 AM, Mark Thompson wrote: > Only works if packed headers are supported, where we can know the > output before generating the first frame. > --- > If this is wanted when packed headers aren't supported, we will need a > different approach because we can't know what the o

Re: [libav-devel] [PATCH] avidec: Do not special case palette on big-endian

2016-10-01 Thread Vittorio Giovara
On Sat, Oct 1, 2016 at 5:35 PM, Martin Storsjö wrote: > On Sat, 1 Oct 2016, Vittorio Giovara wrote: > >> On Wed, Sep 28, 2016 at 2:01 AM, Anton Khirnov wrote: >>> >>> Quoting Vittorio Giovara (2016-09-28 00:12:00) >>>> >>>> --- >>

Re: [libav-devel] [PATCH] avidec: Do not special case palette on big-endian

2016-10-01 Thread Vittorio Giovara
On Wed, Sep 28, 2016 at 2:01 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-09-28 00:12:00) >> --- >> libavformat/avidec.c | 6 +- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/libavformat/avidec.c b/libavformat/avidec.c

Re: [libav-devel] [PATCH 1/2] avconv: make sure the filtergraph is freed on init failure

2016-10-01 Thread Vittorio Giovara
On Sat, Oct 1, 2016 at 3:22 PM, Anton Khirnov wrote: > The filtergraph's existence is used in several places to mean that the > filtergraph is fully configured. This causes problems if it's allocated, > but the initialization fails (e.g. if a non-existent filter is > specified). > --- > avconv_fi

Re: [libav-devel] [PATCH] huffyuv: ppc: Enable the altivec code for LE as well

2016-10-01 Thread Vittorio Giovara
On Sat, Oct 1, 2016 at 3:30 PM, Luca Barbato wrote: > Confirmed to work by checkasm. > --- > libavcodec/ppc/huffyuvdsp_altivec.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/ppc/huffyuvdsp_altivec.c > b/libavcodec/ppc/huffyuvdsp_altivec.c > index 33

Re: [libav-devel] [PATCH] huffyuv: Enable again the PPC optimization

2016-10-01 Thread Vittorio Giovara
On Sat, Oct 1, 2016 at 3:26 PM, Luca Barbato wrote: > --- > libavcodec/huffyuvdsp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/huffyuvdsp.c b/libavcodec/huffyuvdsp.c > index b5a714d..0fd6fd7 100644 > --- a/libavcodec/huffyuvdsp.c > +++ b/libavcodec/huffyuvdsp.c > @@ -12

Re: [libav-devel] [PATCH] h264dec: support broken files with mp4 extradata/annex b data

2016-10-01 Thread Vittorio Giovara
On Sat, Oct 1, 2016 at 4:12 AM, Anton Khirnov wrote: > Bug-Id: 966 > --- > libavcodec/h264dec.c | 19 ++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c > index 2c5a7db..330a74d 100644 > --- a/libavcodec/h264dec.c > +

Re: [libav-devel] [PATCH] fate: Add test for rscc palette

2016-09-27 Thread Vittorio Giovara
On Tue, Sep 27, 2016 at 6:12 PM, Vittorio Giovara wrote: > --- > diff --git a/tests/ref/fate/rscc-8bit b/tests/ref/fate/rscc-8bit > new file mode 100644 > index 000..5cc4a72 > --- /dev/null > +++ b/tests/ref/fate/rscc-8bit > @@ -0,0 +1,2 @@ > +#tb 0: 100/2997 >

[libav-devel] [PATCH] fate: Add test for rscc palette

2016-09-27 Thread Vittorio Giovara
--- This is updated after the avidec change and adds pix_fmt conversion so that hashes match on big endian. Vittorio tests/fate/screen.mak| 3 +++ tests/ref/fate/rscc-8bit | 2 ++ 2 files changed, 5 insertions(+) create mode 100644 tests/ref/fate/rscc-8bit diff --git a/tests/fate/screen.mak

[libav-devel] [PATCH] avidec: Do not special case palette on big-endian

2016-09-27 Thread Vittorio Giovara
--- libavformat/avidec.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index 3666b57..92ff428 100644 --- a/libavformat/avidec.c +++ b/libavformat/avidec.c @@ -652,12 +652,8 @@ static int avi_read_header(AVFormatContext *s)

Re: [libav-devel] [PATCH] swscale: Rename is9_OR_10 to match what it does

2016-09-27 Thread Vittorio Giovara
On Tue, Sep 27, 2016 at 12:15 PM, Luca Barbato wrote: > It is used to select functions that work with 9-15bits. > --- Probably ok, but keep it separate since it's just renaming. -- Vittorio ___ libav-devel mailing list libav-devel@libav.org https://lis

Re: [libav-devel] [PATCH] pixfmt: Add 12bit Planar YUV

2016-09-26 Thread Vittorio Giovara
On Mon, Sep 26, 2016 at 12:18 PM, Luca Barbato wrote: > It is used by VP9 high bitdepth profiles, AV1 and vc2. > --- How about "libavutil: Bump version after new YUV12 pixel formats" I wouldn't mention which codecs use it because.. they don't yet. Assuming oracle is happy, this and the set look

[libav-devel] [PATCH] swscale: Consistently order input YUV pixel formats

2016-09-25 Thread Vittorio Giovara
Follow a 420, 422, 444 order instead of a random one. This simplifies double-checking additions of new formats. --- libswscale/input.c | 58 +++--- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/libswscale/input.c b/libswscale/input.

Re: [libav-devel] [PATCH 4/4] nvenc: Extended rate-control support as provided by SDK 7

2016-09-24 Thread Vittorio Giovara
On Sat, Sep 24, 2016 at 12:26 PM, Luca Barbato wrote: > On 09/24/16 18:23, Vittorio Giovara wrote: >>> >>> 2016-xx-xx - xxx - lavc 59.27.0 - avcodec.h >>>Add FF_PROFILE_HEVC_REXT, the extended pixel format profile for HEVC. >> >> >>

Re: [libav-devel] [PATCH 4/4] nvenc: Extended rate-control support as provided by SDK 7

2016-09-24 Thread Vittorio Giovara
On Sat, Sep 24, 2016 at 11:55 AM, Diego Biurrun wrote: > From: Yogender Gupta > > Signed-off-by: Luca Barbato > Signed-off-by: Diego Biurrun > --- > doc/APIchanges | 3 +++ > libavcodec/nvenc.c | 47 +++ > libavcodec/nvenc.h | 10

Re: [libav-devel] [PATCH 6/6] examples/output: switch to the new encoding API

2016-09-22 Thread Vittorio Giovara
On Thu, Sep 22, 2016 at 3:35 AM, Anton Khirnov wrote: > --- > doc/examples/output.c | 71 > +++ > 1 file changed, 44 insertions(+), 27 deletions(-) > > diff --git a/doc/examples/output.c b/doc/examples/output.c > index 44a55f5..bb0da30 100644 > ---

Re: [libav-devel] [PATCH 5/6] tdsc: use the new decoding API

2016-09-22 Thread Vittorio Giovara
On Thu, Sep 22, 2016 at 3:35 AM, Anton Khirnov wrote: > --- > libavcodec/tdsc.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/tdsc.c b/libavcodec/tdsc.c > index c70c77f..5b952b3 100644 > --- a/libavcodec/tdsc.c > +++ b/libavcodec/tdsc.c > @@ -

[libav-devel] [PATCH] vp3: Check pixel format index before using it

2016-09-21 Thread Vittorio Giovara
Avoid out of bounds access. --- libavcodec/vp3.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index 26374cc..40e9498 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -2274,8 +2274,15 @@ static int theora_decode_head

Re: [libav-devel] [PATCH 2/3] rscc: Support palette formate

2016-09-21 Thread Vittorio Giovara
On Wed, Sep 21, 2016 at 2:56 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-09-20 23:12:02) >> On Tue, Sep 20, 2016 at 3:07 PM, Anton Khirnov wrote: >> > typo in the commite message >> > >> > Quoting Vittorio Giovara (2016-09-19 22

Re: [libav-devel] [PATCH 2/3] rscc: Support palette formate

2016-09-20 Thread Vittorio Giovara
On Tue, Sep 20, 2016 at 3:07 PM, Anton Khirnov wrote: > typo in the commite message > > Quoting Vittorio Giovara (2016-09-19 22:33:43) >> From: Carl Eugen Hoyos >> >> Signed-off-by: Vittorio Giovara >> --- >> libavcodec/rscc.c | 21 ++---

Re: [libav-devel] [PATCH 1/3] avcodec: Document AV_PKT_DATA_PALETTE side data type

2016-09-20 Thread Vittorio Giovara
On Tue, Sep 20, 2016 at 3:05 PM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-09-19 22:33:42) >> --- >> libavcodec/avcodec.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h >> index c863

[libav-devel] [PATCH] pixfmt: Document alternative names for smpte 431 and 432

2016-09-20 Thread Vittorio Giovara
--- libavutil/pixfmt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h index 8a8d624..e653652 100644 --- a/libavutil/pixfmt.h +++ b/libavutil/pixfmt.h @@ -304,8 +304,8 @@ enum AVColorPrimaries { AVCOL_PRI_BT2020 = 9, ///< IT

[libav-devel] [PATCH 3/3] fate: Add test for rscc palette

2016-09-19 Thread Vittorio Giovara
--- tests/fate/screen.mak| 3 +++ tests/ref/fate/rscc-8bit | 2 ++ 2 files changed, 5 insertions(+) create mode 100644 tests/ref/fate/rscc-8bit diff --git a/tests/fate/screen.mak b/tests/fate/screen.mak index 7e91f19..a386fd3 100644 --- a/tests/fate/screen.mak +++ b/tests/fate/screen.mak @@

[libav-devel] [PATCH 1/3] avcodec: Document AV_PKT_DATA_PALETTE side data type

2016-09-19 Thread Vittorio Giovara
--- libavcodec/avcodec.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index c863e53..840222c 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -1190,6 +1190,9 @@ typedef struct AVCPBProperties { * @{ */ enum AVPacketSideDataT

[libav-devel] [PATCH 2/3] rscc: Support palette formate

2016-09-19 Thread Vittorio Giovara
From: Carl Eugen Hoyos Signed-off-by: Vittorio Giovara --- libavcodec/rscc.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/libavcodec/rscc.c b/libavcodec/rscc.c index 4a91783..91ffae2 100644 --- a/libavcodec/rscc.c +++ b/libavcodec/rscc.c @@ -31,7

Re: [libav-devel] [PATCH 2/5] nvenc: Fix the low-latency preset order

2016-09-19 Thread Vittorio Giovara
On Sat, Sep 17, 2016 at 9:28 AM, Luca Barbato wrote: > From: Yogender Gupta > > Their order got swapped in SDK 7. > --- > configure | 4 ++-- > libavcodec/nvenc.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Shouldn't we still support SDK 6? -- Vittorio _

Re: [libav-devel] [PATCH] vf_scale_vaapi: Crop input surface to active region

2016-09-14 Thread Vittorio Giovara
On Tue, Sep 13, 2016 at 10:00 PM, Mark Thompson wrote: > If the input has been decoded from a stream which uses edge cropping > then the whole surface need not be valid. This defines an input > region for the scaler so we only use the active area of the frame. > --- > Visible at the bottom of the

Re: [libav-devel] [PATCH] libvpx: Support additional pixel format

2016-09-12 Thread Vittorio Giovara
On Mon, Sep 5, 2016 at 2:33 PM, Luca Barbato wrote: > As discussed in the ml, the high bitdept support in vpx allows to > specify the number of bits used. > > Reported-by: Harfe Leier > --- > > libavcodec/libvpx.c| 28 +++- > libavcodec/libvpx.h| 2 +- > libavcod

Re: [libav-devel] [PATCH] vpx: Support high bitdepth encoding

2016-09-12 Thread Vittorio Giovara
On Mon, Sep 5, 2016 at 2:54 PM, Luca Barbato wrote: > --- > > Consider that tentative since I have a plane to take, testing welcome :) > > libavcodec/libvpx.c| 6 ++ > libavcodec/libvpxenc.c | 12 > 2 files changed, 18 insertions(+) > > diff --git a/libavcodec/libvpx.c b/lib

[libav-devel] [PATCH] mpegvideo_motion: Handle edge emulation even without unrestricted_mv

2016-09-12 Thread Vittorio Giovara
From: Michael Niedermayer Fix out of bounds read. Found by: F4B3CD@STARLAB. Signed-off-by: Vittorio Giovara --- libavcodec/mpegvideo_motion.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/libavcodec/mpegvideo_motion.c b/libavcodec/mpegvideo_motion.c

Re: [libav-devel] [PATCH] svq3: Change type of array stride parameters to ptrdiff_t

2016-09-08 Thread Vittorio Giovara
On Thu, Sep 8, 2016 at 2:13 PM, Diego Biurrun wrote: > ptrdiff_t is the correct type for array strides and similar. > --- > > Added a few more change instances. > > libavcodec/svq3.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/svq3.c b/

Re: [libav-devel] [PATCH] pixblockdsp: Change type of stride parameters to ptrdiff_t

2016-09-08 Thread Vittorio Giovara
On Thu, Sep 8, 2016 at 2:34 PM, Diego Biurrun wrote: > diff --git a/libavcodec/dvenc.c b/libavcodec/dvenc.c > index e02f349..d68f708 100644 > --- a/libavcodec/dvenc.c > +++ b/libavcodec/dvenc.c > @@ -234,8 +234,8 @@ static const int dv_weight_248[64] = { > }; > > static av_always_inline int dv_i

[libav-devel] [PATCH] Changelog: Mention mov with multiple stsd

2016-08-25 Thread Vittorio Giovara
--- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index 0d04f47..2a012db 100644 --- a/Changelog +++ b/Changelog @@ -60,6 +60,7 @@ version : - MagicYUV decoder - Duck TrueMotion 2.0 Real Time decoder - Intel QSV video scaling and deinterlacing filter +- supp

Re: [libav-devel] [PATCH 1/3] imgutils: add a function for copying image data from GPU mapped memory

2016-08-25 Thread Vittorio Giovara
On Thu, Aug 25, 2016 at 4:07 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-08-24 16:58:12) >> also, does it have to be a separate function? If so, what does the old >> function do that the new one does not? > > The doxy says what the difference is -- mainly that t

Re: [libav-devel] [PATCH 5/5] libvpx: Cast a pointer to const to squelch a warning

2016-08-24 Thread Vittorio Giovara
On Wed, Aug 24, 2016 at 1:59 PM, Luca Barbato wrote: > On 24/08/16 18:28, Diego Biurrun wrote: >> libavcodec/libvpxdec.c:100:57: warning: passing argument 3 of >> 'av_image_copy' from incompatible pointer type >> av_image_copy(picture->data, picture->linesize, img->planes, >> libavutil/i

Re: [libav-devel] [PATCH 1/3] imgutils: add a function for copying image data from GPU mapped memory

2016-08-24 Thread Vittorio Giovara
On Wed, Aug 24, 2016 at 6:06 AM, Diego Biurrun wrote: > On Wed, Aug 24, 2016 at 11:24:01AM +0200, Anton Khirnov wrote: >> --- /dev/null >> +++ b/libavutil/x86/imgutils_init.c >> @@ -0,0 +1,49 @@ >> + >> +void ff_image_copy_plane_uc_from_sse4(uint8_t *dst, ptrdiff_t dst_linesize, >> +

Re: [libav-devel] [PATCH] doc: Document FATE option HWACCEL

2016-08-17 Thread Vittorio Giovara
On Mon, Aug 15, 2016 at 1:24 PM, Luca Barbato wrote: > --- > doc/fate.texi | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/doc/fate.texi b/doc/fate.texi > index ae326fe..9b8d953 100644 > --- a/doc/fate.texi > +++ b/doc/fate.texi > @@ -99,6 +99,11 @@ Specify or override the wrapper u

Re: [libav-devel] [PATCH] avprobe: Fix memory leak

2016-08-15 Thread Vittorio Giovara
On Thu, Jul 21, 2016 at 9:47 AM, Vittorio Giovara wrote: > After init_opts() there needs to be an uninit_opts() call > to free swscales context and other buffers. > --- > avprobe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/avprobe.c b/avpr

Re: [libav-devel] [PATCH] vpx: Support color range

2016-07-22 Thread Vittorio Giovara
On Fri, Jul 22, 2016 at 9:33 AM, Luca Barbato wrote: > The range field has been introduced in version 1.6.0 > --- > libavcodec/libvpxdec.c | 10 ++ > libavcodec/libvpxenc.c | 10 ++ > 2 files changed, 20 insertions(+) > > diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.

[libav-devel] [PATCH] Revert "avprobe: Zero the allocated avio buffer memory"

2016-07-21 Thread Vittorio Giovara
. Signed-off-by: Vittorio Giovara --- avprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/avprobe.c b/avprobe.c index cf357bc..eff9c0d 100644 --- a/avprobe.c +++ b/avprobe.c @@ -1039,7 +1039,7 @@ static int probe_buf_write(void *opaque, uint8_t *buf, int buf_size) int

Re: [libav-devel] [PATCH] avprobe: Zero the allocated avio buffer memory

2016-07-21 Thread Vittorio Giovara
On Thu, Jul 21, 2016 at 8:35 PM, Martin Storsjö wrote: > On Thu, 21 Jul 2016, Martin Storsjö wrote: > >> On Thu, 21 Jul 2016, Vittorio Giovara wrote: >> >>> On Wed, Jul 20, 2016 at 9:35 PM, Martin Storsjö wrote: >>>> >>>> On Wed, 20 Jul 2016

Re: [libav-devel] [PATCH] lavf: Fix stream codec context memory leak

2016-07-21 Thread Vittorio Giovara
On Thu, Jul 21, 2016 at 8:48 PM, Vittorio Giovara wrote: > st->codec is allocated with avcodec_alloc_context3(), > so it needs to be free'd properly. > --- > libavformat/utils.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/libavformat/

[libav-devel] [PATCH] lavf: Fix stream codec context memory leak

2016-07-21 Thread Vittorio Giovara
st->codec is allocated with avcodec_alloc_context3(), so it needs to be free'd properly. --- libavformat/utils.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 6df1a32..b50f230 100644 --- a/libavformat/utils.c +++ b/libavforma

[libav-devel] [PATCH] avprobe: Fix memory leak

2016-07-21 Thread Vittorio Giovara
After init_opts() there needs to be an uninit_opts() call to free swscales context and other buffers. --- avprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/avprobe.c b/avprobe.c index 5b9a7ec..cf357bc 100644 --- a/avprobe.c +++ b/avprobe.c @@ -1089,7 +1089,7 @@ int main

Re: [libav-devel] [PATCH] avprobe: Zero the allocated avio buffer memory

2016-07-21 Thread Vittorio Giovara
On Wed, Jul 20, 2016 at 9:35 PM, Martin Storsjö wrote: > On Wed, 20 Jul 2016, Vittorio Giovara wrote: > >> Fixes valgrind warning "Conditional jump or move depends on >> uninitialised value(s)." from avio_flush(). >> --- >> avprobe.c | 2 +- >&

Re: [libav-devel] [PATCH] lavc: Document in/out AVCodecParameters ownership in AVBSFContext

2016-07-21 Thread Vittorio Giovara
On Thu, Jul 21, 2016 at 10:49 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-07-20 21:26:26) >> --- >> More compact and typo-free. >> Vittorio >> >> libavcodec/avcodec.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/l

[libav-devel] [PATCH] lavc: Document in/out AVCodecParameters ownership in AVBSFContext

2016-07-20 Thread Vittorio Giovara
--- More compact and typo-free. Vittorio libavcodec/avcodec.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index ace761d..72665ba 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -4985,6 +4985,9 @@ typedef struct AVBSFInternal A

[libav-devel] [PATCH] lavc: Document in/out AVCodecParameters ownership in AVBSFContext

2016-07-20 Thread Vittorio Giovara
--- slightly stronger wording Vittorio libavcodec/avcodec.h | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index ace761d..29b6bbc 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -4985,6 +4985,10 @@ typedef struct AVBSFInternal A

[libav-devel] [PATCH] lavc: Document in/out AVCodecParameters ownership in AVBSFContext

2016-07-20 Thread Vittorio Giovara
--- libavcodec/avcodec.h | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index ace761d..a75a245 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -4985,6 +4985,10 @@ typedef struct AVBSFInternal AVBSFInternal; * The fields in the

Re: [libav-devel] [PATCH 2/2] mov: Wrap stsc index and count compare in a separate function

2016-07-20 Thread Vittorio Giovara
On Wed, Jul 20, 2016 at 6:53 PM, Luca Barbato wrote: > On 20/07/16 18:48, Vittorio Giovara wrote: >> --- >> libavformat/mov.c | 15 ++- >> 1 file changed, 10 insertions(+), 5 deletions(-) >> >> diff --git a/libavformat/mov.c b/libavformat/mov.c

[libav-devel] [PATCH 1/2] mov: Fix stsc_count comparison

2016-07-20 Thread Vittorio Giovara
From: Matthieu Bouron Signed-off-by: Vittorio Giovara --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 14be96e..c0421d2 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -3680,7 +3680,7 @@ static int

[libav-devel] [PATCH 2/2] mov: Wrap stsc index and count compare in a separate function

2016-07-20 Thread Vittorio Giovara
--- libavformat/mov.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index c0421d2..e1e20ee 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1961,12 +1961,17 @@ static int mov_read_stsc(MOVContext *c, AVIOContext

Re: [libav-devel] [PATCH 4/4] lavc: Deprecate avcodec_close()

2016-07-20 Thread Vittorio Giovara
On Wed, Jul 20, 2016 at 4:16 PM, Luca Barbato wrote: > On 20/07/16 16:10, Vittorio Giovara wrote: >> avcodec_free_context() fully replaces it. >> --- >> libavcodec/avcodec.h | 11 +++ >> libavcodec/options.c | 5 + >> libavcodec/utils.c | 2

[libav-devel] [PATCH] ratecontrol: Call Xvid functions externally

2016-07-20 Thread Vittorio Giovara
This will simplify the de-MpegEncContextualization. --- libavcodec/libxvid.h | 7 +++ libavcodec/mpegvideo_enc.c | 33 - libavcodec/ratecontrol.c | 28 libavcodec/ratecontrol.h | 4 4 files changed, 39 insertions(+),

Re: [libav-devel] [PATCH 2/4] ratecontrol: Call xvid functions externally

2016-07-20 Thread Vittorio Giovara
On Wed, Jul 20, 2016 at 5:39 PM, Diego Biurrun wrote: > On Wed, Jul 20, 2016 at 05:26:01PM +0200, Vittorio Giovara wrote: >> On Wed, Jul 20, 2016 at 4:26 PM, Diego Biurrun wrote: >> >> --- a/libavcodec/ratecontrol.c >> >> +++ b/libavcodec/rate

Re: [libav-devel] [PATCH 2/2] mov: Rework the check for invalid indexes in stsc

2016-07-20 Thread Vittorio Giovara
On Wed, Jul 13, 2016 at 9:46 PM, Luca Barbato wrote: > On 13/07/16 21:02, Vittorio Giovara wrote: >> There are samples with invalid stsc that may work fine as is and >> do not need extradata change. So ignore any out of range index, and >> error out only when explode i

Re: [libav-devel] [PATCH 2/4] ratecontrol: Call xvid functions externally

2016-07-20 Thread Vittorio Giovara
On Wed, Jul 20, 2016 at 5:26 PM, Vittorio Giovara wrote: > On Wed, Jul 20, 2016 at 4:26 PM, Diego Biurrun wrote: >>> --- a/libavcodec/ratecontrol.c >>> +++ b/libavcodec/ratecontrol.c >>> @@ -216,19 +209,9 @@ FF_ENABLE_DEPRECATION_WARNINGS >>

Re: [libav-devel] [PATCH 2/4] ratecontrol: Call xvid functions externally

2016-07-20 Thread Vittorio Giovara
On Wed, Jul 20, 2016 at 4:26 PM, Diego Biurrun wrote: >> --- a/libavcodec/ratecontrol.c >> +++ b/libavcodec/ratecontrol.c >> @@ -216,19 +209,9 @@ FF_ENABLE_DEPRECATION_WARNINGS >> >> if (init_pass2(s) < 0) { >> -ff_rate_control_uninit(s); >> -return -1; >> -

Re: [libav-devel] [PATCH 2/4] avconv: Skip partial context release

2016-07-20 Thread Vittorio Giovara
On Wed, Jul 20, 2016 at 4:27 PM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-07-20 16:10:18) >> dec_ctx is fully free'd in avconv_cleanup(). >> --- >> avconv.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/avconv.c b/avconv

Re: [libav-devel] [PATCH] options_table: Move internal symbol to internal.h

2016-07-20 Thread Vittorio Giovara
On Wed, Jul 20, 2016 at 4:59 PM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-07-20 16:57:32) >> On Wed, Jul 20, 2016 at 4:31 PM, Anton Khirnov wrote: >> > Quoting Vittorio Giovara (2016-07-20 16:12:18) >> >> And drop its AV prefix since it's no

Re: [libav-devel] [PATCH] options_table: Move internal symbol to internal.h

2016-07-20 Thread Vittorio Giovara
On Wed, Jul 20, 2016 at 4:31 PM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-07-20 16:12:18) >> And drop its AV prefix since it's not public. >> >> Signed-off-by: Vittorio Giovara >> --- >> libavcodec/internal.h | 2 ++ >> libavcodec/op

[libav-devel] [PATCH 2/4] ratecontrol: Call xvid functions externally

2016-07-20 Thread Vittorio Giovara
This will simplify the de-MpegEncContextualization. --- libavcodec/libxvid.h | 7 +++ libavcodec/mpegvideo_enc.c | 33 - libavcodec/ratecontrol.c | 31 ++- libavcodec/ratecontrol.h | 4 4 files changed, 41 insertions(

[libav-devel] [PATCH 4/4] ratecontrol: Reorder functions to avoid forward declarations

2016-07-20 Thread Vittorio Giovara
--- libavcodec/ratecontrol.c | 872 +++ 1 file changed, 431 insertions(+), 441 deletions(-) diff --git a/libavcodec/ratecontrol.c b/libavcodec/ratecontrol.c index 256823e..d04152d 100644 --- a/libavcodec/ratecontrol.c +++ b/libavcodec/ratecontrol.c @@ -

[libav-devel] [PATCH 4/4] lavc: Deprecate avcodec_close()

2016-07-20 Thread Vittorio Giovara
avcodec_free_context() fully replaces it. --- libavcodec/avcodec.h | 11 +++ libavcodec/options.c | 5 + libavcodec/utils.c | 2 ++ libavcodec/version.h | 3 +++ 4 files changed, 17 insertions(+), 4 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index ace76

[libav-devel] [PATCH] options_table: Move internal symbol to internal.h

2016-07-20 Thread Vittorio Giovara
And drop its AV prefix since it's not public. Signed-off-by: Vittorio Giovara --- libavcodec/internal.h | 2 ++ libavcodec/options_table.h | 6 ++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/internal.h b/libavcodec/internal.h index 4bde09a..e6f495d 1

[libav-devel] [PATCH 3/4] ratecontrol: Move mpegenc-only function where it is used

2016-07-20 Thread Vittorio Giovara
And make it static. --- libavcodec/mpegvideo_enc.c | 24 +++- libavcodec/ratecontrol.c | 21 - libavcodec/ratecontrol.h | 1 - 3 files changed, 23 insertions(+), 23 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index

[libav-devel] [PATCH 1/4] ratecontrol: Drop commented out cruft

2016-07-20 Thread Vittorio Giovara
--- libavcodec/ratecontrol.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/libavcodec/ratecontrol.c b/libavcodec/ratecontrol.c index 47a1490..5508771 100644 --- a/libavcodec/ratecontrol.c +++ b/libavcodec/ratecontrol.c @@ -103,12 +103,6 @@ av_cold int ff_rate_co

[libav-devel] [PATCH 3/4] lavf: Avoid closing try_decode_frame() contexts

2016-07-20 Thread Vittorio Giovara
There is substantial difference in leaving them open, no leakage or different output were noticed with this change. --- libavformat/utils.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 6df1a32..5897ac4 100644 --- a/libavformat/utils.c +++

[libav-devel] [PATCH 1/4] examples: Properly free AVCodecContext

2016-07-20 Thread Vittorio Giovara
--- doc/examples/avcodec.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/doc/examples/avcodec.c b/doc/examples/avcodec.c index f8d043f..8fee552 100644 --- a/doc/examples/avcodec.c +++ b/doc/examples/avcodec.c @@ -213,8 +213,7 @@ static void audio_encode_example(c

[libav-devel] [PATCH 2/4] avconv: Skip partial context release

2016-07-20 Thread Vittorio Giovara
dec_ctx is fully free'd in avconv_cleanup(). --- avconv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/avconv.c b/avconv.c index 3a7a898..d6b41af 100644 --- a/avconv.c +++ b/avconv.c @@ -2760,7 +2760,6 @@ static int transcode(void) for (i = 0; i < nb_input_streams; i++) { ist =

[libav-devel] [PATCH] avprobe: Zero the allocated avio buffer memory

2016-07-20 Thread Vittorio Giovara
Fixes valgrind warning "Conditional jump or move depends on uninitialised value(s)." from avio_flush(). --- avprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/avprobe.c b/avprobe.c index abaaee1..5b9a7ec 100644 --- a/avprobe.c +++ b/avprobe.c @@ -1039,7 +1039,7 @@ static

[libav-devel] [PATCH] lavc: Add a note to avcodec_free_context() usage

2016-07-18 Thread Vittorio Giovara
--- Alternatively we could remove the last two places that still use avcodec_close() (lavf and avconv), and deprecate it. Vittorio libavcodec/avcodec.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index ace761d..e3c6070 100644 --- a/libavcodec

[libav-devel] [PATCH 2/2] mov: Rework the check for invalid indexes in stsc

2016-07-13 Thread Vittorio Giovara
There are samples with invalid stsc that may work fine as is and do not need extradata change. So ignore any out of range index, and error out only when explode is set. Found-by: Matthieu Bouron Signed-off-by: Vittorio Giovara --- libavformat/mov.c | 7 +-- 1 file changed, 5 insertions

[libav-devel] [PATCH 1/2] mov: Fix stsc_count comparison

2016-07-13 Thread Vittorio Giovara
From: Matthieu Bouron Signed-off-by: Vittorio Giovara --- CCing the author in the hope that future fixes get more shared and separated from merge commits. Vittorio libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index

[libav-devel] [PATCH] libdc1394: Fill in packet data directly

2016-07-13 Thread Vittorio Giovara
Drop the packet embedded in the context. --- libavdevice/libdc1394.c | 44 +--- 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/libavdevice/libdc1394.c b/libavdevice/libdc1394.c index 72e2e8b..a0ea592 100644 --- a/libavdevice/libdc1394.c +++

[libav-devel] [PATCH 2/2] libdc1394: Use allocated AVPackets

2016-07-13 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- This is a small step to allow removing sizeof(AVPacket) from ABI (in the very very long run), and to investigate what people think of the idea. There was some discussion in the past and a few founding stone were laid, this would be mainly a continuation of

[libav-devel] [PATCH 1/2] lavd: Drop unneeded av_init_packet()s

2016-07-13 Thread Vittorio Giovara
The input packet is already unref'd by the calling function. --- libavdevice/v4l2.c| 1 - libavdevice/x11grab.c | 1 - 2 files changed, 2 deletions(-) diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c index 74fec51..47241e4 100644 --- a/libavdevice/v4l2.c +++ b/libavdevice/v4l2.c @@ -861,7

Re: [libav-devel] [PATCH 04/10] lavu: Add OpenCL hardware pixfmt

2016-07-13 Thread Vittorio Giovara
On Tue, Jul 12, 2016 at 7:51 PM, Mark Thompson wrote: > --- > Seemed better to keep as a separate patch. > > libavutil/pixdesc.c | 4 > libavutil/pixfmt.h | 7 +++ > 2 files changed, 11 insertions(+) You need to bump version.h and maybe add an APIchange entry. Ok otherwise. -- Vittori

[libav-devel] [PATCH 1/2] fate: Restore order of h264 entries

2016-07-11 Thread Vittorio Giovara
--- tests/fate/h264.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/h264.mak b/tests/fate/h264.mak index 516aeef..29ef25c 100644 --- a/tests/fate/h264.mak +++ b/tests/fate/h264.mak @@ -375,11 +375,11 @@ fate-h264-conformance-sva_nl2_e: CMD =

[libav-devel] [PATCH 2/2] fate: Add a mixed NAL coding sample

2016-07-11 Thread Vittorio Giovara
See commit xx. --- tests/fate/h264.mak | 5 + tests/ref/fate/h264-mixed-nal-coding | 6 ++ 2 files changed, 11 insertions(+) create mode 100644 tests/ref/fate/h264-mixed-nal-coding diff --git a/tests/fate/h264.mak b/tests/fate/h264.mak index 29ef25c..bbce95d 100644 -

[libav-devel] [PATCH 1/2] fate: Preserve order of h264 entries

2016-07-11 Thread Vittorio Giovara
--- tests/fate/h264.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/h264.mak b/tests/fate/h264.mak index 516aeef..b8b61d4 100644 --- a/tests/fate/h264.mak +++ b/tests/fate/h264.mak @@ -375,10 +375,10 @@ fate-h264-conformance-sva_nl2_e: CMD =

[libav-devel] [PATCH 2/2] fate: Add a mixed NAL coding sample

2016-07-11 Thread Vittorio Giovara
See commit xx. --- tests/fate/h264.mak | 5 + tests/ref/fate/h264-mixed-nal-coding | 6 ++ 2 files changed, 11 insertions(+) create mode 100644 tests/ref/fate/h264-mixed-nal-coding diff --git a/tests/fate/h264.mak b/tests/fate/h264.mak index b8b61d4..1269a9d 100644 -

Re: [libav-devel] [PATCH 1/1] h2645_parse: handle embedded Annex B NAL units in size prefixed NAL units

2016-07-08 Thread Vittorio Giovara
decode_nal_units() and a similar > patch by Hendrik Leppkes in FFmpeg (a9bb4cf87d1). > > Bug-Id: ffmpeg/trac5529 > Reported-By: Vittorio Giovara > --- > libavcodec/h2645_parse.c | 46 ++ > 1 file changed, 34 insertions(+),

[libav-devel] [PATCH] h2645_parse: support badly muxed mp4 streams

2016-07-05 Thread Vittorio Giovara
. Bug-Id: ffmpeg/trac5529 Signed-off-by: Vittorio Giovara --- libavcodec/h2645_parse.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c index cd7440a..7ae7b80 100644 --- a/libavcodec/h2645_parse.c +++ b

[libav-devel] [PATCH] h264: Log more information about invalid NALu size

2016-07-05 Thread Vittorio Giovara
--- libavcodec/h2645_parse.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c index defe001..cd7440a 100644 --- a/libavcodec/h2645_parse.c +++ b/libavcodec/h2645_parse.c @@ -215,7 +215,9 @@ int ff_h2645_packet_split(H2645Pac

[libav-devel] [PATCH] mov: Save number of stsd elements after stream extradata allocation

2016-06-29 Thread Vittorio Giovara
Avoid freeing an unallocated array in mov_read_close() in case of a malloc failure. Signed-off-by: Vittorio Giovara --- libavformat/mov.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index fe1f264..0cb3271 100644 --- a

[libav-devel] [PATCH] mov: Save number of stsd elements after stream extradata allocation

2016-06-29 Thread Vittorio Giovara
Avoid freeing an unallocated array in mov_read_close() in case of a malloc failure. Signed-off-by: Vittorio Giovara --- libavformat/mov.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index fe1f264..f800bfa 100644 --- a

[libav-devel] [PATCH] tiffenc: Check zlib support for deflate option during initialization

2016-06-29 Thread Vittorio Giovara
This converts a misleading error about an option not found to a more meaningful one. --- Addressed Diego's comment. Vittorio libavcodec/tiffenc.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavcodec/tiffenc.c b/libavcodec/tiffenc.c index 24312f0..8791c54 10

Re: [libav-devel] [PATCH] movenc: Add an option for skipping writing the mfra/tfra/mfro trailer

2016-06-29 Thread Vittorio Giovara
On Tue, Jun 28, 2016 at 7:33 AM, Martin Storsjö wrote: > When writing a fragmented file, we by default write an index pointing > to all the fragments at the end of the file. This causes constantly > increasing memory usage during the muxing. For live streams, the > index might not be useful at all

Re: [libav-devel] [PATCH 1/2] build: Move MP2 muxer declaration away from MP3 muxer code

2016-06-29 Thread Vittorio Giovara
On Tue, Jun 28, 2016 at 8:09 AM, Diego Biurrun wrote: > The MP2 muxer uses none of the code of the MP3 muxer. > --- > libavcodec/Makefile | 1 - > libavformat/Makefile | 2 +- > libavformat/mp3enc.c | 16 > libavformat/rawenc.c | 13 + > 4 files changed, 14 inserti

Re: [libav-devel] [PATCH 2/5] tiffenc: Check zlib support for deflate option during initialization

2016-06-27 Thread Vittorio Giovara
On Mon, Jun 27, 2016 at 6:56 PM, Diego Biurrun wrote: > On Mon, Jun 27, 2016 at 06:49:52PM -0400, Vittorio Giovara wrote: >> On Mon, Jun 27, 2016 at 6:43 PM, Diego Biurrun wrote: >> > On Mon, Jun 27, 2016 at 11:56:20AM -0400, Vittorio Giovara wrote: >> >> On Mon,

Re: [libav-devel] [PATCH 2/5] tiffenc: Check zlib support for deflate option during initialization

2016-06-27 Thread Vittorio Giovara
On Mon, Jun 27, 2016 at 6:43 PM, Diego Biurrun wrote: > On Mon, Jun 27, 2016 at 11:56:20AM -0400, Vittorio Giovara wrote: >> On Mon, Jun 27, 2016 at 8:25 AM, Diego Biurrun wrote: >> > On Sun, Jun 26, 2016 at 08:08:54PM -0400, Vittorio Giovara wrote: >> >> This con

Re: [libav-devel] [PATCH 1/2] build: Move ff_mpeg12_frame_rate_tab to a separate file

2016-06-27 Thread Vittorio Giovara
On Mon, Jun 27, 2016 at 6:38 PM, Diego Biurrun wrote: > On Mon, Jun 27, 2016 at 11:51:50AM -0400, Vittorio Giovara wrote: >> On Mon, Jun 27, 2016 at 11:05 AM, Hendrik Leppkes >> wrote: >> > On Mon, Jun 27, 2016 at 4:22 PM, Diego Biurrun wrote: >> >> It is

Re: [libav-devel] [PATCH] fate: Add test for webp

2016-06-27 Thread Vittorio Giovara
On Mon, Jun 27, 2016 at 6:34 PM, Diego Biurrun wrote: > --- > tests/fate/image.mak | 3 +++ > tests/ref/fate/webp | 2 ++ > 2 files changed, 5 insertions(+) > create mode 100644 tests/ref/fate/webp > > diff --git a/tests/fate/image.mak b/tests/fate/image.mak > index e58291b..83fa71a 100644 > --

Re: [libav-devel] [PATCH 5/5] rle: Convert into a proper dsp module

2016-06-27 Thread Vittorio Giovara
On Mon, Jun 27, 2016 at 2:56 PM, Diego Biurrun wrote: > On Mon, Jun 27, 2016 at 12:00:21PM -0400, Vittorio Giovara wrote: >> On Mon, Jun 27, 2016 at 10:51 AM, Diego Biurrun wrote: >> > On Mon, Jun 27, 2016 at 04:31:16PM +0200, Luca Barbato wrote: >> >> On 27/06

Re: [libav-devel] [PATCH] ffv1: Remove version 2 and mark version 3 as non-experimental

2016-06-27 Thread Vittorio Giovara
On Mon, Jun 27, 2016 at 12:08 PM, Luca Barbato wrote: > On 27/06/16 17:25, Vittorio Giovara wrote: >> On Mon, Jun 27, 2016 at 10:26 AM, Luca Barbato wrote: >>> On 27/06/16 05:11, Luca Barbato wrote: >>>> On 27/06/16 04:38, Vittorio Giovara wrote: >>>

Re: [libav-devel] [PATCH 4/4] pixdesc: Add documentation about the main use-case of color name APIs

2016-06-27 Thread Vittorio Giovara
On Tue, Jun 21, 2016 at 10:23 AM, Vittorio Giovara wrote: > --- > doc/APIchanges | 6 ++ > libavutil/pixdesc.h | 9 + > 2 files changed, 15 insertions(+) This patch is dropped, it makes no sense to mention command line parameters in the public api.

Re: [libav-devel] [PATCH 5/5] rle: Convert into a proper dsp module

2016-06-27 Thread Vittorio Giovara
On Mon, Jun 27, 2016 at 10:51 AM, Diego Biurrun wrote: > On Mon, Jun 27, 2016 at 04:31:16PM +0200, Luca Barbato wrote: >> On 27/06/16 14:32, Diego Biurrun wrote: >> > Adding an rle component that other components can select seems useful, >> > but making this a dsp-like component provides no gain.

Re: [libav-devel] [PATCH 1/5] targaenc: Move size check to initialization function

2016-06-27 Thread Vittorio Giovara
On Mon, Jun 27, 2016 at 8:22 AM, Diego Biurrun wrote: > On Sun, Jun 26, 2016 at 08:08:53PM -0400, Vittorio Giovara wrote: >> --- >> libavcodec/targaenc.c | 9 + >> 1 file changed, 5 insertions(+), 4 deletions(-) > > Why? To make it fail early rather than aft

<    3   4   5   6   7   8   9   10   11   12   >