Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-11 Thread Kostya
On Sun, Apr 10, 2011 at 09:44:51PM +0200, Diego Biurrun wrote: When HAVE_7REGS was not defined these functions had an empty body causing the following warnings during compilation. In file included from libswscale/x86/yuv2rgb_mmx.c:58: libswscale/x86/yuv2rgb_template.c: In function

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-11 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 11:25:49AM +0200, Luca Barbato wrote: On 04/10/2011 09:44 PM, Diego Biurrun wrote: When HAVE_7REGS was not defined these functions had an empty body causing the following warnings during compilation. In file included from libswscale/x86/yuv2rgb_mmx.c:58:

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-11 Thread Luca Barbato
On 04/11/2011 03:44 PM, Ronald S. Bultje wrote: This isn't right. You're declaring empty functions for stuff that is supposed to do something. In x86/yuv2rgb_mmx.c, you'll see these functions are only called under if (HAVE_7REGS) anyway, so the proper fix is to not declare these functions at

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-11 Thread Ronald S. Bultje
Hi, On Mon, Apr 11, 2011 at 10:01 AM, Luca Barbato lu_z...@gentoo.org wrote: On 04/11/2011 03:44 PM, Ronald S. Bultje wrote: This isn't right. You're declaring empty functions for stuff that is supposed to do something. In x86/yuv2rgb_mmx.c, you'll see these functions are only called under if

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 10:06:43AM -0400, Ronald S. Bultje wrote: Hi, On Mon, Apr 11, 2011 at 10:01 AM, Luca Barbato lu_z...@gentoo.org wrote: On 04/11/2011 03:44 PM, Ronald S. Bultje wrote: This isn't right. You're declaring empty functions for stuff that is supposed to do something. In

[libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-10 Thread Diego Biurrun
When HAVE_7REGS was not defined these functions had an empty body causing the following warnings during compilation. In file included from libswscale/x86/yuv2rgb_mmx.c:58: libswscale/x86/yuv2rgb_template.c: In function ‘yuva420_rgb32_MMX’: libswscale/x86/yuv2rgb_template.c:412: warning: no return

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-10 Thread Luca Barbato
On 04/10/2011 09:44 PM, Diego Biurrun wrote: causing the following warnings during compilation. Could you please try to rebase it on my github swscale cleanup branch? (Help to squash and push it here welcome) lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-10 Thread Luca Barbato
On 04/10/2011 10:11 PM, Diego Biurrun wrote: On Sun, Apr 10, 2011 at 09:53:44PM +0200, Luca Barbato wrote: On 04/10/2011 09:44 PM, Diego Biurrun wrote: causing the following warnings during compilation. Could you please try to rebase it on my github swscale cleanup branch? Can we do that