Re: [libav-devel] [PATCH] Drop DCTELEM typedef

2013-01-22 Thread Luca Barbato
On 22/01/13 10:53, Diego Biurrun wrote: On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun di...@biurrun.de wrote: It does not help as an abstraction and adds dsputil dependencies. I like the commit. I do want to add, though, that

Re: [libav-devel] [PATCH] Drop DCTELEM typedef

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 1:53 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun di...@biurrun.de wrote: It does not help as an abstraction and adds dsputil dependencies. I like the

Re: [libav-devel] [PATCH] Drop DCTELEM typedef

2013-01-22 Thread Diego Biurrun
On Tue, Jan 22, 2013 at 07:12:21AM -0800, Ronald S. Bultje wrote: On Tue, Jan 22, 2013 at 1:53 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun di...@biurrun.de wrote: It does not help

Re: [libav-devel] [PATCH] Drop DCTELEM typedef

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 7:49 AM, Diego Biurrun di...@biurrun.de wrote: On Tue, Jan 22, 2013 at 07:12:21AM -0800, Ronald S. Bultje wrote: On Tue, Jan 22, 2013 at 1:53 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: On Mon, Jan

Re: [libav-devel] [PATCH] Drop DCTELEM typedef

2013-01-21 Thread Luca Barbato
On 22/01/13 01:04, Diego Biurrun wrote: It does not help as an abstraction and adds dsputil dependencies. --- doc/optimization.txt |2 +- libavcodec/4xm.c | 10 ++-- libavcodec/alpha/dsputil_alpha.c | 12 ++--

Re: [libav-devel] [PATCH] Drop DCTELEM typedef

2013-01-21 Thread Ronald S. Bultje
Hi, On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun di...@biurrun.de wrote: It does not help as an abstraction and adds dsputil dependencies. I like the commit. I do want to add, though, that you're not actually practically removing the dsputil dependency from a lot of files (at build time),