Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Diego Biurrun
On Tue, Oct 02, 2012 at 05:48:26PM -0700, Ronald S. Bultje wrote: 2) a lot of ff_ symbols, and dsputil_init, are accessed from outside the library in which they exist. These are bugs and should be fixed (i.e. renamed). You seem to be working on the wrong tree. --- a/configure +++

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Ronald S. Bultje
Hi, On Wed, Oct 3, 2012 at 4:02 AM, Diego Biurrun di...@biurrun.de wrote: On Tue, Oct 02, 2012 at 05:48:26PM -0700, Ronald S. Bultje wrote: 2) a lot of ff_ symbols, and dsputil_init, are accessed from outside the library in which they exist. These are bugs and should be fixed (i.e. renamed).

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Wed, Oct 3, 2012 at 4:02 AM, Diego Biurrun di...@biurrun.de wrote: On Tue, Oct 02, 2012 at 05:48:26PM -0700, Ronald S. Bultje wrote: 2) a lot of ff_ symbols, and dsputil_init, are accessed from outside the library in which they exist. These

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Luca Barbato
On 10/03/2012 04:37 PM, Ronald S. Bultje wrote: Hi, On Wed, Oct 3, 2012 at 4:02 AM, Diego Biurrun di...@biurrun.de wrote: On Tue, Oct 02, 2012 at 05:48:26PM -0700, Ronald S. Bultje wrote: 2) a lot of ff_ symbols, and dsputil_init, are accessed from outside the library in which they exist.

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Derek Buitenhuis
On 03/10/2012 10:44 AM, Måns Rullgård wrote: What's AV_HAVE_SHARED_LIBS? I'm not aware of it anywhere. What do you need avconfig.h for? These AVCODEC_SYMBOL things will be used in public headers, thus the definition needs t exist in a public header. Since I need to use __declspec(dllimport)

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Diego Biurrun
On Wed, Oct 03, 2012 at 07:37:29AM -0700, Ronald S. Bultje wrote: On Wed, Oct 3, 2012 at 4:02 AM, Diego Biurrun di...@biurrun.de wrote: On Tue, Oct 02, 2012 at 05:48:26PM -0700, Ronald S. Bultje wrote: 2) a lot of ff_ symbols, and dsputil_init, are accessed from outside the library in which

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Ronald S. Bultje
Hi, On Wed, Oct 3, 2012 at 7:44 AM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: These AVCODEC_SYMBOL things will be used in public headers, thus the definition needs t exist in a public header. Since I need to use __declspec(dllimport) only for .dll

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Wed, Oct 3, 2012 at 7:44 AM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: These AVCODEC_SYMBOL things will be used in public headers, thus the definition needs t exist in a public header. Since I need to

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Ronald S. Bultje
Hi, On Wed, Oct 3, 2012 at 8:27 AM, Diego Biurrun di...@biurrun.de wrote: On Wed, Oct 03, 2012 at 07:37:29AM -0700, Ronald S. Bultje wrote: --- a/libavcodec/golomb.h +++ b/libavcodec/golomb.h @@ -33,13 +33,14 @@ -extern const uint8_t ff_golomb_vlc_len[512]; -extern const uint8_t

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Diego Biurrun
On Wed, Oct 03, 2012 at 08:31:43AM -0700, Ronald S. Bultje wrote: On Wed, Oct 3, 2012 at 7:44 AM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: These AVCODEC_SYMBOL things will be used in public headers, thus the definition needs t exist in a public header.

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Diego Biurrun
On Wed, Oct 03, 2012 at 08:49:30AM -0700, Ronald S. Bultje wrote: On Wed, Oct 3, 2012 at 8:43 AM, Diego Biurrun di...@biurrun.de wrote: On Wed, Oct 03, 2012 at 08:31:43AM -0700, Ronald S. Bultje wrote: On Wed, Oct 3, 2012 at 7:44 AM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Ronald S. Bultje
Hi, On Wed, Oct 3, 2012 at 9:07 AM, Diego Biurrun di...@biurrun.de wrote: On Wed, Oct 03, 2012 at 08:49:30AM -0700, Ronald S. Bultje wrote: On Wed, Oct 3, 2012 at 8:43 AM, Diego Biurrun di...@biurrun.de wrote: On Wed, Oct 03, 2012 at 08:31:43AM -0700, Ronald S. Bultje wrote: On Wed, Oct 3,

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Diego Biurrun
On Wed, Oct 03, 2012 at 08:41:58AM -0700, Ronald S. Bultje wrote: On Wed, Oct 3, 2012 at 8:27 AM, Diego Biurrun di...@biurrun.de wrote: On Wed, Oct 03, 2012 at 07:37:29AM -0700, Ronald S. Bultje wrote: --- a/libavcodec/golomb.h +++ b/libavcodec/golomb.h @@ -33,13 +33,14 @@

[libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This patch adds support for .dll shared library generation using MSVC's native build tools. To properly load non-function symbols from DLL files, we prefix them with __declspec(dllimport) on MSVC for shared library builds when accessed from outside the

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-03 Thread Luca Barbato
On 10/03/2012 10:09 PM, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com This patch adds support for .dll shared library generation using MSVC's native build tools. To properly load non-function symbols from DLL files, we prefix them with __declspec(dllimport) on MSVC for

[libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-02 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This patch adds support for .dll shared library generation using MSVC's native build tools. To properly load non-function symbols from DLL files, we prefix them with __declspec(dllimport) on MSVC for shared library builds when accessed from outside the

Re: [libav-devel] [PATCH] Shared library support for MSVC build.

2012-10-02 Thread Luca Barbato
On 10/03/2012 02:48 AM, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com This patch adds support for .dll shared library generation using MSVC's native build tools. To properly load non-function symbols from DLL files, we prefix them with __declspec(dllimport) on MSVC for