Re: [libav-devel] [PATCH] Support for MSVC.

2012-10-09 Thread aviad rozenhek
On Thu, Jun 14, 2012 at 1:59 AM, Ronald S. Bultje rsbul...@gmail.comwrote: Hi, see attached. It's kinda big, some parts can/should be done differently, but it's a starting point so let's start talking about how to get this in the right way. Some general comments: - only tested on 32bit so

Re: [libav-devel] [PATCH] Support for MSVC.

2012-10-09 Thread Ronald S. Bultje
Hi, On Tue, Oct 9, 2012 at 10:33 AM, aviad rozenhek avia...@gmail.com wrote: On Thu, Jun 14, 2012 at 1:59 AM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, see attached. It's kinda big, some parts can/should be done differently, but it's a starting point so let's start talking about how

Re: [libav-devel] [PATCH] Support for MSVC.

2012-06-20 Thread Måns Rullgård
Derek Buitenhuis derek.buitenh...@gmail.com writes: On 13/06/2012 11:40 PM, Derek Buitenhuis wrote: On 13/06/2012 7:59 PM, Ronald S. Bultje wrote: - the include of mathematics.h, avconfig.h and avstring.h everywhere is (I think) legit, to account for snprintf(), M_PI or inline. We don't

Re: [libav-devel] [PATCH] Support for MSVC.

2012-06-14 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: Hi, see attached. It's kinda big, some parts can/should be done differently, but it's a starting point so let's start talking about how to get this in the right way. If you split the patch into logically independent fixes, reviewing it might be

Re: [libav-devel] [PATCH] Support for MSVC.

2012-06-14 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Wed, Jun 13, 2012 at 8:49 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 13/06/2012 11:40 PM, Derek Buitenhuis wrote: On 13/06/2012 7:59 PM, Ronald S. Bultje wrote: - the include of mathematics.h, avconfig.h and avstring.h

Re: [libav-devel] [PATCH] Support for MSVC.

2012-06-14 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Wed, Jun 13, 2012 at 8:40 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 13/06/2012 7:59 PM, Ronald S. Bultje wrote: - the include of mathematics.h, avconfig.h and avstring.h everywhere is (I think) legit, to account for

Re: [libav-devel] [PATCH] Support for MSVC.

2012-06-13 Thread Derek Buitenhuis
On 13/06/2012 7:59 PM, Ronald S. Bultje wrote: - the include of mathematics.h, avconfig.h and avstring.h everywhere is (I think) legit, to account for snprintf(), M_PI or inline. We don't need to do this for mathematics.h, as discussed on IRC. If we define _USE_MATH_DEFINES, we have access to

Re: [libav-devel] [PATCH] Support for MSVC.

2012-06-13 Thread Derek Buitenhuis
On 13/06/2012 11:40 PM, Derek Buitenhuis wrote: On 13/06/2012 7:59 PM, Ronald S. Bultje wrote: - the include of mathematics.h, avconfig.h and avstring.h everywhere is (I think) legit, to account for snprintf(), M_PI or inline. We don't need to do this for mathematics.h, as discussed on IRC.

Re: [libav-devel] [PATCH] Support for MSVC.

2012-06-13 Thread Ronald S. Bultje
Hi, On Wed, Jun 13, 2012 at 8:40 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 13/06/2012 7:59 PM, Ronald S. Bultje wrote: - the include of mathematics.h, avconfig.h and avstring.h everywhere is (I think) legit, to account for snprintf(), M_PI or inline. We don't need to do this

Re: [libav-devel] [PATCH] Support for MSVC.

2012-06-13 Thread Ronald S. Bultje
Hi, On Wed, Jun 13, 2012 at 8:49 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 13/06/2012 11:40 PM, Derek Buitenhuis wrote: On 13/06/2012 7:59 PM, Ronald S. Bultje wrote: - the include of mathematics.h, avconfig.h and avstring.h everywhere is (I think) legit, to account for