Re: [libav-devel] [PATCH] Windows Media Image decoder (WMVP/WVP2)

2011-08-23 Thread Anton Khirnov
On Sun, 21 Aug 2011 18:38:31 -0700, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Sun, Aug 21, 2011 at 7:48 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: On 17 August 2011 14:40, Alberto Delmás adel...@gmail.com wrote: On 17/08/2011 2:08, Ronald S. Bultje wrote: I don't

Re: [libav-devel] [PATCH] Windows Media Image decoder (WMVP/WVP2)

2011-08-22 Thread compn
Kostya Shishkov kostya.shishkov@... writes: On 17 August 2011 14:40, Alberto Delmás adelmas at gmail.com wrote: On 17/08/2011 2:08, Ronald S. Bultje wrote: The patch looks fine by me. Any other comments? hi, please test with samples from picsearch (url lists may have 404s):

Re: [libav-devel] [PATCH] Windows Media Image decoder (WMVP/WVP2)

2011-08-21 Thread Kostya Shishkov
On 17 August 2011 14:40, Alberto Delmás adel...@gmail.com wrote: On 17/08/2011 2:08, Ronald S. Bultje wrote: I don't believe this works for negative numbers. Same for effects_param1/2. Probably should be abs(sd-coefs[sprite][i]) in the last line. Yeah, fixed. (Not that there should be any

Re: [libav-devel] [PATCH] Windows Media Image decoder (WMVP/WVP2)

2011-08-21 Thread Ronald S. Bultje
Hi, On Sun, Aug 21, 2011 at 7:48 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: On 17 August 2011 14:40, Alberto Delmás adel...@gmail.com wrote: On 17/08/2011 2:08, Ronald S. Bultje wrote: I don't believe this works for negative numbers. Same for effects_param1/2. Probably should be

Re: [libav-devel] [PATCH] Windows Media Image decoder (WMVP/WVP2)

2011-08-17 Thread Kostya
On Tue, Aug 16, 2011 at 05:08:52PM -0700, Ronald S. Bultje wrote: Hi, On Tue, Aug 16, 2011 at 5:24 AM, Alberto Delmás adel...@gmail.com wrote: +av_log(avctx, AV_LOG_DEBUG, %d.%.3d, + sd-coefs[sprite][i] / (116), + (sd-coefs[sprite][i]

[libav-devel] [PATCH] Windows Media Image decoder (WMVP/WVP2)

2011-08-15 Thread Alberto Delmás
From 1a04903b69eaac956d2b7f1d2abf17f9b2e01843 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alberto=20Delm=C3=A1s?= adel...@gmail.com Date: Mon, 15 Aug 2011 20:42:26 +0200 Subject: [PATCH] Windows Media Image decoder (WMVP/WVP2) --- Changelog |1 + configure |1 +

Re: [libav-devel] [PATCH] Windows Media Image decoder (WMVP/WVP2)

2011-08-15 Thread Ronald S. Bultje
Hi, that came out of nowhere - cool stuff! On Mon, Aug 15, 2011 at 2:12 PM, Alberto Delmás adel...@gmail.com wrote: @@ -208,6 +208,7 @@ enum CodecID { CODEC_ID_PRORES, CODEC_ID_JV, CODEC_ID_DFA, +CODEC_ID_WMIMAGE, So later on, I see you relying on codec_tag to

Re: [libav-devel] [PATCH] Windows Media Image decoder (WMVP/WVP2)

2011-08-15 Thread Alex Converse
On Mon, Aug 15, 2011 at 2:12 PM, Alberto Delmás adel...@gmail.com wrote: From 1a04903b69eaac956d2b7f1d2abf17f9b2e01843 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alberto=20Delm=C3=A1s?= adel...@gmail.com Date: Mon, 15 Aug 2011 20:42:26 +0200 Subject: [PATCH] Windows Media Image decoder