Re: [libav-devel] [PATCH] aacsbr: silence message for SBR extension "padding".

2012-12-10 Thread Alex Converse
On Mon, Dec 10, 2012 at 5:48 AM, Jindřich Makovička wrote: > Hi, > > this is a backport of a patch from FFMPEG, which silences error > messages for AAC streams padded with zeros. These messages are emitted > for each AAC packet and can easily make hundreds of megabytes per day > if logged. > > A s

Re: [libav-devel] [PATCH] aacsbr: silence message for SBR extension "padding".

2012-12-10 Thread Luca Barbato
On 12/10/2012 04:28 PM, Jindřich Makovička wrote: > On Mon, Dec 10, 2012 at 3:07 PM, Diego Biurrun wrote: >> On Mon, Dec 10, 2012 at 02:48:28PM +0100, Jindřich Makovička wrote: >>> >>> Some files contain a few additional, all-0 bits. >>> Check for that case and don't print incorrect "not supported

Re: [libav-devel] [PATCH] aacsbr: silence message for SBR extension "padding".

2012-12-10 Thread Jindřich Makovička
On Mon, Dec 10, 2012 at 6:29 PM, Kieran Kunhya wrote: > Off-topic but that transport stream is incredibly screwed up. Or is it just > coincidentally cut so that it contains only part of a GOP? Yes, I captured only a few seconds and missed the key frame, but I didn't bother to take a new sample as

Re: [libav-devel] [PATCH] aacsbr: silence message for SBR extension "padding".

2012-12-10 Thread Kieran Kunhya
Off-topic but that transport stream is incredibly screwed up. Or is it just coincidentally cut so that it contains only part of a GOP? ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] aacsbr: silence message for SBR extension "padding".

2012-12-10 Thread Måns Rullgård
Jindřich Makovička writes: > On Mon, Dec 10, 2012 at 4:18 PM, Måns Rullgård wrote: >> Jindřich Makovička writes: >> >>> On Mon, Dec 10, 2012 at 3:00 PM, Måns Rullgård wrote: Jindřich Makovička writes: > diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c > index add9f18..

Re: [libav-devel] [PATCH] aacsbr: silence message for SBR extension "padding".

2012-12-10 Thread Jindřich Makovička
On Mon, Dec 10, 2012 at 4:18 PM, Måns Rullgård wrote: > Jindřich Makovička writes: > >> On Mon, Dec 10, 2012 at 3:00 PM, Måns Rullgård wrote: >>> Jindřich Makovička writes: >>> diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c index add9f18..dac2372 100644 --- a/libavcodec/a

Re: [libav-devel] [PATCH] aacsbr: silence message for SBR extension "padding".

2012-12-10 Thread Jindřich Makovička
On Mon, Dec 10, 2012 at 3:07 PM, Diego Biurrun wrote: > On Mon, Dec 10, 2012 at 02:48:28PM +0100, Jindřich Makovička wrote: >> >> Some files contain a few additional, all-0 bits. >> Check for that case and don't print incorrect "not supported" >> message. >> Fixes trac issue #836. > > We don't use

Re: [libav-devel] [PATCH] aacsbr: silence message for SBR extension "padding".

2012-12-10 Thread Måns Rullgård
Jindřich Makovička writes: > On Mon, Dec 10, 2012 at 3:00 PM, Måns Rullgård wrote: >> Jindřich Makovička writes: >> >>> diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c >>> index add9f18..dac2372 100644 >>> --- a/libavcodec/aacsbr.c >>> +++ b/libavcodec/aacsbr.c >>> @@ -926,7 +926,9 @@ st

Re: [libav-devel] [PATCH] aacsbr: silence message for SBR extension "padding".

2012-12-10 Thread Jindřich Makovička
On Mon, Dec 10, 2012 at 3:00 PM, Måns Rullgård wrote: > Jindřich Makovička writes: > >> diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c >> index add9f18..dac2372 100644 >> --- a/libavcodec/aacsbr.c >> +++ b/libavcodec/aacsbr.c >> @@ -926,7 +926,9 @@ static void read_sbr_extension(AACContex

Re: [libav-devel] [PATCH] aacsbr: silence message for SBR extension "padding".

2012-12-10 Thread Diego Biurrun
On Mon, Dec 10, 2012 at 02:48:28PM +0100, Jindřich Makovička wrote: > > Some files contain a few additional, all-0 bits. > Check for that case and don't print incorrect "not supported" > message. > Fixes trac issue #836. We don't use trac. > --- a/libavcodec/aacsbr.c > +++ b/libavcodec/aacsbr.c

Re: [libav-devel] [PATCH] aacsbr: silence message for SBR extension "padding".

2012-12-10 Thread Måns Rullgård
Jindřich Makovička writes: > diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c > index add9f18..dac2372 100644 > --- a/libavcodec/aacsbr.c > +++ b/libavcodec/aacsbr.c > @@ -926,7 +926,9 @@ static void read_sbr_extension(AACContext *ac, > SpectralBandReplication *sbr, > } >

[libav-devel] [PATCH] aacsbr: silence message for SBR extension "padding".

2012-12-10 Thread Jindřich Makovička
Hi, this is a backport of a patch from FFMPEG, which silences error messages for AAC streams padded with zeros. These messages are emitted for each AAC packet and can easily make hundreds of megabytes per day if logged. A sample stream produced by an encoder from Cisco is available at geraldine.f