[libav-devel] [PATCH] dsputil: Refactor duplicated CALL_2X_PIXELS / PIXELS16 macros

2014-03-19 Thread Diego Biurrun
--- Amended to not break some long lines for enhanced readability. libavcodec/arm/hpeldsp_init_arm.c | 2 +- libavcodec/dsputil.h | 2 -- libavcodec/dsputil_template.c | 2 ++ libavcodec/hpel_template.c | 2 ++ libavcodec/hpeldsp_template.c | 2 ++

Re: [libav-devel] [PATCH] dsputil: Refactor duplicated CALL_2X_PIXELS / PIXELS16 macros

2014-03-19 Thread Diego Biurrun
On Wed, Mar 19, 2014 at 06:54:44PM +0100, Luca Barbato wrote: On 19/03/14 18:34, Diego Biurrun wrote: --- Amended to not break some long lines for enhanced readability. Readability remains impaired. +#define HPELDSP_AVG_PIXELS16(CPUEXT) \ +

Re: [libav-devel] [PATCH] dsputil: Refactor duplicated CALL_2X_PIXELS / PIXELS16 macros

2014-03-19 Thread Luca Barbato
On 19/03/14 19:02, Diego Biurrun wrote: I don't get your point. This patch is about unifying two duplicated macros: CALL_2X_PIXELS and PIXELS16. The former name is more descriptive, so I settled for it. The end result is not improving readability at all. Do as you prefer. lu

Re: [libav-devel] [PATCH] dsputil: Refactor duplicated CALL_2X_PIXELS / PIXELS16 macros

2014-03-19 Thread Luca Barbato
On 19/03/14 18:34, Diego Biurrun wrote: --- Amended to not break some long lines for enhanced readability. Readability remains impaired. +#define HPELDSP_AVG_PIXELS16(CPUEXT) \ +CALL_2X_PIXELS(put_no_rnd_pixels16_x2 ## CPUEXT, ff_put_no_rnd_pixels8_x2 ## CPUEXT,