Re: [libav-devel] [PATCH] eval: fix printing of NaN in eval fate test.

2012-07-26 Thread Luca Barbato
On 07/26/2012 03:39 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Jul 25, 2012 at 11:05 PM, Alex Converse > wrote: >> On Wed, Jul 25, 2012 at 8:42 PM, Ronald S. Bultje wrote: >>> >>> From: "Ronald S. Bultje" >>> >>> This fixes "make fate-eval" on MSVC builds. Without this, the test outputs >>>

Re: [libav-devel] [PATCH] eval: fix printing of NaN in eval fate test.

2012-07-26 Thread Ronald S. Bultje
Hi, On Wed, Jul 25, 2012 at 11:05 PM, Alex Converse wrote: > On Wed, Jul 25, 2012 at 8:42 PM, Ronald S. Bultje wrote: >> >> From: "Ronald S. Bultje" >> >> This fixes "make fate-eval" on MSVC builds. Without this, the test outputs >> "-1.#NaN" instead of "nan" on MSVS 2010. >> --- >> libavutil/

Re: [libav-devel] [PATCH] eval: fix printing of NaN in eval fate test.

2012-07-25 Thread Luca Barbato
On 07/26/2012 08:05 AM, Alex Converse wrote: > Funny, when I proposed this without the MSC ifdef, you were wholly against it. > > And once again I will state that a conformant libc has the freedom to > print "[-]nan(n-char-sequence)". So why not just drop the ifdef? It is fine for me and I was wo

Re: [libav-devel] [PATCH] eval: fix printing of NaN in eval fate test.

2012-07-25 Thread Alex Converse
On Wed, Jul 25, 2012 at 8:42 PM, Ronald S. Bultje wrote: > > From: "Ronald S. Bultje" > > This fixes "make fate-eval" on MSVC builds. Without this, the test outputs > "-1.#NaN" instead of "nan" on MSVS 2010. > --- > libavutil/eval.c |5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [libav-devel] [PATCH] eval: fix printing of NaN in eval fate test.

2012-07-25 Thread Luca Barbato
On 07/26/2012 05:42 AM, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > This fixes "make fate-eval" on MSVC builds. Without this, the test outputs > "-1.#NaN" instead of "nan" on MSVS 2010. > --- > libavutil/eval.c |5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavuti

[libav-devel] [PATCH] eval: fix printing of NaN in eval fate test.

2012-07-25 Thread Ronald S. Bultje
From: "Ronald S. Bultje" This fixes "make fate-eval" on MSVC builds. Without this, the test outputs "-1.#NaN" instead of "nan" on MSVS 2010. --- libavutil/eval.c |5 + 1 file changed, 5 insertions(+) diff --git a/libavutil/eval.c b/libavutil/eval.c index ef37ad8..6131263 100644 --- a/li