Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-20 Thread Luca Barbato
On 1/20/12 6:16 AM, Janne Grunau wrote: If I knew how sure. Threading is initiliazed in avcodec_open2() but AVHWAccel based hardware acceleration only after the first frame is available. AVHWAccel might be overhauled completely, currently is nearly a bad hack. lu _

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-20 Thread Janne Grunau
On 2012-01-20 14:02:57 +, Måns Rullgård wrote: > Reinhard Tartler writes: > > > On Mi, Jan 18, 2012 at 23:25:04 (CET), Ronald S. Bultje wrote: > > > >> OK, so it can crash. What's the use case of draw_horiz_band if > >> threading is enabled? Shouldn't the whole callback never be used, > >> si

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-20 Thread Måns Rullgård
Reinhard Tartler writes: > On Mi, Jan 18, 2012 at 23:25:04 (CET), Ronald S. Bultje wrote: > >> OK, so it can crash. What's the use case of draw_horiz_band if >> threading is enabled? Shouldn't the whole callback never be used, >> since we force codec delay? Is there a valid use case where the >>

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-20 Thread Anton Khirnov
On Fri, 20 Jan 2012 10:58:41 +0100, Reinhard Tartler wrote: > On Mi, Jan 18, 2012 at 23:25:04 (CET), Ronald S. Bultje wrote: > > > OK, so it can crash. What's the use case of draw_horiz_band if > > threading is enabled? Shouldn't the whole callback never be used, > > since we force codec delay?

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-20 Thread Reinhard Tartler
On Mi, Jan 18, 2012 at 23:25:04 (CET), Ronald S. Bultje wrote: > OK, so it can crash. What's the use case of draw_horiz_band if > threading is enabled? Shouldn't the whole callback never be used, > since we force codec delay? Is there a valid use case where the > user-supplied draw_horiz_band shou

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Ronald S. Bultje
Hi, On Wed, Jan 18, 2012 at 1:15 PM, Uoti Urpala wrote: > On Wed, 2012-01-18 at 06:35 -0800, Ronald S. Bultje wrote: >> On Wed, Jan 18, 2012 at 5:52 AM, Janne Grunau wrote: >> > On 2012-01-18 12:46:28 +, Måns Rullgård wrote: >> >> "Ronald S. Bultje" writes: >> >> > On Wed, Jan 18, 2012 at 2

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Uoti Urpala
On Wed, 2012-01-18 at 06:35 -0800, Ronald S. Bultje wrote: > On Wed, Jan 18, 2012 at 5:52 AM, Janne Grunau wrote: > > On 2012-01-18 12:46:28 +, Måns Rullgård wrote: > >> "Ronald S. Bultje" writes: > >> > On Wed, Jan 18, 2012 at 2:46 AM, Janne Grunau > >> > wrote: > >> >> Users of libavcodec

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 11:46:36AM +0100, Janne Grunau wrote: > Users of libavcodec could break if they do not threadsafe callbacks. > Avconv and avplay still use -threads auto if not specified. .. could break if they do threadunsafe callbacks. Diego __

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Ronald S. Bultje
Hi, On Wed, Jan 18, 2012 at 5:52 AM, Janne Grunau wrote: > On 2012-01-18 12:46:28 +, Måns Rullgård wrote: >> "Ronald S. Bultje" writes: >> >> > Hi, >> > >> > On Wed, Jan 18, 2012 at 2:46 AM, Janne Grunau >> > wrote: >> >> Users of libavcodec could break if they do not threadsafe callbacks.

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Janne Grunau
On 2012-01-18 12:46:28 +, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > > > Hi, > > > > On Wed, Jan 18, 2012 at 2:46 AM, Janne Grunau > > wrote: > >> Users of libavcodec could break if they do not threadsafe callbacks. > >> Avconv and avplay still use -threads auto if not specified. >

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > On Wed, Jan 18, 2012 at 2:46 AM, Janne Grunau wrote: >> Users of libavcodec could break if they do not threadsafe callbacks. >> Avconv and avplay still use -threads auto if not specified. > > What callbacks? get_buffer() and friends I presume, since there ar

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Ronald S. Bultje
Hi, On Wed, Jan 18, 2012 at 2:46 AM, Janne Grunau wrote: > Users of libavcodec could break if they do not threadsafe callbacks. > Avconv and avplay still use -threads auto if not specified. What callbacks? Ronald ___ libav-devel mailing list libav-dev

[libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Janne Grunau
Users of libavcodec could break if they do not threadsafe callbacks. Avconv and avplay still use -threads auto if not specified. --- avconv.c |4 avplay.c |2 ++ libavcodec/options.c |2 +- 3 files changed, 7 insertions(+), 1 deletions(-) diff --git a/avco