Re: [libav-devel] [PATCH 1/4] x86: include x86inc.asm in x86util.asm

2012-10-30 Thread Luca Barbato
On 10/30/2012 04:42 AM, Ronald S. Bultje wrote: Hi, On Mon, Oct 29, 2012 at 7:28 PM, Diego Biurrun di...@biurrun.de wrote: -%include x86inc.asm %include x86util.asm Didn't you come up with the rule that each file should contain all headers it directly takes symbols from? How do these

Re: [libav-devel] [PATCH 1/4] x86: include x86inc.asm in x86util.asm

2012-10-30 Thread Diego Biurrun
On Mon, Oct 29, 2012 at 08:42:18PM -0700, Ronald S. Bultje wrote: On Mon, Oct 29, 2012 at 7:28 PM, Diego Biurrun di...@biurrun.de wrote: -%include x86inc.asm %include x86util.asm Didn't you come up with the rule that each file should contain all headers it directly takes symbols from?

[libav-devel] [PATCH 1/4] x86: include x86inc.asm in x86util.asm

2012-10-29 Thread Diego Biurrun
This is necessary to allow refactoring some x86util macros with cpuflags. It also allows having custom macro definitions outside of x86inc.asm. --- libavcodec/x86/ac3dsp.asm |1 - libavcodec/x86/dct32.asm|1 - libavcodec/x86/deinterlace.asm |1 -

Re: [libav-devel] [PATCH 1/4] x86: include x86inc.asm in x86util.asm

2012-10-29 Thread Ronald S. Bultje
Hi, On Mon, Oct 29, 2012 at 7:28 PM, Diego Biurrun di...@biurrun.de wrote: -%include x86inc.asm %include x86util.asm Didn't you come up with the rule that each file should contain all headers it directly takes symbols from? How do these changes fit with that scheme? Ronald