Re: [libav-devel] [PATCH 3/3] Use parsers for RealVideo 3/4 to determine correct PTS

2011-08-17 Thread Kostya
On Tue, Aug 16, 2011 at 04:13:35PM -0700, Ronald S. Bultje wrote: Hi, On Mon, Aug 15, 2011 at 11:43 PM, Kostya kostya.shish...@gmail.com wrote: On Mon, Aug 15, 2011 at 09:42:50PM +0100, Måns Rullgård wrote: Kostya kostya.shish...@gmail.com writes: [...] Why are most of the frames

Re: [libav-devel] [PATCH 3/3] Use parsers for RealVideo 3/4 to determine correct PTS

2011-08-17 Thread Vladimir Pantelic
Ronald S. Bultje wrote: Hi, On Tue, Aug 16, 2011 at 11:06 PM, Kostyakostya.shish...@gmail.com wrote: On Tue, Aug 16, 2011 at 04:13:35PM -0700, Ronald S. Bultje wrote: On Mon, Aug 15, 2011 at 11:43 PM, Kostyakostya.shish...@gmail.com wrote: On Mon, Aug 15, 2011 at 09:42:50PM +0100, Måns

Re: [libav-devel] [PATCH 3/3] Use parsers for RealVideo 3/4 to determine correct PTS

2011-08-17 Thread Kostya
On Wed, Aug 17, 2011 at 09:20:33AM -0700, Ronald S. Bultje wrote: Hi, On Tue, Aug 16, 2011 at 11:06 PM, Kostya kostya.shish...@gmail.com wrote: On Tue, Aug 16, 2011 at 04:13:35PM -0700, Ronald S. Bultje wrote: On Mon, Aug 15, 2011 at 11:43 PM, Kostya kostya.shish...@gmail.com wrote: On

Re: [libav-devel] [PATCH 3/3] Use parsers for RealVideo 3/4 to determine correct PTS

2011-08-17 Thread Vladimir Pantelic
Am 17.08.2011 18:34 schrieb Vladimir Pantelic vlado...@gmail.com: /* I/P frames have a pts that is after the previous I or P frame, so the difference is positive module 13bit */ Modulo of course +s-pts = pc-key_dts + ((pts - pc-key_pts) 0x1FFF); +else /* B

Re: [libav-devel] [PATCH 3/3] Use parsers for RealVideo 3/4 to determine correct PTS

2011-08-16 Thread Kostya
On Mon, Aug 15, 2011 at 09:42:50PM +0100, Måns Rullgård wrote: Kostya kostya.shish...@gmail.com writes: [...] Why are most of the frames completely different? Why is there one frame less decoded? [...] Here too many frames have a different checksum. Why? Because of the wonderful

Re: [libav-devel] [PATCH 3/3] Use parsers for RealVideo 3/4 to determine correct PTS

2011-08-16 Thread Ronald S. Bultje
Hi, On Mon, Aug 15, 2011 at 11:43 PM, Kostya kostya.shish...@gmail.com wrote: On Mon, Aug 15, 2011 at 09:42:50PM +0100, Måns Rullgård wrote: Kostya kostya.shish...@gmail.com writes: [...] Why are most of the frames completely different?  Why is there one frame less decoded? [...] Here

Re: [libav-devel] [PATCH 3/3] Use parsers for RealVideo 3/4 to determine correct PTS

2011-08-15 Thread Vladimir Pantelic
Kostya Shishkov wrote: --- libavcodec/Makefile |2 + libavcodec/allcodecs.c |2 + libavcodec/rv30_parser.c | 78 ++ libavcodec/rv40_parser.c | 77 ++ libavformat/rmdec.c |1 + tests/ref/fate/real-rv40 | 351

Re: [libav-devel] [PATCH 3/3] Use parsers for RealVideo 3/4 to determine correct PTS

2011-08-15 Thread Kostya
On Mon, Aug 15, 2011 at 11:39:25AM +0200, Vladimir Pantelic wrote: Kostya Shishkov wrote: [...] 1) maybe merge the 2 parsers into one with a little if(...codec_id..) when extracting type/pts 2) even with that parser, at least avplay still does not have the correct timestamps, adding a

Re: [libav-devel] [PATCH 3/3] Use parsers for RealVideo 3/4 to determine correct PTS

2011-08-15 Thread Vladimir Pantelic
Kostya wrote: On Mon, Aug 15, 2011 at 11:39:25AM +0200, Vladimir Pantelic wrote: Kostya Shishkov wrote: [...] 1) maybe merge the 2 parsers into one with a little if(...codec_id..) when extracting type/pts 2) even with that parser, at least avplay still does not have the correct

Re: [libav-devel] [PATCH 3/3] Use parsers for RealVideo 3/4 to determine correct PTS

2011-08-15 Thread Vladimir Pantelic
Vladimir Pantelic wrote: Kostya wrote: On Mon, Aug 15, 2011 at 11:39:25AM +0200, Vladimir Pantelic wrote: Kostya Shishkov wrote: [...] 1) maybe merge the 2 parsers into one with a little if(...codec_id..) when extracting type/pts 2) even with that parser, at least avplay still

Re: [libav-devel] [PATCH 3/3] Use parsers for RealVideo 3/4 to determine correct PTS

2011-08-15 Thread Kostya
On Mon, Aug 15, 2011 at 01:07:09PM +0200, Vladimir Pantelic wrote: Vladimir Pantelic wrote: Kostya wrote: On Mon, Aug 15, 2011 at 11:39:25AM +0200, Vladimir Pantelic wrote: Kostya Shishkov wrote: [...] 1) maybe merge the 2 parsers into one with a little if(...codec_id..) when

Re: [libav-devel] [PATCH 3/3] Use parsers for RealVideo 3/4 to determine correct PTS

2011-08-15 Thread Vladimir Pantelic
Kostya wrote: On Mon, Aug 15, 2011 at 01:07:09PM +0200, Vladimir Pantelic wrote: Vladimir Pantelic wrote: Kostya wrote: On Mon, Aug 15, 2011 at 11:39:25AM +0200, Vladimir Pantelic wrote: Kostya Shishkov wrote: [...] 1) maybe merge the 2 parsers into one with a little

Re: [libav-devel] [PATCH 3/3] Use parsers for RealVideo 3/4 to determine correct PTS

2011-08-15 Thread Kostya
On Mon, Aug 15, 2011 at 02:44:09PM +0200, Vladimir Pantelic wrote: Kostya wrote: On Mon, Aug 15, 2011 at 01:07:09PM +0200, Vladimir Pantelic wrote: Vladimir Pantelic wrote: Kostya wrote: On Mon, Aug 15, 2011 at 11:39:25AM +0200, Vladimir Pantelic wrote: Kostya Shishkov wrote:

[libav-devel] [PATCH 3/3] Use parsers for RealVideo 3/4 to determine correct PTS

2011-08-14 Thread Kostya Shishkov
--- libavcodec/Makefile |2 + libavcodec/allcodecs.c |2 + libavcodec/rv30_parser.c | 78 ++ libavcodec/rv40_parser.c | 77 ++ libavformat/rmdec.c |1 + tests/ref/fate/real-rv40 | 351 ++ tests/ref/fate/rv30