Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2016-05-12 Thread Vittorio Giovara
Andreas, sorry we keep getting sidetracked, since you originally requested this API, would be able to send a patch with the appropriate rename/apichange/version bump? Thanks for your help. Vittorio On Sat, Mar 19, 2016 at 7:50 PM, Luca Barbato wrote: > On 19/03/16 21:55, Vittorio Giovara wrote: >

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2016-03-19 Thread Luca Barbato
On 19/03/16 21:55, Vittorio Giovara wrote: > On Sun, Jun 7, 2015 at 1:07 PM, Luca Barbato wrote: >> On 07/06/15 16:30, Andreas Cadhalpun wrote: >>> It seems Luca accidentally pushed an old version of this patch. >>> The pushed version still has the ffio_read_size name and Luca's >>> comment about

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2016-03-19 Thread Vittorio Giovara
On Sun, Jun 7, 2015 at 1:07 PM, Luca Barbato wrote: > On 07/06/15 16:30, Andreas Cadhalpun wrote: >> It seems Luca accidentally pushed an old version of this patch. >> The pushed version still has the ffio_read_size name and Luca's >> comment about the error handling is also not addressed. > > Goo

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-06-07 Thread Luca Barbato
On 07/06/15 16:30, Andreas Cadhalpun wrote: > It seems Luca accidentally pushed an old version of this patch. > The pushed version still has the ffio_read_size name and Luca's > comment about the error handling is also not addressed. Good thing it is an internal function and thanks for spotting!

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-06-07 Thread Luca Barbato
On 07/06/15 16:37, Andreas Cadhalpun wrote: > On 01.06.2015 09:13, Luca Barbato wrote: >> On 01/06/15 00:37, Andreas Cadhalpun wrote: >>> Since I don't expect that many people would start using that function before >>> a release, I think delaying this doesn't do much good. But then, it doesn't >>>

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-06-07 Thread Andreas Cadhalpun
On 01.06.2015 09:13, Luca Barbato wrote: > On 01/06/15 00:37, Andreas Cadhalpun wrote: >> Since I don't expect that many people would start using that function before >> a release, I think delaying this doesn't do much good. But then, it doesn't >> do much harm either, for precisely the same reason

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-06-07 Thread Andreas Cadhalpun
On 26.05.2015 16:41, Vittorio Giovara wrote: > On Tue, May 26, 2015 at 3:24 PM, wm4 wrote: >> On Tue, 26 May 2015 14:24:38 +0100 >> Vittorio Giovara wrote: >>> +int ffio_read_size(AVIOContext *s, unsigned char *buf, int size) >>> +{ >>> +int ret = avio_read(s, buf, size); >>> +if (ret !=

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-06-01 Thread Luca Barbato
On 01/06/15 00:37, Andreas Cadhalpun wrote: > On 31.05.2015 12:35, Vittorio Giovara wrote: >> On Thu, May 28, 2015 at 1:41 AM, Luca Barbato wrote: >>> On 27/05/15 23:45, Andreas Cadhalpun wrote: Why delaying it? >>> >>> Because I'd rather have people rely on released software when build >>> t

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-05-31 Thread Andreas Cadhalpun
On 31.05.2015 12:35, Vittorio Giovara wrote: > On Thu, May 28, 2015 at 1:41 AM, Luca Barbato wrote: >> On 27/05/15 23:45, Andreas Cadhalpun wrote: >>> Why delaying it? >> >> Because I'd rather have people rely on released software when build >> theirs at least if the changes are pure sugar on top

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-05-31 Thread Vittorio Giovara
On Thu, May 28, 2015 at 1:41 AM, Luca Barbato wrote: > On 27/05/15 23:45, Andreas Cadhalpun wrote: >> Why delaying it? > > Because I'd rather have people rely on released software when build > theirs at least if the changes are pure sugar on top of already existing > functionality. > > If it is so

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-05-27 Thread Luca Barbato
On 27/05/15 23:45, Andreas Cadhalpun wrote: > Why delaying it? Because I'd rather have people rely on released software when build theirs at least if the changes are pure sugar on top of already existing functionality. If it is something required by somebody and it is solving an actual problem I

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-05-27 Thread Andreas Cadhalpun
On 27.05.2015 14:37, Luca Barbato wrote: > On 27/05/15 02:00, Vittorio Giovara wrote: >> On Tue, May 26, 2015 at 7:50 PM, Andreas Cadhalpun >> wrote: >> +int ffio_read_size(AVIOContext *s, unsigned char *buf, int size) >> +{ >> +int ret = avio_read(s, buf, size); >> +if (re

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-05-27 Thread Luca Barbato
On 27/05/15 02:00, Vittorio Giovara wrote: > On Tue, May 26, 2015 at 7:50 PM, Andreas Cadhalpun > wrote: > +int ffio_read_size(AVIOContext *s, unsigned char *buf, int size) > +{ > +int ret = avio_read(s, buf, size); > +if (ret != size) > +return AVERROR_INVALIDD

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-05-26 Thread Vittorio Giovara
On Tue, May 26, 2015 at 7:50 PM, Andreas Cadhalpun wrote: +int ffio_read_size(AVIOContext *s, unsigned char *buf, int size) +{ +int ret = avio_read(s, buf, size); +if (ret != size) +return AVERROR_INVALIDDATA; > > I like the idea of having such a function a

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-05-26 Thread Andreas Cadhalpun
On 26.05.2015 15:59, Vittorio Giovara wrote: > On Tue, May 26, 2015 at 2:44 PM, Luca Barbato wrote: >> On 26/05/15 15:24, Vittorio Giovara wrote: >>> >>> --- >>> libavformat/avio_internal.h | 7 +++ >>> libavformat/aviobuf.c | 8 >>> 2 files changed, 15 insertions(+) >>> >>>

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-05-26 Thread Vittorio Giovara
On Tue, May 26, 2015 at 3:24 PM, wm4 wrote: > On Tue, 26 May 2015 14:24:38 +0100 > Vittorio Giovara wrote: > >> --- >> libavformat/avio_internal.h | 7 +++ >> libavformat/aviobuf.c | 8 >> 2 files changed, 15 insertions(+) >> >> diff --git a/libavformat/avio_internal.h b/libav

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-05-26 Thread wm4
On Tue, 26 May 2015 14:24:38 +0100 Vittorio Giovara wrote: > --- > libavformat/avio_internal.h | 7 +++ > libavformat/aviobuf.c | 8 > 2 files changed, 15 insertions(+) > > diff --git a/libavformat/avio_internal.h b/libavformat/avio_internal.h > index c8630ab..aff5564 100644

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-05-26 Thread Vittorio Giovara
On Tue, May 26, 2015 at 2:44 PM, Luca Barbato wrote: > On 26/05/15 15:24, Vittorio Giovara wrote: >> >> --- >> libavformat/avio_internal.h | 7 +++ >> libavformat/aviobuf.c | 8 >> 2 files changed, 15 insertions(+) >> >> diff --git a/libavformat/avio_internal.h b/libavformat

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-05-26 Thread Luca Barbato
On 26/05/15 15:24, Vittorio Giovara wrote: --- libavformat/avio_internal.h | 7 +++ libavformat/aviobuf.c | 8 2 files changed, 15 insertions(+) diff --git a/libavformat/avio_internal.h b/libavformat/avio_internal.h index c8630ab..aff5564 100644 --- a/libavformat/avio_inte

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-05-26 Thread Luca Barbato
On 26/05/15 15:24, Vittorio Giovara wrote: --- libavformat/avio_internal.h | 7 +++ libavformat/aviobuf.c | 8 2 files changed, 15 insertions(+) Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/ma

[libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2015-05-26 Thread Vittorio Giovara
--- libavformat/avio_internal.h | 7 +++ libavformat/aviobuf.c | 8 2 files changed, 15 insertions(+) diff --git a/libavformat/avio_internal.h b/libavformat/avio_internal.h index c8630ab..aff5564 100644 --- a/libavformat/avio_internal.h +++ b/libavformat/avio_internal.h @@ -85,