Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-04 Thread Andreas Cadhalpun
On 03.12.2015 01:53, Vittorio Giovara wrote: > On Wed, Dec 2, 2015 at 1:53 PM, Andreas Cadhalpun > wrote: >> So this deprecating seems fine, but an entry in APIchanges would be nice. > > I'm hesitant about this, this removal, and the the changes from global > to codec private (i have more in a br

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-03 Thread Anton Khirnov
Quoting Vittorio Giovara (2015-12-03 19:19:34) > On Thu, Dec 3, 2015 at 1:04 PM, Anton Khirnov wrote: > >> These variables leaked from mpegvideoenc where are supposedly used for > >> statistics. > > > > "leaked"? I already said it's not statistics. And they are very > > deliberately exported. One

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-03 Thread Vittorio Giovara
On Thu, Dec 3, 2015 at 1:04 PM, Anton Khirnov wrote: >> These variables leaked from mpegvideoenc where are supposedly used for >> statistics. > > "leaked"? I already said it's not statistics. And they are very > deliberately exported. One can argue that we don't want to provide this > information

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-03 Thread Anton Khirnov
Quoting Vittorio Giovara (2015-12-03 18:55:29) > On Thu, Dec 3, 2015 at 12:31 PM, Anton Khirnov wrote: > > Quoting Vittorio Giovara (2015-12-03 17:53:12) > >> On Thu, Dec 3, 2015 at 3:48 AM, Anton Khirnov wrote: > >> > Quoting Vittorio Giovara (2015-11-30 18:19:36) > >> >> These variables leaked

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-03 Thread Vittorio Giovara
On Thu, Dec 3, 2015 at 12:31 PM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2015-12-03 17:53:12) >> On Thu, Dec 3, 2015 at 3:48 AM, Anton Khirnov wrote: >> > Quoting Vittorio Giovara (2015-11-30 18:19:36) >> >> These variables leaked from mpegvideoenc where are supposedly used for >> >> sta

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-03 Thread Anton Khirnov
Quoting Vittorio Giovara (2015-12-03 17:53:12) > On Thu, Dec 3, 2015 at 3:48 AM, Anton Khirnov wrote: > > Quoting Vittorio Giovara (2015-11-30 18:19:36) > >> These variables leaked from mpegvideoenc where are supposedly used for > >> statistics. However they might very well be private, and, due to

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-03 Thread Vittorio Giovara
On Thu, Dec 3, 2015 at 3:48 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2015-11-30 18:19:36) >> These variables leaked from mpegvideoenc where are supposedly used for >> statistics. However they might very well be private, and, due to their >> absolute lack of documentation, they are hard

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-03 Thread Anton Khirnov
Quoting Vittorio Giovara (2015-11-30 18:19:36) > These variables leaked from mpegvideoenc where are supposedly used for > statistics. However they might very well be private, and, due to their > absolute lack of documentation, they are hardly used in the wild. Despite > being write-only there are o

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-02 Thread Luca Barbato
On 03/12/15 01:53, Vittorio Giovara wrote: > I'm hesitant about this, this removal, and the the changes from global > to codec private (i have more in a branch) might pollute a little too > much the file. Maybe we could do a single entry that list all the > fields that got removed before release? >

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-02 Thread Vittorio Giovara
On Wed, Dec 2, 2015 at 1:53 PM, Andreas Cadhalpun wrote: > On 30.11.2015 18:19, Vittorio Giovara wrote: >> These variables leaked from mpegvideoenc where are supposedly used for >> statistics. However they might very well be private, and, due to their >> absolute lack of documentation, they are ha

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-02 Thread Andreas Cadhalpun
On 30.11.2015 18:19, Vittorio Giovara wrote: > These variables leaked from mpegvideoenc where are supposedly used for > statistics. However they might very well be private, and, due to their > absolute lack of documentation, they are hardly used in the wild. Despite > being write-only there are opt

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-11-30 Thread Luca Barbato
On 30/11/15 18:19, Vittorio Giovara wrote: > These variables leaked from mpegvideoenc where are supposedly used for > statistics. However they might very well be private, and, due to their > absolute lack of documentation, they are hardly used in the wild. Despite > being write-only there are optio

[libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-11-30 Thread Vittorio Giovara
These variables leaked from mpegvideoenc where are supposedly used for statistics. However they might very well be private, and, due to their absolute lack of documentation, they are hardly used in the wild. Despite being write-only there are options to initalize them, without any effect. There is