Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-18 Thread Diego Biurrun
On Tue, Jan 17, 2012 at 03:48:39AM +0200, Donald wrote: The reply is over 100kb to send.Here is my patch. Pushed, thanks. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-16 Thread Luca Barbato
On 1/15/12 11:37 PM, Diego Biurrun wrote: On Sun, Jan 15, 2012 at 11:42:56PM +0200, Donald Ovcharov wrote: To: Diego First of all thank you for the spent time to clarify my task.I do appreciate it. I got rid of the abv mailer .I have problems with thunderbird connecting to my abv e-mail so

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-16 Thread Diego Biurrun
On Mon, Jan 16, 2012 at 11:11:42PM +0200, Donald wrote: Patch attached here. From 0eea4ea1cd482941b4d8581e2b94a5729b928379 Mon Sep 17 00:00:00 2001 From: Donald Ovcharov dtt...@abv.bg Date: Sat, 17 Dec 2011 21:30:01 +0200 Subject: [PATCH] error_resilience:cosmetics So which is your official

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-16 Thread Diego Biurrun
On Mon, Jan 16, 2012 at 11:11:42PM +0200, Donald wrote: [...] Looks mostly good. Send a fresh patch with the changes I request below. I will queue it tomorrow. I'm OK with you getting your GCI points for sending that updated patch. --- a/libavcodec/error_resilience.c +++

[libav-devel] Patch error_resilience:cosmetics

2012-01-15 Thread Donald Ovcharov
To: Diego Hello. First of all thank you for the spent time to clarify my task.I do appreciate it. I really need to finish my task until 16th January so I'm working on it. I got rid of the abv mailer .I have problems with thunderbird connecting to my abv e-mail so I've made a new registration on

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-14 Thread Diego Biurrun
On Fri, Jan 13, 2012 at 07:18:39PM +0200, доналд овчаров wrote: My patch is ready to be reviewed. You are still using your broken mailer and breaking threads, which I very specifically told you not to do. Let me make this very clear, your task has two parts: 1) Creating a patch fit for

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-11 Thread Diego Biurrun
On Tue, Jan 10, 2012 at 09:20:41PM +0200, доналд овчаров wrote: Someone told me that : [..] + prev_x = s-last_picture.f.motion_val[0][mot_index][0]; + prev_y = s-last_picture.f.motion_val[0][mot_index][1]; +

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-10 Thread Diego Biurrun
On Mon, Jan 09, 2012 at 05:50:46PM +0200, доналд овчаров wrote: I didn't compile it because I think I'm not able to change it properly... For the third time: stop top-posting. I don't understand your question. What is it? You surely can change the code, so I don't see what you cannot change

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-10 Thread доналд овчаров
: Re: [libav-devel] Patch error_resilience:cosmetics До: libav development Изпратено на: Вторник, 2012, Януари 10 16:53:50 EET On Mon, Jan 09, 2012 at 05:50:46PM +0200, доналд овчаров wrote: I didn't compile it because I think I'm not able to change it properly... For the third time

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-07 Thread Diego Biurrun
On Sat, Jan 07, 2012 at 05:13:21PM +0200, доналд овчаров wrote: I didn't make the local variable changes because I'm afraid I could broke the code. Rest is done ... Did you compile to find out whether or not you broke the code? From 7b7b19631a44a7ecccdc22fd9c06a565cd27b881 Mon Sep 17

Re: [libav-devel] Patch error_resilience:cosmetics

2011-12-25 Thread Ronald S. Bultje
Hi, On Sun, Dec 25, 2011 at 3:19 AM, доналд овчаров dtt...@abv.bg wrote: I hope I got this right (about the top-posting) [..] @@ -40,26 +40,38 @@ [..] +s-dest[0] = s-current_picture.f.data[0] + (s-mb_y * 16 * s-linesize) + + s-mb_x * 16;

Re: [libav-devel] Patch error_resilience:cosmetics

2011-12-25 Thread Ronald S. Bultje
Hi, On Sun, Dec 25, 2011 at 2:09 PM, Ronald S. Bultje rsbul...@gmail.comwrote: Until line 537. Rest will come in a separate review. @@ -537,150 +614,167 @@ skip_mean_and_median: [..] +prev_x = s-last_picture.f.motion_val[0][mot_index][0]; +

Re: [libav-devel] Patch error_resilience:cosmetics

2011-12-23 Thread Luca Barbato
On 20/12/11 13:32, доналд овчаров wrote: Here's the new patch.Sorry but I don't know what top-posting is :( http://libav.org/contact.html Please follow the netiquette when posting on Libav mailing lists, especially avoid top-posting and thread hijacking (that is, replying to a thread and

Re: [libav-devel] Patch error_resilience:cosmetics

2011-12-23 Thread Diego Biurrun
On Thu, Dec 22, 2011 at 09:20:56PM +0200, доналд овчаров wrote: Ok it's done. Please do not top-post. --- a/libavcodec/error_resilience.c +++ b/libavcodec/error_resilience.c @@ -40,26 +40,38 @@ -if(ref = h-ref_count[0]) //FIXME it is posible albeit uncommon that slice

Re: [libav-devel] Patch error_resilience:cosmetics

2011-12-21 Thread Ronald S. Bultje
Hi, On Wed, Dec 21, 2011 at 11:25 AM, доналд овчаров dtt...@abv.bg wrote: [..] -if(ref = h-ref_count[0]) //FIXME it is posible albeit uncommon that slice references differ between slices, we take the easy approuch and ignore it for now. If this turns out to have any relevance in

Re: [libav-devel] Patch error_resilience:cosmetics

2011-12-21 Thread Ronald S. Bultje
Hi, On Wed, Dec 21, 2011 at 11:48 AM, Ronald S. Bultje rsbul...@gmail.com wrote: [review for line 537-1037]. static int is_intra_more_likely(MpegEncContext *s){ { goes on its own line. -if (!s-last_picture_ptr || !s-last_picture_ptr-f.data[0]) return 1; //no previous frame available -

Re: [libav-devel] Patch error_resilience:cosmetics

2011-12-21 Thread Ronald S. Bultje
Hi, On Wed, Dec 21, 2011 at 11:59 AM, Ronald S. Bultje rsbul...@gmail.com wrote: On Wed, Dec 21, 2011 at 11:48 AM, Ronald S. Bultje rsbul...@gmail.com wrote: [review for line 537-1037]. [ and the rest] @@ -1125,27 +1246,34 @@ void ff_er_frame_end(MpegEncContext *s){ [..] -

Re: [libav-devel] Patch error_resilience:cosmetics

2011-12-18 Thread Ronald S. Bultje
Hi, On Sat, Dec 17, 2011 at 12:52 PM, Luca Barbato lu_z...@gentoo.org wrote: I'd say we could consider it a sheer improvement and commit it. The probably another pass to fix small issue might be needed but this patch already is huge. Let's give it a few rounds of review - we do that for

Re: [libav-devel] Patch error_resilience:cosmetics

2011-12-18 Thread Diego Biurrun
On Sat, Dec 17, 2011 at 10:12:00PM +0200, доналд овчаров wrote: Fixed. Please stop top-posting and use a mailer that does not break threads. --- a/libavcodec/error_resilience.c +++ b/libavcodec/error_resilience.c @@ -40,26 +40,36 @@ +static void decode_mb(MpegEncContext *s, int ref) {

Re: [libav-devel] Patch error_resilience:cosmetics

2011-12-17 Thread Luca Barbato
On 17/12/11 20:42, доналд овчаров wrote: +v_block_filter(s, s-current_picture.f.data[0], s-mb_width * 2, + s-mb_height * 2, s-linesize , 1); +v_block_filter(s, s-current_picture.f.data[1], s-mb_width , + s-mb_height , s-uvlinesize,

Re: [libav-devel] Patch error_resilience:cosmetics

2011-12-17 Thread Måns Rullgård
Luca Barbato lu_z...@gentoo.org writes: On 17/12/11 20:42, доналд овчаров wrote: +v_block_filter(s, s-current_picture.f.data[0], s-mb_width * 2, + s-mb_height * 2, s-linesize , 1); +v_block_filter(s, s-current_picture.f.data[1], s-mb_width , +